1049 Commits

Author	SHA1	Message	Date
Dean Herbert	8f61f5e4c6	Cache Playfield for the sake of tests ... I'm open to an alternative. Name it.	2023-07-05 18:44:27 +09:00
Dean Herbert	561fff801a	Consume nested object states in HitObjectLifetimeEntry	2023-07-05 18:44:27 +09:00
Dean Herbert	beed390031	Add balance adjust to base implementation of DrumSampleTriggerSource	2023-07-05 18:44:27 +09:00
Dean Herbert	6d4fa6569f	Add back required pieces to GameplaySampleTriggerSource from old PR	2023-07-05 18:44:27 +09:00
Dean Herbert	8bd6f7a46a	Rename ClicksPerSecondCalculator to ClicksPerSecondController	2023-06-27 16:38:46 +09:00
Dean Herbert	e21583ff1b	Refactor InputCountController to not require being added to foreign body via Attach ... I've made the flow match `ClicksPerSecondCalculator` as close as possible. Hopefully this reads better.	2023-06-27 16:36:00 +09:00
Bartłomiej Dach	40ceb4dfac	Fix incorrect indent size	2023-06-26 22:40:25 +02:00
Bartłomiej Dach	8d91580dc1	Rename {KeyCounter -> InputCount}Controller	2023-06-26 19:27:42 +02:00
Bartłomiej Dach	cc45ec4fff	Mark IHasRecordingHandler.Recorder nullable	2023-06-26 18:52:05 +02:00
Dean Herbert	084354a8dc	Split out interfaces from RulesetInputManager and improve xmldoc	2023-06-26 16:34:57 +09:00
Dean Herbert	c8e081c2b6	Remove unused interface	2023-06-26 16:32:19 +09:00
tsrk	350d722c8d	Merge branch 'master' into hud/kc-skinnable	2023-06-25 15:42:08 +02:00
tsrk	a7088ffe22	revert: bring back old attachment flow ... As discussed, this would bring more problems that anything. Refs: 4c39708, f83a4f4	2023-06-25 15:21:55 +02:00
Bartłomiej Dach	25842105ce	Merge pull request #23976 from peppy/gameplay-sample-trigger-source-correctness ... Adjust `GameplaySampleTriggerSource` to only switch samples when close enough to the next hit object	2023-06-25 08:23:55 +02:00
Dean Herbert	2bda63c2c8	Merge branch 'master' into mass-nrt	2023-06-24 09:59:15 +09:00
Dean Herbert	df5b389629	Manual fixes to reduce warnings to zero	2023-06-24 01:52:53 +09:00
Dean Herbert	0ab0c52ad5	Automated pass	2023-06-24 01:00:03 +09:00
Dean Herbert	08b3c0cce0	Change "floating fruits" mod to only apply adjustments to the playfield ... Avoids things like touch screen inputs also being flipped. Note that these adjustments can't be applied directly to the playfield due to how playfields are used in various rulesets (basically relying on the `PlayfieldAdjustContainer` to get things in the right place). Closes #24000.	2023-06-23 14:18:43 +09:00
Dean Herbert	64b726d5ec	Fix nested logic not being completely correct (favouring already-passed rather than near-future)	2023-06-23 13:48:13 +09:00
Bartłomiej Dach	79606317ab	Remove redundant parentheses	2023-06-22 20:02:10 +02:00
Dean Herbert	4ff5275208	Make IGameplayClock optional in GameplaySampleTriggerSource to ease testing	2023-06-21 17:33:42 +09:00
Dean Herbert	cb07f2399f	Apply NRT to GameplaySampleTriggerSource	2023-06-20 21:03:55 +09:00
Dean Herbert	04dad6c6e8	Use IGameplayClock to ensure our clock source is correct	2023-06-20 20:47:56 +09:00
Dean Herbert	0e86102681	Fix nested lookups	2023-06-20 20:45:02 +09:00
Dean Herbert	786d5a394b	Add back optimisation and increase time allowance slightly	2023-06-20 20:30:07 +09:00
Dean Herbert	555ce7684b	Adjust GameplaySampleTriggerSource to only switch samples when close enough to the next hit object ... Closes #23963. To simplify things, I've removed the optimisation of using `AliveObject`s because it would break the way this whole lookup works.	2023-06-20 20:06:07 +09:00
tsrk	f83a4f4952	refactor: tidy up attachement flow ... TODO: find better naming and improve XMLDocs	2023-06-18 22:57:21 +02:00
tsrk	141f9efad5	style(KeyCounterController): remove reliance on Receptor	2023-06-18 21:26:16 +02:00
tsrk	b4cbcb210e	refactor: remove detachment logic ... No real use case, cleaning up the diff	2023-06-15 12:24:37 +02:00
tsrk	42b740a175	Merge branch 'master' into hud/kc-skinnable	2023-06-14 22:19:45 +02:00
tsrk	c637fddf73	refactor: decouple Trigger logic from KeyCounterDisplay ... This allows to keep a coeherent state regardless of the progress of the play	2023-06-14 21:13:35 +02:00
Salman Ahmed	62cb6a98ca	Remove redundant nullable suppression directives	2023-06-07 08:20:41 +03:00
Dean Herbert	c0016fa5d2	Fix gameplay playfield border being affected by beatmap track time ... Closes https://github.com/ppy/osu/issues/23470.	2023-06-06 16:08:24 +09:00
tsrk	6fc6729677	feat: integrate attachment flow in SkinComponentsContainer	2023-06-06 00:27:43 +02:00
tsrk	4c397085c5	refactor: improve attachement flow ... This removes the hard reliance on individual classes and makes its usage easiser to ingreate anywhere else.	2023-06-06 00:12:53 +02:00
Dean Herbert	cb468fa4ec	Fix OverlappingScrollAlgorithm returning incorrect results for TimeAt before first control point	2023-05-26 19:59:19 +09:00
Bartłomiej Dach	5229cf7343	Add failing test cases for drum roll/swell sample playback	2023-05-21 18:57:01 +02:00
Dean Herbert	8c542c6c51	Fix hold-for-right-click showing during gameplay	2023-05-13 21:32:30 +09:00
Dean Herbert	1b7dd32eb1	Apply nullability in related classes and remove unused variable	2023-05-08 17:09:08 +09:00
OliBomby	ebe1d852f5	remove other usages of hitobject SampleControlPoint	2023-04-25 16:01:43 +02:00
Dan Balasescu	c0a25144cf	Apply changes to custom ShaderManager	2023-04-18 11:31:56 +09:00
Andrei Zavatski	ed565b1e59	Fix SampleStore isn't being disposed	2023-04-06 11:40:04 +03:00
Bartłomiej Dach	e5d57a65c9	Fix incorrect indent	2023-04-05 19:47:25 +02:00
Bartłomiej Dach	432f698697	Merge branch 'master' into gameplay/key-counter-abstraction	2023-04-05 19:45:14 +02:00
Dean Herbert	7011928d86	Fix abysmal debug performance due to try-catch logic in DrawableRulesetDependencies	2023-04-03 18:04:33 +09:00
Dean Herbert	b0c09df259	Merge branch 'master' into gameplay/key-counter-abstraction	2023-04-03 15:33:35 +09:00
Dean Herbert	0d77ec013a	Fix ruleset-local shader manager not correctly falling back to existing cached shaders	2023-03-28 15:00:49 +09:00
Dean Herbert	c742b3f0a8	Update DrawableRulesetDependencies xmldoc to read more correctly	2023-03-28 14:15:19 +09:00
Dean Herbert	5f9b13a775	Rename Add/AddRange methods as they are no longer conflicting with Container	2023-03-15 18:02:41 +09:00
Dan Balasescu	e327993d11	Merge pull request #22527 from Terochi/replay-length-extension ... Replay recording extension until results screen transition	2023-03-11 15:41:32 +09:00