53 Commits

• Move DI resolution to inside BDL parameters
  Dean Herbert · 2021-05-13 13:54:06 +09:00
  b81f86bd4d
• Simplify binding flow in InterpretationSection
  Dean Herbert · 2021-05-13 13:51:41 +09:00
  c6648112e5
• Tidy up specification of SettingsSection
  Dean Herbert · 2021-05-13 13:45:10 +09:00
  cdcbaf4291
• Set default for bindable in object initializer

  Fixes the CI failure.

  Naxess · 2021-05-13 06:08:48 +02:00
  47948d7b34
• Also refresh when interpreted difficulty changes
  Naxess · 2021-05-13 06:00:21 +02:00
  fb305130de
• Use local bound copy in InterpretationSection as well

  Else we're relying on the `VerifyScreen`'s bindable instance, and by extension the `VerifyScreen` instance itself.

  Naxess · 2021-05-13 05:59:49 +02:00
  ee0a6ba93e
• Keep track of local bound copy
  Naxess · 2021-05-13 05:46:47 +02:00
  e80d8f6922
• Use more consistent lambda discards
  Naxess · 2021-05-13 05:38:45 +02:00
  04c1585eb2
• Use local bound copy for HiddenIssueTypes
  Naxess · 2021-05-13 05:25:20 +02:00
  e86834b740
• Isolate refreshing to IssueList
  Naxess · 2021-05-13 05:25:02 +02:00
  c8d21f2c3f
• Split ShowIssueTypes dict into hidden and configurable lists

  This way `VerifyScreen` is decoupled from which options `VisibilitySection` provides.
  
  Bindings are a bit less neat, though.

  Naxess · 2021-05-13 04:50:32 +02:00
  fbb76ba598
• Set interpreted difficulty to correct default
  Naxess · 2021-05-13 04:36:20 +02:00
  dd8423c4c4
• Remove unnecessary local variable

  This now exists in `VerifyScreen`, which we can access from here.

  Naxess · 2021-05-13 04:30:40 +02:00
  6806e40ad9
• Move ShowIssueTypes to VerifyScreen
  Naxess · 2021-05-13 04:29:27 +02:00
  56bd897666
• Reverse direction of binding to allow for better abstract class definitions
  Dean Herbert · 2021-05-12 16:53:58 +09:00
  d2e0e8ad94
• Rename Settings to have a more localised name
  Dean Herbert · 2021-05-12 16:38:04 +09:00
  17e3764576
• Add InterpretationSection and its bindable in IssueList

  We'll eventually connect that bindable so that checks can access it.

  Naxess · 2021-05-12 01:32:18 +02:00
  4aeaec6ecc
• Refresh IssueList on changes in VisibilitySection
  Naxess · 2021-05-12 01:30:45 +02:00
  ad78aec1ef
• Add IssueList filtering based on those bindables
  Naxess · 2021-05-12 01:29:46 +02:00
  1bb7d412da
• Add VisibilitySection and its bindables in IssueList
  Naxess · 2021-05-12 01:27:21 +02:00
  2e4399f0c1
• Add abstract Section class

  Similar to `Section` in the timing screen, but does not make use of checkboxes, nor specific to control points.
  
  So there's a lot of things that differ, hence new class instead of factoring that out.

  Naxess · 2021-05-12 01:26:12 +02:00
  01b8794757
• Separate IssueList into own class
  Naxess · 2021-05-12 01:23:31 +02:00
  1de35f880b
• Take IssueList in IssueSettings constructor

  We'll be using this for bindables later.

  Naxess · 2021-05-12 01:22:32 +02:00
  d3c1ec55ee
• Factor out load from settings into new Settings class
  Naxess · 2021-05-12 01:21:38 +02:00
  97bd482d4d
• Simplify verifier run call args

  Uses the resolved working beatmap instead of resolving it every time.
  
  Also uses the EditorBeatmap itself as playable beatmap, as it is of type `IBeatmap` already, and `.PlayableBeatmap` forwards everything anyway.

  Naxess · 2021-04-20 13:34:12 +02:00
  3e1b6b3b34
• Remove now unused import
  Naxess · 2021-04-20 02:39:11 +02:00
  496df411a7
• Merge branch 'master' into bg-audio-quality-checks
  Naxess · 2021-04-20 02:36:13 +02:00
  0e6b66f457
• Add the playable beatmap as check argument

  This is different from the working beatmap's `.Beatmap` property in that it is mutated by the ruleset/editor.
  
  So hit objects, for example, are actually of type `Slider` and such instead of the legacy `ConvertSlider`.
  
  This should be preferred over `workingBeatmap.Beatmap`.

  Naxess · 2021-04-20 01:31:51 +02:00
  8656176ab8
• Split out rounded content screen from SetupScreen for use in other places
  Dean Herbert · 2021-04-19 14:28:32 +09:00
  e143afb598
• Fix resolved fields
  Naxess · 2021-04-18 01:15:13 +02:00
  ef65c8910f
• Use WorkingBeatmap instead of IBeatmap

  This lets us access things like the background, track, etc. which are necessary for quality and filesize checks.
  
  Also improves the structure of the `CheckBackgroundTest` class in the process.

  Naxess · 2021-04-17 17:33:53 +02:00
  448574e7e6
• Move common table layout logic into EditorTable abstract class
  Dean Herbert · 2021-04-13 23:26:19 +09:00
  21e8e5fbca
• Split out common EditorTable base class
  Dean Herbert · 2021-04-13 23:05:58 +09:00
  0edc1a850d
• Fix some styling issues with the verify screen layout
  Dean Herbert · 2021-04-13 19:55:17 +09:00
  464fc02875
• Split out general checks into its own verifier class (and remove static usage)
  Dean Herbert · 2021-04-13 19:50:22 +09:00
  03ba04e8ce
• Make BeatmapVerifier an interface
  Naxess · 2021-04-13 10:40:56 +02:00
  60c2494b31
• Reverse IssueType ordering

  Reversed both in the enum and where it's displayed, so ends up the same in the end.

  Naxess · 2021-04-12 15:49:13 +02:00
  008dbc7dd6
• Fix Template.Origin -> Check
  Naxess · 2021-04-12 15:47:58 +02:00
  1c69829ad4
• Rename CreateChecker -> CreateBeatmapVerifier
  Naxess · 2021-04-12 10:08:30 +02:00
  a2fc9c398f
• Move check origin from IssueTemplate to Issue

  As a result we can also make check an interface, and need to provide the check itself when constructing an issue.

  Naxess · 2021-04-12 10:08:08 +02:00
  65ebdd8f7a
• Change Metadata into a get property
  Dean Herbert · 2021-04-12 15:52:29 +09:00
  8bf85d737c
• Fix formatting of colour getter
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  3551322f1d
• Checker -> BeatmapVerifier
  Dean Herbert · 2021-04-12 15:29:05 +09:00
  1c553b5d48
• Remove old todo
  Naxess · 2021-04-10 15:18:15 +02:00
  7d40b01722
• Improve table formatting
  Naxess · 2021-04-10 13:10:05 +02:00
  747e0f00dc
• Show table even if no issues
  Naxess · 2021-04-10 13:09:16 +02:00
  3a4f2e3d7e
• Remove todo

  Doesn't really matter in the end, as only one checker will run at a time in this case.

  Naxess · 2021-04-10 13:05:24 +02:00
  c995eca029
• Add issue selection

  This mainly helps with keeping track of which issue was clicked, since doing so switches tab.

  Naxess · 2021-04-10 13:04:39 +02:00
  6d3cf78e4a
• Move components to more appropriate spot
  Naxess · 2021-04-10 13:02:22 +02:00
  d1007ff26a
• Remove visibility settings

  Can look into this later, not really important for a first iteration.

  Naxess · 2021-04-10 12:58:40 +02:00
  43174b708c