1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-16 02:03:51 +08:00
Commit Graph

2 Commits

Author SHA1 Message Date
smoogipoo
a1394c1830 Fix a few missed judgements 2020-09-29 16:33:38 +09:00
Dean Herbert
ffc7eaa3f2 Fix hitobjects with unknown lifetimes by enforcing non-null judgement
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.

This fixes BananaShower and JuiceStreams in osu!catch.

This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 13:49:06 +09:00