Dan Balasescu
3b8b8ae87f
Merge pull request #31917 from bdach/nudge-fix
...
Fix nudge operations incurring FP error from coordinate space conversions
2025-02-18 12:19:14 +09:00
Bartłomiej Dach
f37a56c307
Fix nudge operations incurring FP error from coordinate space conversions
...
Closes https://github.com/ppy/osu/issues/31915 .
Reproduction of aforementioned issue requires 1280x720 resolution, which
should also be a good way to confirm that this does anything.
To me this is also equal-parts-bugfix, equal-parts-code-quality PR,
because tell me: what on earth was this code ever doing at
`ComposeBlueprintContainer` level? Nudging by one playfield-space-unit
doesn't even *make sense* in something like taiko or mania.
2025-02-17 15:21:07 +01:00
Dean Herbert
42fb544218
Merge pull request #31912 from bdach/more-snap-grid
...
Fix some more visual issues with osu! distance snap grid
2025-02-17 21:11:17 +09:00
Bartłomiej Dach
2b4b21beb6
Fix distance snap grid line opacity being incorrect on non-1.0x velocities
...
Noticed in passing.
2025-02-17 10:11:47 +01:00
Bartłomiej Dach
8423d9de9b
Fix distance snap grid colours being off-by-one in certain cases
...
Closes https://github.com/ppy/osu/issues/31909 .
Previously: https://github.com/ppy/osu/pull/30062 .
Happening because of rounding errors - in this case the beat index
pre-flooring was something like a 0.003 off of a full beat, which would
get floored down rather than rounded up which created the discrepancy.
But also we don't want to round *too* far, which is why this
frankenstein solution has to exist I think. This is probably all
exacerbated by stable not handling decimal control point start times.
Would add tests if not for the fact that this is like extremely annoying
to test.
2025-02-17 10:11:23 +01:00
Dean Herbert
d5566831d2
Stop beat divisor "slider" from accepting focus
2025-02-17 15:06:35 +09:00
Bartłomiej Dach
de9362dae5
Merge branch 'master' into bss/the-actual-submission
2025-02-13 08:45:23 +01:00
Dean Herbert
b9ed217308
Add basic brighten animation instead
2025-02-11 17:13:34 +09:00
Dean Herbert
1fa8d53232
Disable scale animation when holding editor "test" button
2025-02-11 17:11:20 +09:00
Bartłomiej Dach
daf0130b23
Reword copy to be less verbose
2025-02-11 08:06:12 +01:00
Bartłomiej Dach
38e2f793ca
Add menu items to open beatmap info & discussion pages in browser from editor
2025-02-10 12:47:38 +01:00
Dean Herbert
b8e33a28d2
Minor code refactors
2025-02-10 17:41:38 +09:00
Bartłomiej Dach
45259b374a
Remove unused using
2025-02-10 09:09:43 +01:00
Bartłomiej Dach
895493877c
Allow performing beatmap reload after submission from song select
2025-02-10 09:03:40 +01:00
Dean Herbert
eae1ea7e32
Adjust animations and induce some short delays to make things more graceful
2025-02-10 15:23:25 +09:00
Dean Herbert
930aaecd7f
Fix back button displaying before it should
2025-02-10 15:22:31 +09:00
Dean Herbert
7853456c06
Add delay before browser displays beatmap
2025-02-10 15:12:59 +09:00
Dean Herbert
274b422139
Add percent progress display to editor footer
2025-02-10 14:51:48 +09:00
Bartłomiej Dach
64f0d234d8
Fix exiting being eternally blocked after successful beatmap submission
2025-02-07 15:37:27 +01:00
Dean Herbert
753eae426d
Update strings
2025-02-07 18:42:41 +09:00
Dean Herbert
783ef00785
Change BeatmapSubmissionScreen to use global back button instead of custom implementation
2025-02-07 18:34:48 +09:00
Dean Herbert
95967a2fde
Adjust beatmap stream creation to make a bit more sense
2025-02-07 18:17:49 +09:00
Dean Herbert
12881f3f36
Don't show informational screens for subsequent submissions
...
These are historically only presented to the user when uploading a new
beatmap for the first time.
2025-02-07 18:06:31 +09:00
Dean Herbert
46290ae76b
Disallow changing beatmap / ruleset while submitting beatmap
2025-02-07 18:05:47 +09:00
Dean Herbert
6335228fb0
Merge branch 'master' into bss/the-actual-submission
2025-02-07 17:44:48 +09:00
Dean Herbert
41c8f64806
Simplify naming of endpoints
2025-02-07 17:33:32 +09:00
Bartłomiej Dach
070d402ac2
Merge branch 'bss/api-setup' into bss/the-actual-submission
2025-02-06 08:38:08 +01:00
Bartłomiej Dach
5bcd79956b
Merge branch 'master' into bss/api-setup
2025-02-06 08:30:01 +01:00
Dean Herbert
d9b370e3a1
Add xmldoc for menu implying external consumption
2025-02-06 13:48:38 +09:00
Dean Herbert
dd53ae0e02
Merge pull request #31806 from bdach/bookmark-follow-ups
...
Improve bookmark controls
2025-02-06 13:48:12 +09:00
Bartłomiej Dach
10711e5e27
Add missing partial
2025-02-05 15:39:36 +01:00
Bartłomiej Dach
4cbfb51707
Fix undoing bookmark operations potentially making them unsorted
...
Found in testing of previous commit. This would break seeking between
bookmarks.
Reproduction steps on `master`:
- open map with bookmark
- delete the first bookmark
- undo the deletion of the first bookmark
- seek to previous bookmark will now always seek to the first bookmark
rather than closest preceding regardless of current clock time
2025-02-05 15:30:11 +01:00
Bartłomiej Dach
abce42b1c8
Improve bookmark controls
...
- Bookmark menu items get disabled when they would do nothing.
- Bookmark deletion only deletes the closest bookmark instead of all of
them within the proximity of 2 seconds to current clock time. Action
is only however *enabled* within 2 seconds of a bookmark.
Additionally, logic was moved out of `Editor` because it's a huge class
and I dislike huge classes if they can be at all avoided.
2025-02-05 15:28:27 +01:00
Bartłomiej Dach
78e85dc2c7
Add beatmap submission support
2025-02-05 14:01:37 +01:00
Bartłomiej Dach
fff99a8b40
Implement special exporter intended specifically for submission flows
2025-02-05 14:01:37 +01:00
Bartłomiej Dach
7d299bb2ad
Expose EndpointConfiguration directly in IAPIAccess
2025-02-05 13:31:37 +01:00
Bartłomiej Dach
092b953dca
Implement visual component for displaying submission progress
2025-02-05 13:31:35 +01:00
Dean Herbert
c37fa261c3
Merge pull request #31789 from bdach/distance-snap-fix
...
Fix distance snap grid not properly working due to multiple issues
2025-02-05 18:41:46 +09:00
Dean Herbert
9b79cf6c61
Merge pull request #31784 from bdach/bss/wizard-appearance
...
Implement visual appearance of beatmap submission wizard
2025-02-05 17:34:30 +09:00
NecoDev
13fa49d5b5
Merge branch 'master' into pr
2025-02-05 14:53:20 +08:00
NecoDev
db7b665f4d
Removed unused using
...
For https://github.com/ppy/osu/pull/31780
2025-02-05 13:31:57 +08:00
Bartłomiej Dach
2dbf30a096
Select timing point on enter if no effect point is active at the time
...
Noticed during testing.
2025-02-04 12:44:05 +01:00
Bartłomiej Dach
a0b6610054
Always select the closest control point group regardless of whether it has a timing point
2025-02-04 12:35:02 +01:00
Bartłomiej Dach
731f100aaf
Fix incorrect snapping behaviour when previous object is not snapped to beat
2025-02-04 11:45:15 +01:00
Bartłomiej Dach
4dd4e52e6d
Implement visual appearance of beatmap submission wizard
2025-02-04 09:06:33 +01:00
Bartłomiej Dach
a1185df2eb
Refactor IDistanceSnapProvider to accept slider velocity objects as a reference
...
Method signatures are also changed to be a lot more explicit as to what
inputs they expect.
2025-02-03 14:00:57 +01:00
Bartłomiej Dach
b60a8341e4
Merge pull request #31778 from peppy/editor-menu-mutual-exclusive
...
Make distance snap settings mutually exclusive
2025-02-03 11:58:34 +01:00
NecoDev
55f46e3b66
Added warning
2025-02-03 16:47:38 +08:00
Dean Herbert
26a8fb6984
Make distance snap settings mutually exclusive
2025-02-03 17:34:55 +09:00
Bartłomiej Dach
8718483c70
Avoid moving already placed objects temporally when "limit distance snap to current time" is active
2025-01-31 09:51:13 +01:00
