45041 Commits

This Branch

This Branch

All Branches

• Merge branch 'master' into da-mod-refactor
  Bartłomiej Dach · 2021-07-10 11:41:54 +02:00
  6f89f8e572
• Invert strangely negated condition
  Bartłomiej Dach · 2021-07-10 11:23:38 +02:00
  c5011865fc
• Fix up English in comment
  Bartłomiej Dach · 2021-07-10 11:22:54 +02:00
  494089e402
• Merge pull request #13841 from peppy/update-song-progress-keyboard-handling

  Move handling of replay seek operations out of progress bar

  Bartłomiej Dach · 2021-07-10 11:17:40 +02:00
  e8005e3bfb
• Limit update notifications to once per startup

  This logic was intentionally designed to continue to prompt the user to
  update if they haven't, but that seems pretty anti-user. The change will
  stop the update prompts from showing more than once per game startup,
  unless manually invoked by the user a second time.
  
  Closes https://github.com/ppy/osu/issues/13821.

  Dean Herbert · 2021-07-09 18:23:30 +09:00
  a9250a0d98
• Remove previous seek testing logic from common test scene
  Dean Herbert · 2021-07-09 16:52:03 +09:00
  6ae631b03a
• Modify comment
  ekrctb · 2021-07-09 15:13:54 +09:00
  995ef953c6
• Add test coverage of seeking and pausing
  Dean Herbert · 2021-07-09 14:47:11 +09:00
  9083b28114
• Move handling of replay seek operations out of progress bar

  This is in order to avoid using the now obsoleted property
  `SliderBar.AllowKeyboardInputWhenNotHovered`
  (see https://github.com/ppy/osu-framework/pull/4579).

  Dean Herbert · 2021-07-09 14:28:59 +09:00
  6a5f0e8237
• Simplify bindable update methods
  Dean Herbert · 2021-07-09 13:58:44 +09:00
  741062a6da
• Refactor DifficultyAdjustSettingsControl to help with readability
  Dean Herbert · 2021-07-09 13:50:07 +09:00
  e0277763d0
• Update override matching test to match expectations
  Dean Herbert · 2021-07-09 13:30:14 +09:00
  51bd83b3f4
• Allow null values for ReadCurrentFromDifficulty

  As long as this isn't a constructor parameter it feels best to
  gracefully handle omission. Realistically having it in the ctor is the
  best move, but it doesn't feel great in line with the other parameters
  passed in via object initalisers.

  Dean Herbert · 2021-07-09 13:26:01 +09:00
  f9cd7f10d8
• Standardise variables
  Dean Herbert · 2021-07-09 13:24:26 +09:00
  90326f8864
• Fix storage wrapping logic setting logger too early in startup sequence
  Dean Herbert · 2021-07-09 13:18:49 +09:00
  df4bd86cfc
• Fix storage wrapping logic setting logger too early in startup sequence
  Dean Herbert · 2021-07-09 13:17:25 +09:00
  f3b68a4fbf
• Expand the selection movement limiting code with detailed comments
  ekrctb · 2021-07-09 12:58:08 +09:00
  7e14679606
• Ensure run-from-screen song select reaches correct point in execution

  Fixes issues as seen at
  https://github.com/ppy/osu/runs/3023581865?check_suite_focus=true. Song
  select may take a few frames to perform initial selection as there is a
  bit of internal async logic. This ensures that the beatmap has been
  updated before continuing with test execution.

  Dean Herbert · 2021-07-09 12:36:56 +09:00
  9786e1a932
• Fix migration target having left over files potentially causing test failures

  As seen at
  https://github.com/ppy/osu/pull/13831/checks?check_run_id=3025050324.

  Dean Herbert · 2021-07-09 12:21:25 +09:00
  887035c12e
• Fix test failures due to logger pollution

  As seen at
  https://github.com/ppy/osu/pull/13831/checks?check_run_id=3025050307. I
  can't confirm that this will fix the issue but it looks like the only
  plausible reason. I have confirmed that the logging is not coming from
  the local (first logging is guaranteed to be after `SetupForRun`).

  Dean Herbert · 2021-07-09 12:15:30 +09:00
  9f7c6adb58
• Merge pull request #13831 from nekodex/add-dropdown-sound-to-profile

  Change profile section expansion button to use dropdown sounds

  Dean Herbert · 2021-07-09 11:58:48 +09:00
  dbfeea9880
• Rename function to be more accurate
  Jamie Taylor · 2021-07-09 11:16:47 +09:00
  2eb12a59b7
• Remove no longer necessary method definitions
  Salman Ahmed · 2021-07-09 00:49:05 +03:00
  0223c569df
• Improve documentation

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Salman Ahmed · 2021-07-09 00:39:09 +03:00
  a7be632770
• Fix incorrect curve, move total hits factor into a separate variable for clarity
  StanR · 2021-07-09 00:06:05 +03:00
  02298c2cf4
• Merge pull request #13827 from peppy/fix-mod-select-cross-talk

  Fix cross talk between `ModSelectOverlay`s

  Bartłomiej Dach · 2021-07-08 20:31:55 +02:00
  bd3f8b78cc
• Merge branch 'master' into fix-mod-select-cross-talk
  Bartłomiej Dach · 2021-07-08 19:53:50 +02:00
  3e21eeb7c2
• Merge pull request #13830 from nekodex/volume-control-switching-sound

  Add sound for switching between volume controls

  Dean Herbert · 2021-07-09 01:03:36 +09:00
  1c7854b846
• Merge branch 'master' into consume-bindable-current-factory
  Salman Ahmed · 2021-07-08 18:13:48 +03:00
  f5166d8dd5
• Rename control class to be more descriptive
  Dean Herbert · 2021-07-08 20:37:38 +09:00
  b7803b889e
• Avoid double playback of sample
  Jamie Taylor · 2021-07-08 20:36:25 +09:00
  8746ef0ba9
• Change profile section expansion to use dropdown sounds
  Jamie Taylor · 2021-07-08 20:23:11 +09:00
  546f55d341
• Add sound for switching between volume controls
  Jamie Taylor · 2021-07-08 20:01:39 +09:00
  93eb385dd4
• Don't move selected objects outside the playfield in catch editor
  ekrctb · 2021-07-08 18:49:32 +09:00
  c937c45360
• Add test coverage
  Dean Herbert · 2021-07-08 18:29:54 +09:00
  7153983dd4
• Fix cross talk between ModSelectOverlays
  Dean Herbert · 2021-07-08 17:59:04 +09:00
  af270cccc4
• Cleanup
  StanR · 2021-07-08 11:54:58 +03:00
  592d3fdf00
• Change approach rate bonuses to be less punishing on mid-length maps
  StanR · 2021-07-08 11:52:43 +03:00
  c67f756c75
• Simplify serialisation edge case by moving to Value override
  Dean Herbert · 2021-07-08 17:49:00 +09:00
  ba939c0b65
• Add more comments and xmldoc
  Dean Herbert · 2021-07-08 17:49:00 +09:00
  52ea62e3b2
• Add comprehensive tests of difficulty adjust settings
  Dean Herbert · 2021-07-08 17:49:00 +09:00
  533db01cc0
• Use existing reflection methods to avoid manual binding of ExtendedLimits
  Dean Herbert · 2021-07-08 17:49:00 +09:00
  88b00123f6
• Avoid the need for per-settings control classes
  Dean Herbert · 2021-07-08 17:49:00 +09:00
  bd7c334588
• Add back extended limits support
  Dean Herbert · 2021-07-08 17:49:00 +09:00
  a6e94dd491
• Initial implementation of new flow (only working for approach rate)
  Dean Herbert · 2021-07-08 17:48:08 +09:00
  c4313d6e96
• Fix ShowsDefaultIndicator not actually being consumed
  Dean Herbert · 2021-07-08 17:48:08 +09:00
  fcee69ffe6
• Fix assert step not waiting for transformation
  ekrctb · 2021-07-08 16:40:18 +09:00
  25b94061fd
• Add tests of banana shower placement blueprint
  ekrctb · 2021-07-08 16:36:44 +09:00
  8ac3015f14
• Expose current placement blueprint
  ekrctb · 2021-07-08 16:36:41 +09:00
  4ac7d629d7
• Fix placement blueprint animation is not running in test scene
  ekrctb · 2021-07-08 16:17:09 +09:00
  68116aa042