45041 Commits

This Branch

This Branch

All Branches

• Merge pull request #13928 from ekrctb/juice-stream-path

  Add `JuiceStreamPath` as alternative representation of `JuiceStream` path for catch editor

  Dean Herbert · 2021-07-19 22:18:05 +09:00
  6d49165664
• Merge branch 'master' into fix-replay-date
  Dan Balasescu · 2021-07-19 21:58:37 +09:00
  5ef1fe6948
• Merge pull request #13929 from peppy/i-deep-cloneable

  Create a deep clone of score for score submission purposes

  Dan Balasescu · 2021-07-19 21:58:27 +09:00
  f3bcaf7f11
• Merge branch 'localisation-header' of https://github.com/kj415j45/osu into localisation-header
  kj415j45 · 2021-07-19 20:48:54 +08:00
  9c642f0028
• Add localisation for BeatmapSetHeader
  kj415j45 · 2021-07-19 20:45:03 +08:00
  fe7aa73aad
• Fix request failing due to parameters
  smoogipoo · 2021-07-19 21:24:22 +09:00
  0a43e54dfc
• Fix item ordering
  ekrctb · 2021-07-19 21:05:36 +09:00
  81d0a9bd9c
• use same code style

  Co-authored-by: frenzibyte <frenzibyte@gmail.com>

  kj415j45 · 2021-07-19 20:02:39 +08:00
  3a4da6b867
• Fix web request failing if password is null
  smoogipoo · 2021-07-19 20:57:16 +09:00
  a001e4aa16
• Add room joining tests
  smoogipoo · 2021-07-19 20:55:14 +09:00
  05295241b8
• Fix possible exception
  smoogipoo · 2021-07-19 20:50:30 +09:00
  3168a927dc
• Merge 'master' of ppy/osu into localisation-header
  kj415j45 · 2021-07-19 19:46:40 +08:00
  48d398b04a
• Move strings
  kj415j45 · 2021-07-19 19:27:33 +08:00
  765881d8b0
• symbol renaming

  Co-authored-by: frenzibyte <frenzibyte@gmail.com>

  kj415j45 · 2021-07-19 19:27:33 +08:00
  57eed88601
• Apply suggestion from code review

  Co-authored-by: frenzibyte <frenzibyte@gmail.com>

  kj415j45 · 2021-07-19 19:27:33 +08:00
  5fc1397564
• Fix API request potentially firing failed events after completion

  Specifically, `Cancel()` calls were not thread safe. Due to a series of
  events, `ListPollingComponent` could call `Cancel` from a non-update
  thread, leading to a race condition where both a `Success` and `Fail`
  event can be fired.
  
  This is intended to be the simplest fix possible, locking and guarding
  specifically on the callbacks. Further work could be done in the future
  to improve the flow surrounding `pendingFailure`, potentially reducing
  redundant work and cleaning up the code, but that's not happening here.
  
  Closes https://github.com/ppy/osu/issues/13632.

  Dean Herbert · 2021-07-19 20:27:01 +09:00
  80c2b1449b
• Merge https://github.com/kj415j45/osu into localisation-header
  kj415j45 · 2021-07-19 19:24:09 +08:00
  bf6204f64e
• Add [NotNull]
  ekrctb · 2021-07-19 20:20:10 +09:00
  41169fbdaf
• Fix password not copied from multiplayer client
  smoogipoo · 2021-07-19 20:20:08 +09:00
  2eec524f27
• Remove local APIRoom from test multiplayer client
  smoogipoo · 2021-07-19 20:19:23 +09:00
  d6aa15e5d7
• Move child drawable creation of CatchPlayfield from constructor to load.
  ekrctb · 2021-07-19 20:18:17 +09:00
  7201cfe0b4
• Fix catcher trails displayed in wrong place
  ekrctb · 2021-07-19 20:13:31 +09:00
  879467961f
• Pass DroppedObjectContainer via constructor instead of DI

  It is now just one level deep, so it is not beneficial to use DI here.
  This effectively reverts ae09c23e.

  ekrctb · 2021-07-19 20:11:49 +09:00
  b88ee3c1a1
• Add test
  smoogipoo · 2021-07-19 20:08:29 +09:00
  1b9d297911
• Also copy password in test room manager
  smoogipoo · 2021-07-19 20:07:56 +09:00
  a5a0f12e19
• Set HasPassword correctly in the response room
  smoogipoo · 2021-07-19 20:03:32 +09:00
  26d0eea485
• Use room password to fill settings textbox
  smoogipoo · 2021-07-19 20:03:32 +09:00
  2515785f93
• Make test multiplayer client validate password
  smoogipoo · 2021-07-19 20:03:27 +09:00
  8c0daa89a0
• Update test room manager to not return passwords
  smoogipoo · 2021-07-19 20:03:27 +09:00
  063f14da98
• Replace usage of CatcherArea.MovableCatcher with Catcher
  ekrctb · 2021-07-19 19:52:40 +09:00
  50f9e5f362
• Create Catcher in CatchPlayfield
  ekrctb · 2021-07-19 19:44:40 +09:00
  97059a9f50
• Fix date being updated on replays unexpectedly
  Dean Herbert · 2021-07-19 19:28:35 +09:00
  b3f60c8253
• Move clone to earlier in the process
  Dean Herbert · 2021-07-19 19:18:34 +09:00
  f16b4957aa
• Merge pull request #13887 from ekrctb/legacy-converted-y

  Preserve Y position of hit objects in osu!catch

  Dean Herbert · 2021-07-19 18:48:23 +09:00
  23ef666f34
• Merge pull request #13926 from peppy/set-rank-on-failed-submission

  Set score's rank on a failed submission

  Dan Balasescu · 2021-07-19 18:45:21 +09:00
  f1f6af88a1
• Move playfield constant to top of file and make internal
  Dean Herbert · 2021-07-19 18:41:29 +09:00
  443058f879
• Merge pull request #13908 from peppy/editor-disallow-placement-when-untimed

  Fix editor composer allowing object placement without timing present

  Dan Balasescu · 2021-07-19 18:37:19 +09:00
  473011070f
• Merge pull request #13927 from ekrctb/catch-hitobjec-utils

  Change the way position is set for components of catch editor

  Dean Herbert · 2021-07-19 18:26:11 +09:00
  5f94692aa6
• Mark identifiers as verbatim strings
  Dean Herbert · 2021-07-19 18:15:09 +09:00
  13cb658d29
• Merge branch 'master' into localise-profile-overlay
  Dean Herbert · 2021-07-19 18:14:59 +09:00
  80539fefe1
• Ensure tool is always set back to select tool when beatmap becomes untimed
  Dean Herbert · 2021-07-19 17:08:40 +09:00
  b29209d13f
• Rename radio button classes to be local to editor
  Dean Herbert · 2021-07-19 16:57:12 +09:00
  bde35d9f21
• Simplify DependencyProvidingContainer

  Using an array of tuple for dependencies instead of using children.

  ekrctb · 2021-07-19 14:37:19 +09:00
  87c39909c6
• Copy score during submission process to ensure it isn't modified
  Dean Herbert · 2021-07-19 14:14:28 +09:00
  caba78cb5d
• Add deep cloning support to Score/ScoreInfo/Replay
  Dean Herbert · 2021-07-19 14:14:28 +09:00
  e507faef29
• Add tests of JuiceStreamPath.

  "Property testing" is heavily used, tests that generates random cases and asserting properties.
  That gives high confidence of round-trip correctness of `SliderPath` conversion, for example.

  ekrctb · 2021-07-19 13:59:10 +09:00
  fffe0d2e57
• Add JuiceStreamPath to allow editing JuiceStream in catch editor

  A `JuiceStream` holds a legacy `SliderPath` as the representation of the path.
  However, the `SliderPath` representation is difficult to work with because `SliderPath` works in 2D position, while osu!catch works in `(time, x)` coordinates.
  This `JuiceStreamPath` represents the path in a more convenient way, a polyline connecting list of `(distance, x)` vertices.

  ekrctb · 2021-07-19 13:59:10 +09:00
  be495a7488
• Use added utility function
  ekrctb · 2021-07-19 13:33:46 +09:00
  c347584851
• Add a function to compute hit object position in catch editor
  ekrctb · 2021-07-19 13:33:22 +09:00
  70c9d7105f
• Add IDeepCloneable interface and update existing CreateCopy methods to use it
  Dean Herbert · 2021-07-19 12:54:17 +09:00
  3c028ce05c