Dean Herbert
928bce8fcd
Fix crash when attempting to watch a replay when the storage file doesn't exist
2022-08-30 18:18:46 +09:00
Dan Balasescu
0e68620f70
Merge pull request #20026 from peppy/notifications-nrt
...
Apply NRT to notification classes
2022-08-30 17:23:11 +09:00
Dean Herbert
e39d236f27
Merge pull request #20028 from smoogipoo/add-legacy-total-score
...
Add LegacyTotalScore to SoloScoreInfo
2022-08-30 16:39:25 +09:00
Dean Herbert
b8fda1a16f
Apply NRT to notification classes
...
and tidy things up a bit.
2022-08-30 15:57:10 +09:00
Dan Balasescu
799c015bff
Add LegacyTotalScore to SoloScoreInfo
2022-08-30 15:50:19 +09:00
Dean Herbert
ea7e5797d1
Merge pull request #20024 from smoogipoo/populate-maximum-statistics-test
...
Populate `MaximumStatistics` for test scores
2022-08-30 15:44:52 +09:00
Dan Balasescu
8b3742188f
Fix test by also clearing out maximum statistics
2022-08-30 15:42:36 +09:00
Dan Balasescu
5202c15a0e
Populate MaximumStatistics for test scores
2022-08-30 15:11:39 +09:00
Dean Herbert
706ac3e44f
Merge pull request #19982 from OliBomby/fix-illegal-merge
...
Fixed 0 length merge being allowed
2022-08-30 12:28:18 +09:00
OliBomby
44916c51d7
Updated canMerge check to be totally accurate
2022-08-30 00:18:55 +02:00
Dean Herbert
2e5770be4e
Move helper method to bottom of class
2022-08-30 02:51:42 +09:00
OliBomby
d50e9caa11
Moved guards to separate canMerge method
2022-08-29 18:58:29 +02:00
Dan Balasescu
e34c8e4975
Merge pull request #19716 from MBmasher/fl-grid
...
Nerf repeated angles in Flashlight skill
2022-08-29 21:15:45 +09:00
Dan Balasescu
0491addbbd
Merge pull request #19974 from peppy/no-gameplay-clock-editor-offset
...
Fix editor not applying offsets
2022-08-29 21:10:29 +09:00
Dan Balasescu
8e42af8e66
Merge pull request #19973 from peppy/no-gameplay-clock-beat-synced-container
...
Fix beat synced components not applying offsets
2022-08-29 20:43:26 +09:00
Dean Herbert
82b9e1f0eb
Merge pull request #20011 from smoogipoo/scoring-refactor
...
Refactor scoring to remove async methods / simplify
2022-08-29 19:55:27 +09:00
Dan Balasescu
eb3601b7ff
Merge pull request #20013 from peppy/always-reprocess-beatmap-after-update
...
Always reprocess beatmaps after a user update request
2022-08-29 18:50:27 +09:00
Dan Balasescu
e3e204001e
Merge pull request #19907 from peppy/ruleset-api-versioning
...
Add ruleset API versioning
2022-08-29 18:50:01 +09:00
Dan Balasescu
b25d1fbbae
Merge pull request #20012 from peppy/target-mod-toggle-metronome
...
Add setting to toggle metronome in "Target" mod
2022-08-29 18:47:43 +09:00
Dean Herbert
2e3c62296a
Merge branch 'master' into no-gameplay-clock-beat-synced-container
2022-08-29 18:22:54 +09:00
Dean Herbert
3eda284b03
Always reprocess beatmaps after a user update request
...
This covers the rare case where metadata may have changed server-side but not
the beatmap itself.
Tested with the provided user database to resolve the issue.
Closes #19976 .
2022-08-29 18:17:42 +09:00
Dan Balasescu
07b502f69a
Simplify OrderByTotalScore implementation
2022-08-29 17:58:57 +09:00
Salman Ahmed
b56fbacaa6
Merge pull request #19409 from peppy/carousel-maintain-selection-over-update
...
Fix beatmap carousel not maintaining selection if currently selected beatmap is updated
2022-08-29 11:55:04 +03:00
Salman Ahmed
f2378d3fde
Merge branch 'master' into carousel-maintain-selection-over-update
2022-08-29 11:23:22 +03:00
Dean Herbert
780121eeee
Add setting to toggle metronome in "Target" mod
...
As mentioned in https://github.com/ppy/osu/discussions/20006#discussioncomment-3496732 .
2022-08-29 17:12:10 +09:00
Dean Herbert
9b830d063f
Merge pull request #20010 from smoogipoo/scoreprocessor-no-rewrite-statistics
...
Don't include misses in failed score statistics
2022-08-29 17:07:13 +09:00
Dean Herbert
2dafa041a7
Account for offset being applied to editor clock time in TestSceneEditorClock
2022-08-29 16:42:50 +09:00
Dean Herbert
cf8fad045d
Update template rulesets to include baked value
2022-08-29 16:32:41 +09:00
Dean Herbert
be5c6232e8
Encapsulate Track inside a FramedClock to avoid mutating operations
2022-08-29 16:29:19 +09:00
Dean Herbert
c50695ea49
Merge branch 'master' into no-gameplay-clock-beat-synced-container
2022-08-29 16:16:59 +09:00
Dan Balasescu
d4a37725c4
Adjust test
2022-08-29 15:59:57 +09:00
Dean Herbert
2b7b77157a
Merge pull request #20008 from smoogipoo/scoreprocessor-computescore
...
Refactor/merge `ScoreProcessor.ComputeScore()` methods
2022-08-29 15:54:43 +09:00
Dan Balasescu
81ac0daba8
Update xmldoc
2022-08-29 15:51:12 +09:00
Dan Balasescu
d75543ad68
Simplify GetMaximumAchievableCombo further
2022-08-29 15:36:10 +09:00
Dan Balasescu
423f6f90f2
Remove async calls from ScoreManager
2022-08-29 15:34:08 +09:00
Dan Balasescu
b2e80ca7f0
Don't include misses in failed score statistics
2022-08-29 15:27:19 +09:00
Dean Herbert
e8ae6840ea
Add test coverage of selection being retained
2022-08-29 15:23:34 +09:00
Dean Herbert
892f43da43
Add test coverage of ruleset being marked unavailable if methods are throwing
2022-08-29 14:28:55 +09:00
Dean Herbert
5ff4e6a4fe
Add test coverage for outdated ruleset
2022-08-29 14:26:12 +09:00
Dean Herbert
90b9c02ac6
Remove "internal" identifier as unnecessary
2022-08-29 14:01:15 +09:00
Dan Balasescu
c0b13c7e1f
Refactor ScoreProcessor ComputeScore() methods
2022-08-29 13:51:10 +09:00
Dean Herbert
3e246caf05
Merge pull request #19995 from its5Q/import-crash-fix
...
Fix crash with legacy import from incomplete installs
2022-08-28 13:52:12 +09:00
its5Q
0cc6a76c17
Fix crash with legacy import from incomplete installs
2022-08-28 14:13:38 +10:00
OliBomby
16e0ec2f88
Fixed 0 length merge being allowed
2022-08-27 13:53:50 +02:00
MBmasher
b082dc1fe4
Slightly buff flashlight multiplier
2022-08-27 18:31:07 +10:00
Dan Balasescu
cf6bb3b030
Merge pull request #19958 from peppy/fix-fail-freq-stuck
...
Ensure fail animation sequence isn't run after the player exit sequence has started
2022-08-27 00:58:41 +09:00
Dean Herbert
35f0273c8a
Merge pull request #19850 from nekodex/text-selection-sfx
...
Add audio feedback for text selection
2022-08-27 00:54:28 +09:00
Salman Ahmed
764ab9f095
Merge branch 'master' into text-selection-sfx
2022-08-26 17:50:03 +03:00
Dan Balasescu
289b6f1a58
Merge pull request #19924 from peppy/fix-playlist-overlay-test-failures
...
Fix intermittent test failures in `TestScenePlaylistOverlay`
2022-08-26 23:36:16 +09:00
Dean Herbert
470bec7949
Move private method down
2022-08-26 23:29:03 +09:00
