Endrik Tombak
bbbaaae3ee
Write tests
2020-03-26 19:18:16 +02:00
Dan Balasescu
d0c7b49376
Merge branch 'master' into fix-carousel-root-selects-from-nothing
2020-03-23 11:34:04 +09:00
smoogipoo
bf70276496
Fix test re-using the same beatmap sets
2020-03-23 11:12:36 +09:00
Dean Herbert
8136ea561e
Fix a couple of broken tests
2020-03-20 15:02:13 +09:00
Dean Herbert
9b60b535e5
Fix selection not occurring when switching from empty ruleset on first load
2020-03-20 15:01:26 +09:00
Dean Herbert
3a50c4bb51
Update tests
2020-03-19 18:58:22 +09:00
Dean Herbert
9bb3a6c677
Merge branch 'master' into click-group-difficulty-icons
2020-03-16 12:01:09 +09:00
Dean Herbert
d6be8eec0c
Merge branch 'master' into click-disabled-difficulty-icons
2020-03-16 11:30:57 +09:00
Dan Balasescu
bd05462a7f
Merge branch 'master' into carousel-selection-fallback-improvement
2020-03-16 10:53:10 +09:00
Dan Balasescu
25a35a1370
Merge branch 'master' into always-apply-ruleset-filter
2020-03-16 10:32:36 +09:00
Dean Herbert
de9857ccdc
Fix incorrect id reference in test
2020-03-13 11:02:53 +09:00
Dean Herbert
ba0dec891d
Update test temporarily
2020-03-13 10:58:36 +09:00
Dean Herbert
bab197553e
Update carousel test logic to match new carousel selection behaviour
2020-03-12 19:55:25 +09:00
Dean Herbert
250061ddf5
Fix test failure due to off-screen panel
2020-03-12 19:46:21 +09:00
Dean Herbert
1819a15509
Make test ID assigning simpler
2020-03-12 19:27:54 +09:00
Dean Herbert
db5c8043db
Add test covering ruleset change on difficulty icon selection
2020-03-12 18:42:08 +09:00
Dean Herbert
6e11c3014c
Allow grouped difficulty icons to be clicked
2020-03-12 18:42:08 +09:00
Dean Herbert
2bcf079386
Update carousel test logic to match new carousel selection behaviour
2020-03-12 18:42:08 +09:00
Dean Herbert
5537b279de
Fix failing test occasionally getting wrong ruleset beatmap
2020-03-12 18:39:43 +09:00
Dean Herbert
933a8ffc8a
Add test coverage
2020-03-12 17:10:51 +09:00
Dean Herbert
28ac5af91c
Fix beatmap carousel tests loading beatmap manager beatmaps in test browser
2020-03-12 16:53:23 +09:00
Dean Herbert
7b368dca35
Add test coverage
2020-03-11 02:59:24 +09:00
Dean Herbert
a047456354
Revert changes to make HitObject abstract
2020-02-25 19:07:15 +09:00
Dean Herbert
ffc7eaa3f2
Fix hitobjects with unknown lifetimes by enforcing non-null judgement
...
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.
This fixes BananaShower and JuiceStreams in osu!catch.
This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 13:49:06 +09:00
Dean Herbert
cd666166d5
Merge pull request #7809 from voidedWarranties/proposal-difficulty-icon-select
...
Allow selecting/playing a specific difficulty using the beatmapset difficulty icons
2020-02-21 10:24:12 +09:00
smoogipoo
1a689231c2
Support null leaderboard position
2020-02-20 14:51:25 +09:00
voidedWarranties
8c81f1e684
Move CarouselBeatmap access to private, test using indices
2020-02-15 17:51:55 -08:00
voidedWarranties
8e1ecddb1d
Add testing
2020-02-14 17:23:24 -08:00
Dean Herbert
333f976580
Fix test finding deleted beatmaps under dotnet-test
2020-02-11 17:47:10 +09:00
Dean Herbert
926cde9afc
Fix potential test failures
2020-02-10 18:17:59 +09:00
Dean Herbert
d61516e10c
Add failing tests
2020-02-10 16:59:54 +09:00
Dan Balasescu
93952d438f
Merge pull request #7677 from peppy/decouple-mod-select-bindable
...
Decouple ModSelectOverlay from global SelectedMods
2020-02-03 16:27:47 +09:00
Dean Herbert
9183c78319
Fix crash on exiting song select with ctrl-enter autoplay
2020-02-03 16:04:32 +09:00
Bartłomiej Dach
e90ae667b7
Add failing tests
2020-02-01 16:08:24 +01:00
Bartłomiej Dach
a74d22d9e5
Extract beatmap stats test to separate scene
2020-02-01 15:50:33 +01:00
Dean Herbert
ab7bbf38a8
Set default beatmap later in test initialisation
2020-01-31 16:14:55 +09:00
Dean Herbert
5f48affcba
Centralise screen exit logic to ScreenTestScene
2020-01-31 14:19:29 +09:00
smoogipoo
f457ecaf83
Fix random test failures
2020-01-29 13:54:12 +09:00
Dean Herbert
fd7f07433d
Ensure selection has occurred before storing value
2020-01-27 18:26:44 +09:00
Dean Herbert
1f0aaabf7b
Add tests
2020-01-27 12:21:17 +09:00
smoogipoo
bb390b4470
Add test
2020-01-24 19:40:20 +09:00
Dean Herbert
56724d2580
Merge branch 'master' into #7146
2020-01-10 01:08:20 +08:00
Dean Herbert
ab9603b06a
Merge remote-tracking branch 'upstream/master' into #7146
2020-01-09 17:08:12 +08:00
smoogipoo
91735ff367
Update MathUtils namespace usages
2020-01-09 13:43:44 +09:00
Lucas A
3bd3ebad49
Move placeholders to a dedicated namespace
2020-01-04 19:56:34 +01:00
Willy Tu
e23c71be80
Update Resolved and Cached attribute issues
2020-01-03 11:34:26 -08:00
Willy Tu
0a4e180ce7
Merge branch 'master' of github.com:ppy/osu into #7146
2020-01-03 11:32:06 -08:00
Dean Herbert
69227d6179
Add asserts
2019-12-22 06:37:18 +09:00
Dean Herbert
725008286f
Move test and remove pointless duplicate tests
2019-12-22 06:09:16 +09:00
Dean Herbert
df14f473c2
Split tests out
2019-12-20 19:52:54 +09:00
Willy Tu
6abbd33b51
Fixed CI issues
2019-12-19 21:57:14 -08:00
Willy Tu
8ab26e8889
Update Tests with dependencies on LeaderboardScore. Added its dependency on DialogOverlay for the tests. Added test for deleting individual local score
2019-12-19 21:29:54 -08:00
Dean Herbert
54572b6de9
Update selected mdos references
2019-12-18 16:42:18 +09:00
Dean Herbert
d7eb4f73f4
Merge branch 'master' into update-beatmap-settings
2019-12-16 14:57:57 +09:00
Dean Herbert
bc31146560
Mods -> SelectedMods
2019-12-13 21:45:38 +09:00
unknown
3945e7403a
improve tests and refactor AdvancedStats
2019-12-13 09:39:54 +08:00
unknown
ec5b506960
apply mod difficulty settings during song select
2019-12-12 23:41:46 +08:00
Dean Herbert
cdde5d1d69
Fix song select filters not reapplied if in a child screen
...
Closes https://github.com/ppy/osu/issues/6980 .
2019-12-10 02:30:23 +09:00
Dean Herbert
f0d49d0cdf
Decouple APILegacyScoreInfo from ScoreInfo
2019-12-03 15:31:11 +09:00
Dean Herbert
296fff9243
Merge remote-tracking branch 'upstream/master' into fix-carousel-double-filter
2019-11-15 18:20:36 +09:00
Dean Herbert
b8bb97607b
Merge remote-tracking branch 'upstream/master' into fix-mod-retention
2019-11-15 13:46:44 +09:00
Dean Herbert
e81dfcad4c
Fix remaining cases of pollution
2019-11-15 11:46:32 +09:00
Dean Herbert
22c3be2c6f
Clear count variables on carousel creation
2019-11-15 11:26:01 +09:00
Dean Herbert
1109d201c3
Add failing test
2019-11-14 13:28:13 +09:00
Dean Herbert
2fe068174a
Fix unnecessary string interpolation
2019-11-13 19:42:33 +09:00
Dean Herbert
2cd156f3d4
Clean up carousel tests
2019-11-13 19:09:03 +09:00
Dean Herbert
bca1be0bfa
Add failing test
2019-11-13 18:54:33 +09:00
Huo Yaoyuan
ccc8aa6fa4
Apply brace style.
2019-11-11 20:13:13 +08:00
Bartłomiej Dach
022cc13952
Add beatmap carousel item sorting stability test
...
Add visual test to ensure sorting stability when sorting criteria are
applied in the beatmap carousel.
2019-10-27 22:55:46 +01:00
smoogipoo
12cd57744b
Make RulestStore initialise at construction time
2019-10-15 16:14:06 +09:00
Dan Balasescu
69b9e359bf
Merge branch 'master' into fix-ss-track-playback
2019-10-09 12:26:07 +09:00
Dean Herbert
8ebccfe31f
Add comprehensive audio state tests
2019-10-08 17:03:13 +09:00
Dean Herbert
f284d096b7
Fix ignored song select test
2019-10-08 16:37:47 +09:00
Dean Herbert
46d6c5ec3b
Add failing test
2019-10-07 15:17:03 +09:00
Dean Herbert
62c4c1266e
Move private functions to bottom
2019-10-07 15:17:03 +09:00
Joehu
de658c932e
Fix test regression
2019-10-04 17:22:42 -07:00
smoogipoo
a5e1cb8feb
Merge remote-tracking branch 'Game4all/master' into truncate-metadata-on-wedge
2019-10-04 11:21:33 +09:00
Dean Herbert
e9c73ce30f
Fix random failures on BeatmapCarousel filter test
...
The "un-filter" step causes a `SelectNextRandom` invocation. If this happens to select a difficulty in set 3 other than the previously buffered difficulty #2 , the subsequent test would fail.
I've split this test out to remove the random element, but added a new assert to ensure buffered (previously visited?) difficulty is re-selected on return to the same set.
2019-10-03 16:21:14 +08:00
Dean Herbert
539f3329ce
Rename method to match new behaviour
2019-09-29 12:23:18 +08:00
Bartłomiej Dach
2487d4f0f2
Migrate beatmap carousel test to AddUntilStep
...
Due to non-deterministic test failures in TestSceneBeatmapCarousel,
migrate the checkSelected helper step from AddAssert to AddUntilStep.
This adds more leniency for performance-related issues while still
checking the desired behaviour.
2019-09-28 11:58:27 +02:00
Dean Herbert
2089f6fc42
Fix potential test fail case
2019-09-25 14:28:35 +09:00
Joehu
102dbd85bd
Fix CI errors
2019-09-24 16:48:22 -07:00
Joehu
cc6030ca14
Update beatmap info wedge tests
2019-09-24 16:23:36 -07:00
Joehu
8efba255c3
Add truncation test
2019-09-24 16:21:08 -07:00
Dean Herbert
4a59e3351e
Update beatmap carousel tests code style
...
Also fixes one issue I spotted in BeatmapCarousel related to incorrectly holding a selection after new sets are loaded.
2019-09-25 02:42:12 +09:00
Bartłomiej Dach
51509f6be0
Add filter steps to carousel visual test
...
Just a couple of steps for added coverage in visual tests. Very
on-the-surface, the unit tests are supposed to cover the gory details.
2019-09-22 00:20:54 +02:00
Dean Herbert
2b6c9aeb26
Move top score container to more local namespace
2019-09-19 15:38:40 +09:00
Dean Herbert
9b35de9ce1
Update tests
2019-09-19 15:23:37 +09:00
Dean Herbert
a7b6895d4c
Revert changes to BeatmapDetailArea
2019-09-19 14:26:15 +09:00
Dean Herbert
e5509cd390
Rename test
2019-09-19 13:19:48 +09:00
Dean Herbert
2e0a85c2f6
Merge remote-tracking branch 'upstream/master' into songselect-best-user-score
2019-09-19 12:57:30 +09:00
Dan Balasescu
4910c23482
Merge branch 'master' into show-beatmap-not-selected-in-leaderboards
2019-09-10 17:43:42 +09:00
iiSaLMaN
22fabef344
Use TestWorkingBeatmap in BeatmapDetailsArea tests
2019-09-09 19:52:31 +03:00
iiSaLMaN
a1c580f27e
Create "none selected" placeholder state
2019-09-05 05:56:21 +03:00
Dean Herbert
7885c79467
Make bindables private
2019-08-27 14:31:34 +09:00
Dean Herbert
69145eb83a
Merge branch 'master' into select-filters-persistence
2019-08-27 14:12:59 +09:00
iiSaLMaN
830ddd6ed9
Use all rulesets for many difficulties test
2019-08-24 01:31:53 +03:00
Lucas A
6ea10ada34
Fix visual tests.
2019-08-23 13:31:45 +02:00
Dean Herbert
c14c3ba8ec
Move database isolation logic to OsuTestScene for easier reuse
2019-07-29 16:57:02 +09:00
Dean Herbert
27258e3a9b
Rename test scene to match class
2019-07-15 14:38:28 +09:00
Andrei Zavatski
a01e7260e0
Testcase fix
2019-07-14 16:49:46 +03:00
Andrei Zavatski
19680c8df8
Minor adjustments
2019-07-14 16:37:05 +03:00
Andrei Zavatski
ecf0e62484
CI fixes
2019-07-14 16:16:21 +03:00
Andrei Zavatski
963e025bb8
Make it works and some layout adjustments
2019-07-14 14:03:14 +03:00
Andrei Zavatski
d1409d4610
Add top score section into beatmap detail area
2019-07-14 13:33:47 +03:00
Andrei Zavatski
922c3c89ae
Make leaderboard score use metric system
2019-07-14 12:47:35 +03:00
Andrei Zavatski
d30ae24f58
Use Bindable for setting score
2019-07-14 12:40:54 +03:00
Andrei Zavatski
0584ee9ce5
Basic implementation
2019-07-14 12:34:12 +03:00
iiSaLMaN
129899f419
Add a BPM property in BeatmapInfo
2019-07-08 10:43:35 +03:00
iiSaLMaN
90d5484818
Return BPM back to OnlineInfo
...
Revert commit of "Move BPM out of OnlineInfo"
2019-07-08 09:10:41 +03:00
iiSaLMaN
729f0901f7
Move Length out of OnlineInfo
2019-07-07 20:25:36 +03:00
iiSaLMaN
3ea9629daf
Move BPM out of OnlineInfo
2019-07-07 20:11:44 +03:00
iiSaLMaN
31e1d204d4
Add test for sorting by BPM and Length
2019-07-07 18:27:12 +03:00
Dean Herbert
cd31d2bc05
Simplify tests
2019-07-07 13:06:31 +09:00
Joehu
5767f4360e
Remove unnecessary test checks
2019-07-06 12:07:13 -07:00
Joehu
1534b75d27
Fix ci errors
2019-07-04 21:39:21 -07:00
Joehu
04ef6c4d45
Add beatmap status tests
2019-07-04 21:25:10 -07:00
Dean Herbert
2d20c088f7
Remove test which is failing due to magic numbers
2019-06-18 18:31:42 +09:00
Dean Herbert
587edcb716
Merge branch 'master' into fix-beatmapoverlay-graphs
2019-06-15 13:42:13 +09:00
smoogipoo
512b9dfd82
Fix potential songselect testcase failures
2019-06-14 20:18:22 +09:00
smoogipoo
d8ef18c56a
Remove unused using
2019-06-13 19:16:19 +09:00
smoogipoo
2ad4045b2e
Refactor beatmap details testcase
2019-06-13 18:51:41 +09:00
smoogipoo
f54f6e552b
Fix beatmap details potentially using the incorrect metrics
2019-06-13 18:04:42 +09:00
smoogipoo
0a79b444d9
Move metrics to beatmap set
2019-06-13 16:52:49 +09:00
smoogipoo
aef94ce9f1
Make BeatmapMetrics non-IEnumerables
2019-06-13 16:30:38 +09:00
smoogipoo
243cd517ad
Merge remote-tracking branch 'origin/master' into backgrounded-beatmap-status-lookups
...
# Conflicts:
# osu.Game.Tests/Visual/SongSelect/TestScenePlaySongSelect.cs
2019-06-12 17:24:16 +09:00
smoogipoo
28f8b04765
Merge remote-tracking branch 'origin/master' into backgrounded-beatmap-status-lookups
2019-06-12 16:47:56 +09:00
smoogipoo
5d3fa51360
Merge remote-tracking branch 'origin/master' into selection-update
2019-06-12 15:10:57 +09:00
Dean Herbert
606be3d7ce
Merge branch 'master' into backgrounded-beatmap-status-lookups
2019-06-12 00:22:47 +09:00
David Zhao
a53ade07a5
remove unused using
2019-06-11 15:51:57 +09:00
David Zhao
975bb3db8a
cleanup
2019-06-11 15:51:14 +09:00
Dean Herbert
609a82bc94
Update VisibilityContainer usage in line with framework
2019-06-11 15:13:58 +09:00
David Zhao
d4ba67747b
fix test count
2019-06-11 14:24:04 +09:00
Dean Herbert
fc0fc8f164
Merge branch 'master' into backgrounded-beatmap-status-lookups
2019-06-10 19:37:35 +09:00
David Zhao
41e3e2222b
fix test
2019-06-10 18:40:49 +09:00
David Zhao
1aa865c3fb
split out method for reuse
2019-06-10 18:34:24 +09:00
Dean Herbert
d7cb932606
Merge branch 'master' into selection-update
2019-06-10 17:51:40 +09:00
Dean Herbert
600503ec8e
Use Task.Run/Wait to avoid warnings
2019-06-10 13:42:29 +09:00
iiSaLMaN
d3ff2c6dd5
Use ScoreRank.D instead of F
2019-06-08 19:34:03 +03:00
Dean Herbert
b52276c489
Pass individual components to DummyWorkingBeatmap, not game
2019-05-31 14:51:12 +09:00
Dean Herbert
f33a5bc54c
Centralise and update WorkingBeatmap creation in test cases
2019-05-31 14:40:53 +09:00
David Zhao
1a871af552
Fix hide selection, add test
2019-05-28 19:15:29 +09:00
David Zhao
436760de96
Change test name
2019-05-28 14:34:52 +09:00
David Zhao
e59a00ac6e
Remove excessive selection updating
2019-05-28 14:04:33 +09:00
Roman Kapustin
459a285cd8
Rename test cases to test scenes inline with the framework change
2019-05-14 22:37:25 +03:00
smoogipoo
d7c09e7dbd
Merge remote-tracking branch 'origin/master' into fix-new-inspections
...
# Conflicts:
# osu.Game.Rulesets.Catch/Judgements/CatchDropletJudgement.cs
# osu.Game.Rulesets.Catch/Judgements/CatchJudgement.cs
# osu.Game.Rulesets.Mania/Scoring/ManiaScoreProcessor.cs
# osu.Game.Rulesets.Osu/Replays/OsuAutoGenerator.cs
# osu.Game.Rulesets.Osu/UI/Cursor/CursorTrail.cs
# osu.Game.Tests/Visual/SongSelect/TestCaseBeatmapScoresContainer.cs
# osu.Game/Graphics/OsuFont.cs
# osu.Game/Online/API/Requests/Responses/APILegacyScoreInfo.cs
# osu.Game/Overlays/Profile/Header/BadgeContainer.cs
# osu.Game/Overlays/Profile/ProfileHeader.cs
# osu.Game/Screens/Select/PlaySongSelect.cs
# osu.Game/Skinning/LegacySkinDecoder.cs
2019-05-07 13:20:17 +09:00
smoogipoo
0222424aef
Make mods IReadOnlyList<Mod> gamewide
...
Prevents potential multiple evaluations of enumerable.
2019-04-10 17:20:36 +09:00
smoogipoo
4310f07a5c
Rename SelectedMods -> Mods
2019-04-10 12:03:57 +09:00
smoogipoo
cbb3fdaca8
Fix various crashes due to bindable being disabled
2019-04-09 12:59:32 +09:00
smoogipoo
c584967eb1
Remove mods from workingbeatmap
2019-04-09 12:59:32 +09:00
