486 Commits

• Ensure tool is always set back to select tool when beatmap becomes untimed
  Dean Herbert · 2021-07-19 17:08:40 +09:00
  b29209d13f
• Rename radio button classes to be local to editor
  Dean Herbert · 2021-07-19 16:57:12 +09:00
  bde35d9f21
• Disable toolbox composition buttons when beatmap is not timed
  Dean Herbert · 2021-07-17 02:30:13 +09:00
  eac9b1ec7e
• Add new checks to verifiers
  Naxess · 2021-07-13 10:53:25 +02:00
  3a5912e35e
• Add zero-length objects check and tests
  Naxess · 2021-07-13 10:50:11 +02:00
  6da2a3d51f
• Fix hit object selection blueprint potential null reference
  ekrctb · 2021-07-08 14:19:00 +09:00
  663ffae42f
• Add check for spanDuration <= 0 prior to division
  Naxess · 2021-06-27 15:40:09 +02:00
  9f9e96ce9e
• Improve acceptable difference for repeat edges

  Likelihood that `spanDuration` is greater than E+7 is quite low in any realistic case, so this should work fine.

  Naxess · 2021-06-27 15:39:31 +02:00
  a4a5325b73
• Improve precision for repeat edges
  Naxess · 2021-06-27 03:26:35 +02:00
  4cfa0ae5ec
• Add "or equal to" to volume threshold xmldocs
  Naxess · 2021-06-27 02:30:12 +02:00
  2cd7eda3c4
• Order hitobjects by endtime
  Naxess · 2021-06-27 01:25:03 +02:00
  0c0fd291d9
• Use local variables for hasHitsound & couldHaveHitsound
  Naxess · 2021-06-27 00:04:30 +02:00
  4796b1b208
• Rename hasHitsounds -> mapHasHitsounds
  Naxess · 2021-06-26 23:49:25 +02:00
  5bc08ebadb
• Add negligible template to PossibleTemplates
  Naxess · 2021-06-26 23:49:06 +02:00
  d29e6f4695
• Use HitSampleInfo.AllAdditions instead of new list
  Naxess · 2021-06-26 23:48:28 +02:00
  1913084342
• Factor out edge type logic
  Naxess · 2021-06-26 20:45:31 +02:00
  f78cc9397e
• Make || and && priority explicit
  Naxess · 2021-06-26 20:44:39 +02:00
  51147405c5
• Add few hitsounds check
  Naxess · 2021-06-26 19:20:46 +02:00
  4b436b774d
• Add muted objects check
  Naxess · 2021-06-26 19:20:34 +02:00
  d8117fa730
• Remove IPlayfieldProvider by caching Playfield
  ekrctb · 2021-06-17 10:15:24 +09:00
  9dcd0bf311
• Introduce IPlayfieldProvider
  ekrctb · 2021-06-15 14:43:04 +09:00
  ef96ceb4ab
• Remove replay logic from DrawableRuleset (and implement in DrawableEditorRulesetWrapper)
  Dean Herbert · 2021-06-02 11:06:30 +09:00
  8a76d97b63
• Ensure RegenerateAutoplay is only run once per frame
  Dean Herbert · 2021-05-23 21:20:08 +09:00
  bbfd7ea23f
• Fix PlacementBlueprint using the wrong beatmap when applying defaults

  Closes #12855.

  Dean Herbert · 2021-05-19 18:34:07 +09:00
  6c4709e7b4
• Merge pull request #12782 from smoogipoo/rework-hitobject-blueprints

  Rename hitobject blueprints and tie them to HitObjects

  Dean Herbert · 2021-05-18 16:30:58 +09:00
  a96603f025
• Remove now unnecessary Apply() method
  smoogipoo · 2021-05-18 14:26:26 +09:00
  882d54a8f8
• Add Apply() method for applying new DHOs
  smoogipoo · 2021-05-18 14:14:10 +09:00
  e621cfc4ea
• Fix unresolved xmldocs
  smoogipoo · 2021-05-18 13:11:58 +09:00
  f1f3606fd0
• Fix up xmldocs

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dan Balasescu · 2021-05-18 13:02:23 +09:00
  9d423245d8
• Add local variable for regular access to HitObjects
  Dean Herbert · 2021-05-14 16:23:45 +09:00
  fcb226bd20
• Fix formatting of #nullable enable
  Naxess · 2021-05-14 03:38:35 +02:00
  a447f20095
• Add #nullable enable

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Naxess · 2021-05-14 03:34:50 +02:00
  90e0b3374e
• Rework hitobject blueprints to take in hitobject models
  smoogipoo · 2021-05-13 19:53:32 +09:00
  ffb6135a1b
• Move IBeatmap arg into context
  Naxess · 2021-05-13 11:24:22 +02:00
  19800f5f7f
• Change interpreted difficulty from bindable to regular value

  There's no reason for why checks would need this to be bindable. A 1-directional binding is more appropriate.

  Naxess · 2021-05-13 09:00:30 +02:00
  b37cb3bdbe
• Rename "playableBeatmap" check arg to "beatmap"

  The working beatmap is now in the context, so it's easier to distinguish beatmap type, hence no need for this prefix.

  Naxess · 2021-05-12 02:34:16 +02:00
  b7bc42e0d3
• Add interpreted difficulty info to BeatmapVerifierContext

  Enables checks to make use of the difficulty level as shown in the settings UI.

  Naxess · 2021-05-12 02:30:21 +02:00
  64d96b06a6
• Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks

  This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.
  
  See next commit for example.

  Naxess · 2021-05-12 02:29:18 +02:00
  c13b93e6f1
• Remove negligible default hidden TODO
  Naxess · 2021-05-12 01:31:16 +02:00
  75adec57eb
• Merge branch 'master' into skin-components-list
  Salman Ahmed · 2021-04-30 21:10:55 +03:00
  b145f46a0a
• Merge branch 'master' into basic-compose-checks
  Dan Balasescu · 2021-04-30 23:41:46 +09:00
  e6eea73b8b
• Use the existing toolbox design
  Dean Herbert · 2021-04-30 14:41:06 +09:00
  a1e64f4e3c
• Refactor SelectionBlueprint and MoveSelectionEvent to work in screen-space coordinates

  Until now, the implementation of the overrides in `SelectionBlueprint`
  have been confusing to the point where I would just implement by
  trial-and-error (or copying from an existing implementation). This was
  due to a combination of using "object" space coordinates
  (ie. the thing the `Blueprint` is operating on) and screen-space coordinates.
  
  This change switches all event related coordinates to screen-space,
  which is how we already handle rotation/scale operations. With the
  introduction of other editor types where the related objects are
  drawables, this also makes a lot more sense.

  Dean Herbert · 2021-04-29 16:10:42 +09:00
  9c62c90cfc
• Rename methods to match generally how these find-methods are named elsewhere
  Dean Herbert · 2021-04-28 16:57:52 +09:00
  f3c7694eeb
• Move snap/divisor helper methods to inside ControlPointInfo
  Dean Herbert · 2021-04-28 16:47:30 +09:00
  48d6c9ac4b
• Rename unsnap check templates
  Naxess · 2021-04-27 13:56:05 +02:00
  200352b750
• Remove hitobject terminology from base classes
  Dean Herbert · 2021-04-27 19:01:29 +09:00
  7ec5ea1eb5
• Make SelectionHandler abstract to ensure things get implemented
  Dean Herbert · 2021-04-27 19:01:29 +09:00
  dd3d8e5d03
• Refactor editor selection/blueprint components to be generic
  Dean Herbert · 2021-04-27 19:01:29 +09:00
  f2e56bd306
• Fix a couple of inspections
  Dean Herbert · 2021-04-27 13:23:14 +09:00
  ec1c336b0a