9880 Commits

• Allow toggling leaderboard visibility in replays

  Closes https://github.com/ppy/osu/issues/31744 I guess.
  
  This isn't the resolution that I had in mind for this but my hand has
  been basically forced by user feedback to do this, at least in the
  short-term.

  Bartłomiej Dach · 2025-04-21 08:51:34 +02:00
  d8df499e72
• Add failing test coverage
  Bartłomiej Dach · 2025-04-18 14:21:50 +02:00
  20b2cc8251
• Merge pull request #32820 from peppy/global-audio-offset-control-fixes

  Fix global offset adjust control showing adjustment available when it shouldn't

  Dean Herbert · 2025-04-18 18:04:18 +09:00
  21fd4e857f
• Merge pull request #32823 from smoogipoo/fix-mp-results-background

  Fix multiplayer background changing in results screen

  Bartłomiej Dach · 2025-04-17 14:16:20 +02:00
  0138f78845
• Fix incorrect assertion message

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dan Balasescu · 2025-04-17 20:05:34 +09:00
  47d943afd7
• Fix garbage data in test case
  Bartłomiej Dach · 2025-04-17 11:37:28 +02:00
  5f4afe156f
• Add failing test
  Dan Balasescu · 2025-04-17 03:30:55 +09:00
  1a68edfa58
• Fix global offset adjust control showing adjustment available when it shouldn't

  Audio offset is integer based in configuration, so let's make sure not
  to show that there's an applicable offset when the value difference is
  too low.
  
  I've also fixed rounding to match expectations (`AudioOffset` is
  precision limited to integer), and handled the case where a user adjusts
  the slider but also has a suggested offset – previously it would not
  enable the button after slider adjustments but now it will work as
  expected.

  Dean Herbert · 2025-04-16 20:21:50 +09:00
  51ad6289ca
• Avoid adding arbitrary background in SongSelectComponentsTestScene
  Dean Herbert · 2025-04-16 19:41:49 +09:00
  4c1f4a512c
• Make some test methods static for future reuse
  Dean Herbert · 2025-04-16 19:41:49 +09:00
  2ac1b89037
• Merge pull request #32757 from smoogipoo/playlist-completion-icon

  Add display to show completed playlist items

  Dean Herbert · 2025-04-16 19:41:12 +09:00
  435f03745f
• Rename song select v2 classes and namespaces

  This aims to bring some conformity to naming to make it easier to
  understand component structure for new components.
  
  Renames are pulled out of the song select v2 changes and are more
  relevant there due to many new classes being added.
  
  - `V2` suffix is dropped, with v2 components being moved to a relevant V2 namespace.
  - Related classes have a prefix of the area they are used.
  - Experimenting with using partial/nested classes in the song select v2 implementation.
    Not committing to this yet but want to see how it plays out.
  - Moved base carousel components to a generic namespace to avoid confusion with actual beatmap carousel implementation.

  Dean Herbert · 2025-04-16 18:34:53 +09:00
  0aff50fbf5
• Merge pull request #32815 from peppy/global-shear

  Change global shear definition to be a `Vector2`

  Dean Herbert · 2025-04-16 18:34:39 +09:00
  572bc6d8b4
• Change global shear definition to be a Vector2

  Saves having this defined in 20+ places. If we ever make any changes to
  shear, it's 100% going to need to be applied to every usage (there will
  never be a case of multiple different shears in the game).
  
  Also fixes a mismatching definition in `ShearedNub`.

  Dean Herbert · 2025-04-16 18:01:08 +09:00
  7a8e96f322
• Add failing test
  Bartłomiej Dach · 2025-04-16 10:27:05 +02:00
  64b9d4642a
• Merge pull request #32494 from bdach/yet-another-leaderboard-rewrite-attempt

  Extract leaderboard fetch logic from song select beatmap leaderboard drawable

  Dean Herbert · 2025-04-16 16:06:07 +09:00
  57a81658f8
• Merge pull request #32799 from peppy/middle-click-closes-channels

  Add support for closing chat channels with middle click

  Bartłomiej Dach · 2025-04-14 09:17:52 +02:00
  b214539929
• Merge pull request #32759 from peppy/status-pill-improvements

  Allow showing "unknown" state on status pill

  Bartłomiej Dach · 2025-04-14 09:03:12 +02:00
  cd3aa18213
• Add support for closing chat channels with middle click

  Closes https://github.com/ppy/osu/issues/32797.

  Dean Herbert · 2025-04-14 15:30:40 +09:00
  f4cb3a7fb3
• Improve group panel test scene
  Salman Alshamrani · 2025-04-12 21:14:46 +09:00
  b95b9b3643
• Reduce bleed in tests to allow them to pass
  Bartłomiej Dach · 2025-04-11 10:13:49 +02:00
  9911e0819e
• Merge branch 'master' into fix-carousel-bleed
  Bartłomiej Dach · 2025-04-11 08:23:37 +02:00
  4398479846
• Remove previous beatmap wedge implementation
  Salman Alshamrani · 2025-04-11 01:55:36 +09:00
  430b22b383
• Fix carousel handling of bleed areas

  The idea of specifying "bleed" is to make the carousel aware of its
  vertical display area. The top bleed is under the filter control; bottom
  beneath the toolbar. At the end of the day, the point of panel X offset
  incursion, and the scroll target for current selection, should be at the
  centre of the screen.
  
  The fixes match code which already exists in the previous
  implementation. Basically, without incorporating `BleedTop` into
  calculations a second time, the centre position would not match
  expectations (of being the centre including bleed).

  Dean Herbert · 2025-04-11 00:05:51 +09:00
  f9112066d3
• Allow displaying "unknown" status in status pill
  Dean Herbert · 2025-04-10 23:42:29 +09:00
  57033fc180
• Fix status pill animating from zero height
  Dean Herbert · 2025-04-10 20:11:04 +09:00
  69035ef48f
• Add display to show completed playlist items
  Dan Balasescu · 2025-04-10 18:07:10 +09:00
  34180c62eb
• Merge branch 'master' into yet-another-leaderboard-rewrite-attempt
  Bartłomiej Dach · 2025-04-08 12:54:27 +02:00
  567c7cb798
• Merge pull request #32669 from smoogipoo/refactor-match-subscreen

  Rewrite match subscreen to remove bindables

  Bartłomiej Dach · 2025-04-08 12:51:36 +02:00
  b3626bfb48
• Add failing countdown start test
  Dan Balasescu · 2025-04-08 18:35:22 +09:00
  968fe6e618
• Merge pull request #32665 from peppy/fix-editor-metadata-save-without-commit

  Fix saving via ctrl+s while metadata textbox is focused not saving changes

  Bartłomiej Dach · 2025-04-08 08:21:03 +02:00
  5f168b9b9f
• Merge pull request #32679 from bdach/playlist-hacksawing

  Remove filtering & rearranging controls from now playing overlay

  Dean Herbert · 2025-04-07 23:07:39 +09:00
  10abd55a15
• Merge pull request #32640 from bdach/better-user-tag-ui

  Re-do user tag voting UI to address user complaints

  Dean Herbert · 2025-04-07 22:52:10 +09:00
  3e9ce6cd3c
• Fix crashes in statistics panel test scene
  Bartłomiej Dach · 2025-04-07 14:49:55 +02:00
  9643beafa7
• Merge pull request #32678 from bdach/prev-next-weirdness

  Fix weird behaviour when skipping back and forth with shuffle enabled

  Dan Balasescu · 2025-04-07 21:11:16 +09:00
  19f761b125
• Switch to using a popover again
  Dean Herbert · 2025-04-07 20:14:08 +09:00
  43ee43c9e2
• Remove unused local variable in test
  Dean Herbert · 2025-04-05 23:34:43 +09:00
  3287cc2e55
• Remove filtering & rearranging controls from now playing overlay
  Bartłomiej Dach · 2025-04-04 13:16:12 +02:00
  f5b849b4f3
• Add failing test coverage
  Bartłomiej Dach · 2025-04-04 13:12:24 +02:00
  55129620b8
• Disallow adjusting scroll speed during gameplay

  Matches stable. Addresses https://github.com/ppy/osu/discussions/32670.

  Dean Herbert · 2025-04-04 19:46:14 +09:00
  32c60bfb36
• Rewrite match subscreen to use full online state
  Dan Balasescu · 2025-04-04 10:48:55 +09:00
  286b3d9f5b
• Merge pull request #32593 from peppy/less-sample-overhead-during-silly-sliders

  Fix stutters when sliders with hundreds of repeats display for the first time

  Bartłomiej Dach · 2025-04-03 12:31:46 +02:00
  f11d3ddb5c
• Merge branch 'master' into better-user-tag-ui
  Bartłomiej Dach · 2025-04-03 11:59:16 +02:00
  375beae8a9
• Merge pull request #32657 from bdach/ruleset-specific-user-tags

  Add support for ruleset-specific user tags

  Dean Herbert · 2025-04-03 18:58:05 +09:00
  42a7094f9c
• Merge pull request #32601 from sineplusx/median-offset

  Use median instead of mean for average hit error calculations

  Dean Herbert · 2025-04-03 18:56:04 +09:00
  db0811bad9
• Change editor to save metadata changes without explicit textbox commit

  Closes https://github.com/ppy/osu/issues/32365.

  Dean Herbert · 2025-04-03 15:31:24 +09:00
  ce288023fe
• Merge branch 'ruleset-specific-user-tags' into better-user-tag-ui
  Bartłomiej Dach · 2025-04-02 13:28:28 +02:00
  ad334b2bf4
• Add rudimentary test coverage
  Bartłomiej Dach · 2025-04-02 13:25:18 +02:00
  db0f1895fb
• Add failing test
  Dan Balasescu · 2025-04-02 19:58:31 +09:00
  56169d7ac4
• Add failing test case

  Co-authored-by: Rodrigo Correia <rodrigo.figueiredo.correia@tecnico.ulisboa.pt>

  Bartłomiej Dach · 2025-03-31 14:25:35 +02:00
  79375eccb7