920 Commits

• Merge pull request #25185 from bdach/minimum-sample-volume
  Dean Herbert · 2023-10-24 22:04:43 +09:00
  34505b3933
• Enforce minimum gameplay sample volume of 5%
  Bartłomiej Dach · 2023-10-20 15:50:13 +02:00
  b321d556b6
• Fix fudge not being applied
  Dean Herbert · 2023-10-20 20:18:14 +09:00
  906b700aca
• Move helper method to LegacyRulesetExtensions and stop applying rounding allowance to catch

  As discussed, it isn't used in stable like this. Was a mistake.

  Dean Herbert · 2023-10-20 18:57:14 +09:00
  3fb74cb5f9
• Merge branch 'master' into legacy-tick-test-coverage
  Dan Balasescu · 2023-10-18 15:21:31 +09:00
  939b55020c
• Fix various other inspections
  Dean Herbert · 2023-10-17 17:48:51 +09:00
  e081fa48a2
• Move validation to DHO.ApplyResult()
  Dan Balasescu · 2023-10-10 21:42:37 +09:00
  a1a46e58fc
• Add better commenting around legacy last tick edge case
  Dean Herbert · 2023-10-04 13:45:26 +09:00
  cfb18e18c0
• Document remaining pieces of LastTick and add back legacy prefix for generation flow
  Dean Herbert · 2023-09-29 16:58:17 +09:00
  62bcb62842
• Move LegacyLastTickOffset specification to generation code and stop passing everywhere
  Dean Herbert · 2023-09-29 14:32:29 +09:00
  81485c548c
• Merge branch 'master' into fix-slider-length
  Bartłomiej Dach · 2023-09-20 11:10:01 +02:00
  28da5baea4
• Merge pull request #24800 from sw1tchbl4d3r/invalid_bank

  Default to normal bank if invalid sample bank is specified

  Dean Herbert · 2023-09-19 22:28:34 +09:00
  aea7f81f1c
• Replace sample bank fix with more correct fix

  stable does not treat unknown enum members as `None` / `Auto`, it treats
  them as `Normal`:
  
      switch (sampleSet)
      {
          case SampleSet.Normal:
          default:
              sample = 0;
              break;
          case SampleSet.None:
          case SampleSet.Soft:
              sample = 1;
              break;
          case SampleSet.Drum:
              sample = 2;
              break;
      }
  
      (from https://github.com/peppy/osu-stable-reference/blob/1531237b63392e82c003c712faa028406073aa8f/osu!/Audio/AudioEngine.cs#L1158-L1171).

  Bartłomiej Dach · 2023-09-19 13:53:49 +02:00
  c4a0ca326e
• Check if path lists are empty
  Magnus-Cosmos · 2023-09-19 02:28:28 -04:00
  73db68a49a
• Fix slider path calculations for edge cases
  Magnus-Cosmos · 2023-09-19 01:31:26 -04:00
  a9b45c6fdc
• Fix extension check using control points instead of path points
  Magnus-Cosmos · 2023-09-18 11:40:00 -04:00
  83584519e6
• Make not extension method
  Dean Herbert · 2023-09-15 18:13:04 +09:00
  56cc2b62f0
• Move to extension method and throw on non-legacy ruleset
  Dean Herbert · 2023-09-15 17:38:34 +09:00
  0031da76ff
• Default to none bank if invalid samplebank is specified
  sw1tchbl4d3 · 2023-09-13 12:44:00 +02:00
  5b2af7f264
• Make rounding error even less precise

  Basically matching the old code more closely to avoid too much precision
  from doing math in a slightly different way.

  Dean Herbert · 2023-09-12 18:41:09 +09:00
  4ecc4632aa
• Remove all usage of LegacyDifficultyControlPoint
  Dean Herbert · 2023-09-07 17:41:57 +09:00
  b34a36f6ce
• Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity
  Dean Herbert · 2023-09-06 19:01:08 +09:00
  1a37543d28
• Merge branch 'master' into judge-fix
  Bartłomiej Dach · 2023-08-22 09:44:58 +02:00
  8cd9f0822a
• Reword comment to be better
  Bartłomiej Dach · 2023-08-22 09:37:54 +02:00
  5be5335784
• Update inline comments
  OliBomby · 2023-08-21 13:09:31 +02:00
  e283aa2843
• Merge branch 'master' into fix-slider-reversing
  Bartłomiej Dach · 2023-08-21 09:29:46 +02:00
  1d657a8844
• Reformat xmldoc
  Bartłomiej Dach · 2023-08-21 08:29:51 +02:00
  dd1ac461db
• expand xmldoc
  OliBomby · 2023-08-19 19:39:29 +02:00
  56b1062c2f
• Add braces for clarification

  I like no-braces for single-line ifs as much as anyone, but with inline
  comments involved it gets rather dicey.

  Bartłomiej Dach · 2023-08-19 14:34:20 +02:00
  0a55830c16
• Update Reverse() based on the changes in #24581
  Pasi4K5 · 2023-08-19 02:40:18 +02:00
  44a85139e4
• Merge remote-tracking branch 'OliBomby/fix-segment-ends' into fix-slider-reversing
  Pasi4K5 · 2023-08-19 02:38:34 +02:00
  47d787b359
• Revert changes in SliderPath
  Pasi4K5 · 2023-08-19 00:16:05 +02:00
  0e691d5935
• fix GetSegmentEnds
  OliBomby · 2023-08-18 12:20:40 +02:00
  ff07fbae15
• Fix segmentEnds being calculated incorrectly
  Pasi4K5 · 2023-08-18 04:34:10 +02:00
  3481c41a22
• Fix possible IndexOutOfRangeException
  Pasi4K5 · 2023-08-16 01:19:41 +02:00
  58bffa13cd
• Replace .Distinct() with truncateEndingDuplicates()
  Pasi4K5 · 2023-08-16 01:14:25 +02:00
  e7e0c49f42
• Improve code readability and add assertion to test scene
  Pasi4K5 · 2023-08-15 23:27:12 +02:00
  6346872c39
• Code cleanup
  Pasi4K5 · 2023-08-14 21:56:08 +02:00
  449bee98cc
• Remove unnecessary circle arc approximation
  Pasi4K5 · 2023-08-14 21:09:58 +02:00
  19c8b74a47
• Fix IndexOutOfRangeException when trying to reverse a zero-length slider
  Pasi4K5 · 2023-08-14 14:09:08 +02:00
  55ac942e7a
• Fix linear sliders sometimes being reversed incorrectly

  Extract control point reversing to separate method

  Pasi4K5 · 2023-08-14 14:08:02 +02:00
  f42b3603b3
• Fix sliders being reversed incorrectly in the editor.
  Pasi4K5 · 2023-08-12 20:30:48 +02:00
  8912a0e91e
• Fix DrawableHitObject state not synchronizing with hitobject edits
  OliBomby · 2023-08-11 22:34:04 +02:00
  d2f5e696e7
• Merge remote-tracking branch 'upstream/master' into legacy-export
  OliBomby · 2023-07-18 12:18:49 +02:00
  5d82190b70
• legacy export broken
  OliBomby · 2023-07-11 02:30:16 +02:00
  06e5ef88c0
• Fix GenerateTicks being lost during osu! beatmap conversion process
  Bartłomiej Dach · 2023-07-08 23:24:38 +02:00
  56a2ba4ac0
• Replace various local implementations of rewinding checks with new property
  Dean Herbert · 2023-07-07 15:21:24 +09:00
  e0fc97bb93
• Fix fallback for Judged to be more correct

  Without this change, when the `Judged` value is checked on an
  `HitObjectLifetimeEntry` it would return `true` if a `DrawableHitObject`
  has not yet been associated with the entry. Which is completely wrong.
  
  Of note, the usage in `DrawableHitObject` will have never fallen through
  to this incorrect value as they always have a result populated:
  
  https://github.com/ppy/osu/blob/f26f001e1d01ca6bb53225da7bf06c0ad21153c5/osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs#L721-L726

  Dean Herbert · 2023-07-05 18:03:58 +09:00
  3f8dfc7cb0
• Redirect judgement-related flags from DHO to HOLE
  Bartłomiej Dach · 2023-07-04 23:45:08 +02:00
  6c4e52821d
• Ensure synthetic entries from non-pooled DHO are linked to parents
  Bartłomiej Dach · 2023-07-04 23:45:08 +02:00
  0ceaf3c451