9356 Commits

Author	SHA1	Message	Date
Fabian Bech Persson	363fc0d5da	Merge branch 'master' into master	2024-08-30 11:06:54 +02:00
Dean Herbert	a71bc3a24a	Merge pull request #28737 from OliBomby/doubleclick ... Add more ways to seek to sample points	2024-08-30 16:22:50 +09:00
Dean Herbert	60c1e0fa72	Merge pull request #29440 from OliBomby/spacebar-resume ... Allow play/pause with spacebar while placing hitobjects	2024-08-30 12:58:41 +09:00
OliBomby	3a1afda2b3	fix test	2024-08-29 22:22:15 +02:00
OliBomby	ba0c4df2a9	Merge remote-tracking branch 'upstream/master' into doubleclick	2024-08-29 19:34:18 +02:00
Dean Herbert	c013974790	Merge branch 'master' into detached-beatmap-cache	2024-08-29 22:49:11 +09:00
Dan Balasescu	fec8fa46fa	Merge pull request #29533 from bdach/fix-sample-bank-stuff-again ... Fix incorrect bank set / sample addition logic	2024-08-29 21:36:26 +09:00
Dean Herbert	def1abaeca	Fix some tests not always waiting long enough for beatmap loading ... These used to work because there was a huge blocking load operation, which is now more asynchronous. Note that the change made in `SongSelect` is not required, but defensive (feels it should have been doing this the whole time).	2024-08-29 18:42:43 +09:00
Joseph Madamba	f0b2176c30	Add failing pinned comment replies state test	2024-08-28 22:58:57 -07:00
Dean Herbert	e04b5bb3f2	Tidy up test beatmap loading	2024-08-28 23:28:44 +09:00
Dean Herbert	853023dfba	Reduce test filter count expectation by one due to initial filter being implicit	2024-08-28 23:28:44 +09:00
Dean Herbert	9123d2cb7f	Fix multiple test failures	2024-08-28 23:28:43 +09:00
Dean Herbert	dd4a1104e4	Always debounce external Filter requests (except for tests) ... The only exception to the rule here was "when screen isn't active apply without debounce" but I'm not sure we want this. It would cause a stutter on returning to song select and I'm not even sure this is a common scenario. I'd rather remove it and see if someone finds an actual case where this is an issue.	2024-08-28 19:13:50 +09:00
Dean Herbert	336abadbd1	Allow running initial filter criteria asynchronously ... This reverts a portion of https://github.com/ppy/osu/pull/9539. The rearrangement in `SongSelect` is required to get the initial filter into `BeatmapCarousel` (and avoid the `FilterChanged` event firing, causing a delayed/scheduled filter application).	2024-08-28 19:13:50 +09:00
Fabep	6adaf6a41f	Changed ModCustomisationPanelState names	2024-08-28 10:09:47 +02:00
Bartłomiej Dach	a3b0ff4808	Merge branch 'master' into break-overlay-animation	2024-08-27 11:17:56 +02:00
Bartłomiej Dach	321e509f11	Merge pull request #29615 from peppy/break-overlay-improvements ... Add shadow around break overlay middle content to make sure it remains visible	2024-08-27 11:16:08 +02:00
Bartłomiej Dach	7c0550d251	Merge pull request #29500 from frenzibyte/fix-pausing-for-the-millionth-time ... Fix oversight in osu! pause input handling	2024-08-27 10:04:47 +02:00
Bartłomiej Dach	e59689f31a	Fix test and NRT failure	2024-08-27 09:49:49 +02:00
Dean Herbert	6f1664f0a6	Add beat-synced animation to break overlay ... I've been meaning to make the progress bar synchronise with the beat rather than a continuous countdown, just to give the overlay a bit more of a rhythmic feel. Not completely happy with how this feels but I think it's a start? I had to refactor how the break overlay works in the process. It no longer creates transforms for all breaks ahead-of-time, which could be argued as a better way of doing things. It's more dynamically able to handle breaks now (maybe useful for the future, who knows).	2024-08-27 16:34:37 +09:00
Dean Herbert	c2c83fe73d	Fix TestSceneBreakTracker not removing old drawables ... Also adds a bright background for testing overlay display.	2024-08-27 14:33:36 +09:00
Salman Ahmed	b54487031a	Add DailyChallengeButton for intro played flag reset logic	2024-08-24 22:19:17 +09:00
Jonas Brandstötter	89a4025c01	Fix Daily Challenge play count using a different colour than osu-web	2024-08-24 11:21:28 +02:00
Salman Ahmed	f5e195a7ee	Remove existing test asserts	2024-08-24 06:40:30 +09:00
Dean Herbert	60271fb0f7	Merge pull request #29564 from peppy/skinnable-components-what-2 ... Remove requirement of `base` calls to ensure user skin container layouts are retrieved	2024-08-23 17:52:46 +09:00
Dean Herbert	48cfd77ee8	Component -> Lookup	2024-08-23 14:48:50 +09:00
Bartłomiej Dach	a32a817305	Merge pull request #29512 from peppy/toolbar-pp-change-weird ... Fix toolbar PP change showing `+0` instead of `0`	2024-08-22 12:08:12 +02:00
Dean Herbert	b57b8168a6	Rename Target lookup to Component	2024-08-22 19:00:28 +09:00
Dean Herbert	9a21174582	Move GlobalSkinnableContainers to global scope	2024-08-22 18:46:07 +09:00
Dean Herbert	f37cab0c6e	Rename SkinComponentsContainerLookup to GlobalSkinnableContainerLookup	2024-08-22 18:39:36 +09:00
Dean Herbert	41756520b1	Rename SkinComponentsContainer to SkinnableContainer	2024-08-22 17:42:50 +09:00
Dean Herbert	67f0ea5d7d	Fix flooring causing delta to not work as expected	2024-08-22 16:22:00 +09:00
Dean Herbert	7e483bbee3	Merge pull request #29541 from frenzibyte/fix-mod-customisation-dragging-outside ... Keep mod customisation panel open when dragging outside	2024-08-22 15:28:32 +09:00
Bartłomiej Dach	d33f4837fa	Merge pull request #29532 from bdach/redesign-timing-table-tracking ... Redesign timing table tracking	2024-08-22 08:21:39 +02:00
Dean Herbert	9b9986b6f2	Add isolated test for daily challenge intro flag	2024-08-22 15:14:52 +09:00
Dean Herbert	236a273e09	Simplify DailyChallengeIntro test scene ... Seems like some bad copy-paste in the past. Most of this is already being done in `TestSceneDailyChallenge`.	2024-08-22 15:14:42 +09:00
Dean Herbert	dfb4a76e29	Fix test being repeat step	2024-08-22 14:45:40 +09:00
Dean Herbert	54e5f1c9f0	Merge pull request #29556 from frenzibyte/kiai-star-bursts ... Add star fountains/bursts when entering kiai mode in gameplay	2024-08-22 14:14:25 +09:00
Salman Ahmed	a669c53df7	Add failing test cases	2024-08-22 06:00:07 +09:00
Dean Herbert	2876cb73bd	Merge pull request #28991 from Layendan/master ... Add collection and favourite buttons to results screen	2024-08-21 23:59:26 +09:00
Salman Ahmed	c92af71029	Add in-gameplay version of kiai star fountains/burst	2024-08-21 17:34:38 +09:00
OliBomby	ae6d855f8d	Merge remote-tracking branch 'upstream/master' into doubleclick	2024-08-20 23:19:27 +02:00
Salman Ahmed	ae4fefeba1	Add failing test case	2024-08-21 03:22:03 +09:00
Dan Balasescu	2011d5525f	Add flaky test attribute to some tests ... See occurences like https://github.com/ppy/osu/actions/runs/10471058714.	2024-08-20 22:21:10 +09:00
Dan Balasescu	44213a34ae	Merge pull request #29508 from peppy/hold-for-menu-sometimes ... Change "hold for menu" button to only show for touch by default	2024-08-20 21:45:50 +09:00
Bartłomiej Dach	3202c77279	Add failing test	2024-08-20 12:36:05 +02:00
Dean Herbert	a633fcdb49	Merge branch 'master' into redesign-timing-table-tracking	2024-08-20 19:16:03 +09:00
Bartłomiej Dach	333e5b8cac	Remove outdated tests	2024-08-20 11:23:39 +02:00
Dean Herbert	73f2f5cb12	Fix more tests	2024-08-20 17:59:55 +09:00
Dean Herbert	c85b04bca5	Add more test coverage to better show overlapping break / kiai sections	2024-08-20 17:45:44 +09:00
Salman Ahmed	2ecf5ec939	Add further test coverage	2024-08-20 16:47:20 +09:00
Dean Herbert	5ba1b4fe3d	Update test coverage	2024-08-20 01:13:00 +09:00
Bartłomiej Dach	7693d4c039	Merge branch 'master' into master	2024-08-19 14:30:20 +02:00
Dean Herbert	610ebc5481	Fix toolbar PP change showing +0 instead of 0	2024-08-19 20:50:11 +09:00
Bartłomiej Dach	42675be6cf	Merge branch 'master' into additions	2024-08-19 11:13:43 +02:00
Salman Ahmed	9e962ce314	Add failing test case	2024-08-19 14:14:12 +09:00
OliBomby	3d4bc8a2cc	fix tests	2024-08-16 15:04:38 +02:00
Dean Herbert	68bad9a277	Attempt file operations more than once in another test instance ... See https://github.com/ppy/osu/pull/29433/checks?check_run_id=28833985792.	2024-08-16 17:39:45 +09:00
Dean Herbert	5710f0f302	Merge pull request #26254 from frenzibyte/mania-combo-counter ... Add argon/classic osu!mania combo counter	2024-08-15 17:56:28 +09:00
Dean Herbert	e603888130	Update remaining tests to use new base class (and tidy up V2 suffixes)	2024-08-14 21:09:28 +09:00
Dean Herbert	1665d9a93e	Fix failing test setup	2024-08-14 21:01:35 +09:00
Joseph Madamba	6f2bc7e6f1	Use Content override instead	2024-08-14 00:44:03 -07:00
Dean Herbert	2174510544	Move other V2 tests to new test namespace	2024-08-14 15:51:07 +09:00
Joseph Madamba	c24f1444f9	Directly resolve IBindable<WorkingBeatmap> by making a local variant of DifficultyNameContent	2024-08-13 23:26:18 -07:00
Joseph Madamba	f8796e3192	Move resizing width and background logic to SongSelectComponentsTestScene	2024-08-13 23:26:17 -07:00
Joseph Madamba	2b41f71fd0	Workaround single-frame layout issues with {Link|Text|Fill}FlowContainers	2024-08-13 23:26:17 -07:00
Joseph Madamba	625c6fc7eb	Implement song select v2 difficulty name content component	2024-08-13 23:26:17 -07:00
Joseph Madamba	46d41cb590	Add base song select components test scene	2024-08-13 23:26:17 -07:00
Dean Herbert	e465049050	Merge branch 'master' into mania-combo-counter	2024-08-14 15:12:00 +09:00
Dean Herbert	dd9705b660	Fix file access test failure by forcing retries ... See https://github.com/ppy/osu/actions/runs/10369630825/job/28708248682.	2024-08-14 12:26:21 +09:00
Salman Ahmed	7acc1772cb	Add test coverage	2024-08-13 13:07:21 +03:00
Dean Herbert	14a00621f8	Fix occasional test failures in TestSceneBetmapRecommendations ... The game was being constructed befor the API was setup, which could mean depending on test execution ordering and speed, the recommendations array would not be filled. Easy to reproduce by `[Solo]`ing `TestCorrectStarRatingIsUsed`. See https://github.com/ppy/osu/runs/28689915929#r0s0.	2024-08-13 17:28:16 +09:00
Dan Balasescu	4b4f0ecf7d	Merge pull request #29342 from cl8n/remove-mania-action-special ... Remove "Special" `ManiaAction`s for center columns	2024-08-13 15:36:36 +09:00
Bartłomiej Dach	06c2952fe8	Merge branch 'master' into grids-3	2024-08-12 13:55:35 +02:00
Bartłomiej Dach	92bd123ebc	Merge pull request #29363 from peppy/fix-daily-challenge-notification-spam ... Fix daily challenge notification spam	2024-08-12 12:18:38 +02:00
Bartłomiej Dach	041c70e4eb	Fix tests	2024-08-12 11:19:02 +02:00
Dean Herbert	c8a7727199	Make ID retrieval global to all tests and fix multiple other usages	2024-08-09 17:46:51 +09:00
Dean Herbert	18c80870d8	Update one more RNG usage in same tests	2024-08-09 17:40:48 +09:00
Dean Herbert	0a8e342830	Fix occasionally ChatOverlay test failures due to RNG usage ... See https://github.com/ppy/osu/actions/runs/10302758137/job/28517150950. Same ID gets chosen twice for PM channel.	2024-08-09 17:38:17 +09:00
Dean Herbert	80c814008f	Update in line with new changes	2024-08-09 14:55:01 +09:00
Dean Herbert	e645651ef4	Merge branch 'master' into mania-combo-counter	2024-08-09 00:19:17 +09:00
Dean Herbert	dcafee7cb7	Merge pull request #26249 from frenzibyte/ruleset-specific-combo-counter ... Move combo counter to ruleset-specific HUD components container	2024-08-08 17:41:58 +09:00
Dean Herbert	278d887ee5	Fix test failures due to missing room name	2024-08-08 15:10:14 +09:00
Dean Herbert	1ee5522a25	Merge branch 'master' into daily-challenge-intro-screen-part-2	2024-08-08 14:08:14 +09:00
clayton	48d9bc982f	Fix tests	2024-08-07 14:36:04 -07:00
Dean Herbert	b5a19707d0	Merge branch 'master' into additions	2024-08-08 03:31:11 +09:00
Dean Herbert	3c572abaa7	Merge branch 'master' into ruleset-specific-combo-counter	2024-08-08 03:21:52 +09:00
Bartłomiej Dach	e6d5389608	Merge branch 'master' into hover-open-mod-customise	2024-08-07 14:05:19 +02:00
Bartłomiej Dach	518c1aa5a0	Remove weird Expanded / ExpandedState duality	2024-08-07 14:01:30 +02:00
Salman Ahmed	a0615a8f18	Frenzi's WIP animation	2024-08-07 19:07:45 +09:00
Dean Herbert	6870311c1e	Remove requirement of specifying animateOnnter in BackgroundScreen ctor	2024-08-07 19:07:44 +09:00
Dean Herbert	b081b47714	Add test of daily challenge flow from main menu	2024-08-07 19:07:44 +09:00
Dean Herbert	b1488fd5b7	Merge pull request #29027 from normalid-awa/feature/skin/legacy-input-overlay ... Add legacy key counter support	2024-08-07 17:48:30 +09:00
Dean Herbert	1aea8e911c	Add test coverage of chat mentions	2024-08-07 01:33:56 +09:00
Dean Herbert	f7b45a26de	Improve test coverage and segregation	2024-08-06 19:32:00 +09:00
Dean Herbert	9ccd8c906d	Merge branch 'master' into hover-open-mod-customise	2024-08-06 18:35:35 +09:00
Dean Herbert	8619bbb943	Fix legacy key counter's background being visible when intended to be hidden	2024-08-06 16:12:00 +09:00
Dean Herbert	60fc02bb9b	Merge branch 'master' into feature/skin/legacy-input-overlay	2024-08-06 14:05:33 +09:00
Dan Balasescu	d637bbf752	Merge pull request #29286 from peppy/middle-click-delete ... Allow object deletion with middle mouse	2024-08-06 13:38:56 +09:00
Dean Herbert	17eb134797	Merge branch 'master' into bugfix/visual/long-commet-tooltip-overflow	2024-08-05 17:01:20 +09:00
Dean Herbert	24a0ead62e	Make tests actually show what value they are testing	2024-08-05 17:01:00 +09:00
Dean Herbert	9c5e29b2c9	Fix test being disabled for cases which should pass	2024-08-05 16:58:00 +09:00
Dean Herbert	c0814c2749	Add test of existing slider placement behaviour for safety	2024-08-05 14:25:10 +09:00
Dean Herbert	9673985e2c	Add test coverage of right/middle click behaviours with placement blueprints	2024-08-05 14:25:09 +09:00
Dan Balasescu	136cdcfb29	Merge pull request #29059 from frenzibyte/fix-results-fetching-twice ... Fix results screen fetching scores twice when scrolled to edge	2024-08-05 14:23:47 +09:00
Dean Herbert	419d5a76ce	Merge branch 'master' into fix-pause-in-osu-again	2024-08-05 12:00:21 +09:00
jkh675	273bd73a99	Fix unit test error	2024-08-04 19:50:57 +08:00
jkh675	6f9866d542	Add unit test for OsuTooltip	2024-08-04 18:56:19 +08:00
Caiyi Shyu	c85dc40f91	Merge branch 'master' into hover-open-mod-customise	2024-08-02 19:07:27 +08:00
Salman Ahmed	dc9f6a07cb	Fix inspections	2024-08-02 11:16:32 +03:00
Salman Ahmed	c3b2d81066	Add failing test case	2024-08-02 10:19:44 +03:00
Dean Herbert	310def64f4	Merge branch 'master' into user-profile-daily-challenge-streak-display	2024-08-02 15:40:46 +09:00
Dean Herbert	816dee181a	Rename classes to remove "streak" terminology ... Since the primary display isn't showing a streak.	2024-08-02 15:33:30 +09:00
Caiyi Shyu	051d52c23f	Update ModCustomisationPanel to use ExpandedState enum	2024-08-01 19:25:45 +08:00
Dean Herbert	e9ed9ff58b	Merge pull request #29188 from bdach/daily-challenge/better-messaging ... Add notification on daily challenge conclusion & start of new one	2024-07-31 13:35:25 +09:00
Dean Herbert	5ebb5ad670	Fix test failure due to TestMetadataClient providing null statistics array	2024-07-31 02:53:10 +09:00
Dean Herbert	d75c170ba1	Merge branch 'master' into daily-challenge/better-messaging	2024-07-30 19:04:48 +09:00
Dean Herbert	71649005bf	Elongate usernames in DrawableChannel test	2024-07-30 17:52:55 +09:00
Dean Herbert	71acb7e9fc	Merge pull request #29137 from normalid-awa/feature/visual/chatline-background-altering ... Alternate background colour of chat lines to better visually distinguish wrapped lines	2024-07-30 17:51:41 +09:00
Bartłomiej Dach	1b57a2a136	Show new daily challenge notification globally	2024-07-30 10:36:26 +02:00
Bartłomiej Dach	a05f810724	Attempt to fix tests more	2024-07-30 10:07:38 +02:00
Bartłomiej Dach	ae38e66036	Add failing test coverage	2024-07-30 08:39:01 +02:00
Salman Ahmed	91dfe4515b	Fix daily challenge display showing incorrect statistic	2024-07-30 08:12:03 +03:00
Salman Ahmed	7c3d592a84	Fix user profile overlay test scene being broke	2024-07-30 07:06:59 +03:00
Bartłomiej Dach	b77a10b6db	Fix tests maybe	2024-07-29 15:28:52 +02:00
Dean Herbert	1daeb7ebd0	Rename typo in test naming	2024-07-29 22:19:38 +09:00
Bartłomiej Dach	b46f3c97da	Add notification on daily challenge conclusion & start of new one ... Because I wish to stop seeing "DAILY CHALLENGE WHERE" every day on #general. The notifications are constrained to the daily challenge screen only to not spam users who may not care.	2024-07-29 14:30:10 +02:00
Dean Herbert	7afcd72872	Fix potentially too many scores displaying in breakdown while in gameplay	2024-07-29 20:58:42 +09:00
Dean Herbert	76cd2df699	Add ability to test daily challenge carousel items when hidden	2024-07-29 20:43:47 +09:00
Dean Herbert	997b3eb498	Fix typos and visuals	2024-07-29 20:24:51 +09:00
normalid	e58bdbb8a9	Improve unit test	2024-07-28 15:08:36 +08:00
Salman Ahmed	82fbd5b045	Rename file	2024-07-28 06:40:16 +03:00
Salman Ahmed	e82c54a31c	Integrate daily challenge streak display with user profile overlay	2024-07-28 05:58:30 +03:00
Salman Ahmed	17f5d58be2	Add daily challenge streak display and tooltip	2024-07-28 05:58:27 +03:00
Joseph Madamba	bc25e5d706	Remove unnecessary depth and padding set	2024-07-27 19:13:11 -07:00
Joseph Madamba	850bcaef7a	Merge remote-tracking branch 'upstream/master' into pr/28991	2024-07-27 19:09:02 -07:00
Joseph Madamba	b4ca07300a	Use same size button for everything	2024-07-27 18:43:54 -07:00
normalid	4e44a6e7f8	Clean up code	2024-07-27 18:55:17 +08:00
normalid	73a98b45e9	FIx code quality	2024-07-27 18:48:45 +08:00
normalid	7f4bfb25a9	Implement unit test	2024-07-27 18:24:32 +08:00
Caiyi Shyu	bd017aea38	fix TestPreexistingSelection failing	2024-07-26 23:58:52 +08:00
Caiyi Shyu	a3576a55c2	add test for hovering ModCustomisationPanel	2024-07-26 22:45:12 +08:00
Dean Herbert	4fa6a19409	Merge pull request #29108 from bdach/daily-challenge/better-breakdown ... Improve score breakdown on daily challenge	2024-07-26 23:12:04 +09:00
Dean Herbert	1607075e0c	Merge pull request #29099 from bdach/daily-challenge/totals-display ... Implement component for displaying running totals in daily challenge	2024-07-26 21:44:58 +09:00
Bartłomiej Dach	fc0ade2c61	Highlight where local user's best is on the breakdown	2024-07-26 14:32:01 +02:00
Bartłomiej Dach	174dc91f4b	Implement component for displaying running totals in daily challenge ... Total pass count and cumulative total score, to be more precise.	2024-07-26 09:51:39 +02:00
Bartłomiej Dach	e489ae8f72	Merge pull request #29055 from peppy/event-feed-improvements ... Improve daily challenge event feed	2024-07-26 08:37:47 +02:00
Bartłomiej Dach	09a1fd2cd1	Merge pull request #29057 from frenzibyte/daily-challenge-replay-download-button ... Fix daily challenge not showing a replay button in results screen	2024-07-26 08:03:17 +02:00
Salman Ahmed	3e8917cadb	Add test case against resetting score in download button	2024-07-26 05:08:13 +03:00
Salman Ahmed	f3dd1facf1	Add failing test case	2024-07-25 09:16:09 +03:00
Salman Ahmed	e1ccf68801	Revert "Add failing test case" ... This reverts commit 0182f3d7c3.	2024-07-25 08:51:48 +03:00
Dean Herbert	f1dda4ab1e	Fix too many event rows displaying after spending a long time in gameplay/results	2024-07-25 14:31:22 +09:00
Dean Herbert	bba151a776	Make event feed test show more realistic content automatically	2024-07-25 14:31:21 +09:00
Salman Ahmed	0182f3d7c3	Add failing test case	2024-07-25 07:39:58 +03:00
Salman Ahmed	b3e3bf7cec	Add lenience to avoid floating point errors	2024-07-24 23:26:23 +03:00
Salman Ahmed	6645dac71d	Fix dragging number boxes overwritten by select-all-on-focus feature	2024-07-24 23:19:04 +03:00
Bartłomiej Dach	12a9086aa3	Fix test failure ... After the legacy key counter was moved to ruleset-specific component containers, `TestSceneSkinnableHUDOverlay` no longer had a key counter, because it wasn't creating a ruleset-specific HUD component container due to 4983e5f33e/osu.Game/Screens/Play/HUDOverlay.cs (L131-L133) Therefore, to fix, do just enough persuading to make it create one.	2024-07-24 18:30:18 +02:00
Bartłomiej Dach	087dd759be	Adjust layout to ballpark-match stable ... I dunno what the wiki is claiming with the "24px" figure or why but I'm not playing conversion games either. Dimensions ballparked via screenshots captured at x768 resolution. Also removes a weird homebrew method to keep the text upright. There is one canonical way to do this, namely `UprightAspectMaintainingContainer`. And the other key counters were already using it.	2024-07-24 14:52:56 +02:00
Bartłomiej Dach	ace5071d88	Add better test scene	2024-07-24 14:25:51 +02:00
Bartłomiej Dach	55382a4ba6	Add test coverage for expected sample popover behaviour	2024-07-24 12:08:13 +02:00
normalid	95f287104e	Add visual test seane	2024-07-24 12:24:58 +08:00
Bartłomiej Dach	dd8be62d07	Merge pull request #28849 from frenzibyte/custom-profile-colour ... Add custom hue support to user profile overlay	2024-07-22 09:41:32 +02:00
Bartłomiej Dach	088b8aff11	Merge pull request #28881 from smoogipoo/fix-judgement-cut ... Fix judgement animation getting cut early	2024-07-22 09:24:57 +02:00
Layendan	6a4872faa8	Remove nullable disable	2024-07-21 23:56:47 -07:00
Layendan	e4cccb5e31	Fix lint errors	2024-07-22 12:22:52 +09:00
Layendan	a575566638	Add tests	2024-07-22 12:22:51 +09:00
Salman Ahmed	d7651ef387	Add extensive test cases for correct input handling while paused in osu! & non-osu!	2024-07-19 18:48:35 +03:00
Dean Herbert	d9297438ba	Merge pull request #28900 from smoogipoo/fix-more-tests ... Fix more test failures	2024-07-19 19:38:52 +09:00
Dan Balasescu	7a4758d8cc	Attempt to fix TestSelectableMouseHandling test failure ... https://github.com/ppy/osu/pull/28900/checks?check_run_id=27652166871 This is an attempt. Going frame-by-frame I noticed that there's one frame in which the text is loaded but the FillFlowContainer/GridContainer haven't properly validated so the text is not positioned correctly (it's overflowing the panel to the left). If the cursor is moved at this exact time, then it may not be properly positioned for the following assertion, even though it is _somewhere_ on the panel. If the above is the case, then this is a known o!f issue, but not a simple one to solve. I haven't reproed this locally.	2024-07-19 17:49:16 +09:00
Dan Balasescu	d7ae9505b2	Fix TestCancelNavigationToEditor test failure ... https://github.com/ppy/osu/actions/runs/10002179087/job/27648253709 The editor could be pushed before the exit actually occurs.	2024-07-19 15:04:21 +09:00
Bartłomiej Dach	79cf644b8d	Enable NRT while we're here	2024-07-19 07:34:00 +02:00
Bartłomiej Dach	73edb32440	Add failing test coverage	2024-07-19 07:30:57 +02:00
Dan Balasescu	3f4e56be3c	Fix TestPostAsOwner test failure ... https://github.com/smoogipoo/osu/actions/runs/9990112749/job/27610257309 Comments are loaded asynchronously, both from the initial request and the following message-post request. By sheer timing luck, these could be out of order and the assertion on the posted message could fail.	2024-07-18 20:54:05 +09:00
Dan Balasescu	33a81d8181	Use constraint to improve assertion message	2024-07-18 18:34:08 +09:00
Dan Balasescu	f3cd3d7d3b	Fix TestAllSamplesStopDuringSeek test failure ... https://github.com/smoogipoo/osu/actions/runs/9986761756/job/27599851263 This is a bit of a workaround, likely timing related. I don't foresee an until step in this case to cause false-passes.	2024-07-18 16:26:42 +09:00
Dan Balasescu	1906c2f725	Fix TestTouchScreenDetectionAtSongSelect test failure ... https://github.com/ppy/osu/actions/runs/9985890747/job/27597501295 In this case, the settings overlay is taking a very long time to load (on a background thread), and pops in when it finishes loading because it's been requested to open. The opens the settings overlay, closes it (by pressing escape, this does not actually close it because it's not loaded yet), and then enters song select by pressing 'P' 3 times. The settings overlay finishes loading at just the right opportune moment to eat one of the 'P' key presses.	2024-07-18 16:26:16 +09:00
Salman Ahmed	7a39435017	Fix intermitent test failure in TestSceneArgonHealthDisplay	2024-07-18 01:20:50 +03:00
Bartłomiej Dach	76d016df34	Fix code inspection	2024-07-16 11:31:16 +02:00
Dan Balasescu	d4ea604ad0	Add test	2024-07-16 18:19:00 +09:00
OliBomby	e5bc359b88	fix test	2024-07-14 23:39:19 +02:00
OliBomby	29c2e821ea	extend tests	2024-07-14 22:50:25 +02:00
Salman Ahmed	be1d3c0ea4	Add test coverage	2024-07-13 11:58:54 +03:00
Dean Herbert	eb3f480a2a	Merge pull request #28683 from frenzibyte/footer-v2-integration ... Replace local footer in existing sheared overlays (e.g. mod select & first-run setup) with `ScreenFooter`	2024-07-12 22:45:06 +09:00
Bartłomiej Dach	518dc17518	Merge pull request #28788 from bdach/timeline-redesign ... Redesign editor timelines to address most frequent user complaints	2024-07-12 10:58:59 +02:00
Bartłomiej Dach	452fbed681	Merge pull request #28808 from frenzibyte/fix-all-notifications ... Fix confirm exit dialog potentially showing incorrect number of ongoing operations	2024-07-12 10:56:29 +02:00
Dean Herbert	43addc8400	Fix test regression	2024-07-12 16:29:41 +09:00
Salman Ahmed	3ea0f58daa	Update TestSceneFreeModSelectOverlay to work again	2024-07-11 15:31:23 +03:00
Salman Ahmed	7a5624fd0e	Add screen footer to ScreenTestScene	2024-07-11 15:30:07 +03:00
Bartłomiej Dach	f1fa34e5d5	Merge pull request #28800 from peppy/file-mounting-v3 ... Add ability to edit beatmap content externally	2024-07-11 10:47:36 +02:00
Dean Herbert	c139478aa2	Merge pull request #28805 from frenzibyte/select-all-on-focus ... Select all text when focusing sample bank/volume textboxes in editor (and number boxes in general)	2024-07-11 17:33:30 +09:00
Bartłomiej Dach	a859978efd	Add failing test steps for locally modified state not being set	2024-07-11 09:43:00 +02:00
Dean Herbert	b5bb94e4ec	Merge branch 'master' into file-mounting-v3	2024-07-11 15:54:54 +09:00
Salman Ahmed	8ca8648a09	Add failing test case	2024-07-10 16:14:12 +03:00
Salman Ahmed	7d667ac46b	Fix confirm exit dialog overflowing from too many ongoing operations	2024-07-10 16:06:53 +03:00
Salman Ahmed	94f51c92e0	Select all text when focusing a number box	2024-07-10 15:16:10 +03:00
Dean Herbert	106d558147	Add test coverage of difficulty being retained	2024-07-10 18:34:47 +09:00
Dean Herbert	aa16c72e06	Add test coverage of external editing	2024-07-10 18:34:47 +09:00
Dean Herbert	72091b43df	Simplify editor navigation tests	2024-07-10 18:34:47 +09:00
Salman Ahmed	f0a7a3f856	Add failing test case for edge case	2024-07-10 11:51:49 +03:00
Salman Ahmed	002679ebb0	Ask for VisibilityContainer explicitly	2024-07-10 11:14:22 +03:00