35 Commits

• Fix play button starting wrong beatmap before selection loads (#36104)

  * Fix play button starting wrong beatmap before selection loads
  
  When clicking the osu! cookie (play button) before a newly selected beatmap finishes loading, the previous beatmap would be played instead of the currently selected one. 
  
  This was caused by the cookie reading from the global beatmap state which is debounced by 150ms, while the Enter key correctly used the carousel's current selection.
  
  The fix makes the cookie use the same beatmap source as Enter - the carousel's current selection - which is always up-to-date regardless of debounce timing.
  
  Closes #36074
  
  * Use ensureGlobalBeatmapValid() for logo and Enter key actions
  
  * Add test for beatmap selection timing bug
  
  Tests the fix for issue #36074 where clicking the play button immediately after selecting a different difficulty would start the wrong beatmap due to the 150ms selection debounce.

  Jul · 2026-01-05 14:54:25 +09:00
  ff820f730e
• Revert "Expand group that current selection resides in when moving mouse to left side of song select"

  Reverts https://github.com/ppy/osu/pull/35184 as per
  https://github.com/ppy/osu/discussions/35683#discussioncomment-15034835.

  Bartłomiej Dach · 2025-11-24 13:38:53 +01:00
  a69b2cd803
• Use new implementation in ScreenTestScene
  Dan Balasescu · 2025-10-17 19:01:28 +09:00
  4be29425a0
• Add failing test scene covering song select left hover action not always activating
  Dean Herbert · 2025-10-06 18:21:10 +09:00
  d08b5a72b7
• Add failing test scene
  Bartłomiej Dach · 2025-10-03 09:24:37 +02:00
  ae4e015352
• Fix multiple failing song select tests
  Dean Herbert · 2025-09-10 01:31:15 +09:00
  0cd3894fa6
• Attempt to fix flaky test TestFilteringRunsAfterReturningFromGameplay

  The double escape key press was dodgy from the get-go.

  Dean Herbert · 2025-09-03 18:49:21 +09:00
  71d0afd4c2
• Ensure filtering also runs after local gameplay LastPlayed changes
  Dean Herbert · 2025-08-28 19:10:20 +09:00
  7e109add96
• Add back random button tests
  Dean Herbert · 2025-06-16 19:59:30 +09:00
  05a50f523c
• Add failing test coverage showing bad selection logic
  Dean Herbert · 2025-06-04 15:45:36 +09:00
  b42b8ba0de
• Add failing test showing double filter on entering song select
  Dean Herbert · 2025-05-30 16:03:31 +09:00
  666d9b153c
• Merge pull request #33318 from bdach/song-select-v2-footer-buttons-stupid

  SongSelectV2: Disable footer buttons when transitioning to another screen

  Dean Herbert · 2025-05-29 18:43:24 +09:00
  9e6d657ec8
• Add failing test case for mod select becoming visible after suspending song select
  Bartłomiej Dach · 2025-05-29 10:34:46 +02:00
  d328d3d6ed
• Add failing test coverage for osu! cookie attempting to start gameplay with nothing selected
  Bartłomiej Dach · 2025-05-29 09:32:38 +02:00
  d1d9749de5
• Update tests to no longer require local selection
  Dean Herbert · 2025-05-26 19:32:32 +09:00
  e33b92fa5c
• Add test coverage of eager selection behaviours
  Dean Herbert · 2025-05-26 19:32:31 +09:00
  0c76c5297d
• Fix github code quality ping
  Dean Herbert · 2025-05-23 14:52:41 +09:00
  68264eb1ad
• Merge branch 'master' into ssv2-score-opens-results
  Bartłomiej Dach · 2025-05-16 13:23:38 +02:00
  ea55fa2703
• Fix code quality
  Bartłomiej Dach · 2025-05-16 13:23:05 +02:00
  4992e4e5e1
• Add test coverage of opening score from song select v2
  Dean Herbert · 2025-05-16 18:35:38 +09:00
  c642d06576
• SongSelectV2: Add support for deselecting all mods by right clicking mod button

  Addresses https://github.com/ppy/osu/discussions/28301.
  
  No sound effects on click because right click handling is weird. I would
  have liked to call `DeselectAll` on the mod select overlay, but this
  doesn't work unless it's displayed due to queued operation.

  Dean Herbert · 2025-05-16 18:22:25 +09:00
  a8b247f7f1
• Rename and expose some song select test properties better
  Dean Herbert · 2025-05-16 18:21:57 +09:00
  7474a7a251
• Fix compile failure
  Bartłomiej Dach · 2025-05-15 13:59:56 +02:00
  4924563eb1
• Hook up footer beatmap options via new ISongSelectBeatmapActions class
  Dean Herbert · 2025-05-15 20:31:54 +09:00
  9fea4a2ed0
• Make carousel handle pressing enter with modifier keys
  Salman Alshamrani · 2025-05-15 16:54:14 +09:00
  87c97ad0b5
• Add test coverage
  Salman Alshamrani · 2025-05-15 16:54:14 +09:00
  e2ae3f2ad0
• Add rate adjustment keybinds

  Add test coverage

  Salman Alshamrani · 2025-05-13 17:30:38 +09:00
  1b2054c49d
• Refactor song select test scenes and add non-filtering area
  Salman Alshamrani · 2025-05-12 15:57:10 +03:00
  168a43a3ae
• Manually load song select in each test case
  Salman Alshamrani · 2025-05-07 08:44:30 +03:00
  cc6e52adee
• Add toolbar in song select test to determine selected ruleset
  Salman Alshamrani · 2025-05-07 08:44:30 +03:00
  1b554d01d6
• Rename song select v2 classes and namespaces

  This aims to bring some conformity to naming to make it easier to
  understand component structure for new components.
  
  Renames are pulled out of the song select v2 changes and are more
  relevant there due to many new classes being added.
  
  - `V2` suffix is dropped, with v2 components being moved to a relevant V2 namespace.
  - Related classes have a prefix of the area they are used.
  - Experimenting with using partial/nested classes in the song select v2 implementation.
    Not committing to this yet but want to see how it plays out.
  - Moved base carousel components to a generic namespace to avoid confusion with actual beatmap carousel implementation.

  Dean Herbert · 2025-04-16 18:34:53 +09:00
  0aff50fbf5
• Add basic subclassing and implement beatmap-start flow
  Dean Herbert · 2025-03-04 17:44:48 +09:00
  f0d6641adf
• Make TestSceneSongSelect work with local database

  It was pointless before.

  Dean Herbert · 2025-02-28 17:55:21 +09:00
  8fc744e9dc
• Allow importing real beatmaps in song select test scene
  Salman Alshamrani · 2025-02-05 21:45:34 -05:00
  29882a2542
• Update remaining tests to use new base class (and tidy up V2 suffixes)
  Dean Herbert · 2024-08-14 21:09:28 +09:00
  e603888130