Endrik Tombak
9e52f9c858
Consider cursor size in trail interval
2020-10-01 23:23:28 +03:00
Dean Herbert
3069428efe
Merge pull request #10316 from smoogipoo/fix-spinner-flicker
...
Fix default spinner flashing yellow glow before completion
2020-10-01 22:29:48 +09:00
Dean Herbert
94996f2cc0
Merge branch 'master' into osu-selection-scaling
2020-10-01 21:09:52 +09:00
smoogipoo
6d3f4c8699
Fix a few more similar cases
2020-10-01 20:38:47 +09:00
Dan Balasescu
df07ca445f
Merge branch 'master' into legacy-SpinnerNoBlink
2020-10-01 20:34:23 +09:00
smoogipoo
ba76089219
Fix spinner flashing yellow glow before completion
2020-10-01 20:24:32 +09:00
smoogipoo
3e6af7ce43
Refactor for readability
2020-10-01 20:09:09 +09:00
Max Hübner
7e5ecd84bc
Add braces to clear up operator precedence
2020-10-01 12:41:44 +02:00
Dean Herbert
b6dc8bb2d3
Fix remaining manual degree-to-radian conversions
2020-10-01 18:10:05 +09:00
Dan Balasescu
3a81602d0c
Merge pull request #10286 from peppy/fix-hitobject-sample-stuck-on-future-seek
...
Fix HitObject samples getting stuck in a playing state on seeking far into the future
2020-10-01 18:08:17 +09:00
Dean Herbert
538973e394
Use float methods for math operations
2020-10-01 17:06:05 +09:00
Dean Herbert
b7ac779760
Merge branch 'master' into fix-hitobject-sample-stuck-on-future-seek
2020-10-01 16:46:14 +09:00
Dean Herbert
983b693858
Add flip logic to OsuSelectionHandler
2020-10-01 16:24:50 +09:00
Dean Herbert
02f14ab4b0
Rename operation start/end to be more encompassing
2020-10-01 16:24:09 +09:00
smoogipoo
7890319802
Merge branch 'master' into adjust-hit-result-types
2020-10-01 16:19:07 +09:00
smoogipoo
cb6b35116a
Merge branch 'master' into scoring-standardisation
2020-10-01 12:28:51 +09:00
smoogipoo
3c9ee6abc1
Use local static to determine score per spinner tick
2020-10-01 12:15:34 +09:00
Dean Herbert
4b70fe8585
Merge branch 'fix-storyboard-sample-pausing' into fix-hitobject-sample-stuck-on-future-seek
2020-09-30 22:46:09 +09:00
Dean Herbert
7f579850dd
Merge branch 'master' into fix-editor-silence-on-seek
2020-09-30 17:03:23 +09:00
Dean Herbert
414c40d298
Reverse inheritance order of SkinnableSound's pause logic
2020-09-30 15:45:14 +09:00
Dean Herbert
59ce9fcab9
Merge branch 'master' into fix-editor-silence-on-seek
2020-09-30 15:35:55 +09:00
Dean Herbert
7fad9ce34a
Simplify HandleScale method
2020-09-30 15:20:25 +09:00
Dean Herbert
f1298bed79
Combine scale operations and tidy up scale drag handle construction
2020-09-30 15:08:56 +09:00
Dean Herbert
313b0d149f
Refactor scale and rotation operations to share code better
...
Also adds support for scaling individual sliders.
2020-09-30 14:41:33 +09:00
Dean Herbert
39b55a85df
Move a lot of the implementation to base SelectionHandler
2020-09-30 13:52:57 +09:00
Dean Herbert
99a3801267
Tidy up scale/rotation operation code
2020-09-30 13:02:05 +09:00
Dean Herbert
5ae6b2cf5b
Fix syntax
2020-09-29 20:10:17 +09:00
Dean Herbert
a2e2cca396
Add proper change handler support
2020-09-29 20:08:56 +09:00
Dean Herbert
934db14e03
Add rotation support
2020-09-29 20:08:56 +09:00
Dean Herbert
33b24b6f46
Refactor to be able to get a quad for the current selection
2020-09-29 20:08:56 +09:00
Dean Herbert
0a10e40ce0
Add scaling support to osu! editor
2020-09-29 20:08:56 +09:00
smoogipoo
f439c1afbc
Make osu/taiko/catch use Ok+Great
2020-09-29 17:16:55 +09:00
smoogipoo
cd895c792c
Merge branch 'master' into scoring-standardisation
2020-09-29 17:04:59 +09:00
smoogipoo
bad48d6d44
Merge branch 'master' into scoring-standardisation
2020-09-29 16:33:38 +09:00
smoogipoo
31fae045fa
Update judgement processors with new hit results
2020-09-29 16:33:38 +09:00
smoogipoo
a1394c1830
Fix a few missed judgements
2020-09-29 16:33:38 +09:00
smoogipoo
a77741927c
Use new hit results in osu
2020-09-29 16:33:38 +09:00
Dean Herbert
5d1c377379
Fix HitObject samples getting stuck in a playing state on seeking far into the future
2020-09-29 15:07:55 +09:00
Dean Herbert
d6f3beffb6
Use existing bindable flow instead
2020-09-29 12:50:17 +09:00
Dean Herbert
cc9bf67d42
Merge branch 'master' into fix-spinner-rpm-user-rate-adjust
2020-09-29 12:10:24 +09:00
Dan Balasescu
66e89f56d9
Merge pull request #10280 from peppy/editor-fix-spinner-extending
...
Fix extending spinners in editor causing them to disappear temporarily
2020-09-28 19:41:44 +09:00
Max Hübner
54852991f3
Move SpinnerNoBlink to OsuSkinConfiguration
2020-09-28 12:24:30 +02:00
Max Hübner
40a4654ef9
Invert spinnerNoBlink to spinnerBlink locally
2020-09-28 12:21:43 +02:00
smoogipoo
b6bc829bd5
Guard against nulls (load not run)
2020-09-28 17:46:22 +09:00
Dean Herbert
fd58a24183
Merge branch 'master' into fix-spinner-rpm-user-rate-adjust
2020-09-28 17:45:48 +09:00
Dan Balasescu
1b6ef60f36
Merge branch 'master' into editor-fix-slider-drag-after-snaking
2020-09-28 17:45:04 +09:00
Dean Herbert
e60e47ff66
Unbind events on disposal
2020-09-28 17:41:10 +09:00
Dean Herbert
63b5b8b841
Fix sliders not dragging correctly after snaking has begun
...
Closes #10278 .
2020-09-28 17:33:00 +09:00
Dean Herbert
8692c24dfc
Fix extending spinners in editor causing them to disappear temporarily
2020-09-28 17:20:36 +09:00
Dean Herbert
5237fa7bf2
Remove unused local in case statement
2020-09-28 16:37:54 +09:00
Dean Herbert
467a16bf75
Fix fade out extension logic (and make it generally look better for sliders)
2020-09-28 16:21:20 +09:00
Dean Herbert
6095446f10
Fix autoplay generators failing on empty hitobjects lists
2020-09-28 15:38:54 +09:00
Max Hübner
33d000e532
Add support for SpinnerNoBlink in legacy spinner
2020-09-26 16:25:57 +02:00
Dean Herbert
b2261f03e2
Merge branch 'master' into fix-spinner-rpm-user-rate-adjust
2020-09-25 20:21:35 +09:00
Dean Herbert
346d14d40b
Rename variables to match
2020-09-25 17:45:19 +09:00
Dean Herbert
22511c36c3
Ensure toggles are not instantiated more than once for safety
2020-09-25 17:43:09 +09:00
Dean Herbert
ae68dcd962
Add ternary toggle buttons to editor toolbox selection
2020-09-25 16:38:12 +09:00
Dean Herbert
0f8551e9ea
Merge branch 'editor-ternary-states' into new-combo-toggle
2020-09-25 15:36:33 +09:00
Dean Herbert
bca774a0d4
Allow BlueprintContainer to specify toggles
2020-09-25 14:09:31 +09:00
Dean Herbert
7df8b5bce7
Merge branch 'master' into fix-spinner-rpm-user-rate-adjust
2020-09-25 13:17:03 +09:00
Dean Herbert
d9e8ac6842
Add support for slider end snapping
2020-09-24 16:24:35 +09:00
Dean Herbert
44be0ab762
Add basic osu! object to object snapping
2020-09-24 16:24:35 +09:00
Dean Herbert
ba160aab76
Fix large construction/disposal overhead on beatmaps with hitobjects at same point in time
2020-09-23 15:41:43 +09:00
Dan Balasescu
625c146460
Merge pull request #10199 from peppy/fix-editor-binding-crash
...
Fix bindings not correctly being cleaned up in OsuHitObjectComposer
2020-09-23 12:38:18 +09:00
Dan Balasescu
53788968c8
Merge pull request #10205 from peppy/fix-composer-distance-snap-selection
...
Fix compose mode not showing distance snap grid when entering with a selection
2020-09-23 11:55:42 +09:00
Dean Herbert
b1f7cfbd5b
Reduce children levels in RingPiece
2020-09-22 17:34:21 +09:00
Dean Herbert
8e43266460
Fix compose mode not showing distance snap grid when entering with a selection
2020-09-22 16:02:07 +09:00
Dean Herbert
25bf160d94
Fix missing GameplayClock in some tests
2020-09-21 22:30:14 +09:00
Dean Herbert
3f788da06d
Fix SPM changing incorrectly with playback rate changes
2020-09-21 19:39:54 +09:00
Dean Herbert
842f8bea55
Fix bindings not correctly being cleaned up in OsuHitObjectComposer
2020-09-21 18:15:33 +09:00
Dean Herbert
1e09d8fd1a
Merge branch 'master' into catch-combo-counter
2020-09-21 17:53:00 +09:00
Dean Herbert
141fbbf5bb
Merge pull request #10180 from smoogipoo/beatmap-conversion-cancellation
...
Make beatmap conversion support cancellation tokens
2020-09-17 22:30:46 +09:00
smoogipoo
c7d24203ce
Make beatmap conversion support cancellation tokens
2020-09-17 17:40:05 +09:00
smoogipoo
009e1b4445
Make Spinner use cancellation token
2020-09-17 17:05:24 +09:00
Dan Balasescu
0761aab42f
Merge branch 'master' into catch-combo-counter
2020-09-15 17:20:31 +09:00
Dean Herbert
a8b405791a
Fix non-convert slider and spinner serialization
2020-09-14 17:32:32 +09:00
Dean Herbert
23b51e8f7f
Merge pull request #10106 from smoogipoo/score-recalc
2020-09-10 19:05:42 +09:00
Dean Herbert
ef44c7d063
Merge branch 'master' into score-recalc
2020-09-10 18:30:41 +09:00
Dean Herbert
df1537f2a0
Update framework
2020-09-10 18:10:39 +09:00
Dan Balasescu
6f6adb61d7
Merge pull request #10099 from peppy/add-editor-tool-icons
...
Add icons for editor toolbox tools
2020-09-09 22:22:58 +09:00
Dean Herbert
fb2aced3ac
Add toggle for distance snap
2020-09-09 19:15:35 +09:00
Dean Herbert
c9f5005efd
Add icons for editor toolbox tools
2020-09-09 18:40:01 +09:00
smoogipoo
117c7ec6b2
Merge branch 'master' into score-recalc
2020-09-09 14:38:36 +09:00
Dean Herbert
4680728b9c
Merge branch 'master' into update-dcc-exclusions
2020-09-07 18:01:44 +09:00
Dan Balasescu
025ead195c
Merge branch 'master' into fix-sliderborder-more-thicker
2020-09-07 15:40:34 +09:00
Yao Chung Hu
96f39dd350
Merge remote-tracking branch 'upstream/master' into visible-playfield-boundary
2020-09-05 01:50:13 -05:00
smoogipoo
1143d5d992
Update class exclusion for dynamic compilation
2020-09-04 20:41:08 +09:00
Salman Ahmed
569a56eccb
Revert "Move adjustment to LegacySkinConfiguration as a default value"
...
This reverts commit 18927304f1
2020-09-04 13:33:23 +03:00
Dean Herbert
25e142965d
Strongly type and expose default beatmap information icon implementations for other rulesets
2020-09-04 15:01:32 +09:00
Salman Ahmed
18927304f1
Move adjustment to LegacySkinConfiguration as a default value
2020-09-03 16:29:38 +03:00
Dean Herbert
72cb65c22f
Update and add missing beatmap statistic icons to info wedge
2020-09-03 17:52:22 +09:00
Salman Ahmed
5180d71fd9
Attach an inline comment explaining how the value was reached
2020-09-03 06:09:52 +03:00
Salman Ahmed
e7eaaf8b02
Bring legacy slider border width closer to osu!stable
2020-09-03 04:46:26 +03:00
Salman Ahmed
99a68e880a
Merge remote-tracking branch 'upstream/master' into catch-combo-counter
2020-09-01 20:46:38 +03:00
Salman Ahmed
a0a4501008
Merge remote-tracking branch 'upstream/master' into catch-combo-counter
2020-09-01 20:17:25 +03:00
Dean Herbert
3d0121ceb1
Merge pull request #10022 from PajLe/auto-on-low-duration-spinners
2020-09-01 12:19:44 +09:00
Bartłomiej Dach
69ec2a76ef
Replace reaction time check with spins required check
2020-08-31 17:20:45 +02:00
PajLe
0655fc1473
changed comparing Duration to autoplay's reactionTime instead of 0
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-08-31 16:50:31 +02:00
Pavle Aleksov
fde4b03dab
added spinner duration check - skip HitObjectReplay if duration is 0
2020-08-31 16:21:00 +02:00
smoogipoo
acbeb5406f
Add/improve xmldoc
2020-08-31 13:33:41 +09:00
Bartłomiej Dach
3ab32a5d35
Change structure of old style spinner to be closer to stable
2020-08-29 23:29:29 +02:00
Dean Herbert
cd0a73883d
Merge pull request #9945 from smoogipoo/skin-colour-fix-2
...
Exactly reproduce osu!stable skin colour alphas
2020-08-29 20:06:26 +09:00
smoogipoo
1c1afa1c96
Move MaxCombo to base DifficultyAttributes
2020-08-28 19:16:20 +09:00
Bartłomiej Dach
43d6d2b2e8
Add back unstable rate display
2020-08-27 20:46:49 +02:00
Bartłomiej Dach
f152e1b924
Revert IStatisticRow changes
2020-08-27 20:13:44 +02:00
Bartłomiej Dach
05e725d59f
Add unstable rate statistic to rulesets in which it makes sense
2020-08-26 22:06:29 +02:00
Bartłomiej Dach
bbb3d7522e
Scope up return type to IStatisticRow
2020-08-26 19:24:12 +02:00
smoogipoo
ab8d9be095
Move out into a separate method
2020-08-25 15:16:41 +09:00
Salman Ahmed
cf6b34db1e
Merge remote-tracking branch 'upstream/master' into catch-combo-counter
2020-08-22 13:07:28 +03:00
smoogipoo
08078b9513
Rename method to remove "InitialColour" namings
2020-08-22 00:56:29 +09:00
smoogipoo
16a2ab9dea
Update osu with legacy colour setters
2020-08-22 00:20:33 +09:00
Salman Ahmed
deb5cc752b
Merge remote-tracking branch 'upstream/master' into catch-combo-counter
2020-08-19 08:39:58 +03:00
Salman Ahmed
422100192c
Move HasFont to legacy skin extensions class instead
2020-08-19 07:58:23 +03:00
smoogipoo
da07354f05
Fix some judgements potentially giving wrong score
2020-08-18 19:51:16 +09:00
Bartłomiej Dach
5f35b3ebb9
Fix constant casing
2020-08-15 20:44:02 +02:00
Ron B
390e872730
Fix acoording to review
2020-08-15 21:34:17 +03:00
Ron B
a1079bac32
Move frequency values into consts
2020-08-15 21:19:47 +03:00
Ron B
40445d0005
replicate osu-stable behaviour for spinningSample frequency
2020-08-15 21:07:44 +03:00
Ron B
07c25d5a78
Move spinnerFrequencyModulate set to ApplySkin
2020-08-15 20:51:33 +03:00
Ron B
61de3c7540
Replace accidental tab with spaces
2020-08-15 20:18:56 +03:00
Ron B
896a87e629
Replace accidental tab with spaces
2020-08-15 20:14:36 +03:00
Ron B
5c11270b98
Add SpinnerFrequencyModulate skin config option
2020-08-15 20:12:06 +03:00
Dan Balasescu
b7ae70ff96
Merge branch 'master' into fix-skinnable-sound-mute
2020-08-14 19:01:32 +09:00
Dean Herbert
662281d727
Adjust legacy spinners to fade in later
...
Matches stable 1:1 for legacy skins. I've left lazer default as it is
because changing to use the shorter apperance looks bad. This will
probably change as we proceed with the redesign of the default skin.
2020-08-13 18:20:46 +09:00
Dean Herbert
05b06e7451
Merge branch 'master' into fix-skinnable-sound-mute
2020-08-12 22:01:04 +09:00
Bartłomiej Dach
4f3f95540b
Check for zero rate to prevent crashes on unpause
2020-08-11 22:34:46 +02:00
Bartłomiej Dach
bcaaf25278
Fix Spun Out mod being affected by rate-changing mods
2020-08-11 22:04:18 +02:00
Bartłomiej Dach
cca78235d5
Replace CumulativeRotation with RateAdjustedRotation
2020-08-10 23:02:06 +02:00
Dean Herbert
365aae799e
Merge branch 'master' into fix-skinnable-sound-mute
2020-08-10 23:55:51 +09:00
Bartłomiej Dach
a636c7052c
Merge branch 'master' into adujustable-skinnablesound
2020-08-08 21:51:47 +02:00
Dean Herbert
0d1f273603
Merge branch 'master' into fix-skinnable-sound-mute
2020-08-08 23:24:03 +09:00
Dan Balasescu
d8ffc00f75
Merge pull request #6345 from frenzibyte/expand-number-piece-on-old-skins
...
Expand number piece for legacy old skins
2020-08-07 17:18:36 +09:00
smoogipoo
3c3756e42d
Merge branch 'master' into expand-number-piece-on-old-skins
2020-08-07 16:36:58 +09:00
smoogipoo
bce3f3952f
Split out variable declaration
2020-08-07 16:36:40 +09:00
Dan Balasescu
3c8fe12ccf
Merge branch 'master' into playfield-shift
2020-08-07 16:27:03 +09:00
Dean Herbert
e3105fd4c8
Add more resilient logic for whether to avoid playing SkinnableSound on no volume
2020-08-06 19:16:26 +09:00
smoogipoo
9a00ad48c6
Update components to use extension methods
2020-08-06 14:43:39 +09:00
Salman Ahmed
9465e7abe1
Rename sprites container to "circleSprites"
2020-08-05 23:45:00 +03:00
Salman Ahmed
43161697f8
Fix wrong english
2020-08-05 23:42:05 +03:00
Sebastian Krajewski
2c73fc0e1b
Merge branch 'master' into playfield-shift
2020-08-05 22:34:43 +02:00
Salman Ahmed
1ab6110c05
Apply fade out to the number piece with quarter the pieces duration
2020-08-05 20:07:26 +03:00
Salman Ahmed
84f6b7608c
Remove misleading ExpandNumberPiece lookup
2020-08-05 20:05:53 +03:00
Dean Herbert
bb73489ae5
Fix very short spinners being impossible to complete
2020-08-05 18:46:58 +09:00
smoogipoo
24bc9b33b1
Always place spinners behind hitcircles/sliders
2020-08-05 15:40:45 +09:00
Salman Ahmed
2771c95bec
Merge remote-tracking branch 'upstream/master' into expand-number-piece-on-old-skins
2020-08-04 22:17:54 +03:00
Sebastian Krajewski
9fb7b8f3d8
Rename the property to "AlignWithStoryboard"
2020-08-04 15:43:33 +02:00
Salman Ahmed
29053048ff
Add support to use legacy combo fonts for the counter on legacy skins
2020-08-03 21:40:20 +03:00
Sebastian Krajewski
675f618b28
Apply playfield's offset only in play mode
2020-08-03 14:18:45 +02:00
Sebastian Krajewski
c48648ea2a
Add playfield shift like in osu-stable
2020-08-03 13:00:36 +02:00
smoogipoo
cd9896c35e
Merge branch 'master' into spinner-spinning
2020-08-01 01:06:53 +09:00
Dean Herbert
180afff805
Ensure damp is always positive exponent
2020-08-01 00:39:04 +09:00
Dean Herbert
bb01ee5be9
Fix trackign alpha not being applied
2020-08-01 00:27:00 +09:00
Dean Herbert
9e244be489
Use better conditional for choosing which spinner type to use
...
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2020-08-01 00:05:04 +09:00
Dean Herbert
186b452331
Apply common multiplication refactor
2020-07-31 14:48:56 +09:00
Dean Herbert
86784e30ad
Fix spacing
2020-07-31 09:54:30 +09:00
Dean Herbert
cd570433f4
Move private methods to bottom of class
2020-07-31 09:04:20 +09:00
Dean Herbert
8e49256a5c
Rename and split up statement to make more legible
2020-07-31 09:03:29 +09:00
Dean Herbert
38a4bdf068
Add spinner spin sample support
2020-07-30 19:34:59 +09:00
Dean Herbert
ec0d7760af
Move todo?
2020-07-30 13:07:11 +09:00
Dean Herbert
41c0f7557a
Remove traceable spinner reference for now
2020-07-30 12:56:30 +09:00
Dean Herbert
c1085d49d3
Add more xmldoc
2020-07-30 12:55:34 +09:00
Dean Herbert
19fb350cd8
Move offset and scale to constant
2020-07-30 12:51:05 +09:00
Dean Herbert
743d165319
Add old style spin metre
2020-07-30 12:32:19 +09:00
Dean Herbert
d2b3fe1e7b
Add scale to old legacy spinner
2020-07-30 12:08:04 +09:00
Dean Herbert
4d822742e8
Add scale and tint to new legacy style spinner
2020-07-30 12:05:19 +09:00
Dean Herbert
54fee7e716
Simplify and standardise scale for default display
2020-07-30 11:50:13 +09:00
Dean Herbert
64c7ae7686
Fix hit transforms not playing out correctly
2020-07-30 11:25:49 +09:00
Dean Herbert
ca21f038e0
Add xmldoc for legacy classes
2020-07-30 10:35:48 +09:00
Dean Herbert
2b71ffa2ed
Add back legacy implementations
2020-07-29 22:32:21 +09:00
Dean Herbert
023feaf438
Refactor to centralise implementation into a single component
...
Turns out this is a better way forward.
2020-07-29 22:31:52 +09:00
Dean Herbert
2a5e9fed4d
Move default background implementation out of DrawableSpinner
2020-07-29 18:15:19 +09:00
Dean Herbert
2cd6e89cb0
Move default centre implementation out of DrawableSpinner
2020-07-29 18:02:12 +09:00
Dean Herbert
1c00cf95d5
Add initial support for spinner middle skinning
2020-07-29 16:55:47 +09:00
Dean Herbert
e98154b432
Add initial support for spinner background layer
2020-07-29 16:37:32 +09:00
Dean Herbert
d01d1ce3f1
Add initial support for spinner disc skinning
2020-07-29 16:25:10 +09:00
Dean Herbert
f97656351d
Merge branch 'master' into scaleMod
2020-07-28 18:55:07 +09:00
Dan Balasescu
bf6cf2144a
Merge pull request #9699 from peppy/fix-autopilow-wind-up
...
Fix Autopilot mod incompatibility with WindUp/WindDown
2020-07-28 18:49:52 +09:00
Dean Herbert
3cb1cc0555
Merge branch 'master' into scaleMod
2020-07-28 15:05:35 +09:00
Dean Herbert
afceab685b
Merge pull request #9688 from peppy/less-spinner-bonus-score
...
Reduce spinner tick and bonus score
2020-07-28 14:21:48 +09:00
Dean Herbert
72c8f0737e
Fix Autopilot mod incompatibility with WindUp/WindDown
2020-07-28 14:18:21 +09:00
Dan Balasescu
89f2d7d38a
Merge branch 'master' into less-spinner-bonus-score
2020-07-28 13:32:55 +09:00
Dean Herbert
dc577aa6fa
Fix display of bonus score
2020-07-28 11:22:58 +09:00
Bartłomiej Dach
7ad3101d08
Bring back custom fade-out delay if hit lighting is on
2020-07-27 19:21:01 +02:00
Bartłomiej Dach
21ae33e284
Determine whether to show lighting at prepare time
2020-07-27 19:07:21 +02:00
Bartłomiej Dach
bbc7d69524
Add failing test cases
2020-07-27 19:07:21 +02:00
Dean Herbert
10101d5b31
Reduce spinner tick and bonus score
2020-07-27 18:06:14 +09:00
Salman Ahmed
5e7237bf56
Fix incorrect default hitcircle font overlapping applied to legacy skins
2020-07-27 10:29:16 +03:00
Dean Herbert
a6a7961af9
Change div to subtraction to fix calculation
2020-07-24 22:09:25 +09:00
Dean Herbert
dd45f0bd40
Adjust max spins to "match" stable
2020-07-24 21:10:46 +09:00
Dean Herbert
82e4050fdd
Fix xmldoc
2020-07-24 19:41:34 +09:00
Dean Herbert
eb84f25036
Adjust maximum spins to roughly match stable
2020-07-24 19:34:13 +09:00
Dean Herbert
0050f6348f
Merge branch 'master' into add-spinner-bonus-score
2020-07-23 23:05:04 +09:00
smoogipoo
c348599189
Merge branch 'master' into add-slider-slide-support
2020-07-23 21:24:45 +09:00
smoogipoo
f883cb85d7
Null out the sample too
2020-07-23 21:24:31 +09:00
Dan Balasescu
f106106dc4
Merge pull request #9648 from peppy/fix-slider-ball-rotation
...
Fix slider ball rotation being applied to follow circle and specular layer
2020-07-23 19:39:58 +09:00
Dean Herbert
113fac84dd
Fix circle container type
2020-07-22 21:14:04 +09:00
Dan Balasescu
372754f1a2
Merge pull request #9649 from peppy/hide-repeat-judgements
...
Hide slider repeat judgements temporarily
2020-07-22 20:36:00 +09:00
Dan Balasescu
a640541324
Merge pull request #9612 from peppy/input-handler-updates
...
Input handler updates in line with framework changes
2020-07-22 20:30:32 +09:00
Dean Herbert
2c62b23d85
Update naming
2020-07-22 19:53:45 +09:00
Dean Herbert
bd6a51f545
Hide slider repeat judgements temporarily
2020-07-22 19:30:10 +09:00
Dean Herbert
53a9ac3c1a
Fix slider ball rotation being applied to follow circle and specular layer
2020-07-22 19:06:39 +09:00
Dean Herbert
2126f6bffc
Add slider "sliding" sample support
2020-07-22 16:37:58 +09:00
Dean Herbert
bc079fccf5
Add health drain for spinner ticks
2020-07-21 19:52:16 +09:00
Dean Herbert
1560e1786a
Revert back to bool for application
2020-07-21 19:48:44 +09:00
Dean Herbert
7f2ae694cc
Simplify rewind handling
2020-07-21 19:21:30 +09:00
Dean Herbert
947f4e0d4c
Move tick handling to DrawableSpinner itself
2020-07-21 19:20:19 +09:00
Dean Herbert
05102bc1ba
Split ticks up into bonus and non-bonus
2020-07-21 18:22:37 +09:00
Salman Ahmed
35ad409da6
Fix spinner bonus ticks samples not actually playing
2020-07-21 06:59:29 +03:00
Dean Herbert
4dd40542d5
Rename rotation set method to match others
2020-07-21 11:31:29 +09:00
Dean Herbert
f48984920d
Change bonus volume logic to work
2020-07-21 11:31:29 +09:00
Dean Herbert
35d53139e7
Merge branch 'master' into add-spinner-bonus-score
2020-07-21 11:21:17 +09:00
Dean Herbert
e06d3c5812
Minor adjustments to tick clearance
2020-07-20 17:52:59 +09:00
Dean Herbert
4cbc176cb6
Add less fill and more transparency
2020-07-20 17:50:11 +09:00
Dean Herbert
33e58bb7db
Fix sizing and colour not correct on hit
2020-07-20 17:22:30 +09:00
Dean Herbert
55d921ef85
Improve feel of animation
2020-07-20 17:22:30 +09:00
Dean Herbert
648e414c14
Update InputHandlers in line with framework changes
2020-07-19 11:39:11 +09:00
Fabian
56b0094d43
Update slider labels & descriptions
2020-07-18 23:10:05 +02:00
Fabian
0975610bf7
Increased maximum start modifier higher (15x -> 25x)
...
Tried playing around with higher values and personally had quite fun when the circles covered the whole screen so I raised the max modifier to 25. Works best with an AR of <6.
2020-07-18 02:21:55 +02:00
Fabian
a6cf77beae
Clarified what the slider value is
2020-07-17 17:53:20 +02:00
Fabian
9857779d42
Added slider for the grow/deflate mod
2020-07-17 16:12:01 +02:00
Dan Balasescu
f3a498482b
Merge pull request #9553 from peppy/difficulty-adjust-range-match-stabl
...
Change difficulty adjust mod to match stable range of 0-10
2020-07-14 20:12:28 +09:00
Dean Herbert
b59e4f8a7e
Change difficulty adjust mod to match stable range of 0-10
2020-07-14 08:15:14 +09:00
smoogipoo
8a3cadc111
Fix judgement animations not resetting on use
2020-07-13 21:21:59 +09:00
Dean Herbert
dd025262d0
Fix one more nullref
2020-07-10 22:48:34 +09:00
Dean Herbert
0a61f80c8b
Remove result nullable check
2020-07-10 22:39:35 +09:00
Dean Herbert
13205319f3
Fix null reference if hit lighting is disabled
2020-07-10 22:37:29 +09:00
Yao Chung Hu
d40f209f4b
Move Playfield Border to OsuPlayfield Ruleset
2020-07-10 07:36:21 -05:00
Dean Herbert
024fb52726
Fix unnecessary using
2020-07-10 19:05:31 +09:00
Dean Herbert
c9e54651d5
Merge branch 'master' into judgement-pooling
2020-07-10 18:51:42 +09:00
Dean Herbert
f872343bab
Make Apply virtual to further simplify application process
2020-07-10 18:35:20 +09:00
Dean Herbert
8aff828dfe
Move application of judgements to Apply method
2020-07-10 18:34:31 +09:00
Dean Herbert
1b9f09f9c2
Merge branch 'master' into osu-cursor-visibility
2020-07-10 17:15:34 +09:00
Dean Herbert
3138cc455c
Merge branch 'master' into judgement-pooling
2020-07-10 17:15:19 +09:00
Dean Herbert
bd5957bc0a
Add dynamic compilation exclusion rules for ruleset types
2020-07-10 14:49:44 +09:00
Dean Herbert
c562435267
Adjust cursor transforms for better feel
2020-07-10 14:44:30 +09:00
Dean Herbert
a21c2422c5
Make cursor centre portion non-expanding and more visible with outline
2020-07-10 14:44:20 +09:00
Dean Herbert
e211ba5e7d
Fix cursor scale potentially not being updated if set too early
2020-07-10 14:43:30 +09:00
Dean Herbert
efb2c2f4ae
Rename variable to be more clear on purpose
2020-07-09 12:01:00 +09:00
Bartłomiej Dach
4cd874280c
Add clarifying xmldoc for RotationAbsolute
2020-07-08 22:37:50 +02:00
Bartłomiej Dach
213dfac344
Fix broken spinner rotation logic
2020-07-08 22:37:50 +02:00
Dean Herbert
e6ec883084
Remove slider tail circle judgement requirements
2020-07-08 20:21:44 +09:00
Dean Herbert
51050ec4ef
Add per-result type pooling
2020-07-06 12:54:39 +09:00
Bartłomiej Dach
d229993e5c
Use RotationAbsolute instead
2020-07-05 02:12:26 +02:00
Bartłomiej Dach
cd6bdcdb88
Replace further spinner transforms with manual lerp
2020-07-05 00:25:01 +02:00
Dean Herbert
ffec4298a7
Use DrawablePool for DrawableJudgements
2020-07-04 16:45:50 +09:00
Dean Herbert
c095753f24
Add better line smoothing
2020-06-25 19:02:04 +09:00
Dean Herbert
fd13c0a6dd
Standardise line thickness
2020-06-25 18:44:04 +09:00
Dean Herbert
0d3bc1ac29
Add basic heatmap colour scaling based on peak value
2020-06-24 22:29:30 +09:00
Dean Herbert
9119f41604
Merge branch 'master' into results-screen-statistics-overlapping-transition
2020-06-24 18:22:51 +09:00
Dean Herbert
14ad3835ff
Update naming
2020-06-23 21:27:01 +09:00
smoogipoo
cb03e6faa9
Improve visual display of arrow
2020-06-22 21:09:47 +09:00
smoogipoo
beb6e6ea88
Buffer the accuracy heatmap for performance
2020-06-22 21:00:13 +09:00
smoogipoo
1aec1ea53f
Fix off-by-one causing auto to not be centred
2020-06-22 20:45:44 +09:00
smoogipoo
983f0ada2d
Increase number of points to ensure there's a centre
2020-06-22 20:45:33 +09:00
smoogipoo
988baad16f
Expand statistics to fill more of the screen
2020-06-22 19:20:43 +09:00
smoogipoo
30aa6ec2d3
Don't consider slider tails in accuracy heatmap
2020-06-22 19:05:41 +09:00
smoogipoo
2b7fb2b71d
Rename to Position
2020-06-22 19:04:51 +09:00
smoogipoo
261adfc4e6
Create a local playable beatmap instead
2020-06-22 18:38:41 +09:00
smoogipoo
9dbd230ad3
Don't consider slider tails in timing distribution
2020-06-22 18:06:52 +09:00
smoogipoo
533d6e72eb
Refactor + comment angle math
2020-06-22 18:05:21 +09:00
smoogipoo
21f776e51f
Simplify/optimise heatmap point additoin
2020-06-22 15:48:42 +09:00
smoogipoo
33fdd7466c
Merge branch 'master' into results-screen-statistics-overlapping-transition
2020-06-22 15:38:48 +09:00
Bartłomiej Dach
ad85c5f538
Add base legacy skin transformer
2020-06-21 23:06:55 +02:00
smoogipoo
486b899e8f
Rename method
2020-06-19 22:11:29 +09:00
smoogipoo
863666f7c4
Move accuracy heatmap to osu! ruleset, rename, remove magic number
2020-06-19 21:14:31 +09:00
smoogipoo
49997c54d0
Remove unused class
2020-06-19 21:14:17 +09:00
smoogipoo
89a863a337
Refactor OsuRuleset
2020-06-19 21:02:20 +09:00
smoogipoo
ad3bc99e7c
Fix hit event position offset not being set
2020-06-19 20:49:05 +09:00
smoogipoo
83e6c3efdb
Adjust API for returning statistics
2020-06-19 20:31:52 +09:00
smoogipoo
1cbbd6b442
Move timing distribution graph to osu.Game
2020-06-19 20:03:18 +09:00
smoogipoo
eab00ec9d9
Move hit events to the ScoreProcessor
2020-06-19 19:58:35 +09:00
smoogipoo
ef56225d9a
Rename CursorPosition -< PositionOffset
2020-06-19 19:43:46 +09:00
smoogipoo
8c9506197d
Increase the number of bins in the timing distribution
2020-06-19 19:41:46 +09:00
smoogipoo
d3e4e63258
Remove unnecessary class
2020-06-19 19:12:48 +09:00
smoogipoo
cae3a5f447
Rework heatmap for more consistent performance
2020-06-19 19:08:36 +09:00
smoogipoo
20db5b33ab
Rework score processor to provide more generic events
2020-06-18 22:11:03 +09:00
smoogipoo
a2ddb4edb4
Change interface for creating statistic rows
2020-06-16 17:49:28 +09:00
smoogipoo
076eac2362
Inset entire graph rather than just the axis
2020-06-16 17:46:34 +09:00
smoogipoo
3dbe164b2c
Add some very basic safety checks around non-existent data
2020-06-16 17:20:38 +09:00
smoogipoo
9ea7c3dc90
Make heatmap support dynamic sizing
2020-06-16 16:31:02 +09:00
smoogipoo
89b54be673
Add initial implementation of the statistics panel
2020-06-15 22:45:18 +09:00
smoogipoo
900da88498
Populate hit offsets from score processor
2020-06-15 22:44:55 +09:00
smoogipoo
f9db37a1de
Split out types
2020-06-15 21:48:59 +09:00
smoogipoo
3b630eabd6
Merge branch 'master' into results-screen-statistics
2020-06-12 17:46:11 +09:00
smoogipoo
f3b5149648
Move some suggestions to warnings, resolve issues
2020-06-03 16:48:44 +09:00
smoogipoo
dc41e74e19
Fix cursor trail not displaying
2020-06-02 23:54:23 +09:00
smoogipoo
e98f51923a
Add timing distribution to OsuScoreProcessor
2020-06-02 23:38:24 +09:00
Dan Balasescu
a8b137bb71
Merge pull request #9123 from peppy/move-setter-to-duration
...
Move setter from EndTime to Duration
2020-06-01 16:52:38 +09:00
Dan Balasescu
64d1b4b11b
Merge branch 'master' into move-setter-to-duration
2020-06-01 15:55:48 +09:00
Dean Herbert
b9464a2aa8
Merge branch 'master' into editor-create-composer-fix
2020-06-01 15:38:15 +09:00
Dean Herbert
0ef971be28
Merge branch 'master' into i-has-curve-with-repeats
2020-05-31 22:30:18 +09:00
Dean Herbert
d4b7c81f96
Merge branch 'master' into results-screen-condensed-panel
2020-05-30 23:13:52 +09:00
Dean Herbert
e8b43e8e1f
Merge branch 'master' into move-setter-to-duration
2020-05-29 16:04:23 +09:00
Dean Herbert
8fa8c561e7
Pass hitobjects as a parameter to CreateBlueprintContainer
2020-05-29 12:20:50 +09:00
Dean Herbert
f5c974dd89
Hide non-alive selection blueprints by default
2020-05-27 13:40:16 +09:00
Dean Herbert
cbd563e80b
Rename to IHasDuration
2020-05-27 12:38:39 +09:00
Dean Herbert
b8e0a6f127
Move sett from EndTime to Duration
2020-05-27 12:37:44 +09:00
Dean Herbert
6b5b215299
Split out IHasPath from IHasCurve to better define hitobjects
2020-05-26 17:44:47 +09:00
smoogipoo
51e74687f8
Merge branch 'editor-scrolling-playfield-support' of https://github.com/peppy/osu ; branch 'results-screen-condensed-panel' of https://github.com/smoogipoo/osu into results-screen-condensed-panel
2020-05-26 15:39:39 +09:00
Dan Balasescu
b5de30ef3d
Merge branch 'master' into editor-scrolling-playfield-support
2020-05-26 14:46:58 +09:00
Dean Herbert
0cc6d6d97c
Merge pull request #9033 from smoogipoo/applydefaults-cancellation
...
Add cancellation token support to CreateNestedHitObjects()
2020-05-26 12:04:06 +09:00
Dean Herbert
e7442ec3a2
Remove need for ManiaSnapResult
2020-05-25 19:33:03 +09:00
smoogipoo
ebe2e97372
Merge branch 'master' into editor-clock-transform
2020-05-25 19:01:04 +09:00
smoogipoo
bc35bc5efb
Merge branch 'master' into applydefaults-cancellation
2020-05-25 16:45:30 +09:00
Dean Herbert
decdc58de5
Merge branch 'editor-clock-cache' into editor-clock-transform
2020-05-24 12:55:47 +09:00
Dean Herbert
a8dbfe2791
Fix distance snap grid not disappearing when exiting playfield
2020-05-23 10:57:17 +09:00
Dean Herbert
bc82c2d3b7
Move drawable addition above event bindings
2020-05-23 10:44:53 +09:00
Dean Herbert
a3a9810344
Merge branch 'master' into editor-clock-cache
2020-05-23 00:44:04 +09:00
Dean Herbert
1311fd2f64
Merge branch 'master' into editor-move-distance-snap-grid
2020-05-23 00:42:43 +09:00
smoogipoo
d5ea076427
Merge branch 'master' into results-screen-condensed-panel
2020-05-22 20:45:39 +09:00
Dean Herbert
af30d1201f
Fix slider path control point blueprint not working correctly
2020-05-22 18:57:28 +09:00
Dean Herbert
d18eb663b1
Add tweening seek support to EditorClock
2020-05-22 16:47:52 +09:00
Dean Herbert
8a47e2431b
Move distance snap grid implementation to OsuHitObjectComposer
2020-05-21 17:13:22 +09:00
Dean Herbert
a9a1c00cf1
Move responsibility placement blueprint's StartTime set to within
2020-05-21 14:50:33 +09:00
Dean Herbert
82d6549161
Pass down snap result and remove local TimeAt usage
2020-05-20 21:01:29 +09:00
Dean Herbert
c46bfc2532
Create SnapResult class to hold various snapping results
2020-05-20 21:00:47 +09:00
Dean Herbert
3354d48a38
Change snapping to be screen space coordinate based
2020-05-20 21:00:29 +09:00
Huo Yaoyuan
c20902f249
Fix double in accuracy calculation in OsuPerformanceCalculator.
2020-05-18 18:22:03 +08:00
Huo Yaoyuan
373aae0610
Use int for total hits in OsuPerformanceCalculator.
2020-05-18 17:45:32 +08:00
smoogipoo
1865cd0762
Fix possible exceptions in performance calculators
2020-05-18 15:10:59 +09:00
smoogipoo
2bde4fc3ee
Initial implementation of contracted score panel
2020-05-16 18:20:19 +09:00
smoogipoo
4719fcc291
Actually use the cancellation token
2020-05-15 18:17:39 +09:00
smoogipoo
98125102a7
Add cancellation token support to CreateNestedHitObjects()
2020-05-15 18:07:41 +09:00
Dean Herbert
de50b725d5
Fix mod failure checks executing actual game logic
2020-05-12 20:08:35 +09:00
smoogipoo
f195933844
Fix hardrock potentially taking a long time to load
2020-05-11 13:03:59 +09:00
smoogipoo
efff2bf15d
Add HitObject to DefaultsApplied event
2020-05-08 18:49:19 +09:00
alex
0e2ccac33b
Add spaces to comments
2020-05-04 18:36:24 -07:00
smoogipoo
ca692f30e6
Do full placement on mouse down
2020-04-24 12:27:56 +09:00
smoogipoo
8d5732aabd
Make placements happen on mouse down
2020-04-23 12:17:11 +09:00
Dean Herbert
1f0b7465e2
Add back missing line
2020-04-21 16:06:40 +09:00
Dean Herbert
5e3fad86cf
Fix relax replays playing back incorrectly
2020-04-21 15:28:25 +09:00
Dan Balasescu
eb7b04d8bc
Merge branch 'master' into fix-osu-hidden-mod-alt
2020-04-20 17:47:27 +09:00
smoogipoo
355e682e24
Fix typo in exception
2020-04-20 13:23:27 +09:00
Dean Herbert
8c85602ad0
Use foreach for conformity
2020-04-20 11:00:42 +09:00
Dean Herbert
e1acfd26a6
Simplify return logic
2020-04-20 10:59:44 +09:00
Dean Herbert
28318a0140
Add mention of notelock in xmldoc (potentially easier to find class)
2020-04-20 10:59:08 +09:00
smoogipoo
bbcbd7e3fb
Simplify by removing custom enumerator
2020-04-17 14:48:12 +09:00
smoogipoo
2dee5e03e3
Dispose enumerators for safety
2020-04-17 14:40:29 +09:00
smoogipoo
4e4fe5cc90
Fix slider heads not being blocked when hit out of order
2020-04-17 14:33:29 +09:00
smoogipoo
a4a7823817
Add fail-safe to ensure hittability after a hit
2020-04-17 14:22:03 +09:00
smoogipoo
62f77a05be
Optimise by removing state machine
2020-04-17 14:00:00 +09:00
smoogipoo
3daacbc2d2
Initial inefficient refactor of hitobject enumeration
2020-04-17 13:34:20 +09:00
Dean Herbert
9dda7da489
Fix spinners being considered the "first object" for increased visibility in hidden
2020-04-16 14:11:38 +09:00
Dean Herbert
2b2ab2bf19
Show new segments as red points even when hovered
2020-04-13 21:59:23 +09:00
smoogipoo
4cfc686683
Fix excption with 0 control points
2020-04-13 21:41:18 +09:00
Dean Herbert
63de493c85
Merge branch 'master' into fix-red-point-placement
2020-04-13 20:56:50 +09:00
Dean Herbert
64422fbf6d
Merge pull request #8697 from smoogipoo/more-change-state-support
...
Add change state support to more Editor components
2020-04-13 20:19:04 +09:00
Dean Herbert
d56b6900ad
Merge pull request #8737 from smoogipoo/fix-overlapping-controlpoints
...
Fix connections hidden due to overlapping controlpoints
2020-04-13 20:06:24 +09:00
Dean Herbert
ca5971578a
Merge branch 'master' into more-change-state-support
2020-04-13 19:13:07 +09:00
Dean Herbert
0e88c28060
Merge branch 'editor-undo-redo' into more-change-state-support
2020-04-13 18:07:00 +09:00
