Dan Balasescu
50c4f90983
Fix intermittent playlists results screen tests
2025-03-06 12:55:59 +09:00
Dan Balasescu
f6cf63edae
Merge pull request #32199 from bdach/negative-leaderboard-position
...
Fix playlists results screens potentially displaying negative score positions
2025-03-05 16:13:12 +09:00
Dan Balasescu
cf3664349d
Merge branch 'master' into remove-selectedroom
2025-03-04 17:00:43 +09:00
Dean Herbert
9e8a611728
Rename RoomsContainer and scope down bindables
2025-03-04 15:05:12 +09:00
Dan Balasescu
446718f929
Merge branch 'master' into remove-roommanager
2025-03-04 13:17:04 +09:00
Dean Herbert
58a671decb
Merge pull request #31637 from smoogipoo/room-management-lio
...
Create, join, and part multiplayer rooms only via the multiplayer server
2025-03-04 13:13:55 +09:00
Bartłomiej Dach
28f9e734f0
Add failing test case
2025-03-03 12:32:27 +01:00
Dan Balasescu
a33aff9bbd
Merge branch 'master' into room-management-lio
2025-02-27 14:14:19 +09:00
Dan Balasescu
c280c8fa1c
Add support to tests
...
Somewhat informal because it isn't super easy to handle.
2025-02-26 18:31:06 +09:00
Dean Herbert
db4a4a1723
Minor bump some packages
2025-02-17 15:23:26 +09:00
Dean Herbert
8ce28d56bb
Fix tests not waiting enough
2025-02-14 14:58:04 +09:00
Dan Balasescu
205d6ecffb
Remove SelectedRoom abstraction from OnlinePlayTestScene
2025-02-12 22:55:19 +09:00
Dan Balasescu
1b07b6d16f
Remove selected room leasing, make bindables private
...
I believe once upon a time the `SelectedRoom` bindable used to be bound
to `RoomManager.JoinedRoom` or similar. But now it's effectively private
to the lounge subscreen and so a lease is unnecessary.
2025-02-12 21:48:59 +09:00
Dan Balasescu
f146a7d116
Remove RoomManager and related components
2025-02-12 21:37:34 +09:00
Dan Balasescu
068a66e7d4
Move room tracking to lounge subscreen
2025-02-12 21:10:21 +09:00
Layendan
aad12024b0
remove using cache, improve tests, and revert loading
2025-02-07 03:13:51 -07:00
Layendan
b7483b9442
Add playlist collection button w/ tests
2025-02-06 07:25:45 -07:00
Dan Balasescu
ab4162e2aa
Various refactorings and cleanups
2025-01-25 19:32:59 +09:00
Dan Balasescu
9a623257f5
Adjust + fix tests
2025-01-23 16:27:38 +09:00
Dean Herbert
a3998fbd52
Merge branch 'master' into better-room-status
2024-12-11 18:06:55 +09:00
Dan Balasescu
6ff1dec7b2
Add tests
2024-12-03 15:45:58 +09:00
Bartłomiej Dach
2e6f43a75d
Merge branch 'master' into close-playlists
2024-11-28 14:01:36 +01:00
Bartłomiej Dach
4314f9c0a9
Remove unused accessors
2024-11-28 09:22:08 +01:00
Salman Alshamrani
dfbccc2144
Knock some sense into the playlists results screen implementation
...
As we're moving towards using the `/playlist/<id>/scores/<id>` endpoint,
the existing playlists results screen classes needed some restructuring.
2024-11-27 01:20:43 -05:00
Salman Alshamrani
d150aeef2b
Use score-based endpoint everywhere
2024-11-26 01:01:59 -05:00
Dan Balasescu
82a63228de
Improve handling of multiplayer room status
2024-11-22 21:21:04 +09:00
Bartłomiej Dach
cfc38df889
Add close button to playlists footer
2024-11-22 09:57:56 +01:00
Bartłomiej Dach
512d2c6e3b
Merge branch 'master' into multiplayer-nrt
2024-11-22 08:09:42 +01:00
Dan Balasescu
6870c99eb2
Enable NRT for multiplayer and playlists
2024-11-21 20:32:09 +09:00
Dan Balasescu
8dbf750446
Fix inspection
2024-11-21 18:38:56 +09:00
Dan Balasescu
fe8e9d455a
Add failing test
2024-11-21 18:09:39 +09:00
Dan Balasescu
34c0f72dd6
Make Room.Playlist non-bindable
2024-11-15 15:51:01 +09:00
Dan Balasescu
b16edbbf52
Make Room.RecentParticipants non-bindable
2024-11-15 15:25:43 +09:00
Dan Balasescu
6c84e425f8
Make Room.MaxAttempts non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
0ceaafe731
Make Room.Duration & Room.StartDate & Room.EndDate non-bindable
2024-11-15 14:42:45 +09:00
Dan Balasescu
b8bae30b66
Make Room.ParticipantCount & Room.MaxParticipants non-bindable
2024-11-15 14:42:45 +09:00
Dan Balasescu
8694f7e1cc
Make Room.Host non-bindable
2024-11-15 14:42:17 +09:00
Dan Balasescu
6160df1586
Make Room.Name non-bindable
2024-11-15 14:29:15 +09:00
Dan Balasescu
99762da7b8
Make RoomID non-bindable
...
Most important changes are to `RoomSubScreen` and `PlaylistsRoomSubScreen`, because those are the only two cases that now bind to the event instead.
2024-11-13 16:28:54 +09:00
Salman Ahmed
f3dd1facf1
Add failing test case
2024-07-25 09:16:09 +03:00
Bartłomiej Dach
b29e535ca5
Add results screen for displaying arbitrary daily challenge scores
...
At this point its primary usage is the daily challenge event feed, but
the leaderboard will be using this too shortly.
Because the playlists results screen that exists in `master` is
hard-coupled to showing the *local user's* best result on a given
playlist by way of hard-coupling itself to the relevant API request,
allowing show of *arbitrary* score by ID requires a whole bunch of
subclassery as things stand. Oh well.
Class naming is... best effort, due to the above.
2024-07-04 13:45:24 +02:00
Bartłomiej Dach
0074bdc5a1
Change ResultsScreen constructor boolean params to init-only properties
2024-02-22 20:15:03 +01:00
Dan Balasescu
b44f77cee1
Update R# + fix inspections
2024-02-02 21:00:28 +09:00
Dean Herbert
fb24c66342
Mark ResultsScreen.Score as nullable
...
Is nullable in playlist results at very least.
2024-01-29 16:43:26 +09:00
Bartłomiej Dach
988794cf90
Improve test coverage for empty results
2024-01-15 18:49:41 +01:00
Bartłomiej Dach
8a839f64ed
Add failing test coverage for placeholder shown when it shouldn't be
2024-01-15 18:47:46 +01:00
wooster0
d5fdd0c0f9
make each test bind the handler only once, depending on its need
2024-01-09 21:44:05 +09:00
wooster0
ea37c70e0b
apply suggestion
2024-01-09 21:34:40 +09:00
wooster0
8ad697ff4c
apply some suggestions/corrections
2024-01-09 21:28:46 +09:00
wooster0
0c85fd496f
Don't leave scores screen empty if no scores are present yet
...
Addresses https://github.com/ppy/osu/discussions/23787
I originally wanted to set `allowShowingResults` to false if there are
no results but because this involves an API request to fetch the scores
that would mean all the scores would have to be fetched all at once so
that it knows whether to hide or show the "View results" button on a
beatmap.
Because that would slow things down and be very inefficient, this still
allows the user to view the scores screen but if there aren't any
scores, it shows a text, which I think is at least for now better than
nothing.
As for the testing of this, I wasn't sure how to not generate scores
only for one specific test so I opted into not using `SetUpSteps` and
doing it that way.
2023-12-31 22:42:32 +09:00
