Dean Herbert
17f6efc6fe
Fix missed cases of incorrect .Value usage
...
Changing from `Bindable` to `Nullable` comes with its issues...
2021-08-26 14:02:57 +09:00
Dean Herbert
e633b2716d
Fix regression in outro skip handling logic
2021-08-26 13:58:45 +09:00
Dean Herbert
e15198f077
Update missed tests
2021-08-26 13:47:10 +09:00
Dean Herbert
e32933eb54
Avoid Enum.GetValues in each score population pass
2021-08-26 13:37:53 +09:00
Dean Herbert
8cfb3d456b
Avoid expensive text spacing transforms for now
2021-08-26 13:15:27 +09:00
Dean Herbert
f4199958d9
Avoid unnecessary array/LINQ operations when replay frames have no action changes
2021-08-26 13:03:50 +09:00
Dean Herbert
69064c1938
Avoid unnecessary unbind operations when constructing FollowPointLifetimeEntry
2021-08-26 12:35:31 +09:00
Dean Herbert
6dcd9427ac
Remove bindable usage in PathControlPoint
...
This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.
I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.
2021-08-26 12:33:53 +09:00
Dean Herbert
b1a261c902
Avoid using scheduled delegates at all for skip overload input handling
2021-08-26 12:25:37 +09:00
Dean Herbert
956e3c554b
Avoid skip overlay attempting to show when it is already invalid
2021-08-26 12:25:37 +09:00
Salman Ahmed
5acaafa708
Make end accept one user ID rather than unnecessarily an array
2021-08-25 18:28:25 +03:00
Salman Ahmed
998abcbf31
Replace occurences of Enumerable.Range(PLAYER_1_ID, ...) with a method
2021-08-25 18:25:31 +03:00
Salman Ahmed
b4d6495f99
Fix editor skin providing container not providing playable beatmap
2021-08-25 17:52:36 +03:00
Salman Ahmed
f9b25a0159
Add test case for switching to each screen in editor test scenes
2021-08-25 17:52:35 +03:00
Dean Herbert
f02b6b3657
Merge pull request #14494 from frenzibyte/editor-quick-mode-switch-crash
...
Fix editor crashing when quickly switching between screens
2021-08-25 23:43:32 +09:00
Salman Ahmed
3ad0b529fb
Make EditorScreen inherit from VisibilityContainer rather than unsafe transforms
2021-08-25 17:14:52 +03:00
Salman Ahmed
c32168c61f
Add failing test case
2021-08-25 17:03:34 +03:00
Dean Herbert
7e6e2a7e29
Remove unused assignment
2021-08-25 17:39:06 +09:00
Salman Ahmed
13acdb5f19
Add test coverage
2021-08-25 11:31:02 +03:00
Salman Ahmed
196c74fce8
Gray out and remove player clock when users stop playing
2021-08-25 11:31:02 +03:00
Salman Ahmed
599145b46a
Stop clocks when removing them from sync manager
2021-08-25 11:31:02 +03:00
Dean Herbert
fd78d0440b
Update missed conditional
2021-08-25 17:00:32 +09:00
Dean Herbert
ccfff50c6f
Apply fixes in line with issues found during testing
...
I was trying to be too smart with caching, but if the `Play` method was
not called often enough it would have a recent reference. Unfortunately
this requires a separate query to `Entries`, but is also a special case
(no future hitobjects).
This also removes the time-based checks (result status alone should be
all we care about).
2021-08-25 16:56:44 +09:00
Dean Herbert
fc85ae0e34
Add test coverage
2021-08-25 16:56:44 +09:00
Dean Herbert
ef2b5e1c51
Tidy up variable names and unused resolved properties
2021-08-25 16:56:44 +09:00
Dean Herbert
8e0a04c4e5
Update taiko InputDrum to use new trigger logic
2021-08-25 16:56:44 +09:00
Dean Herbert
a1936b141b
Refactor base class to allow correct usage in taiko drum
2021-08-25 16:56:44 +09:00
Dean Herbert
681215e5b5
Rewrite object lookup to use previous entry regardless
...
This changes the fallback logic to always prefer the previous resolved
lifetime entry rather than fallback to the first entry ever. I think
this is more correct in all cases.
Also rewrites the inline comments to hopefully be easier to parse.
2021-08-25 16:56:44 +09:00
Dean Herbert
4a294d4de4
Optimise fallback logic to reduce lookups to bare minimum
2021-08-25 16:56:44 +09:00
Dean Herbert
6aa894e55e
Split out separate component
2021-08-25 16:56:44 +09:00
Dan Balasescu
d5fcc5f762
Merge pull request #14485 from peppy/fix-mania-hold-note-input-gobbling
...
Fix osu!mania hold notes eating input whenever on screen
2021-08-25 15:35:20 +09:00
Dan Balasescu
10cdb1c963
Merge pull request #14484 from peppy/user-events-in-participant-list
...
Add ability to handle user join/leave/kick events in `MultiplayerComposite`s
2021-08-25 15:14:28 +09:00
Dan Balasescu
351015357c
Merge branch 'master' into user-events-in-participant-list
2021-08-25 14:39:26 +09:00
Dean Herbert
6a1cf12763
Merge pull request #14480 from bdach/countdown-beatmap-info
...
Add countdown settings to beatmap info
2021-08-25 14:38:34 +09:00
Dean Herbert
e1ab3434ed
Add ability to handle user join/leave/kick events in MultiplayerComposites
2021-08-25 14:37:14 +09:00
Salman Ahmed
ca527262e3
Merge branch 'master' into countdown-beatmap-info
2021-08-25 08:30:27 +03:00
Salman Ahmed
84637b59ef
Define DifficultyBindableWithCurrent and use in SliderControl
2021-08-25 07:40:41 +03:00
Dean Herbert
414457ba57
Add basic xmldoc explaining CountdownOffset
2021-08-25 13:24:52 +09:00
Dan Balasescu
6fcbf81995
Merge pull request #14284 from LeNitrous/activity-on-multiplayer-screens
...
Update Discord user status for multiplayer/playlists
2021-08-25 11:22:26 +09:00
Bartłomiej Dach
acc27fc79c
Add test case for countdown in encode-decode stability test
2021-08-24 22:04:56 +02:00
Bartłomiej Dach
a6c2cbd2e5
Add countdown settings to beatmap info model
2021-08-24 21:55:10 +02:00
Bartłomiej Dach
e503182a8d
Merge branch 'master' into activity-on-multiplayer-screens
2021-08-24 18:50:55 +02:00
Dean Herbert
6252b8aa42
Fix hold notes handling all input ever
2021-08-24 19:08:04 +09:00
Dean Herbert
4289773371
Merge pull request #14476 from smoogipoo/fix-hud-test-failure-2
...
Fix gameplay HUD load not always completing if initially hidden
2021-08-24 17:18:40 +09:00
Dean Herbert
568a8ee97e
Merge branch 'master' into fix-hud-test-failure-2
2021-08-24 16:54:48 +09:00
Dean Herbert
3f0f820653
Add comment explaining reasoning for override
2021-08-24 16:54:19 +09:00
Dean Herbert
08f757a584
Merge pull request #14474 from smoogipoo/fix-multi-crash
...
Fix crash when entering multiplayer gameplay
2021-08-24 16:20:18 +09:00
Dan Balasescu
6a916a264f
Merge pull request #14441 from Henry-YSLin/mod-incompatibility-ui
...
Show mods that are incompatible with the current selection
2021-08-24 16:16:35 +09:00
Dan Balasescu
ea98ce1b39
Merge pull request #14465 from peppy/improve-stable-skin-import
...
Improve skin stable import behaviour to better handle similar skins
2021-08-24 16:08:15 +09:00
smoogipoo
9f17c38e36
Fix hud overlay components being blocked from load
2021-08-24 15:18:27 +09:00
