295 Commits

Author	SHA1	Message	Date
smoogipoo	f992b59b4f	Fix DrawableHoldNote retaining hit states through applications	2021-05-12 17:07:42 +09:00
smoogipoo	1af3bbf400	Fix base.OnLoadComplete() not being called	2021-05-12 17:06:44 +09:00
smoogipoo	4e7551d50e	Fix crashes	2021-05-12 16:40:46 +09:00
smoogipoo	5692cecaa4	Initial implementation of DHO pooling	2021-05-12 16:35:05 +09:00
smoogipoo	713c169332	Fix mania crashing on playing samples after skin change	2021-05-11 16:21:21 +09:00
Dean Herbert	db815f7930	Tidy up implementation in DrawableNote	2021-05-01 20:39:10 +09:00
Justus Franklin Tumacder	fdf8c12947	Replace BeatDivisorFinder with GetClosestBeatDivisor	2021-05-01 11:57:47 +08:00
Justus Franklin Tumacder	ecb053b0de	Merge branch 'master' of https://github.com/ppy/osu into justusft/mania-color-snap	2021-05-01 11:20:28 +08:00
Justus Franklin Tumacder	c4d28110d6	Add visual tests for timing based note coloring	2021-04-27 19:02:57 +08:00
Naxess	a3570e18dd	Add concurrent objects check ... Here we use `IHasColumn` to support rulesets with columns, and so I moved that interface out into `osu.Game` from `osu.Game.Rulesets.Mania`. We also use the same threshold as the unsnap check to ensure that no problems slip through. Specifically where an object is simultaneously not concurrent and not unsnapped but still on the same tick.	2021-04-26 20:17:18 +02:00
Justus Franklin Tumacder	559d403abe	Rename ColourCodedNotes to TimingBasedNoteColouring	2021-04-26 19:05:12 +08:00
Justus Franklin Tumacder	58ebec4803	Move BindValueChanged hooks to LoadComplete()	2021-04-26 19:00:40 +08:00
Bartłomiej Dach	e14255f395	Rename {Snap -> BeatDivisor}Finder	2021-04-25 17:44:26 +02:00
Bartłomiej Dach	afb67726f0	Reduce casting	2021-04-25 17:41:23 +02:00
Bartłomiej Dach	f9e228d6bf	Use null-permitting BDL to reduce number of fields	2021-04-25 17:40:23 +02:00
Justus Franklin Tumacder	211bff6a8f	Fix cake errors	2021-04-25 09:21:25 +08:00
Justus Franklin Tumacder	8b9d2a6cff	Remove caching for ConfigColourCodedNotes	2021-04-25 08:32:49 +08:00
Justus Franklin Tumacder	d3db19c3ce	Simplify DrawableNote	2021-04-25 08:11:44 +08:00
Justus Franklin Tumacder	e0ca44c908	Move SnapFinder from mania ruleset to osu.Game	2021-04-25 07:35:53 +08:00
Justus Franklin Tumacder	bedabc1ddf	Fix cake errors	2021-04-24 22:12:07 +08:00
Justus Franklin Tumacder	8b01082cbb	Fix visual tests missing dependency for ColourCodedNotes	2021-04-24 21:28:48 +08:00
Justus Franklin Tumacder	3103fd8343	Move snapping logic into SnapFinder	2021-04-24 21:28:35 +08:00
Justus Franklin Tumacder	a8b401522b	Remove ManiaColourCode in favor for boolean	2021-04-24 20:39:22 +08:00
Justus Franklin Tumacder	d6d81fb8e5	Move color snap logic from Note to DrawableNote	2021-04-24 19:53:21 +08:00
Justus Franklin Tumacder	f9905ebe68	Remove beatmap argument in Note	2021-04-24 19:37:10 +08:00
Justus Franklin Tumacder	7e3a611f95	Add snap color option for osu!mania	2021-04-24 16:23:52 +08:00
smoogipoo	4148d473e3	Fix hold note crashing with 0 length	2021-04-22 19:51:33 +09:00
smoogipoo	43e48406ca	Miss all ticks when hold note is hit	2021-03-31 12:21:14 +09:00
Bartłomiej Dach	9a330c4c56	Fix mania hold note heads hiding when frozen ... This was an insidious regression from a3dc1d5. Prior to that commit, `DrawableHoldNoteHead` had `UpdateStateTransforms()` overridden, to set the hold note head's lifetime. When that method was split into `UpdateInitialStateTransforms()` and `UpdateHitStateTransforms()`, the lifetime set was moved to the former. Unfortunately, that override served two purposes: both to set the lifetime, and to suppress hit animations which would normally be added by the base `DrawableManiaHitObject`. That fact being missed led to `UpdateHitStateTransforms()` hiding the hold note head immediately on hit and with a slight delay on miss. To resolve, explicitly override `UpdateHitStateTransforms()` and suppress the base call, with an explanatory comment.	2021-03-21 18:46:41 +01:00
ekrctb	e3c035fe9c	Adjust namespace	2020-12-07 12:32:52 +09:00
ekrctb	40da799103	Move piece files of Mania ruleset	2020-12-07 12:31:56 +09:00
smoogipoo	0414e5c550	Add MaximumJudgementOffset to DrawableHitObject, use in more places	2020-11-26 01:12:42 +09:00
Dean Herbert	49b8331ccd	Merge pull request #10877 from smoogipoo/fix-mania-judgement-displays ... Fix hold note judgements displaying incorrectly	2020-11-18 19:00:14 +09:00
smoogipoo	77942af3a6	Fix hold note judgements displaying incorrectly	2020-11-17 13:37:58 +09:00
Bartłomiej Dach	b62bf5798d	Store time of hold note break	2020-11-13 21:14:34 +01:00
Bartłomiej Dach	7a89e58483	Disable pressed/released action logic when rewinding	2020-11-13 20:49:06 +01:00
Dean Herbert	a3dc1d5730	Update existing implementations	2020-11-04 17:14:23 +09:00
Bartłomiej Dach	1f0620ffd4	Replace assignment references to HitResult.Miss with Judgement.MinResult	2020-10-02 23:31:24 +02:00
Bartłomiej Dach	2b1ef16f89	Replace comparison references to HitResult.Miss with IsHit	2020-10-02 23:31:24 +02:00
smoogipoo	e789e06c86	Don't display hold note tick judgements	2020-09-29 16:33:38 +09:00
smoogipoo	b1877b649b	Use new hit results in mania	2020-09-29 16:33:38 +09:00
Bartłomiej Dach	d419fe4dbf	Remove note shaking mention that doesn't apply in mania	2020-08-31 12:03:05 +02:00
smoogipoo	acbeb5406f	Add/improve xmldoc	2020-08-31 13:33:41 +09:00
smoogipoo	aa151e4cd7	Merge branch 'master' into mania-notelock	2020-08-31 13:31:41 +09:00
smoogipoo	deb172bb6c	Implement basic mania hit order policy	2020-08-27 20:24:21 +09:00
smoogipoo	1db836e9e0	Merge branch 'master' into hold-note-lighting	2020-08-26 20:22:07 +09:00
smoogipoo	9372c6eef6	Implement hold note lighting	2020-08-26 20:21:56 +09:00
smoogipoo	b3338347b7	Remove fade on successful hits	2020-08-21 23:56:27 +09:00
smoogipoo	8632c3adf0	Fix hold notes bouncing with SV changes	2020-08-21 23:11:15 +09:00
Dan Balasescu	42ee9b75df	Apply suggestions from code review ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-08-21 19:38:59 +09:00