Bartłomiej Dach
508f1f488c
Merge branch 'master' into limit-barline-generation-sanity
2022-11-23 17:12:36 +01:00
Bartłomiej Dach
06449b62f1
Add test coverage for crash scenario
2022-11-23 16:11:57 +01:00
Andrei Zavatski
2204af04e4
Improve test scene to better show colour gradient
2022-11-23 16:12:13 +03:00
Dean Herbert
8d0fe61aff
Merge pull request #21224 from honguyenminh/VerticalStackedCatchTouchInput
...
Vertically stacked osu!catch touch input
2022-11-23 18:55:20 +09:00
Dean Herbert
5467097387
Fix adjacent day separators potentially being left behind after pending message resolution
2022-11-23 18:49:51 +09:00
Dean Herbert
f9d952220f
Fix barlines being misaligned if generation start time is clamped
2022-11-23 18:12:03 +09:00
Dean Herbert
e69ed67335
Add test of barline generation with negative start time control point
2022-11-23 18:11:52 +09:00
Dean Herbert
a6bba1967e
Update serialisation test to match new comopnent naming
2022-11-23 17:06:22 +09:00
Dean Herbert
774f70e380
Simplify class structure
2022-11-23 16:56:40 +09:00
Dean Herbert
0749a7bb07
Simplify attribute assignment
2022-11-23 16:53:36 +09:00
Dean Herbert
0f034606fd
Use LocalisableDescription from BeatmapOnlineStatus enum instead of locally defined
2022-11-23 16:49:51 +09:00
Dean Herbert
a8af83e62a
Move label initialisation out of ctor
2022-11-23 16:49:39 +09:00
Dean Herbert
27473262af
Rename attributes in enum to match better with user expectations
2022-11-23 16:45:46 +09:00
Dean Herbert
b89689a34a
Rename class and reword settings text/tooltips to avoid clashing with other naming
2022-11-23 16:31:50 +09:00
Dean Herbert
a9192c32ea
Merge branch 'master' into beatmap-info
2022-11-23 16:10:12 +09:00
Dean Herbert
9b9b8a5977
Add ability to seek between control points in editor using down/up arrows
...
Matches stable. Addresses #21376 .
2022-11-23 15:59:32 +09:00
Dean Herbert
d146f86511
Fix crash when hitting 'T' to tap timing while no timing point is selected
2022-11-23 15:39:56 +09:00
Dean Herbert
23f91ec717
Merge pull request #21379 from Joppe27/taiko-animations-recovered
...
Add taiko hit overlay animations
2022-11-23 15:09:44 +09:00
Dean Herbert
172e798847
Merge pull request #21228 from Terochi/recent-messages-implementation
...
Add ability to view chat send history in input box
2022-11-23 14:58:42 +09:00
Bartłomiej Dach
6e9d163c72
Specify canBeNull: true in [Resolved] for now
2022-11-22 20:56:07 +01:00
Bartłomiej Dach
675e32df57
Add test steps for testing combo reset to 0
2022-11-22 20:43:22 +01:00
Bartłomiej Dach
ce7af0df63
Always use current timing point for circle piece animation
...
Using `LifetimeStart` seemed arbitrary and wrong not only in a
compatibility-with-stable sense, but also in a general sanity sense (why
would each object potentially be using a different timing point to
animate?)
2022-11-22 20:39:22 +01:00
Bartłomiej Dach
38f2a27f53
Split animation logic to its own method
...
Also add a guard, to bypass all of it if the foreground layer is not in
fact animatable.
2022-11-22 20:39:05 +01:00
Bartłomiej Dach
8ac0a759f0
Set combo immediately rather than via repeat steps
...
Doesn't help anyone to be waiting literal minutes for combo to hit 50 or
150 in a test scene supposed to quickly visually demonstrate a
component. Doesn't help for CI runtime, either.
2022-11-22 20:30:27 +01:00
Bartłomiej Dach
5a5b0ed4ef
Restructure tests not to call each other
...
Bit weird to have tests call other tests. Private helper methods is
better, if unavoidable.
2022-11-22 20:28:41 +01:00
Bartłomiej Dach
8dbc38e17a
Remove unused setter
2022-11-22 20:14:22 +01:00
Bartłomiej Dach
39934bccd6
Add back removed test coverage
2022-11-22 19:47:41 +01:00
Bartłomiej Dach
0d2d77f276
Merge pull request #21377 from peppy/song-select-alt-scroll-only
...
Change song select to only allow volume adjusting if alt is held while scrolling
2022-11-22 19:00:04 +01:00
Bartłomiej Dach
012e69fe4f
Merge branch 'master' into song-select-alt-scroll-only
2022-11-22 17:29:58 +01:00
Bartłomiej Dach
54c2becda7
Merge pull request #21372 from peppy/mania-hold-note-end-nearby-tests
...
Add test coverage of input near end of hold note with nearby subsequent note
2022-11-22 17:29:44 +01:00
Joppe27
db34fa99b1
Add tests and clean up inefficient code
2022-11-22 17:22:34 +01:00
Joppe27
5343f6922c
Add legacy circle piece animations based on combo
2022-11-22 17:22:00 +01:00
Bartłomiej Dach
76bb529cfa
Add test for local echo adding day separator
2022-11-22 16:46:21 +01:00
Bartłomiej Dach
eb311f3fe5
Merge branch 'master' into mania-hold-note-end-nearby-tests
2022-11-22 16:41:25 +01:00
Dean Herbert
de163b2bb5
Change song select to only allow volume adjusting if alt is held while scrolling
2022-11-22 19:48:55 +09:00
Dan Balasescu
2e4dc7c467
Merge pull request #21371 from peppy/fix-mania-hold-note-stuck
...
Fix osu!mania hold notes occasionally getting in a visually incorrect hit state
2022-11-22 17:14:39 +09:00
Dean Herbert
c1b193149c
Add test coverage of input near end of hold note with nearby subsequent note
...
Covers the scenarios mentioned in #21371 .
Turns out this seems mostly okay already, so there are no fixes applied here.
2022-11-22 17:09:14 +09:00
Dean Herbert
57723107dd
Fix osu!mania hold notes occasionally getting in a visually incorrect hit state
...
To correctly end a mania hold note, `endHold()` needs to be called. This
was not happening in a very specific scenario:
- The hold note's head is not hit
- The user pressed the column's key within the hold note's tail's window,
but does so to hit the next object (a note in proximity to the hold note's tail).
- The hit policy forces a miss on the hold note, but `endHold()` is not called
- `CheckForResult` is not called after this point due to `Judged` being `true`.
Closes #21311 .
2022-11-22 16:15:34 +09:00
Dean Herbert
1632df1f4d
Update DifficultyBindable to match new bindable spec
2022-11-22 14:51:19 +09:00
Dan Balasescu
6b75f529c7
Merge pull request #21366 from bdach/broken-rank-graph-test
...
Fix broken rank graph test
2022-11-22 14:35:14 +09:00
Dan Balasescu
985781bc3b
Merge pull request #21356 from peppy/standardise-broken-storyboard-paths
...
Add support for storyboards with incorrect path specifications (`\\` instead of `\`)
2022-11-22 14:33:51 +09:00
Bartłomiej Dach
cd43e83494
Merge pull request #21344 from peppy/tablet-settings-test-scene
...
Fix `TestSceneTabletSettings` falling off the bottom of the screen
2022-11-21 21:46:15 +01:00
Bartłomiej Dach
41039340cf
Fix rank graphs not showing in test due to unset IsRanked
2022-11-21 21:00:06 +01:00
Bartłomiej Dach
1777a60136
Add failing assertions
2022-11-21 20:58:52 +01:00
Bartłomiej Dach
735cac3104
Rewrite rank graph test to use more modern style
2022-11-21 20:56:38 +01:00
Bartłomiej Dach
f36ccab84e
Merge branch 'master' into tablet-settings-test-scene
2022-11-21 20:42:04 +01:00
Bartłomiej Dach
4490504104
Merge pull request #21346 from peppy/higher-aspect-ratio-max
...
Increase maximum aspect ratio for tablet settings to 23:9 / 2.55
2022-11-21 20:41:47 +01:00
Bartłomiej Dach
8dbe31a172
Merge branch 'master' into higher-aspect-ratio-max
2022-11-21 19:51:39 +01:00
Bartłomiej Dach
f75353d8f4
Merge pull request #21350 from peppy/hide-no-spin-bonus
...
Hide spinner ticks / bonus from results screen when not applicable to score
2022-11-21 19:50:56 +01:00
Bartłomiej Dach
ff5cb116f0
Fix weird scroll container sizing
2022-11-21 19:27:06 +01:00
