Jamie Taylor
5cc670cd19
Prevent ApplyTransformsAt from propogating to SliderBall children
2019-03-14 19:17:28 +09:00
Dan Balasescu
b131ca12f1
Merge pull request #4462 from peppy/increase-osu-file-validation
...
Increase validation performed on .osu files to avoid hard crashes
2019-03-14 19:09:28 +09:00
Dan Balasescu
2c80f73a88
Merge branch 'master' into increase-osu-file-validation
2019-03-14 18:47:32 +09:00
Dan Balasescu
719056c485
Merge pull request #4458 from peppy/mod-ramp-hotfix
...
Fix "wind" mods adjusting rate twice
2019-03-14 15:23:22 +09:00
smoogipoo
2815c3b07c
Remove unused variable
2019-03-14 15:12:26 +09:00
Dean Herbert
0042cc5337
Merge branch 'master' into mod-ramp-hotfix
2019-03-14 13:02:29 +09:00
Dean Herbert
7d56ce63d3
Fix test case failures
2019-03-14 12:31:17 +09:00
Dean Herbert
85c518f146
Change logic to better handle external adjustments
2019-03-14 12:29:16 +09:00
Dean Herbert
108dcd0a92
Update framework
2019-03-13 21:58:50 +09:00
Dean Herbert
c40e24739b
Fix weird application logic
2019-03-13 21:37:33 +09:00
Dan Balasescu
5d23a966d7
Fix incorrect application logic for rate fallback
...
Co-Authored-By: peppy <pe@ppy.sh>
2019-03-13 20:55:33 +09:00
Dean Herbert
0ce8bcffe1
Merge pull request #4461 from nyquillerium/mania-judgemetns
...
Fix mania miss judgement animations disappearing too quickly
2019-03-13 18:44:39 +09:00
Dean Herbert
3d4a80957f
Improve comment
2019-03-13 18:27:54 +09:00
Dean Herbert
1617e2a729
Merge branch 'master' into mania-judgemetns
2019-03-13 18:17:42 +09:00
Dean Herbert
8f00f2290a
Log issues
2019-03-13 14:56:41 +09:00
Dean Herbert
241e336c21
Fix break parsing
2019-03-13 14:22:16 +09:00
Dean Herbert
f4c505709a
Use parsing methods in more places
...
Limiting scope to beatmap decoding for this pass. Can expand to skin/storyboard in the future.
2019-03-13 13:56:31 +09:00
Dean Herbert
f8b5cf8c8e
Add extra clamping of endTime to startTime
2019-03-13 13:46:41 +09:00
Dan Balasescu
a35d9ccc09
Apply clamping suggestion
...
Co-Authored-By: peppy <pe@ppy.sh>
2019-03-13 12:35:05 +09:00
Dean Herbert
0241148385
Add extensive tests
2019-03-13 11:30:38 +09:00
Dean Herbert
93b774104a
Fix NaN handling
2019-03-13 11:30:33 +09:00
Dean Herbert
73d9aef5bd
Fix filename
2019-03-12 20:38:04 +09:00
Dean Herbert
cc09ecbfcf
Increase validation performed on .osu files to avoid hard crashes
2019-03-12 20:31:15 +09:00
David Zhao
527b77b07d
Make all inheritors of drawablejudgement use new method
2019-03-12 19:52:44 +09:00
David Zhao
7eb253b687
Fix incorrect scale duration
2019-03-12 19:44:53 +09:00
David Zhao
3b3b1e51ee
Move hit animation logic into virtual method
2019-03-12 19:41:33 +09:00
David Zhao
9850122245
Fix incorrect delay
2019-03-12 19:24:46 +09:00
David Zhao
12f334035f
Create properties for use in DrawableManiaJudgement
2019-03-12 19:23:24 +09:00
Dean Herbert
a10cd2288d
Improve ModRamp's handling of external rate changes
2019-03-12 18:15:18 +09:00
Dean Herbert
6832e384a9
Simplify DT/HT/NC/DC
2019-03-12 18:14:41 +09:00
Dean Herbert
c1a356161f
Allow use rate adjust to fallback to clock rate adjust
2019-03-12 18:14:01 +09:00
Dan Balasescu
13f84e8d50
Merge pull request #4445 from Joehuu/direct-stats-offset
...
Fix direct panel stats being misaligned by one pixel
2019-03-12 17:22:30 +09:00
Dan Balasescu
e6e0cf1957
Merge branch 'master' into direct-stats-offset
2019-03-12 16:17:36 +09:00
Dan Balasescu
47e28e8ad6
Merge pull request #4453 from peppy/ensure-import-sanity
...
Ensure import continues if an existing item's online IDs are in a bad state
2019-03-12 14:38:31 +09:00
Dan Balasescu
05358fa458
Merge branch 'master' into ensure-import-sanity
2019-03-12 14:24:07 +09:00
Dan Balasescu
716df570bb
Merge pull request #4454 from peppy/4439-alternative
...
Refactor UpdateableBeatmapBackground lookup logic for clarity
2019-03-12 13:17:03 +09:00
Dan Balasescu
c92ecc4808
Merge branch 'master' into 4439-alternative
2019-03-12 13:07:06 +09:00
Dan Balasescu
8897739a53
Merge pull request #4456 from peppy/fix-direct-queries
...
Fix osu!direct firing excess queries during initial search characters
2019-03-12 12:54:31 +09:00
Dan Balasescu
448e3da429
Merge branch 'master' into fix-direct-queries
2019-03-12 12:47:33 +09:00
Dan Balasescu
fc7cb14388
Merge pull request #4459 from Joehuu/fix-chan-sel-dimming-forever
...
Fix channel selection overlay leaving background dimmed when popped out
2019-03-12 12:32:50 +09:00
Joehu
ad3b956cec
Fix channel selection overlay dimming bg forever when popped out
2019-03-11 20:10:59 -07:00
Dan Balasescu
61ba39d89f
Merge branch 'master' into fix-direct-queries
2019-03-12 12:02:17 +09:00
Dan Balasescu
246b214fa6
Merge pull request #4457 from peppy/fix-hold-to-quit
...
Fix HoldForMenuButton getting stuck in a confirming state
2019-03-12 11:58:43 +09:00
Dean Herbert
cdeaa80fea
Call ResetSpeedAdjustments before adjusting clock
2019-03-12 11:35:25 +09:00
Dean Herbert
13b3036ec6
Fix "wind" mods adjusting rate twice
...
This is a hotfix for incorrect framework behaviour.
Closes #4442
2019-03-12 02:45:45 +09:00
Dean Herbert
1be4c7b813
Fix excess newline
2019-03-12 02:23:23 +09:00
Dean Herbert
38e75421ab
Fix HoldForMenuButton getting stuck in a confirming state
...
Closes #4446 .
2019-03-12 02:21:34 +09:00
Dean Herbert
941a72d69a
Fix osu!direct firing excess queries during initial search characters
...
Due to faulty debounce fire logic, a web request would always fire with a single character search, followed by the real search. This caused unwanted delays and display weirdness.
2019-03-12 01:49:47 +09:00
Dean Herbert
59897bbeb5
Refactor UpdateableBeatmapBackground lookup logic for clarity
...
Closes #4401 . Alternative to #4439 .
2019-03-11 19:00:39 +09:00
Dean Herbert
d0ae75af6e
Add tests and fix scenario where all matching are contained by duplicate candidate
2019-03-11 18:13:33 +09:00