Joseph Madamba
0b41dbf579
Remove code bloat from ClickableAvatar
2023-02-09 12:59:26 -08:00
sw1tchbl4d3
2e2ab4081b
Make LargeBonus
a valid HitResult
in taiko
2023-02-09 21:22:34 +01:00
Ruki
2c1154afc6
refactor: improve wording
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2023-02-09 17:15:30 +00:00
Dean Herbert
ab81397119
Merge pull request #22553 from OpenSauce04/taiko-stable-snapping
...
Snap Taiko hit objects to match Stable
2023-02-09 23:28:21 +09:00
Dean Herbert
34d1890f1c
Change snapping to only apply to classic mod
2023-02-09 18:22:14 +09:00
Dean Herbert
28897b6e18
Merge pull request #22566 from Joehuu/profile-tournament-banner
...
Display tournament banner on user profile
2023-02-09 16:06:36 +09:00
Dean Herbert
92eb6b6717
Simplify TestSceneAccuracyCircle
test specifications
2023-02-09 15:42:03 +09:00
Dean Herbert
cf009432cc
Centralise accuracy cutoff constants and add lookup helper methods
2023-02-09 15:41:58 +09:00
Dean Herbert
240a5f9c85
Merge pull request #22568 from Joehuu/address-init-only-todo
...
Address todos relating to init-only usages
2023-02-09 12:17:54 +09:00
Joseph Madamba
f1decb667e
Address todos relating to init-only usages
2023-02-08 17:51:28 -08:00
Walavouchey
57312279f0
adjust RankNotch
gap size to match original value
2023-02-09 02:20:05 +01:00
Joseph Madamba
3b5d573db1
Display tournament banner on user profile
2023-02-08 17:16:09 -08:00
Walavouchey
fd93bd3f50
move rank accuracy requirements to class-local constants
2023-02-09 00:46:24 +01:00
Walavouchey
9544a1d26d
use values closer to the extremities for test cases
2023-02-09 00:02:32 +01:00
Walavouchey
ee40444fd3
use Precision.AlmostEquals
for bounds check
2023-02-08 23:59:19 +01:00
Bartłomiej Dach
2873905cc6
Merge pull request #22506 from peppy/skin-editor-undo-support
...
Add very basic skin editor undo / redo support
2023-02-08 19:19:25 +01:00
Bartłomiej Dach
0a5c4e04bf
Merge branch 'master' into skin-editor-undo-support
2023-02-08 18:43:59 +01:00
Walavouchey
0531c010eb
display RankBadge
s on on their sector centres
...
the D `RankBadge` does this anyway. the A and S badges are slightly off
centre to prevent overlap with the SS badge
2023-02-08 14:01:40 +01:00
Walavouchey
6ace6bfee1
ensure AccuracyCircle
doesn't land in gaps created by RankNotch
es
2023-02-08 13:20:53 +01:00
OpenSauce
df1355ea4b
Taiko hit objects now snap to hit target
2023-02-08 10:59:08 +00:00
Dean Herbert
21fa29f47f
Merge pull request #22545 from Joehuu/fix-user-profile-context-menu
...
Fix beatmap cards not showing context menu on user profile
2023-02-08 17:07:28 +09:00
Joseph Madamba
0156ff732f
Fix beatmap cards not showing context menu on user profile
2023-02-07 22:56:09 -08:00
Dean Herbert
b0131db1dc
Update test assertions in line with new state saving logic
2023-02-08 15:55:17 +09:00
Dean Herbert
17ca26ebee
Remove unnecessary null check on targetScreen
2023-02-08 15:44:24 +09:00
Dean Herbert
3a3c2e78a1
Merge branch 'master' into skin-editor-undo-support
2023-02-08 15:41:58 +09:00
Dean Herbert
78eae171ed
Merge pull request #22507 from Joehuu/fix-comment-padding
...
Fix comments having too much padding at the bottom
2023-02-08 15:01:05 +09:00
Dean Herbert
b6809e156b
Merge pull request #22432 from mk56-spn/sheared_slider_implementation_clean_ii
...
Implement a sheared slider for the updated design
2023-02-08 15:01:00 +09:00
Dean Herbert
5cd111e6f1
Fix ordering of methods in OsuSliderBar
2023-02-08 14:01:50 +09:00
Dean Herbert
cec1f77e6c
Fix glow flash occurring after releasing mouse and adjust transition slightly
2023-02-08 13:59:09 +09:00
Dean Herbert
ee65c65893
Attempt to fix channel join / leave loop
...
I don't have a solid way to repro the issue, but this should hopefully
help in resolving it. Either way, I think this change brings more
correct behaviour (if a websocket message comes through that we have
left the channel, I don't believe we should be sending a request to
leave that channel again).
2023-02-08 11:31:30 +09:00
Joseph Madamba
277f71d36a
Expire reply editor instead of clearing container
2023-02-07 15:15:51 -08:00
Dean Herbert
0320ba770f
Handle component changes via ISkinnableTarget.Components
rather than inside SkinEditor
directly
...
Seems saner? Maybe?
2023-02-07 16:23:25 +09:00
Dean Herbert
e162fd56da
Change the way initial state saving works in EditorChangeHandler
to be closer to first change
2023-02-07 16:22:51 +09:00
Dean Herbert
dad348111d
Fix holding a selection while changing screens causing a crash
2023-02-07 16:07:33 +09:00
Dean Herbert
71eef238c4
Make OnStateChange
non-implemented rather than wrong
2023-02-07 16:04:31 +09:00
tsrk
da10166628
quality: convert getter property to method so that sensible information can be hidden via an argument
2023-02-06 21:30:55 +00:00
tsrk
1baaae35a9
quality: Simplify string
2023-02-06 20:07:16 +00:00
Bartłomiej Dach
12f6d461b9
Merge pull request #22532 from peppy/fix-long-storyboard-outro
...
Fix storyboard outro time potentially running too long
2023-02-06 20:30:36 +01:00
Bartłomiej Dach
179db09075
Merge pull request #22531 from peppy/apply-future-rider-inspection
...
Apply single inspection from newer inspectcode versions
2023-02-06 20:05:49 +01:00
Bartłomiej Dach
3ee771cbef
Merge pull request #22535 from peppy/forcefully-stop-pause-sample
...
Ensure pause sample loop is stopped on exiting player
2023-02-06 19:51:51 +01:00
tsrk
bc89f8dc5b
feat: add name and rulset verb display support
2023-02-06 12:44:00 +00:00
Dean Herbert
aaf3ad805c
Fix potential nullref in tests
2023-02-06 19:31:45 +09:00
Dean Herbert
b83c8443ea
Ensure pause sample loop is stopped on exiting player
2023-02-06 18:24:31 +09:00
Dean Herbert
c691a0d3af
Merge branch 'master' into sheared_slider_implementation_clean_ii
2023-02-06 17:49:33 +09:00
Dean Herbert
c078d3a344
Merge pull request #22357 from EXtremeExploit/groups-probationary-badges
...
Make probationary groups a bit transparent
2023-02-06 17:43:57 +09:00
Dean Herbert
67ec3199c5
Merge pull request #22515 from Susko3/use-ipc-archive-importer
...
Allow importing beatmaps via file associations on desktop platforms
2023-02-06 17:22:56 +09:00
Dean Herbert
ddcc02fdfe
Merge pull request #22505 from Joehuu/fix-hover-click-sounds
...
Fix some clickable elements having no hover and click sounds
2023-02-06 16:52:19 +09:00
Dean Herbert
eabd1a0cc1
Remove unused Duration
property to avoid any misunderstandings
2023-02-06 16:42:39 +09:00
Dean Herbert
679ec986d5
Fix storyboard outro time potentially running too long
2023-02-06 16:39:44 +09:00
Dean Herbert
4c868372a2
Correctly handle anchor/origin changes as undo states
2023-02-06 15:05:05 +09:00