Dan Balasescu
34c0f72dd6
Make Room.Playlist non-bindable
2024-11-15 15:51:01 +09:00
Dan Balasescu
b16edbbf52
Make Room.RecentParticipants non-bindable
2024-11-15 15:25:43 +09:00
Dan Balasescu
c4f8fd1832
Make Room.DifficultyRange non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
6c84e425f8
Make Room.MaxAttempts non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
0ceaafe731
Make Room.Duration & Room.StartDate & Room.EndDate non-bindable
2024-11-15 14:42:45 +09:00
Dan Balasescu
b8bae30b66
Make Room.ParticipantCount & Room.MaxParticipants non-bindable
2024-11-15 14:42:45 +09:00
Dan Balasescu
ec5be6dbc3
Make Room.Password & Room.HasPassword non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
198681e644
Make Room.QueueMode non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
5d4838a08b
Make Room.Status non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
81e4cb348f
Make Room.Type non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
bde7b8e610
Make Room.Category non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
8694f7e1cc
Make Room.Host non-bindable
2024-11-15 14:42:17 +09:00
Dan Balasescu
6160df1586
Make Room.Name non-bindable
2024-11-15 14:29:15 +09:00
Dan Balasescu
58aba5439a
Merge pull request #30622 from bdach/not-enough-timed-events
...
Do not show timing distribution graph in offset control if there's not enough timed hits
2024-11-15 11:59:20 +09:00
Dean Herbert
3262b6d989
Refactor to avoid dual-boolean mess
2024-11-14 22:10:45 +09:00
Bartłomiej Dach
7ee9802923
Merge pull request #30616 from peppy/collection-management-revamp
...
Fix collection management dialog refreshing full display when any change occurs
2024-11-14 13:21:09 +01:00
Bartłomiej Dach
bbe2c87837
Add failing test case
2024-11-14 13:07:11 +01:00
Bartłomiej Dach
d08c8ae482
Merge pull request #30620 from peppy/fix-offset-adjust-crash
...
Fix crash when resetting offset after a play with no hit events
2024-11-14 12:43:47 +01:00
Bartłomiej Dach
1355fa636d
Merge pull request #30603 from peppy/quick-restart-faster-better
...
Make quick restart even faster
2024-11-14 12:30:13 +01:00
Dean Herbert
7f8eebc510
Merge pull request #30578 from smoogipoo/beatmap-legacy-object-type
...
Simplify convertible hitobject parsing and add `IHasLegacyHitObjectType`
2024-11-14 16:16:44 +09:00
Dean Herbert
1b6952c42a
Add failing test showing crash when adjusting offset with no HitEvents
2024-11-14 16:03:00 +09:00
Dean Herbert
fea6a54432
Fix more tests reading in wrong order
2024-11-14 14:46:58 +09:00
Dean Herbert
d66daf15a5
Fix tests clicking wrong delete buttons due to internal drawable ordering
2024-11-14 14:39:06 +09:00
Dean Herbert
7670a81181
Merge branch 'master' into bat-max-performance
2024-11-14 13:35:29 +09:00
Dean Herbert
f597568476
Fix test failure due to restart happening too fast
2024-11-14 01:23:21 +09:00
Dean Herbert
68945daa40
Add confirmation when pressing 'q' to quit at the main menu
...
Kinda a weird key. I feel like this deserves a confirmation step unlike
mouse clicking the exit button.
Addresses https://github.com/ppy/osu/discussions/30471 .
2024-11-13 19:27:20 +09:00
Dean Herbert
b82f420b52
Merge pull request #30433 from stanriders/fix-userpanel-overflow
...
Fix `UserRankPanel` rank overflowing on 6+ digits
2024-11-13 19:19:30 +09:00
Dan Balasescu
a2a930aa35
Fix CI issues
2024-11-13 17:15:50 +09:00
Dan Balasescu
5b2568d18b
Fix cases where the bindable is resolved directly
2024-11-13 16:38:49 +09:00
Dan Balasescu
99762da7b8
Make RoomID non-bindable
...
Most important changes are to `RoomSubScreen` and `PlaylistsRoomSubScreen`, because those are the only two cases that now bind to the event instead.
2024-11-13 16:28:54 +09:00
Dean Herbert
0760451f3f
Merge branch 'master' into user-statistics-provider
2024-11-13 15:21:55 +09:00
Dean Herbert
78084e33af
Merge pull request #30411 from frenzibyte/editor-slider-touch-support-2
...
Fix placing objects via touch in editor not working sometimes
2024-11-13 15:09:57 +09:00
Dean Herbert
48212dfaeb
Fix test failures due to early disposal of import stream
2024-11-12 21:08:06 +09:00
Dan Balasescu
8d5cd2b353
Fix inspection
2024-11-12 20:12:50 +09:00
Dan Balasescu
72564b5c98
Make CurrentPlaylistItem not a bindable
2024-11-12 18:17:24 +09:00
Dan Balasescu
1c3a30a297
Fix the other test class too
2024-11-11 16:30:26 +09:00
Dan Balasescu
06380f91fc
Update test
2024-11-11 16:25:05 +09:00
Dean Herbert
322df72cce
Merge pull request #30425 from bdach/multiplayer-song-select-wyd
...
Fix multiplayer song select not correctly applying filter sometimes
2024-11-11 14:54:48 +09:00
Dean Herbert
54288c350a
Merge pull request #30525 from smoogipoo/multiplayer-refactor
...
Replace `MultiplayerRoomComposite` with local bindings
2024-11-07 19:53:44 +09:00
Dan Balasescu
4d7fd236c5
Make class partial
2024-11-07 17:28:31 +09:00
Dan Balasescu
bd630c189e
Fix tests not working by forgoing beatmap updates
2024-11-07 17:26:10 +09:00
Dan Balasescu
35d004cdc2
Fix intermittent beatmap recommendations test
2024-11-06 21:12:16 +09:00
Dan Balasescu
9f08b37792
Fix up tests
2024-11-06 16:35:11 +09:00
Bartłomiej Dach
2bd12e14db
Merge pull request #30467 from cdwcgt/friend-add
...
Add the ability to add/remove friends in `UserProfileHeader`
2024-11-05 10:25:27 +01:00
cdwcgt
c576fd8448
add AddFriendResponse
2024-11-05 15:55:42 +08:00
Bartłomiej Dach
7e3bb763cd
Merge branch 'master' into key-reversion-conflict
2024-11-01 19:40:27 +01:00
Bartłomiej Dach
0a33d71671
Add test coverage
2024-11-01 19:26:56 +01:00
Bartłomiej Dach
03fc744e92
Fix test
2024-11-01 18:26:49 +01:00
Bartłomiej Dach
3dc2408965
Merge branch 'master' into bat-max-performance
2024-11-01 13:13:20 +01:00
cdwcgt
1a92e5ad19
remove CreateAPIRelationFromAPIUser
2024-11-01 19:24:58 +08:00
cdwcgt
21b1c799f3
rename FriendAddRequest to AddFriendRequest
2024-11-01 19:16:56 +08:00
Bartłomiej Dach
1b5d1347aa
Merge branch 'master' into bat-mods
2024-11-01 11:27:06 +01:00
cdwcgt
b682285f53
simpily test
2024-11-01 14:24:54 +08:00
cdwcgt
0b2f4facac
add test
2024-11-01 14:05:24 +08:00
StanR
86989aa5ce
Fix UserRankPanel rank overflowing on 6+ digits
2024-10-27 13:40:29 +05:00
Bartłomiej Dach
36bcc5896c
Add failing test case
2024-10-25 21:29:49 +02:00
Salman Alshamrani
2fd495228c
Fix post-merge errors
2024-10-25 02:38:01 -04:00
Salman Alshamrani
701fb565b1
Merge branch 'master' into user-statistics-provider
2024-10-25 01:35:24 -04:00
Salman Alshamrani
6e9ff49e59
Merge branch 'master' into editor-slider-touch-support-2
2024-10-23 17:02:38 -04:00
Dean Herbert
77d2f35765
Merge pull request #30375 from bdach/fix-broken-playfield-skin-layer-rotation
...
Fix playfield skinning layer no longer correctly rotating with the playfield
2024-10-23 19:50:39 +09:00
Dean Herbert
2103b3e186
Merge pull request #28863 from OliBomby/additions
...
Add toggles and hotkeys for configuring sample addition bank
2024-10-23 15:52:55 +09:00
Dean Herbert
213be029ed
Merge pull request #30382 from Maks1mio/ChatChannelListSearch
...
Add search box to chat overlay
2024-10-22 20:10:53 +09:00
Bartłomiej Dach
54aeeaa529
Add test coverage
2024-10-22 12:29:34 +02:00
Dean Herbert
6ea1623889
Merge branch 'master' into lookup-users-endpoint
2024-10-22 18:48:00 +09:00
Dan Balasescu
17702ead0b
Fix ruleset not being reset correctly in tests
2024-10-22 14:20:10 +09:00
Bartłomiej Dach
1e03bd11a3
Fix test compile failures
2024-10-21 13:57:34 +02:00
Bartłomiej Dach
59e9ed7bac
Add test coverage
2024-10-21 12:44:01 +02:00
Dan Balasescu
03094533b4
Add test
2024-10-17 22:03:53 +09:00
Dan Balasescu
c0eda3606c
Add mod-related tests
2024-10-17 22:01:55 +09:00
Dan Balasescu
f3178b1fef
Add test scene
2024-10-17 21:18:44 +09:00
Bartłomiej Dach
8ed0554b91
Merge pull request #30245 from 424ever/group-slider-ends
...
Group `HitResult`s with the same name into one column in beatmap ranking
2024-10-16 09:40:45 +02:00
Salman Alshamrani
0fa1d22210
Add tests covering expected behaviour when going on/off compose area
2024-10-14 15:12:09 -04:00
Jonas Brandstötter
750e0b29ca
Use ChildrenOfType<> to get ScoreTable to test
2024-10-14 16:11:58 +02:00
Jonas Brandstötter
dcd3e5194e
Group HitResults with the same name into one column in beatmap ranking
...
Closes #29911
2024-10-12 22:53:08 +02:00
Dan Balasescu
2de1955892
Merge pull request #30218 from bdach/daily-challenge-conclusion-offline
...
Do not show daily challenge conclusion notification on disconnection
2024-10-12 18:14:22 +09:00
Bartłomiej Dach
07d15cc35a
Add positive assertion for conclusion notification being present too
2024-10-11 14:31:30 +02:00
Bartłomiej Dach
9d1eb842a7
Add failing test
2024-10-11 14:16:24 +02:00
Bartłomiej Dach
1a25e9d179
Add another failing test case for crash
2024-10-11 12:45:03 +02:00
Bartłomiej Dach
0882f1bb70
Add failing test case
2024-10-11 12:33:43 +02:00
Bartłomiej Dach
f1842d781e
Decouple AdvancedStats from global mods
...
Closes https://github.com/ppy/osu/issues/30163 .
If I'm to be blunt, the decoupled stuff in song select makes my head
spin. I spent a solid 20 minutes thinking how I was going to fix this
one but then finally realised that generally most of the cause there
was the fact that `AdvancedStats` was seeing the new rulesets *before*
the "ensure global selected mods are valid for current ruleset" logic,
and so decided to just _delay_ that until the decoupled transfer
thingamajig happens.
I was honestly considering combining `BeatmapInfo`, `Ruleset`, and
`Mods` into one property on `AdvancedStats`. I figured I'd rather not
push my luck and try the baseline version first, but I honestly think
that direction is going to be required at some point to properly corral
all of the decoupled madness taking place in song select.
2024-10-10 14:22:16 +02:00
Bartłomiej Dach
5104f3e7ac
Switch multiplayer away from using UserLookupCache
...
After switching `UserLookupCache` to `GET /users/lookup` from `GET
/users`, multiplayer sort of breaks, since the former endpoint does not
return `ruleset_statistics`, which are used in multiplayer to show
users' ranks. Therefore, switch multiplayer to use the appropriate
request type directly.
2024-10-08 14:46:50 +02:00
Dan Balasescu
19b586e6f7
Remove unrelated test
2024-10-07 17:45:23 +09:00
Dan Balasescu
8dece70097
Merge branch 'master' into updates-outside-of-gameplay-only-2
2024-10-07 17:41:42 +09:00
Dean Herbert
5c826be652
Merge pull request #29860 from bdach/fix-nudging
...
Only allow seek to next/previous object via keybinding if there is no selection
2024-10-07 15:36:19 +09:00
Bartłomiej Dach
86c3e3e987
Replace FormSliderBar.Instantaneous with TransferValueOnCommit
...
Rather than control the propagation of the value between the slider and
the textbox, add a property that controls the propagation of the value
between the bindables inside the form control to external bindables.
This will help alleviate issues where the external bindable update
incurs overheads due to having heavy change callbacks attached.
2024-10-04 14:07:16 +02:00
Bartłomiej Dach
114e53f8b2
Add failing test
2024-10-04 10:00:37 +02:00
Bartłomiej Dach
1280d7ea15
Fix tests again
2024-10-03 15:05:15 +02:00
Bartłomiej Dach
8a650deab6
Fix tests
2024-10-03 13:11:02 +02:00
Bartłomiej Dach
b15608343b
Replace setup screen controls with new "form" controls
2024-10-03 11:49:03 +02:00
Bartłomiej Dach
df730e6b6f
Implement "form" colour palette control
2024-10-03 11:20:47 +02:00
Dean Herbert
ecf144f4a5
Add failing test of importing failed replay in OsuGame flow
...
We had a test covering this but it wasn't within `OsuGame` so didn't
have full import blocking coverage (see
cbbe2f9dc0/osu.Game.Tests/Visual/Gameplay/TestScenePlayerLocalScoreImport.cs (L89-L88)
2024-10-03 17:11:25 +09:00
Dean Herbert
8773c34fdd
Rename enum to non-plural now that it won't conflict
2024-10-01 19:55:46 +09:00
Dean Herbert
54e68005ef
Merge pull request #29691 from bdach/hotkeys-in-context-menus
...
Add hotkey hints to editor menus
2024-10-01 19:29:05 +09:00
Dean Herbert
598bc74614
Merge pull request #30058 from bdach/disabled-beatmap-comment-box
...
Properly disable comment box on things that cannot be commented on
2024-10-01 18:52:40 +09:00
OliBomby
3769b0da5d
Fix TestHotkeysUnifySliderSamplesAndNodeSamples
2024-10-01 11:02:46 +02:00
Dean Herbert
ad3007eaad
Adjust ILocalUserPlayInfo to expose whether gameplay is in a paused/break state
2024-10-01 17:53:46 +09:00
Bartłomiej Dach
8eb5e6b1d5
Merge branch 'master' into shuffle
2024-10-01 10:07:54 +02:00
Bartłomiej Dach
a9818854f4
Merge pull request #30024 from peppy/edit-url-decode
...
Fix editor timestamp URLs not working when they contain a space
2024-10-01 09:44:18 +02:00
Dean Herbert
1b4215576d
Merge branch 'master' into additions
2024-10-01 16:38:56 +09:00
Dean Herbert
87ab953935
Merge pull request #30062 from bdach/distance-snap-weirdness
...
Fix various distance snap grid weirdness around unsnapped objects
2024-10-01 16:16:22 +09:00
