2954 Commits

• Cache non-filtered beatmap counts to massively improve count performance
  Dean Herbert · 2023-12-18 20:44:08 +09:00
  5755fa214a
• Debounce count updates for good measure
  Dean Herbert · 2023-12-18 20:43:23 +09:00
  034c5cd654
• Simplify invalidation logic

  The only case where this was checking is guaranteed by realm to only be called once.

  Dean Herbert · 2023-12-18 20:31:02 +09:00
  6fa1f5ef9b
• Avoid calling invalidation logic per beatmap set updated

  Realm will batch the updates. We don't want to do expensive operations per set when we don't need to.

  Dean Herbert · 2023-12-18 20:31:02 +09:00
  87b7699fcc
• Combine multiple similar invalidation logic into single event
  Dean Herbert · 2023-12-18 20:31:02 +09:00
  32cc3f9ef7
• Merge pull request #25760 from bdach/if-i-speak-i-am-in-big-trouble-pt-1

  Fix `AdjustedAttributesTooltip` being broken by design

  Dean Herbert · 2023-12-15 12:26:10 +09:00
  48e89b903c
• Reduce some allocations in SongSelect in the mania ruleset
  Dan Balasescu · 2023-12-15 11:01:15 +09:00
  fbef40bb1f
• Fix AdjustedAttributesTooltip being broken by design

  Fixes issue described in the following comment:
  https://github.com/ppy/osu/pull/25759#issuecomment-1855954637
  
  That is just not how the tooltip system is supposed to be used.
  
  To name the individual sins:
  
  - Caching and returning a tooltip instance like the classes that used
    tooltips is incorrect. The lifetime of tooltip instances is managed by
    the tooltip container. `GetCustomTooltip()` is called by it
    exclusively. It should return a fresh instance every time.
  
  - Not putting actual data in `IHasCustomTooltip.TooltipContent` is
    wrong.
  
  - Having `Tooltip.SetContent()` be a no-op is *grossly and flagrantly*
    wrong.
  
  I'm not even sure which particular combination of the above
  transgressions caused the issue as it presented itself, but at this time
  I frankly do not care.

  Bartłomiej Dach · 2023-12-14 16:15:56 +01:00
  9e5b6b97ff
• Update AdvancedStats.cs
  Givikap120 · 2023-12-14 14:31:58 +02:00
  b22a7cf520
• change the order of attributes

  + simplifying the bug fix

  Givikap120 · 2023-12-14 14:31:19 +02:00
  c2373bb37b
• fixed bug

  fixed the bug where it's not updates tooltip when there are no mods

  Givikap120 · 2023-12-14 14:00:35 +02:00
  8698835db2
• Refactor everything for sanity
  Dean Herbert · 2023-12-13 17:33:39 +09:00
  5062c53e36
• Update in line with upstream changes
  Dean Herbert · 2023-12-13 16:42:20 +09:00
  fb44fb18e0
• Merge branch 'master' into arod_rate_adjust
  Dean Herbert · 2023-12-13 16:35:18 +09:00
  0259ab761b
• Merge pull request #25711 from smoogipoo/mania-convert-song-select-keycount

  Display osu!mania keycount in song select carousel panels and details

  Dean Herbert · 2023-12-13 16:31:25 +09:00
  fdcf87569c
• Fix failing tests due to more textboxes being present with searchable dropdowns
  Dean Herbert · 2023-12-13 15:11:47 +09:00
  5e10f9f899
• Fix possible nullref
  Dan Balasescu · 2023-12-13 13:32:27 +09:00
  c31ff84417
• fixed one test
  Givikap120 · 2023-12-10 02:00:32 +02:00
  2d94841929
• Merge branch 'master' into arod_rate_adjust
  Givikap120 · 2023-12-10 01:49:18 +02:00
  faf54bca43
• fixed test errors
  Givikap120 · 2023-12-10 00:40:05 +02:00
  1d0c37e138
• Add keycount to song select details panel and carousel panels
  Dan Balasescu · 2023-12-09 22:31:51 +09:00
  b36db3518c
• Fix searching at song select matching incorrect ruleset

  Regressed with https://github.com/ppy/osu/pull/25679.

  Dean Herbert · 2023-12-06 11:32:26 +09:00
  8286d3896f
• Search terms before performing other criteria checks

  Very minor, but putting the more common case towards the
  start of the method allows early return.

  Dean Herbert · 2023-12-05 15:28:56 +09:00
  45e499778f
• Avoid list construction when doing filtering
  Dean Herbert · 2023-12-05 15:26:14 +09:00
  42010574b5
• Avoid sorting items when already in the correct sort order
  Dean Herbert · 2023-12-05 14:47:32 +09:00
  27e778ae09
• Use ordinal comparison when searching at song select

  Bypasses various overheads. In theory should be fine? (until it's not on some language)

  Dean Herbert · 2023-12-05 14:14:13 +09:00
  7fda38d0b0
• Made custom tooltip
  Givikap120 · 2023-11-23 23:30:18 +02:00
  c2a44cf118
• Rename method and adjust xmldoc to be very explicit about how wrong this is
  Dean Herbert · 2023-11-17 17:04:20 +09:00
  9172632b0b
• Add note about localisation
  Dean Herbert · 2023-11-17 16:52:40 +09:00
  d1cea10f21
• Move song select touch detector to solo implementation

  It should not run in multiplayer. Even if we wanted to allow touch-only
  playlist items at some point, the current behaviour of multiplayer song
  selects with respect to touch device mod is currently just broken.

  Bartłomiej Dach · 2023-11-14 16:35:16 +09:00
  70d2de5669
• Fixed precision and updated AdvancedStats
  Givikap120 · 2023-11-12 18:05:18 +02:00
  26d493986c
• Merge branch 'master' into arod_rate_adjust
  Dean Herbert · 2023-11-12 15:49:07 +09:00
  6bd5eda2a0
• fixed naming incconvinence
  Givikap120 · 2023-11-10 15:13:40 +02:00
  60c3e7250b
• Rename touch "input handlers" to detectors
  Bartłomiej Dach · 2023-11-06 10:08:19 +01:00
  97fee6143c
• Update AdvancedStats.cs
  Givikap120 · 2023-11-04 21:57:42 +02:00
  d0b2b4f7b9
• improved tooltip
  Givikap120 · 2023-11-04 21:55:46 +02:00
  820519c37d
• Improve code quality
  Givikap120 · 2023-11-04 17:25:09 +02:00
  57170501cd
• Do not attempt to turn on Touch Device in song select with autoplay active
  Bartłomiej Dach · 2023-11-02 22:56:43 +01:00
  8784dd42c0
• Fix song select touch handler causing crashes when song select is suspended
  Bartłomiej Dach · 2023-11-02 21:24:58 +01:00
  c588f434e5
• Automatically activate and deactivate touch device mod in song select
  Bartłomiej Dach · 2023-11-02 19:45:48 +01:00
  2f6ff893b5
• Use local workaround instead of disabling clipboard entirely
  Susko3 · 2023-10-28 12:23:23 +02:00
  366e41f111
• Fix left side of carousel blocking volume adjust hotkeys

  Closes https://github.com/ppy/osu/issues/25234.
  
  A little ad-hoc, but probably fine...?

  Bartłomiej Dach · 2023-10-26 16:26:35 +02:00
  2fa2217381
• Add failing test scene for scroll handling in song select
  Bartłomiej Dach · 2023-10-26 16:24:16 +02:00
  5d6a58d443
• Merge pull request #24921 from Pasi4K5/diff-name-search

  Add ability to search for difficulty names using square brackets

  Bartłomiej Dach · 2023-10-24 12:07:02 +02:00
  19be0055d5
• Remove incorrect copy paste fail
  Dean Herbert · 2023-10-24 17:32:01 +09:00
  c9161a7bfc
• Fix comment
  Bartłomiej Dach · 2023-10-24 10:05:20 +02:00
  abfe2ce0fe
• Add diff= support for more advanced usages
  Dean Herbert · 2023-10-24 16:09:05 +09:00
  fcb366af4d
• Simplify implementation and remove unsupported test coverage
  Dean Herbert · 2023-10-24 16:01:32 +09:00
  6865d8894d
• Block scroll and click operations on the left side of song select
  Dean Herbert · 2023-10-24 14:51:40 +09:00
  1274829193
• Apply code review suggestions
  Pasi4K5 · 2023-10-23 23:30:54 +02:00
  c5339f440e