4731 Commits

• Move comment to more fitting place
  Bartłomiej Dach · 2023-07-28 22:10:10 +02:00
  caad931a16
• Rename Apply{Vertical -> Horizontal}Centering to match common understanding
  Bartłomiej Dach · 2023-07-28 22:09:28 +02:00
  6d018c08af
• Fix playfield not taking up full width correclty when not vertically centered
  Dean Herbert · 2023-07-28 16:40:14 +09:00
  c9155f85ab
• Fix osu!taiko editor playfield missing a piece

  Regressed with recent centering changes in https://github.com/ppy/osu/pull/24220

  Dean Herbert · 2023-07-27 02:24:10 +09:00
  deba6e2508
• Merge branch 'master' into song-select-drain-length
  Bartłomiej Dach · 2023-07-25 22:40:45 +02:00
  57ccf82f34
• Merge branch 'master' into menu-star-fountains
  Bartłomiej Dach · 2023-07-25 21:58:13 +02:00
  3b9f250c1b
• Add new property to avoid overlapping usages
  Dean Herbert · 2023-07-25 18:14:03 +09:00
  eac6271bd0
• Add helper method to get drain length (and rename some usages)
  Dean Herbert · 2023-07-25 16:58:41 +09:00
  9cfe9164fa
• Merge pull request #24186 from OliBomby/legacy-export

  Add ability to export beatmaps from editor in a stable-compatible format

  Dean Herbert · 2023-07-23 15:25:06 +09:00
  4bf300d64d
• Merge branch 'master' into verify-breaks
  Bartłomiej Dach · 2023-07-22 17:42:55 +02:00
  d7b674bf2b
• Do not reimplement binary sort manually
  Bartłomiej Dach · 2023-07-22 17:12:21 +02:00
  699b66be42
• Merge branch 'master' into editor-key-count
  Bartłomiej Dach · 2023-07-22 16:11:21 +02:00
  d1c69283b2
• Fix "key count" setting showing as "circle size" in osu!mania editor

  Closes https://github.com/ppy/osu/issues/12904.

  Dean Herbert · 2023-07-21 18:52:29 +09:00
  fd2bdc10c7
• Fix playfield getting cut off (again) at tall aspect ratios
  Dean Herbert · 2023-07-21 15:20:20 +09:00
  b58354ac64
• Reduce width of right toolbar ever so slightly (and use more shared constants)
  Dean Herbert · 2023-07-21 14:39:15 +09:00
  f489dbd7a9
• Change check to use binary search
  NiceAesth · 2023-07-20 00:32:35 +03:00
  fa29c25097
• Merge branch 'master' into menu-star-fountains
  Bartłomiej Dach · 2023-07-19 21:26:41 +02:00
  f3a95d4c13
• Merge remote-tracking branch 'upstream/master' into legacy-export
  OliBomby · 2023-07-18 12:18:49 +02:00
  5d82190b70
• Rename variables, fix check message formatting
  NiceAesth · 2023-07-17 20:48:53 +03:00
  ff529d9df7
• Add break length and bounds checks
  NiceAesth · 2023-07-16 23:03:21 +03:00
  3888471148
• Merge pull request #24197 from peppy/allow-autoplay-failure

  Allow autoplay to fail

  Bartłomiej Dach · 2023-07-13 23:44:07 +02:00
  ff56e35093
• Remove unused property
  Bartłomiej Dach · 2023-07-13 21:25:43 +02:00
  674eb1a36b
• Make autoplay compatible with ModFailCondition
  Bartłomiej Dach · 2023-07-13 21:23:57 +02:00
  a1e83b20e6
• Change IBeatSyncProvider.Clock to always be non-null
  Dean Herbert · 2023-07-13 22:13:40 +09:00
  20e4e2581a
• Ensure PerformanceBreakdown pieces cannot be null
  Dean Herbert · 2023-07-13 18:38:16 +09:00
  6edaf4f230
• Allow no fail mod during autoplay
  Dean Herbert · 2023-07-13 17:25:08 +09:00
  2f40989a4f
• Merge branch 'master' into fix-imperfect-simulation
  Dan Balasescu · 2023-07-13 15:41:54 +09:00
  47a65f8890
• Allow autoplay to fail

  Feels more correct.

  Dean Herbert · 2023-07-13 13:41:35 +09:00
  fbf14a0f7c
• Merge branch 'master' into fix-blueprint-end-placement
  Dean Herbert · 2023-07-12 17:38:47 +09:00
  b20190ed4f
• Merge pull request #24169 from bdach/legacy-score-v2

  Backpopulate stable ScoreV2 scores with ScoreV2 system mod (and don't recalculate their total score)

  Dean Herbert · 2023-07-12 12:44:04 +09:00
  8e1e8a2807
• Account for break time
  NiceAesth · 2023-07-11 13:40:19 +03:00
  1dae1d8f0a
• Fix slider blueprint placement when ending placement outside the playfield

  As mentioned in https://github.com/ppy/osu/discussions/24161

  Dean Herbert · 2023-07-11 17:29:53 +09:00
  a0e6748882
• legacy export broken
  OliBomby · 2023-07-11 02:30:16 +02:00
  06e5ef88c0
• Add beatmap minimum length checks
  NiceAesth · 2023-07-10 17:29:49 +03:00
  9a2915f423
• Implement back-and-forth conversion of ModScoreV2 and LegacyMods
  Bartłomiej Dach · 2023-07-09 16:15:21 +02:00
  7be5e0e978
• Add ModScoreV2
  Bartłomiej Dach · 2023-07-09 15:56:51 +02:00
  ae05df3b8c
• Fix GenerateTicks being lost during osu! beatmap conversion process
  Bartłomiej Dach · 2023-07-08 23:24:38 +02:00
  56a2ba4ac0
• Merge branch 'master' into taiko-hitsounding-final-attempt
  Bartłomiej Dach · 2023-07-08 18:10:04 +02:00
  055e4a78f0
• Replace various local implementations of rewinding checks with new property
  Dean Herbert · 2023-07-07 15:21:24 +09:00
  e0fc97bb93
• Fix GameplaySampleTriggerSource not handling rewinds correctly
  Dean Herbert · 2023-07-06 19:08:42 +09:00
  753db044b4
• Expose rewinding state of IGameplayClocks

  The implementation of this requires a bit of a special case
  for 0, so makes sense to implement in a central place.

  Dean Herbert · 2023-07-06 19:08:42 +09:00
  2e98ab0a48
• Fix GameplaySampleTriggerSource not handling rewinds correctly
  Dean Herbert · 2023-07-06 14:16:31 +09:00
  de74c9eb8b
• Expose rewinding state of IGameplayClocks

  The implementation of this requires a bit of a special case
  for 0, so makes sense to implement in a central place.

  Dean Herbert · 2023-07-06 14:16:31 +09:00
  af3f9086e5
• Merge branch 'master' into taiko-hitsounding-final-attempt
  Bartłomiej Dach · 2023-07-05 22:15:32 +02:00
  a87a631c50
• Merge pull request #24121 from peppy/fix-judged-fallback

  Fix fallback for `Judged` to be more correct

  Bartłomiej Dach · 2023-07-05 22:15:04 +02:00
  f3576b88a4
• Merge pull request #24072 from smoogipoo/diffcalc-total-scorev1

  Add difficulty attributes to facilitate conversion from legacy score, and convert existing scores

  Dean Herbert · 2023-07-05 18:47:18 +09:00
  49e5558e4f
• Cache Playfield for the sake of tests

  I'm open to an alternative. Name it.

  Dean Herbert · 2023-07-05 18:44:27 +09:00
  8f61f5e4c6
• Merge branch 'fix-judged-fallback' into taiko-hitsounding-final-attempt
  Dean Herbert · 2023-07-05 18:44:27 +09:00
  c5b949154c
• Fix fallback for Judged to be more correct

  Without this change, when the `Judged` value is checked on an
  `HitObjectLifetimeEntry` it would return `true` if a `DrawableHitObject`
  has not yet been associated with the entry. Which is completely wrong.
  
  Of note, the usage in `DrawableHitObject` will have never fallen through
  to this incorrect value as they always have a result populated:
  
  https://github.com/ppy/osu/blob/f26f001e1d01ca6bb53225da7bf06c0ad21153c5/osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs#L721-L726

  Dean Herbert · 2023-07-05 18:44:27 +09:00
  4364736ccd
• Consume nested object states in HitObjectLifetimeEntry
  Dean Herbert · 2023-07-05 18:44:27 +09:00
  561fff801a