osu-lazer

Fix timeline selection box showing rotation handles

closes https://github.com/ppy/osu/issues/36888.

oooooooops.

Bartłomiej Dach · 2026-03-09 11:58:58 +01:00

a7860dd4c1

Fix rotation of certain objects breaking change states (#36852 )

Closes https://github.com/ppy/osu/issues/36830.

This is a regression from https://github.com/ppy/osu/pull/36681.

Due to the aforementioned pull request's changes, rotating an object
that could not scale on the X or Y axis (due to having that dimension
zero) would trigger `CanScale{X,Y}` to change as said rotated object's
width or height became not zero. This in turn would cause `SelectionBox`
to *fully recreate* all of its handles and buttons, *including* the
rotation handle that initiated the rotation operation, therefore
dropping the ongoing rotation operation completely and leaving the
editor in a half-broken state.

The suggested solution here is to recreate handles more granularly to
prevent this from happening. (I've probably not improved it as much as I
could have, but this is as far as I'm willing to go for now unless
review finds it unpalatable.)

Bartłomiej Dach · 2026-03-07 00:20:10 +09:00

0d74983551

Fix SelectionBox buttons freezing when button is triggered via key event

Marvin Schürz · 2024-10-10 20:14:11 +02:00

9cc6ee2ebc

Animate SelectionBox buttons on unfreeze

Marvin Schürz · 2024-09-24 16:42:37 +02:00

99a80b399c

Only store position instead of entire draw quad

Marvin Schürz · 2024-09-21 15:25:37 +02:00

1095f35025

Freeze select box buttons in place as long as they are hovered

Marvin Schürz · 2024-09-21 14:59:47 +02:00

0077ba72ec

Update HasFlag usages

Dean Herbert · 2024-07-03 00:19:04 +09:00

5350945340

Use better name if we're renaming

Bartłomiej Dach · 2024-05-29 09:40:29 +02:00

4c881b5633

rename CanScaleSelectionOrigin/PlayfieldOrigin to make clear its not the origin being scaled

OliBomby · 2024-05-28 16:14:16 +02:00

a89ba33b47

Merge remote-tracking branch 'upstream/master' into scaling

OliBomby · 2024-05-15 23:05:19 +02:00

8df5f22b4e

Rename CanRotate property of SelectionRotationHandler to a more descriptive name

Nguyên Minh Hồ · 2024-01-25 12:10:50 +07:00

e1f8bc9692

refactor CanScale properties

OliBomby · 2024-01-20 01:13:01 +01:00

a4f771ec08

Refactor scale handling in editor to facilitate reuse

OliBomby · 2024-01-20 00:22:53 +01:00

26c0d1077a

Rename diagonal scale variable and update xmldoc

Dean Herbert · 2023-11-10 17:55:02 +09:00

35e11c7c63

Change selection handling to adjust Size instead of Scale for edge nodes

Dean Herbert · 2023-11-10 14:22:28 +09:00

ec3b6e47fb

Bypass Parent nullability checks for now

Dean Herbert · 2023-10-17 17:48:45 +09:00

5341a335a6

let SelectionBox perform flip with scale handles

Wleter · 2023-09-01 13:01:51 +02:00

fc4069f794

change names

Wleter · 2023-08-29 17:25:52 +02:00

d56ab0fe9a

working negative scaling

Wleter · 2023-08-28 16:41:55 +02:00

07e126241d

Interface with SelectionRotationHandler via DI rather than explicit passing

Bartłomiej Dach · 2023-07-30 20:21:41 +02:00

ebe5dd2ac9

Fix a couple of code style issues in SelectionBox

Dean Herbert · 2023-07-26 14:04:38 +09:00

7fd6bb9d5f

Migrate SelectionHandler to use SelectionRotationHandler

Bartłomiej Dach · 2023-07-23 20:56:22 +02:00

aec3ca250c

Use slightly different condition for better UX

Bartłomiej Dach · 2023-07-01 21:39:08 +02:00

9eec1337b3

Fix edge cases where selection buttons go outside playfield bounds

Addresses
https://github.com/ppy/osu/discussions/23599#discussioncomment-6300885.

Bartłomiej Dach · 2023-07-01 21:27:17 +02:00

183777f8df

Fix hotkey presses generating unnecessary undo history

The buttons don't check whether the operation they correspond to is
possible to perform in the current state of the selection box, so not
checking `Can{Reverse,Rotate}` causes superfluous undo states to be
added without any real changes if an attempt is made to reverse or
rotate a selection that cannot be reversed or rotated.

Bartłomiej Dach · 2023-06-27 22:25:04 +02:00

9be2d9d62e

Mention hotkeys in button tooltips

Bartłomiej Dach · 2023-06-27 22:04:15 +02:00

17ed45d07c

Switch to == true

Bartłomiej Dach · 2023-06-27 22:02:15 +02:00

54280f06be

Enable NRT in SelectionBox

Bartłomiej Dach · 2023-06-27 22:01:44 +02:00

ad3a470eaf

Add support for Ctrl + < / > to rotate selection in editor

As discussed in https://github.com/ppy/osu/discussions/24048.

Dean Herbert · 2023-06-27 17:01:41 +09:00

c6d952abe3

Add a visual effect when keyboard shortcuts are used to trigger selection box buttons

Dean Herbert · 2023-06-27 17:01:13 +09:00

7ddbf4eaa7

Polish a few extreme edge cases

Bartłomiej Dach · 2023-05-25 16:39:54 +02:00

3ad5f8b9c9

Use alternative layouting implementation

Bartłomiej Dach · 2023-05-25 16:17:44 +02:00

beeca5a8dd

Ensure editor selection buttons remain on screen when selection is near edge

Addresses https://github.com/ppy/osu/discussions/23599.

Dean Herbert · 2023-05-24 19:16:53 +09:00

3b9e1e8a94

Partial everything

Dan Balasescu · 2022-11-27 00:00:27 +09:00

7bc8908ca9

Automated #nullable processing

Dan Balasescu · 2022-06-17 16:37:17 +09:00

f8830c6850

Move implementation of drag handle operations to concrete classes

Bartłomiej Dach · 2022-01-08 20:24:00 +01:00

24d377fddb

Add global flip hotkeys

Dean Herbert · 2022-01-05 16:48:07 +09:00

866ae3472b

Remove existing handling of flip hotkeys

Dean Herbert · 2022-01-05 16:30:42 +09:00

13cce50fa7

Allow specifying flipping support of selection box different from scaling

ekrctb · 2021-07-21 15:59:45 +09:00

1bff4373b3

Merge branch 'master' into corner-rotation-controls

Salman Ahmed · 2021-05-04 23:53:23 +03:00

1ac80d42f9

Remove intermediate container to fix tests

Dean Herbert · 2021-05-03 17:35:56 +09:00

3268a75f05

SelectionBoxDragHandleDisplay -> SelectionBoxDragHandleContainer

Salman Ahmed · 2021-04-25 20:03:15 +03:00

7390a12e4b

Replace separated top-centered rotation button with rotation drag handles

Salman Ahmed · 2021-04-25 10:17:36 +03:00

a8c460f7df

Fix selection box operation hotkeys not registering in change handler

Could lead to crashes after reversing a note cluster and playing it
back.

The root cause of the crash was that the hotkey operations were not ran
inside of an editor change handler operation. This, in turn, caused the
autoplay replay to not be regenerated after flipping an object cluster,
therefore finally manifesting as a hard crash due to negative time
offsets appearing in judgement results, which interfered with the
default implementation of note lock.

Note that this incidentally also fixes the fact that selection box
hotkey operations (reverse and flip) did not handle undo/redo.

Bartłomiej Dach · 2021-03-17 22:17:42 +01:00

2e63c2ce20

Use yet another solution leveraging padding

Bartłomiej Dach · 2020-12-18 23:45:42 +01:00

f1878eff63

replace drag cirle function with dictionary