225 Commits

• Update lots of packages (#36996)

  It's been a while.
  
  Notes:
  
  - `SharpCompress` usages changed a bit. Manually adjusted these, mostly
  just renames or adjusted parameters.
  - nUnit 3 -> 4 migrated using
  https://gist.github.com/peppy/07994386d793a117350cb5f24b156585. there's
  a mode in this script to update to the newer `Assert.That` syntax but it
  requires fixes and couldn't really be bothered.
  - DeepEqual nuked as the only usage was on a disabled test. The reason
  it's disabled has been merged upstream, but it's failing for other
  (realm) reasons which I don't think is worthwhile to investigate for
  now.
  - This bumps Moq. I think the author is back in a sensible headspace and
  the new version has the stupid shit removed, so probably okay? Nice to
  be on a level playing field with packages for once in a long time.
  - Automapper is silly, but we've discussed this elsewhere.
  - `TestRealmKeyBindingStore` failures are a wildcard, but fixed by using
  a more standardised testing method. Dunno why, don't care.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-03-17 03:58:02 +09:00
  a996261304
• Merge pull request #34667 from Hiviexd/verify/exclude-audio-from-hs-check

  Exclude all beatmap audios from the hitsounds format check

  Bartłomiej Dach · 2025-08-19 14:33:35 +02:00
  3b49673e83
• Merge pull request #34666 from Hiviexd/verify/check-inconsistent-audio

  Add verify check for inconsistent audio usage

  Bartłomiej Dach · 2025-08-19 14:33:13 +02:00
  b1296b0c83
• more correct hashset usage
  Hivie · 2025-08-15 14:41:59 +01:00
  0bcf29304b
• Rename variables
  Bartłomiej Dach · 2025-08-15 10:21:50 +02:00
  5722e85791
• exclude all beatmap audios from the check

  - prevents false positives on maps with multiple audios

  Hivie · 2025-08-15 00:11:16 +01:00
  7b455efe34
• add check for inconsistent audio usage
  Hivie · 2025-08-15 00:08:55 +01:00
  148bc4ac34
• handle pairwise comparison for video start times
  Hivie · 2025-08-14 13:14:58 +01:00
  f928f9953b
• add verify check for video usage
  Hivie · 2025-08-13 20:26:46 +01:00
  e52a4638fe
• add util for getting storyboard video of a difficulty
  Hivie · 2025-08-13 20:26:26 +01:00
  79fcd045b3
• more check refactors to cover the context changes
  Hivie · 2025-08-11 16:05:52 +01:00
  fb61f00466
• initial pass on updated verifier context usage across most checks
  Hivie · 2025-08-11 14:57:14 +01:00
  fd6cf680b9
• Merge branch 'master' into verify/check-inconsistent-settings
  Bartłomiej Dach · 2025-08-07 06:57:32 +02:00
  39ad5ecd79
• Use strongly-typed equality comparer rather than using object equality comparer

  `EqualityComparer<object>.Default()` will be slow, will fall back to
  `object.Equals()` which may do the right thing, the wrong thing, or be
  useless due to using reference equality semantics.
  
  In practice in this call site it likely doesn't matter anyway but I'd
  rather be future-proof than not.

  Bartłomiej Dach · 2025-08-06 18:26:41 +02:00
  c2a85032a6
• only check widescreen bool when storyboard is present

  matches MV

  Hivie · 2025-08-06 14:57:42 +01:00
  92fda5c2b9
• move storyboard presence check to shared utils
  Hivie · 2025-08-06 14:55:20 +01:00
  9b53d340af
• refactor comparison and use actual object type for field selectors
  Hivie · 2025-08-06 14:04:18 +01:00
  7f886f7534
• fix tests
  Hivie · 2025-08-06 13:06:59 +01:00
  899719e874
• mark timing checks as set-level
  Hivie · 2025-08-06 11:42:57 +01:00
  af8b133019
• use current beatmap as reference

  to be consistent with other checks that follow similar logic

  Hivie · 2025-08-06 11:42:40 +01:00
  f2953652a1
• add check for inconsistent settings
  Hivie · 2025-08-06 11:29:22 +01:00
  3cd6734c10
• use already-existing framework extension method
  Hivie · 2025-08-06 08:42:19 +01:00
  2127b6ca4e
• cleaner definition

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Hivie · 2025-08-06 08:40:34 +01:00
  82f619a58a
• refactor and reduce duplication
  Hivie · 2025-08-06 07:42:40 +01:00
  03b6f35946
• add check for missing genre/language tags
  Hivie · 2025-08-05 23:02:48 +01:00
  f5c6c086ad
• Merge pull request #34465 from Hiviexd/verify/check-inconsistent-timing

  Add verify check for inconsistent timing control points

  Bartłomiej Dach · 2025-08-05 10:34:47 +02:00
  427dc2b31e
• Bring back localisations
  Bartłomiej Dach · 2025-08-05 08:23:47 +02:00
  c1c43fab17
• Use casing of "beatmap set" consistent with the rest of the code base
  Bartłomiej Dach · 2025-08-05 08:18:30 +02:00
  ee5a5cda11
• remove unnecessary localisations
  Hivie · 2025-08-04 22:07:41 +01:00
  2c5aa73ccb
• apply review

  - improve timing tolerance const name and documentation
  - simplify matching logic in `FindMatchingTimingPoint`

  Hivie · 2025-08-04 15:21:43 +01:00
  a7f0ae09bb
• define general checks with a bool in CheckMetadata instead of an interface
  Hivie · 2025-08-04 14:12:59 +01:00
  ed301ec114
• rename scopes
  Hivie · 2025-08-04 14:02:40 +01:00
  8a2053bf61
• mark various set-level checks as general checks
  Hivie · 2025-08-01 21:42:31 +01:00
  0d2618082d
• add VerifyChecksScope enum
  Hivie · 2025-08-01 21:40:33 +01:00
  8e73c57470
• add class for general checks
  Hivie · 2025-08-01 21:39:46 +01:00
  7f8b6981b2
• move methods to TimingCheckUtils

  so they can be reused for future timing-related checks

  Hivie · 2025-08-01 18:37:54 +01:00
  0fcef7b0ee
• add check for inconsistent timing
  Hivie · 2025-08-01 16:01:28 +01:00
  b4dc394127
• Merge pull request #34371 from Hiviexd/verify/check-almost-concurrent-objects

  Account for almost concurrent case in concurrent objects check

  Bartłomiej Dach · 2025-07-28 15:03:26 +02:00
  34dfb2f9ea
• apply review
  Hivie · 2025-07-28 12:36:18 +01:00
  e781ad737b
• apply review
  Hivie · 2025-07-28 12:24:24 +01:00
  8466d64c69
• refactor issue templates to be more unified
  Hivie · 2025-07-24 13:25:15 +01:00
  c0ba8bc997
• Account for almost concurrent case in concurrent objects check
  Hivie · 2025-07-24 13:12:24 +01:00
  806d3160f8
• add verify check for inconsistent metadata
  Hivie · 2025-07-24 12:20:45 +01:00
  ee27be1868
• Merge pull request #34181 from Hiviexd/verify/check-lowest-diff-drain

  Add verify check for lowest diff drain/play time requirements

  Bartłomiej Dach · 2025-07-22 08:38:59 +02:00
  c408d60fbe
• oops
  Hivie · 2025-07-21 13:21:30 +01:00
  209a75c4df
• adjust wording
  Hivie · 2025-07-21 13:18:25 +01:00
  9bab2444ea
• fix one tiny miniscule english error i encountered by editing a beatmap
  Shin Morisawa · 2025-07-20 20:50:20 +09:00
  9572c2ba67
• address review

  - add TODO for refactoring verifier context ctor
  - call `GetPlayableBeatmap()` in verifier context ctor
  - filter diffs with relevant ruleset in check logic
  - fix tests

  Hivie · 2025-07-16 01:53:22 +01:00
  747bff1df9
• Minor cleanups

  Using `ChannelType.Unknown` instead of `0`, adds missing disposal.

  Dan Balasescu · 2025-07-14 15:10:04 +09:00
  8e0ed85ad2
• formatting
  Hivie · 2025-07-13 04:37:22 +01:00
  c36960a06e