10742 Commits

• Added "LN Ratio" display in Mania in the place of useless "key count" (#37581)

  The "Key Count" metric in mania is very useless since you are already
  expected to play maps with a specific Key Count when you are queueing.
  This PR inserts the proportion of LNs (Long Notes) in the place of that
  metric since it is one of the ways players can gudge their skillsets
  (This idea comes from reddit)
  Also improved the test suite for other skillsets by making the
  architecture more minor ruleset friendly
  
  Addresses https://github.com/ppy/osu/discussions/37568.
  
  ---------
  
  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Kao Li Chin (Gao Li Jin) · 2026-05-08 18:04:29 +09:00
  53f945b7ac
• Restore editor mode when changing difficulty (#37671)

  When editing metadata, it's annoying that the editor returns to compose
  mode when switching between difficulties. This fixes that fallacy.
  
  Supersedes and closes https://github.com/ppy/osu/pull/36724.

  Dean Herbert · 2026-05-08 10:25:22 +02:00
  e6fdd37e76
• Add judgement counter mode to show misses only (#37664)

  Not sure if valuable. Came from
  https://github.com/ppy/osu/discussions/37261 but that wants slider ends
  as well, which is like, weird.
  
  🤷

  Dean Herbert · 2026-05-08 10:19:40 +02:00
  7d93c242b7
• Show user rank on list panels (#37659)

  Addresses https://github.com/ppy/osu/discussions/37616 partly.
  
  <img width="828" height="826" alt="osu! 2026-05-07 at 06 59 23"
  src="https://github.com/user-attachments/assets/15343112-dc07-4501-b291-b53db870be5a"
  />

  Dean Herbert · 2026-05-08 15:34:59 +09:00
  9e20929ad3
• Fix non-default mod settings allowing for duplicate freestyle mod selection in multiplayer (#37646)

  Fixes a bug that allowed for selecting the same mod twice in multiplayer
  if the playlist entry has non-default settings for a required mod.
  This happens due to a strict equality mod check in the mod set
  compatibility check function, which only considers mods duplicates if
  their settings are exactly the same. Replacing with a more lenient
  `Type` check fixes this.
  
  Adds a regression test for this behavior
  
  Fixes https://github.com/ppy/osu/issues/37625.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  triacontakai · 2026-05-07 08:59:54 +02:00
  3f5c113394
• Allow reporting users from their profile page (#36335)

  This PR refactors the report popover to have an optional confirmation
  message after completing the request. This was initially meant for
  #32584, but then I realized I can first test it out on the user
  profiles, so I've implemented it here as well. Can be reviewed commit by
  commit.
  
  
  
  https://github.com/user-attachments/assets/cd59c560-c824-4a5e-bab6-5ecbf5125af1
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Krzysztof Gutkowski · 2026-05-05 19:49:24 +09:00
  2006485d60
• Implement animation for RankedPlayBottomOrnament (#37504)

  Based off of https://github.com/ppy/osu/pull/37478 with some
  improvements such as:
  * Simpler `progress` handling (single adjustable value instead of 2)
  * 2 less drawable paths (replaced with circlular containers)
  * Reworked remaining paths to have as little texture sizes as possible
  
  ---------
  
  Co-authored-by: Krzysztof Gutkowski <krzysio.gutkowski@gmail.com>
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Andrei Zavatski · 2026-04-27 18:40:20 +09:00
  662c85d4c2
• Add empty hand check to moveCardFocus (#37489)

  Resolves #37486
  
  Original error log:
  ```
  2026-04-22 21:47:58 [error]: System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
  2026-04-22 21:47:58 [error]: at System.Collections.Generic.List`1.get_Item(Int32 index)
  2026-04-22 21:47:58 [error]: at osu.Game.Screens.OnlinePlay.Matchmaking.RankedPlay.Hand.PlayerHandOfCards.moveCardFocus(Int32 direction)
  2026-04-22 21:47:58 [error]: at osu.Game.Screens.OnlinePlay.Matchmaking.RankedPlay.Hand.PlayerHandOfCards.OnKeyDown(KeyDownEvent e)
  ```
  
  Currently,
  ```osu.Game\Screens\OnlinePlay\Matchmaking\RankedPlay\Hand\PlayerHandOfCards.cs::moveCardFocus```
  does not account for the hand being empty (cards.Count ==0 ), and will
  attempt to move the card focus in the given direction regardless, which
  causes the above index out of range error.
  
  Added empty hand check to moveCardFocus, and a matching test case to
  TestScenePlayerCardHand.cs
  
  New test case before changes, recreating the error:
  <img width="986" height="232" alt="image"
  src="https://github.com/user-attachments/assets/daa62081-c776-44bd-b0d2-382b2dac7938"
  />
  
  After:
  <img width="638" height="223" alt="image"
  src="https://github.com/user-attachments/assets/d6dcd8b8-8caf-42e3-9999-93dfe3fb6452"
  />

  Austin Moore · 2026-04-23 12:23:17 +09:00
  f1ea3b354c
• Apply different workaround to fix ranked play single thread audio issues (#37477)

  Thing to make release happen.
  
  Reverts #37453
  Reverts #37463
  Alternative to #37473
  
  Not that I disagree with any of these but I'm just looking to return to
  what works so we can do a release because we're on a clock here for
  other reasons.
  
  Test which should work but doesn't, so I'm not adding:
  
  ```diff
  diff --git a/osu.Game.Tests/Visual/RankedPlay/TestSceneOpponentPickScreen.cs b/osu.Game.Tests/Visual/RankedPlay/TestSceneOpponentPickScreen.cs
  index f747004bbd..eb8e360d1e 100644
  --- a/osu.Game.Tests/Visual/RankedPlay/TestSceneOpponentPickScreen.cs
  +++ b/osu.Game.Tests/Visual/RankedPlay/TestSceneOpponentPickScreen.cs
  @@ -1,12 +1,17 @@
   // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
   // See the LICENCE file in the repository root for full licence text.
   
  +using System.Linq;
  +using NUnit.Framework;
   using osu.Framework.Extensions;
  +using osu.Framework.Testing;
   using osu.Game.Online.API;
   using osu.Game.Online.Multiplayer;
   using osu.Game.Online.Multiplayer.MatchTypes.RankedPlay;
   using osu.Game.Online.Rooms;
   using osu.Game.Screens.OnlinePlay.Matchmaking.RankedPlay;
  +using osu.Game.Screens.OnlinePlay.Matchmaking.RankedPlay.Card;
  +using osu.Game.Screens.OnlinePlay.Matchmaking.RankedPlay.Hand;
   
   namespace osu.Game.Tests.Visual.RankedPlay
   {
  @@ -14,6 +19,8 @@ public partial class TestSceneOpponentPickScreen : RankedPlayTestScene
       {
           private RankedPlayScreen screen = null!;
   
  +        private readonly BeatmapRequestHandler requestHandler = new BeatmapRequestHandler();
  +
           public override void SetUpSteps()
           {
               base.SetUpSteps();
  @@ -26,8 +33,6 @@ public override void SetUpSteps()
               AddStep("load screen", () => LoadScreen(screen = new RankedPlayScreen(MultiplayerClient.ClientRoom!)));
               AddUntilStep("screen loaded", () => screen.IsLoaded);
   
  -            var requestHandler = new BeatmapRequestHandler();
  -
               AddStep("setup request handler", () => ((DummyAPIAccess)API).HandleRequest = requestHandler.HandleRequest);
   
               AddStep("set pick state", () => MultiplayerClient.RankedPlayChangeStage(RankedPlayStage.CardPlay, state => state.ActiveUserId = 2).WaitSafely());
  @@ -44,7 +49,11 @@ public override void SetUpSteps()
                       }).WaitSafely();
                   }
               });
  +        }
   
  +        [Test]
  +        public void TestBasic()
  +        {
               AddWaitStep("wait", 15);
   
               AddStep("play beatmap", () => MultiplayerClient.PlayUserCard(2, hand => hand[0]).WaitSafely());
  @@ -54,5 +63,29 @@ public override void SetUpSteps()
                   BeatmapID = requestHandler.Beatmaps[0].OnlineID
               }).WaitSafely());
           }
  +
  +        [Test]
  +        public void TestPickPreviewPlayedOnOpponentPick()
  +        {
  +            RankedPlayCard.SongPreviewContainer? originalPreview = null;
  +
  +            AddStep("hover first card",
  +                () => InputManager.MoveMouseTo(this.ChildrenOfType<PlayerHandOfCards>().Single().Cards
  +                                                   .First(c => c.Item.PlaylistItem.Value != null && c.Item.PlaylistItem.Value.BeatmapID != requestHandler.Beatmaps[0].OnlineID)));
  +            AddUntilStep("preview playing", () => originalPreview = this.ChildrenOfType<RankedPlayCard.SongPreviewContainer>().FirstOrDefault(p => p.IsRunning), () => Is.Not.Null);
  +
  +            AddStep("play beatmap", () => MultiplayerClient.PlayUserCard(2, hand => hand[0]).WaitSafely());
  +            AddStep("reveal card", () => MultiplayerClient.RankedPlayRevealUserCard(2, hand => hand[0], new MultiplayerPlaylistItem
  +            {
  +                ID = 0,
  +                BeatmapID = requestHandler.Beatmaps[0].OnlineID
  +            }).WaitSafely());
  +
  +            AddUntilStep("wait for original preview stopped", () => originalPreview?.IsRunning, () => Is.False);
  +
  +            AddUntilStep("preview playing is opponent's pick",
  +                () => ((RankedPlayCard)this.ChildrenOfType<RankedPlayCard.SongPreviewContainer>().SingleOrDefault(p => p.IsRunning)?.Parent!).Item.PlaylistItem.Value?.BeatmapID,
  +                () => Is.EqualTo(requestHandler.Beatmaps[0].OnlineID));
  +        }
       }
   }
  
  ```
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-04-23 02:05:52 +09:00
  a4f79f7c99
• Refactor audio preview logic in ranked play cards to match expectations while hopefully not looking buggy anymore (#37463)

  RFC.
  
  See https://github.com/ppy/osu/pull/37453#issuecomment-4289403735 for
  why.
  
  Of note:
  
  - To facilitate mutual exclusivity of playback `PlayerHandOfCards`
  maintains a bindable pointing at the currently playing song preview.
  - Because of how card drawables are passed between multiple parenting
  drawables, some of which are and some of which are not
  `PlayerHandOfCards` instances, DI fails horribly at working with this
  bindable unless it is manually managed. See relevant overrides in
  `PlayerHandOfCards`.
  - I renamed one of the overloads of `HandOfCards.RemoveCard()` to
  `DetachCard()` because I found the fact that there are two overloads of
  one method that do WILDLY DIFFERENT THINGS utterly *asinine*. (One
  overload scrapes the `RankedPlayCard` out for you to plop elsewhere. One
  *drops it on the floor entirely*.)
  
  This took way too long to write.

  Bartłomiej Dach · 2026-04-22 12:48:45 +09:00
  f1a9be4a19
• Code quality improvements for child/draw order handling in HandOfCards (#37423)

  Attempt at adressing the points made in
  https://github.com/ppy/osu/pull/37419#issuecomment-4279123323
  
  - `CardContainer` is now being sorted immediately instead of only doing
  it once per frame. Given that its only ever gonna have a handful of
  children there wasn't really a need to optimize that that in the first
  place.
  - `HandOfCards.Cards` now exposes `cardLookup.Values` as an
  `IEnumerable` instead of exposing the card container's children
  directly.
  - `HandOfCard` now exposes `GetCardsInDisplayOrder` which returns a copy
  of all cards in display order. Since it's making a copy I made sure this
  isn't called on any hot code paths.
  - `HandOfCard.Clear` previously didn't clear the `cardLookup`
  dictionary. Didn't cause any issues since we're not re-adding cards to
  the hand anywhere but not good regardless.
  Switched to looping over all cards and calling `RemoveCard` to make sure
  changes to the removal logic can't get overlooked there again.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  maarvin · 2026-04-21 22:54:36 +09:00
  7b0e5ecc13
• Use placeholder user models in ranked play if online lookups fail (#37455)

  Suboptimal? Sure. But the primary goal is not to crash. Crashing is a
  failure of the game programmer.
  
  Better can be done later.
  
  Remedies/fixes https://github.com/ppy/osu/issues/37421.

  Bartłomiej Dach · 2026-04-21 22:16:45 +09:00
  71356a9455
• Attempt to improve safety of pushing matchmaking screens (#37452)

  Due to the push of the relevant screens being delayed it's possible that
  the room goes away between the scheduling of the push and the actual
  execution of the push.
  
  This maybe closes https://github.com/ppy/osu/issues/37374 but my hopes
  are not high.
  
  Includes some extra cleanups I noticed along the way.

  Bartłomiej Dach · 2026-04-21 19:11:35 +09:00
  1eee6dc870
• Fix illegible star rating text colour in ranked play intro animation (#37429)

  Closes https://github.com/ppy/osu/issues/37406.
  
  I almost applied
  
  ```diff
  diff --git a/osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Intro/StarRatingSequence.cs b/osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Intro/StarRatingSequence.cs
  index 318572d28f..76719a7de8 100644
  --- a/osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Intro/StarRatingSequence.cs
  +++ b/osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Intro/StarRatingSequence.cs
  @@ -5,8 +5,10 @@
   using osu.Framework.Allocation;
   using osu.Framework.Audio;
   using osu.Framework.Audio.Sample;
  +using osu.Framework.Extensions.Color4Extensions;
   using osu.Framework.Graphics;
   using osu.Framework.Graphics.Containers;
  +using osu.Framework.Graphics.Effects;
   using osu.Framework.Graphics.Shapes;
   using osu.Framework.Graphics.Sprites;
   using osu.Framework.Graphics.Transforms;
  @@ -134,6 +136,14 @@ private void load(OsuColour colour, AudioManager audio)
                       Anchor = Anchor.BottomLeft,
                       Origin = Anchor.BottomLeft,
                       Colour = colour.ForStarDifficulty(Math.Max(difficulty, 0.1)),
  +                    EdgeEffect = difficulty < OsuColour.STAR_DIFFICULTY_DEFINED_COLOUR_CUTOFF
  +                        ? default
  +                        : new EdgeEffectParameters
  +                        {
  +                            Type = EdgeEffectType.Glow,
  +                            Colour = colour.ForStarDifficultyText(difficulty).Opacity((difficulty - OsuColour.STAR_DIFFICULTY_DEFINED_COLOUR_CUTOFF) / (10 - OsuColour.STAR_DIFFICULTY_DEFINED_COLOUR_CUTOFF) / 2),
  +                            Radius = 4
  +                        },
                       Height = 0
                   });
  
  ```
  
  as a bonus but I'm not that confident in myself.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2026-04-20 23:50:25 +09:00
  c148e2056e
• Stop all samples when exiting ranked play results screen early (#37427)

  Intends to close https://github.com/ppy/osu/issues/37408.
  
  I have got to say, the way ranked play apparently re-invents screen
  sub-stacks *again* in a slightly different way to everything else before
  had me *very* confused as to why things I would expect to get called
  aren't getting called.

  Bartłomiej Dach · 2026-04-20 22:32:59 +09:00
  8691004499
• Fix crash when dragging card as discard phase ends (#37419)

  Closes: #37402
  
  Issue was `HandOfCards.CardContainer.Compare` working under the
  assumption that the it would never be called with the same child for
  both entries, which can happen when doing a `BinarySearch` (called in
  `RemoveInternal`).
  This lead to `IndexOf` returning a negative value despite the card being
  present in the container, and the drawable getting disposed but not
  actually removed.
  
  I also included a precautionary `cardContainer.Sort()` call before the
  removal as well, seemed to work without that from testing but better not
  rely on that.
  
  TLDR: card container child sorting was unstable due to poor assumptions

  maarvin · 2026-04-20 10:58:27 +02:00
  11f01113a1
• Unify damage multiplayer formatting (#37366)

  Previously the current stage overlay would not display the decimal part
  of the damage multiplier.
  
  Resolves #37357.

  Krzysztof Gutkowski · 2026-04-20 09:28:38 +02:00
  10543e6b8f
• Avoid recomputing full path vertices in SliderPath when possible (#36285)

  In some cases `SliderPath.GetPathToProgress` used to compute the whole
  path when it can be not needed since it can be already stored inside
  `calculatedPath` list.
  Also some of these use cases will no longer require additional array
  wheen only readonly access is all we need.

  Andrei Zavatski · 2026-04-17 21:35:27 +09:00
  b36f8f9c47
• Ranked Play: Work around rating data not always including user (#37310)

  Fixes
  https://discord.com/channels/188630481301012481/188630652340404224/1493678774540304505
  
  The rating distribution is updated once every 5 minutes, so there are
  periods where it may not include the local user's rating. This is simply
  a workaround where it's considered if it's bounded by it.
  
  Am a little surprised this is as easy to handle as it appears to be,
  even if not the cleanest presentation (it's an edge case).

  Dan Balasescu · 2026-04-16 14:36:02 +09:00
  e6a74fd1f3
• Ranked Play: Fix stutter when entering queue screen (#37295)

  The panels look up the online APIUser models. Maybe I could do this by
  doing the lookups async inside `RankedPlayMatchPanel`, but this will
  probably do for now?

  Dan Balasescu · 2026-04-15 01:10:07 +09:00
  daff79b1d3
• Add additional information to the matchmaking queue screen (#37229)

  - [x] Depends on https://github.com/ppy/osu/pull/37226
  - [x] Depends on https://github.com/ppy/osu-server-spectator/pull/464
  
  This adds two new components to the queue screen:
  - A listing of the most recently completed matches (global).
  - A rank distribution graph.
  
  It looks something like this (fake data / test scene):
  
  <img width="1669" height="1005" alt="image"
  src="https://github.com/user-attachments/assets/caa57119-4267-4c6e-9898-2f414de865bf"
  />
  
  It's completely dev-design(TM), but I used Lichess as inspiration for
  the graph, and the original design document as inspiration for the
  panels.
  
  As for the history, because these are _completed_ matches one of the
  player life points will always be 0, but I've designed it so as to
  possibly support showing ongoing matches too in the future. It's only
  supported for ranked play right now, though there is no reason we
  couldn't track quick play rooms too (it's just... I'm not sure how to
  design the panels for quick play).
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Dan Balasescu · 2026-04-14 10:54:54 +09:00
  ac620ee375
• Add matchmaking profile badge (#37241)

  Using the same styling as osu!web + daily challenge.
  
  <img width="1920" height="1034" alt="Screenshot_20260409-164600"
  src="https://github.com/user-attachments/assets/97e2270e-af9f-478d-b2d6-c9fb8be16720"
  />
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Dan Balasescu · 2026-04-09 19:25:21 +09:00
  93b7c3324d
• Make RankedPlayColourScheme properly static (#37244)
  Dean Herbert · 2026-04-09 18:22:32 +09:00
  b838564039
• Fix footer buttons still being able to fire their action when temporarily hidden by overlay content (#37231)

  In human words: I read [this forum
  thread](https://osu.ppy.sh/community/forums/topics/2195138?n=1) today
  and was horrified to see the user there opening the F3 options menu in
  song select *when the F1 mod overlay was pulled up*, which is (a) not
  intended UX, (b) looks terrible, and (c) just wrecks the game
  behaviourally wholesale from start to end.
  
  So with this change you don't get to open options via F3 while inside
  mod overlay at all.
  
  The `Action` shadowing is pretty ugly but I don't have better ideas.
  Initially I tried to mess with `Enabled` (as I did once previously, see
  https://github.com/ppy/osu/commit/36628e24f92c286b87c118c7c1bb9bc582895571),
  but it's much more complicated in this case because the enabled state
  needs to be restored when the buttons reappear, or it could change
  independently while the buttons are temporarily hidden, etc. So I'd
  rather just not deal with all that and invent a parallel scheme.

  Bartłomiej Dach · 2026-04-08 00:40:50 +09:00
  97ddc8e160
• Add ability to search for users (#37225)

  This was a private request for roundtable event usage. It’s also a
  common feature request, so I decided to spend a bit of time getting this
  working well-enough.
  
  
  https://github.com/user-attachments/assets/acceb57f-2979-43d0-9fc2-33e977bd2dd5
  
  
  ---
  
  ### Delay loading spinner / loading layer initial load briefly to avoid
  flickering
  
  There's cases in this overlay where loading takes a few milliseconds.
  The loading spinner gets annoying. This also happens elsewhere, so this
  could be considered a global fix. Separate PR? probably...
  
  ### Ingest loading state of dashboard child content to show more correct
  loading layer
  
  Each display had their own loading layer implementation, but this is
  already too deep (inside the scroll content) and doesn't display great
  when for instance, results don't take up the full screen height.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-04-07 14:14:49 +02:00
  c570db6c40
• Add method for silently dismissing progress notifications without completion (#37227)

  This was used in one place, but I foresee this being a more common
  scenario. This also fixes an edge case where the dismiss process would
  fail if completion happened on an async thread before the
  `NotificationOverlay`'s scheduler could handle the initial ingress.

  Dean Herbert · 2026-04-07 13:43:14 +02:00
  a3a530c25d
• Ranked play general UI/UX fixes (#37220)
  Dean Herbert · 2026-04-07 15:33:29 +09:00
  e80e5f37ec
• Ranked Play: fix cards not going all the way off-screen (#37222)

  `RankedPlaySubScreen.CenterColumn` had a padding which moved the card
  hand up slightly, causing it to not fully dissapear when contracting.
  
  The padding doesn't serve any purpose anymore (remnant of the very early
  versions of the screens), so I just removed it.
  I checked against `DiscardScreen`, `PickScreen`, `OpponentPickScreen` &
  `EndedScreen` to make sure this doesn't cause any layout breakage.
  
  Also removed the `ButtonsContainer` since it isn't being used anywhere
  anymore.
  
  
  https://github.com/user-attachments/assets/2fd32407-fbf7-45a3-b92a-0730a0f8a3fd

  maarvin · 2026-04-06 23:05:42 +09:00
  ea0c04ae4f
• Turn tests green, for a short while, maybe (#37218)

  ## [Rewrite `BackgroundMusicManager` to not run into framework
  breakage](https://github.com/ppy/osu/commit/622216d8911832c39fa4e126b2810e4e0f46cbf7)
  
  The attempted proper fix to this was
  https://github.com/ppy/osu-framework/pull/6727. Unfortunately when
  presented with [the framework
  bump](https://github.com/ppy/osu/pull/37217) with that change, CI says
  "you're stupid" and fails on some disposal idiocy that of course is
  undebuggable and irreproducible:
  
  The active test run was aborted. Reason: Test host process crashed :
  Unhandled exception. System.AggregateException: One or more errors
  occurred. (Object reference not set to an instance of an object.)
  ---> System.NullReferenceException: Object reference not set to an
  instance of an object.
  at osu.Framework.Audio.Sample.SampleChannelBass.Dispose(Boolean
  disposing)
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  	--- End of stack trace from previous location ---
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task&
  currentTaskSlot, Thread threadPoolThread)
  	   --- End of inner exception stack trace ---
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Threading.AudioThread.OnExit()
  at osu.Framework.Threading.GameThread.setExitState(GameThreadState
  exitState)
  	   at osu.Framework.Threading.GameThread.RunSingleFrame()
  at osu.Framework.Threading.GameThread.<createThread>g__runWork|70_0()
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  	--- End of stack trace from previous location ---
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  
  
  (https://github.com/ppy/osu/actions/runs/24019928154/job/70046733058?pr=37217#step:5:119)
  
  I no longer have the energy for any of this shit.
  
  @nekodex would appreciate if you could check that I actually haven't
  broken anything with the bgm here. Seems okay to me in test scenes at
  least.
  
  ## [Apply lowest-effort maybe-fixing changes to a bunch of flaking
  tests](https://github.com/ppy/osu/commit/7bd3ca4adfcce5b90add11565a13f3fe9177ad5e)
  
  None of the failures are reproducible locally, of course. I'm tired of
  this. If anyone else wants to subject themselves to actually
  investigating any of these, by all means, godspeed and good luck.

  Bartłomiej Dach · 2026-04-06 17:59:39 +09:00
  809298ddeb
• Add current stage overlay to ranked play (#37202)

  Displays the stage name and details like currently picking player
  and damage multiplayer where applicable.
  
  Currently only shown on the discard and pick stages.
  
  # Move user retrieval to `RankedPlayScreen`
  
  This is done because I need the relevant `APIUser` instances in order to
  pass them to the overlay component. `RankedPlayScreen` seems like the
  appropriate place to manage the overlays since it manages the stage
  subscreens, hence the need to access the `APIUser`s in here.
  
  # Add current stage overlay to ranked play
  
  The actual change of this PR. Very much a dev design.
  
  
  https://github.com/user-attachments/assets/2388e934-2fc7-4e15-9947-9f98412765d2
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Krzysztof Gutkowski · 2026-04-06 03:00:58 +09:00
  9a56aed1e9
• Display beatmap state in RankedPlayUserDisplay (#37188)

  This has gone through a few iterations, and eventually ended up as a
  simple text percentage display next to the username. I feel that adding
  another progress bar right next to the big healthbar would make things
  too cluttered, and trying to move the beatmap state elsewhere would make
  it too disconnected from the players that are potentially downloading a
  beatmap.
  
  I considered making the local user fetch download progress data using
  `BeatmapDownloadTracker` instead of relying on `BeatmapAvailability` in
  order to get more frequent updates, but that would add a lot of extra
  complexity for little gain IMO.
  
  
  [Screencast_20260403_095644.webm](https://github.com/user-attachments/assets/85fbd4b8-6b5c-41d2-b29b-c93885f73bb3)

  Krzysztof Gutkowski · 2026-04-04 22:05:28 +09:00
  8b69aa9fdb
• Assorted test deflaking (#37191)

  A few quick ones from https://github.com/ppy/osu/issues/37190.
  
  ## [Rewrite `TestSceneDeleteLocalScore` to have less context menu
  containers (and hopefully no longer
  flake)](https://github.com/ppy/osu/commit/ea0bc5b72374056d1749f8058f4874b7ef66a241)
  
  As seen in
  https://github.com/ppy/osu/actions/runs/23890777748#user-content-r3s3.
  
  This is a speculative fix but I'm feeling somewhat confident about this
  one.
  
  `BeatmapLeaderboardWedge` has TWO separate `ContextMenuContainer`s
  itself, and the test mentioned here was bringing a third. I have a
  feeling that the test flaking may have something to do with the fact
  that the test logic would attempt to click a menu item on specifically
  ONE of the three context menus. My bet is that when it fails, it's
  because it's trying the wrong one, but I don't have reproduction.
  
  ## [Wait for text to appear in flaking
  `TestSceneDrawableRoomPlaylist.TestSelectableMouseHandling`
  test](https://github.com/ppy/osu/commit/9d62eea8b56a0eb013e8116db0d38424b500876f)
  
  As seen in
  https://github.com/ppy/osu/actions/runs/23888446400#user-content-r1s1.
  
  Speculative. Banking on the fact that it takes time to load the sprite
  texts.
  
  ## [Remove all tests from `TestSceneWikiMarkdownContainer` dependent on
  existence of wiki on
  dev](https://github.com/ppy/osu/commit/8f319f91c98510b84e915bb61ec147618a584ce1)
  
  Deletes a flaky as seen in
  https://github.com/ppy/osu/actions/runs/23878899702#user-content-r2s2.
  
  The year is 2026 and LLM scrapers hammer [the
  entire](https://sourcehut.org/blog/2025-04-15-you-cannot-have-our-users-data/)
  [internet](https://blog.metabrainz.org/2025/12/11/we-cant-have-nice-things-because-of-ai-scrapers/)
  all over to scrape whatever ounce of Human Content there is left to feed
  the Moloch so that it can regurgitate it back in the form of The Most
  Average Speech You've Ever Read. We are not immune to this, and as such
  the LLM homunculi have hit the dev.ppy.sh wiki instance enough times for
  it to just completely [be banished to the
  blagole](https://www.youtube.com/watch?v=AfA_2Ku1aJY).
  
  Which means I get to freely delete flaky tests that should never have
  been running as part of CI because they're completely useless now and
  it's not like we're ever turning them back on again.
  
  ## [Use equality check in
  `TestSceneBeatmapCarouselScrolling.TestScrollPositionMaintainedOnRemove_SecondSelected`
  that's less sensitive to floating
  point](https://github.com/ppy/osu/commit/6f2a1de58f7e816830c430e89117ee4c594f529d)
  
  As seen in
  https://github.com/ppy/osu/actions/runs/23826420794#user-content-r0s1.

  Bartłomiej Dach · 2026-04-04 00:17:31 +09:00
  090fe44f86
• Adjust multiplayer logic to accommodate for referees spectating in-game (#37152)

  - Last part of / closes
  https://github.com/ppy/osu-server-spectator/issues/406.
  - Remaining work on slots will be tracked in
  https://github.com/ppy/osu-server-spectator/issues/405.
  
  This PR is a corollary of
  https://github.com/ppy/osu-server-spectator/pull/453 and all of the
  dispensations referee users in a multiplayer have received therein. The
  goal here is to allow access to all relevant room management functions
  even if the referee in question isn't host, as well as to disallow
  access to all non-relevant functions to do with the actual match
  gameplay.
  
  I'm not going to lie, this logic *is* ugly. I would argue that it
  already *was* ugly on `master` and my goal was to operate with as light
  a touch as possible myself. But you could see this as copping out and
  that I should try to refactor some of this. I will try - but only after
  someone else's seen the initial approach and deemed it unsuitable.
  
  The logic in `MatchStartControl` is awful - there are so many moving
  pieces of state that dictate what can happen when with all the buttons,
  and yes, I am making it worse here.
  
  This time there is some test coverage. Not everything is covered, but
  the coverage should be on par in all components and pieces of relevant
  logic I touched that already had tests covering them. On that note,
  please forgive the diffstat size, but the tests *are* most of that size.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2026-04-03 19:38:44 +09:00
  31c1168d76
• Fix osu!mania editor not zooming playfield to match timeline (#37176)

  - Fixes CI failures due to completely wrong test (sorry)
  - Fixes #37167 (oops)

  Dean Herbert · 2026-04-02 12:49:45 +02:00
  e207a42889
• Fix song select dropdowns not being navigable with keyboard (#37158)

  - Closes https://github.com/ppy/osu/issues/31684
  
  Uses the global action variant of up and down for dropdown menus. It is
  already used in multiplayer/playlist room/beatmap navigation and
  gameplay menu overlays.
  
  Comment wording is derived from:
  
  https://github.com/ppy/osu/blob/fc817627e56b7db1c46e2f00fc9a3bd14af51211/osu.Game/Graphics/UserInterface/FocusedTextBox.cs#L73-L74

  Joseph Madamba · 2026-04-01 20:59:47 +09:00
  556be552c3
• Fix replay/spectator scroll text not toggling with Ctrl+H (#37027)

  Intended to add toggle but forgot.
  
  This also fixes https://github.com/ppy/osu/issues/37012 via a convoluted
  refactor of a lot of stuff. The basic overview is:
  
  - Moved all replay overlay concerns out of `HUDOverlay`. We can display
  this above everything confidently (i think).
  - Split out `ReplayOverlay` and `ReplaySettingsOverlay` so the base
  class can handle the visibility, hotkeys and everything that should be
  shared with *all* replay overlay components going forward. `Ctrl+H` is
  supposed to hide any of these kinds of details, and I'm sure we'll add
  more in the future.
  - Reorganised some things in `Player` so the new structure would work.
  Mainly the overlays which add a black layer during fade out.

  Dean Herbert · 2026-04-01 11:29:25 +02:00
  279effe23c
• Ranked Play: Make cards draggable and reorderable (#37157)

  Adds the ability to drag and reorder cards. Card order is preserved
  between rounds and is synchronized between both players (each player can
  see the other player drag around and reorder their cards).
  
  To make this possible I had to rewrite the card layout algorithm to be
  stateless (e0a46fefaf), there wasn't
  really a way around that since I needed a way to calculate a layout
  position based on a card's index. Should hopefully be a lot easier to
  read now though.
  
  Some noteworthy stuff:
  - I didn't really know what the best place to store the card order is,
  so I put it on `RankedPlayCardWithPlaylistItem` since that one will stay
  the same instance per round.
  - To prevent the opponent's cards from dragged into the middle of the
  playfield, only the x axis of the drag gets synchronized for the
  `OpponentHandOfCards` with a fixed y value.
  - I adjusted the replay recorder/player parameters a little. With the
  drag events happening every frame the replay recorder record new frames
  every 25ms and end up dropping half the replay frames per flush
  interval, so I increased the sample interval to 50ms so the buffer size
  matches the sample rate exactly (50ms -> 20 samples per flush every
  1000ms).
  I also increased the buffer size in the replay player a bit so slight
  fluctuations in latency won't make it start to drop frames.
  
  
  https://github.com/user-attachments/assets/b810cb85-db02-4edf-a63e-bfc96cf59665
  
  
  https://github.com/user-attachments/assets/4d2f884d-fcce-4948-9659-fbb314634cb8
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  maarvin · 2026-04-01 18:21:44 +09:00
  c4a49f647f
• "Fix" performance drop caused by changing scroll speed (#37149)

  The fix is just disabling the animation. It works I guess.
  
  ---
  
  - Closes https://github.com/ppy/osu/issues/37042
  
  Currently in Mania, you can change the scroll speed for a brief period
  during the beginning of a song. However this scroll speed change occurs
  over a short period of time, which causes a bunch of extra hit object
  updates, causing major fps and latency drops.
  
  This fix simply replaces the dampening with an immediate scroll speed
  update. Since the scroll speed can only be updated for a short time at
  the beginning of the song, providing immediate visual feedback on the
  scroll speed makes sense to me. However another potential solution would
  be to filter the TimeRange Value updates to keep the gradual scroll
  speed visual change, while greatly reducing the number of updates to the
  hit objects currently on screen.
  
  If there is any feedback I would greatly appreciate it as this is my
  first issue here. I had ran both inspectCode.ps1 and the code formatter
  before creating the merge request. Thank you.
  
  Before fix:
  
  https://github.com/user-attachments/assets/55e30894-7341-414a-af2e-2ec051c3a252
  
  After fix:
  
  https://github.com/user-attachments/assets/c085d33f-c0ae-45dd-8131-e79a5682b9ca
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Austin Moore · 2026-03-31 23:33:53 +09:00
  cbcbc788b8
• Rework ranked play chat to reduce overall area (#37097)

  In discussions, we've come to the conclusion to attempt to use a
  chat-bubble system to minimise the effective area of the chat. In
  particular, the results screen doesn't give us enough space to display
  the full chat box without overlapping the main screen content.
  
  This PR both adds the chat to the results screen, and reworks it to use
  such a bubble system (not sure what to call it, IM style?).
  
  
  https://github.com/user-attachments/assets/a8a88c51-8a9d-4a03-92b6-621112a15a41
  
  - New messages are previewed for 3 seconds.
  - When focusing and unfocusing the textbox, the history moves into
  expanded state (show the most recent 10 messages) or collapsed state
  (fade messages out ASAP).
  
  This is a bit of an initial implementation to get a feel of how it
  behaves, and there's more that can be done such as adding colours,
  improving the transforms, perhaps adding it to the intro screen
  (post-animation) but the structure's a bit weird atm.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Dan Balasescu · 2026-03-31 03:45:47 +09:00
  fc817627e5
• Adjust RankedPlayCard to always show card back (when loading content) (#37129)

  This was mentioned in vivi's feedback. Basically now the card backside
  is always loaded and there, rather than faffing with switching the
  content around.
  
  > Cards have a stale grey background when they are spawning in before
  they get changed into the cards they’re supposed to be. This can be
  changed to the backside of the card or maybe a bright white card. Makes
  it look less placeholdery.
  
  Keeping it simple for now. Can probably hide it when not in use in the
  future.

  Dean Herbert · 2026-03-30 15:48:41 +09:00
  ee2f7a75d7
• Switch online play screens to new header (#37074)

  Specifically the one used on the daily challenge screen. Was bugging me
  that playlists/multi have that old yellow header design used, so I've
  changed it. Will probably come in handy once the footer/leaderboard
  changes are in.
  
  Also localized the headers while at it.
  
  Multiplayer:
  
  
  ![osu_2026-03-23_20-03-22](https://github.com/user-attachments/assets/1f262aea-8bf9-412d-9c4a-89addd65bf38)
  
  Playlists:
  
  
  ![osu_2026-03-23_20-34-18](https://github.com/user-attachments/assets/3f7d349e-7c03-4f56-8e57-1c65ae746235)
  
  The only thing I'm wondering about is whether the detail thing
  (participant count/playlist length) should be using the highlight colour
  here. The old design had them be yellow, but I feel like the pink on
  this one stands out too much.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Krzysztof Gutkowski · 2026-03-25 16:36:18 +09:00
  86ef145f56
• Keep any stateful dropdown menu open on click (#37021)

  Right click is a very obfuscated UX which most users won't find. This
  makes more sense to the average user (probably).
  
  Caveat: clicking away actually sends clicks to underlying UI. This is
  not the case in macOS or windows (locally, same app; globally it still
  sends clicks to other windows).
  
  Coming from https://github.com/ppy/osu/discussions/36926.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-03-21 22:18:02 +09:00
  1016bca280
• Various tournament-minded improvements for multiplayer (#37000)

  https://github.com/user-attachments/assets/042311f1-b8c3-479b-a173-13b93fe2c5cc
  
  - `/roll` command is now supported in multiplayer chat for all players
  (don't need to be a referee).
  - Referees are shown in the room with a special status.
  - Tournament mode rooms can be locked, which prevents users from
  changing team (and slot, whenever those get brought back). When the room
  is locked, the user team indicator shows a padlock icon on top to
  indicate the lock state.
  
  ---
  
  - Related: https://github.com/ppy/osu-server-spectator/issues/406
  
  Grab-bag because I really don't think splitting this into 3 PRs is very
  helpful.
  
  I was going to add an animation for rolling but I had a go on Friday and
  my attempt got more or less the same reception as a wet fart so I'm not
  trying again. Someone else can if so inclined. I have completely lost
  trust in my design senses.
  
  Contrary to stable the roll results are completely ephemeral and go away
  when the room is re-entered. This could be both considered good and bad.
  Not for me to say.

  Bartłomiej Dach · 2026-03-20 18:56:45 +09:00
  43c53b5a8d
• Debounce user offline notifications (#37028)
  Dan Balasescu · 2026-03-19 03:41:58 +09:00
  ed6ec8b417
• Tooling updates (#37031)

  Most of this is as everywhere else, but there's also interesting code
  inspection fixes from the InspectCode bump, so I'll talk about that a
  little.
  
  ## [Fix suspicious equality in
  `Hotkey`](https://github.com/ppy/osu/commit/948136e49e88a721827d54e51c5759fe9aca811d)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/TypeWithSuspiciousEqualityIsUsedInRecord.Global.html
  
  Pretty annoying to fix, nullable array types are a pain. Does look legit
  though.
  
  ## [Fix `StarDifficulty` using inefficient struct
  equality](https://github.com/ppy/osu/commit/2db775ebb0bb9f18de67677ef84b993465d26545)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/DefaultStructEqualityIsUsed.Global.html
  
  This is a dodgy one because there's no real sane way to define equality
  on `StarDifficulty` now that it has difficulty and performance
  attributes jammed into it. So I just basically shut the inspection up
  with a `record` modifier and move on.
  
  Unclear where the equality is used precisely. It's from a global
  inspection. F12 is very unhelpful when trying to track down usages of
  `Equals()`. We definitely have `Bindable<StarDifficulty>` instances and
  those do use equality. Maybe more than that.
  
  ## [Use `nameof` expressions to reference enum member
  names](https://github.com/ppy/osu/commit/aa08175c803bc725f3b15a92174dfe6d1b812d91)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html
  
  Pretty quaint.
  
  ## [Prefer using concrete values over `default` or
  `new()`](https://github.com/ppy/osu/commit/b21ee08d7748be10d42268d5c2eb77369026545d)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/PreferConcreteValueOverDefault.html
  
  I could see this one going both ways, but I'm kinda sold on this
  inspection. Explicit is always better. Saves some allocations in the
  `CancellationToken` cases as well.
  
  ## [Explicitly call `.AsEnumerable()` in some realm
  usages](https://github.com/ppy/osu/commit/c8ce1ecd42b9d8abb8b9e2ab93d471f463e80401)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/PossibleUnintendedQueryableAsEnumerable.html
  
  Not fully sold on this one but it's quick and simple so might as well.
  
  ## [Simplify dictionary removal with single `.Remove()`
  call](https://github.com/ppy/osu/commit/5964ceccea900302df726b7a8ecbf6b74eb2e427)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html
  
  Not much to say.

  Bartłomiej Dach · 2026-03-19 00:05:52 +09:00
  18d4ba5874
• Remove duplicated CollectionDropdown class (#37020)

  Arguably we should just nuke the now playing overlay playlist window
  completely as the functionality was gimped when search was removed. Now
  it doesn't seek to the currently playing track, nor play sequentially,
  nor do anything useful.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-03-18 10:42:01 +01:00
  f84caf1182
• Update lots of packages (#36996)

  It's been a while.
  
  Notes:
  
  - `SharpCompress` usages changed a bit. Manually adjusted these, mostly
  just renames or adjusted parameters.
  - nUnit 3 -> 4 migrated using
  https://gist.github.com/peppy/07994386d793a117350cb5f24b156585. there's
  a mode in this script to update to the newer `Assert.That` syntax but it
  requires fixes and couldn't really be bothered.
  - DeepEqual nuked as the only usage was on a disabled test. The reason
  it's disabled has been merged upstream, but it's failing for other
  (realm) reasons which I don't think is worthwhile to investigate for
  now.
  - This bumps Moq. I think the author is back in a sensible headspace and
  the new version has the stupid shit removed, so probably okay? Nice to
  be on a level playing field with packages for once in a long time.
  - Automapper is silly, but we've discussed this elsewhere.
  - `TestRealmKeyBindingStore` failures are a wildcard, but fixed by using
  a more standardised testing method. Dunno why, don't care.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-03-17 03:58:02 +09:00
  a996261304
• Add replay / spectator mode scrolling text back (#36911)

  As mentioned in https://github.com/ppy/osu/discussions/36883.
  
  This has caught me off-guard a few times.
  
  Was a quick one to make this work like it does on stable. It doesn't fit
  as well as stable because we have a lot of elements at the top of the
  screen, but I think it's better than nothing, as it lets you know you're
  in a replay quick obviously.
  
  I don't think we can easily localise strings with formatting in them
  yet. Maybe using a `MarkdownContainer` or something?

  Dean Herbert · 2026-03-11 11:08:26 +01:00
  d0d5d97cfe
• Fix "Deselect all" mods button becoming enabled when system mods are applied (#36913)

  Closes https://github.com/ppy/osu/issues/36906.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-03-10 12:40:54 +01:00
  14743a14eb
• Fix a few flaky tests

  See failures on https://github.com/ppy/osu/runs/66073876886#r3s1.

  Dean Herbert · 2026-03-07 23:19:13 +09:00
  14ae2312ff