osu-lazer

Unify order of displaying map attributes on mod overlay with SongSelectV2

Bartłomiej Dach · 2025-05-29 11:28:11 +02:00

b20139e9dd

Merge pull request #33266 from bdach/score-correct-processing-status

Fix profile score display logic not matching website

Dean Herbert · 2025-05-27 13:47:52 +09:00

900cef8f20

Remove unused dependency

Dean Herbert · 2025-05-27 02:11:43 +09:00

e1334868e8

Add TODO marking incompatible logic

Chances are this will not be materially noticed anyway because I'm not
even sure that unranked mod scores *can* show up on leaderboards.

Bartłomiej Dach · 2025-05-26 13:22:18 +02:00

bedac98e06

Fix profile score display logic not matching website

Reported via e-mails.

The web-side change that wasn't ported here is
https://github.com/ppy/osu-web/pull/11151. I wanted to port it at the
time but then ran into issues because this logic should *ideally* also
be applied to the beatmap set overlay leaderboards, but those are
hard-glued to `ScoreInfo`, cannot be easily weaned off it to use
`SoloScoreInfo` instead, and I did not want to make `ScoreInfo` even
more of a mess than it already is.

This time I'm just ignoring it and adding a TODO instead because I have
no confidence I will get review eyes on any refactor of the beatmap set
overlay. All I'll say that such refactors would have potentially
beneficial effects on results screens too which also (ab)use
`ScoreInfo`.

Bartłomiej Dach · 2025-05-26 13:11:41 +02:00

90bc8865c9

Remove redundant public specfications in interfaces

Rider EAP being noisy about this now (smoogi will be happy :D).

Dean Herbert · 2025-05-26 17:14:41 +09:00

cb0592d711

Make BeatmapDifficultyCache's returned bindable non-nullable

Dean Herbert · 2025-05-25 22:27:37 +09:00

6500be3f2d

Fix rider EAP new naming inspections

Dean Herbert · 2025-05-25 20:39:55 +09:00

5e3fd7a42a

Merge pull request #33191 from peppy/fix-aggressive-diffcalc

Reduce difficulty calculation churn overheads when using keyboard to iterate quickly at song select

Dan Balasescu · 2025-05-21 20:48:14 +09:00

662cbfcc48

Resolve inspections

Dan Balasescu · 2025-05-21 20:00:05 +09:00

f967091aad

Add very basic transition for DifficultyIcon colour changes

Dean Herbert · 2025-05-20 22:12:03 +09:00

d9c376067d

Merge pull request #33189 from peppy/fix-clock-animation

Fix analog clock animation not animating when hand crosses zero

Bartłomiej Dach · 2025-05-19 09:39:45 +02:00

34e5c7ee42

Fix analog clock animation not animating when hand crosses zero

Pointed out in
[discord](https://discord.com/channels/188630481301012481/188630652340404224/1373836064313180200).

Dean Herbert · 2025-05-19 15:08:15 +09:00

8aedfb81ff

Add confirmation dialog before switching to unstable release stream

Dean Herbert · 2025-05-18 03:57:53 +09:00

b6ce627bc7

Merge pull request #33077 from ohdj/hotfix-showmore-button

Fix fetching too few items per page in profile subsections

Bartłomiej Dach · 2025-05-09 12:08:08 +02:00

37f534a9b1

Revert "Prevent increasing pagination limit on subsequent requests"

This reverts commit 10cb038f12.

ohdj · 2025-05-09 15:23:48 +08:00

c4b650de23

Merge pull request #33070 from ohdj/fix-showmore-button

Fix Show More button may incorrect displayed

Dean Herbert · 2025-05-09 15:23:15 +09:00

68617cda0f

Prevent increasing pagination limit on subsequent requests

ohdj · 2025-05-09 14:09:47 +08:00

10cb038f12

Make hasMore a local variable in UpdateItems

ohdj · 2025-05-09 13:49:29 +08:00

c0361c41f5

Fix Show More button display based on osu-web

ohdj · 2025-05-08 22:36:26 +08:00

c53eb1c647

Use localised strings for user/mapper tags on beatmap set overlay

Bartłomiej Dach · 2025-05-08 08:19:55 +02:00

eca9389f40

Update AdjustedAttributesTooltip.cs

Mods don't necessarily have to change speed, to change beatmap attributes. Also, speed mods don't affect beatmap attributes in mania, making the text misleading.

Marvefect · 2025-04-30 13:01:23 +03:00

3f17d7227a

Merge pull request #32847 from frenzibyte/song-select-v2-sheared-components-changes

Fixes and improvements to existing sheared components

Dean Herbert · 2025-04-30 14:25:28 +09:00

c268dfd99a

Fix weird alignment code in wizard overlay footer content

Salman Alshamrani · 2025-04-29 05:34:10 +03:00

d1c4c65e6d

Fix sheared button alignment in preset popovers

Salman Alshamrani · 2025-04-29 05:34:10 +03:00

72987aa166

Merge pull request #32845 from nekodex/bss-audio-feedback

Add audio feedback to the BSS process

Dean Herbert · 2025-04-25 17:25:12 +09:00

85a5033454

Merge pull request #32922 from peppy/fix-tablet-adjust-precision

Fix tablet settings adjusting with too much precision

Dean Herbert · 2025-04-24 15:23:56 +09:00

4a95973b6e

Merge pull request #32909 from bdach/fix-daily-challenge-marker

Fix daily challenge marker text spacing

Dean Herbert · 2025-04-23 18:24:56 +09:00

0adda23988

Fix tablet settings adjusting with too much precision

Closes https://github.com/ppy/osu/issues/32920.

I don't know if there's going to be other cases of breakage, but from
what I can tell these settings *not* showing infinite precision
representations was a bug with the previous implementation of number
formatting.

Dean Herbert · 2025-04-23 15:40:41 +09:00

8d4d9b7bef

Fix renamed translation keys

Jamie Taylor · 2025-04-23 15:30:41 +09:00

3b80c0af0a

Merge branch 'master' into song-select-v2-wedges-title

Dean Herbert · 2025-04-22 17:35:01 +09:00

ace5f26c0f

Merge pull request #32849 from frenzibyte/song-select-v2-collection-dropdown

Add sheared collection dropdown

Dean Herbert · 2025-04-22 17:31:01 +09:00

bb5c8c85d7

Make mod preset shear buttons take up full width

Dean Herbert · 2025-04-22 17:30:03 +09:00

5e06b3d1b4

Add padding around footer content to avoid sheared overflow

Dean Herbert · 2025-04-22 17:19:16 +09:00

066b036466

Adjust namespaces and naming

Dean Herbert · 2025-04-22 17:03:28 +09:00

ec854f7b7f

Fix daily challenge marker text spacing

Closes https://github.com/ppy/osu/issues/32908.

Have you ever been in a situation wherein you find out you fixed a bug
that you didn't know existed, but that makes *another* bug appear
because it was relying on the other bug? This is where I'm at right now.

But, to start from the top.

`TextFlowContainer.Text` (the setter) is a convenience property that you
use to set the text in one go. Internally it uses `AddText()`:

	https://github.com/ppy/osu-framework/blob/681900ffb70adfeede4e3fa32a69da66252691ee/osu.Framework/Graphics/Containers/TextFlowContainer.cs#L81-L94

`AddText()`'s xmldoc says:

	The \n character will create a new paragraph, not just a line break.
	If you need \n to be a line break, use <see cref="AddParagraph{TSpriteText}(LocalisableString, Action{TSpriteText})"/> instead.

	https://github.com/ppy/osu-framework/blob/681900ffb70adfeede4e3fa32a69da66252691ee/osu.Framework/Graphics/Containers/TextFlowContainer.cs#L226-L239

That's right. This portion of xmldoc was *straight up false* and
*silently broken* before https://github.com/ppy/osu-framework/pull/6556.
If you want to check that out yourself, apply the following patch to
framework:

diff --git a/osu.Framework.Tests/Visual/Containers/TestSceneTextFlowContainer.cs b/osu.Framework.Tests/Visual/Containers/TestSceneTextFlowContainer.cs
index 464f47c2c..e1ad521a7 100644
--- a/osu.Framework.Tests/Visual/Containers/TestSceneTextFlowContainer.cs
+++ b/osu.Framework.Tests/Visual/Containers/TestSceneTextFlowContainer.cs
@@ -180,6 +180,22 @@ public void TestAlignmentIsCorrectWhenLineBreaksAtLastWordOfParagraph(Anchor tex
             });
         }

+        [Test]
+        public void TestSetTextWithNewLine()
+        {
+            AddStep("set text", () => textContainer.Text = "this text\nhas a newline");
+            AddStep("clear and add text", () =>
+            {
+                textContainer.Clear();
+                textContainer.AddText("this text\nhas a newline");
+            });
+            AddStep("clear and add paragraph", () =>
+            {
+                textContainer.Clear();
+                textContainer.AddParagraph("this text\nhas a newline");
+            });
+        }
+
         private void assertSpriteTextCount(int count)
             => AddAssert($"text flow has {count} sprite texts", () => textContainer.ChildrenOfType<SpriteText>().Count() == count);

On `master`, there will be a difference between the first two steps, and
the third. On 2025.321.0, *there will be none*.

My working theory as to why this was always busted is that the
corresponding code that was there before in

	https://github.com/bdach/osu-framework/blob/c31a48178889ca2f9b4d257d2d64915eee90338a/osu.Framework/Graphics/Containers/TextFlowContainer.cs#L454-L458

just straight up ran too late. *The height of the container is being
changed after the flow has laid itself out, without adjusting subsequent
children in any way.*

There is potentially a discussion to be had as to whether the emergent
behaviour of `TextFlowContainer.Text` with respect to `\n` character is
correct, but I'm just going to start with this diff and see what the
reaction is.

Bartłomiej Dach · 2025-04-22 08:52:01 +02:00

5895a8ac49

Remove padding from ShearedButton for better sheared flow alignment

Salman Alshamrani · 2025-04-18 07:23:39 -04:00

62b96466c4

Add beatmap title wedge

Salman Alshamrani · 2025-04-18 06:41:51 -04:00

04fa95d924

Merge pull request #32820 from peppy/global-audio-offset-control-fixes

Fix global offset adjust control showing adjustment available when it shouldn't

Dean Herbert · 2025-04-18 18:04:18 +09:00

21fd4e857f

Move number formatting to extension method and reuse for AudioOffsetAdjustmentControl

Also adds some basic test coverage.

Dean Herbert · 2025-04-18 17:30:31 +09:00

e44b134552

Fix global offset adjust control showing adjustment available when it shouldn't

Audio offset is integer based in configuration, so let's make sure not
to show that there's an applicable offset when the value difference is
too low.

I've also fixed rounding to match expectations (`AudioOffset` is
precision limited to integer), and handled the case where a user adjusts
the slider but also has a suggested offset – previously it would not
enable the button after slider adjustments but now it will work as
expected.

Dean Herbert · 2025-04-16 20:21:50 +09:00

51ad6289ca

Add keywords for converted setting

Dean Herbert · 2025-04-16 19:41:48 +09:00

6021d85e63

Change global shear definition to be a Vector2

Saves having this defined in 20+ places. If we ever make any changes to
shear, it's 100% going to need to be applied to every usage (there will
never be a case of multiple different shears in the game).

Also fixes a mismatching definition in `ShearedNub`.

Dean Herbert · 2025-04-16 18:01:08 +09:00

7a8e96f322

Merge pull request #32799 from peppy/middle-click-closes-channels

Add support for closing chat channels with middle click

Bartłomiej Dach · 2025-04-14 09:17:52 +02:00

b214539929

Add support for closing chat channels with middle click

Closes https://github.com/ppy/osu/issues/32797.

Dean Herbert · 2025-04-14 15:30:40 +09:00

f4cb3a7fb3

Fix status pill animating from zero height

Dean Herbert · 2025-04-10 20:11:04 +09:00

69035ef48f

Fix success rate / points of failure not showing for unranked beatmaps on beatmap info overlay

Joseph Madamba · 2025-04-09 11:41:20 -07:00

bfc6d61e5d

Move key binding string retrieval to RealmKeyBindingStore

Dean Herbert · 2025-04-09 15:23:55 +09:00

9e90f80ab5

Merge pull request #32679 from bdach/playlist-hacksawing

Remove filtering & rearranging controls from now playing overlay

Dean Herbert · 2025-04-07 23:07:39 +09:00

10abd55a15

Merge pull request #32678 from bdach/prev-next-weirdness

Fix weird behaviour when skipping back and forth with shuffle enabled

Dan Balasescu · 2025-04-07 21:11:16 +09:00

19f761b125

10437 Commits