46987 Commits

• Move state updates to separate method and flow
  Dean Herbert · 2025-06-04 15:45:40 +09:00
  4fcdfa2cfc
• Ensure valid ruleset for gameplay
  Dean Herbert · 2025-06-04 15:45:40 +09:00
  c73ef15ebf
• SongSelectV2: Simplify and standardise selection logic

  Before attempting to fix issues with invalid selections reaching
  gameplay, I needed to do a pass of the song select class as selection
  logic was already more complex than I'd hope.
  
  All operations now go through a single flow (`SelectAndRun`) when
  leaving the song select screen in a "success" state.

  Dean Herbert · 2025-06-04 15:45:40 +09:00
  12d3952905
• Merge pull request #33373 from peppy/song-select-v2-more-sane-input-padding

  SongSelectV2: Store input padding adjustments in `CarouselItem` to allow more reliable inflation

  Bartłomiej Dach · 2025-06-04 07:41:18 +02:00
  3624c251a2
• Update one more inline comment
  Bartłomiej Dach · 2025-06-03 15:14:56 +02:00
  367b6727cd
• Remove local manifestation of beatmap sets now that set items is always populated

  Since 4d33602.

  Dean Herbert · 2025-06-03 22:03:12 +09:00
  4a4991e348
• Fix negative input lenience being applied to overlapping panels
  Bartłomiej Dach · 2025-06-03 14:28:41 +02:00
  ad251d701e
• Use UTF-8 encoding when exporting skin archives

  Closes https://github.com/ppy/osu/issues/33337.
  
  See also: https://github.com/ppy/osu/pull/28034#issuecomment-2084450285

  Bartłomiej Dach · 2025-06-03 13:54:54 +02:00
  fe325ba861
• Fix non-matching corner radii
  Dean Herbert · 2025-06-03 18:28:38 +09:00
  88fb08851f
• Merge pull request #33389 from peppy/song-select-v2-fix-background-dim-on-resume

  SongSelectV2: Fix background dim not being applied correctly when returning to screen

  Bartłomiej Dach · 2025-06-03 11:22:14 +02:00
  732451279b
• Merge pull request #33378 from peppy/song-select-v2-fix-background-loading

  SongSelectV2: Fix backgrounds taking too long to load due to model backed drawable

  Bartłomiej Dach · 2025-06-03 10:10:55 +02:00
  a1b03cb7fa
• Update inline comments to add clarity to implementation details
  Dean Herbert · 2025-06-03 15:57:54 +09:00
  429c9d42c1
• Merge pull request #33381 from peppy/song-select-v2-fix-unstable-positioning

  SongSelectV2: Fix unstable positions of panels when scrolling

  Bartłomiej Dach · 2025-06-03 08:55:46 +02:00
  6f9179ed53
• Fix PanelBeatmapStandalone having too much horizontal offset on selection
  Dean Herbert · 2025-06-03 15:32:07 +09:00
  097d02e750
• SongSelectV2: Fix background dim not being applied correctly when returning to screen
  Dean Herbert · 2025-06-03 15:20:46 +09:00
  21c06a7fbd
• De-duplicate logic which is applies when arriving/leaving song select

  Standardises all the logic which is applied in both directions –
  entering/resuming and suspending/exiting.

  Dean Herbert · 2025-06-03 15:20:09 +09:00
  7af6acb17f
• Fix null reference in some test scenes
  Dean Herbert · 2025-06-03 14:45:57 +09:00
  8a12935577
• SongSelectV2: Add padding to avoid overlap between mods button and personal best
  Dean Herbert · 2025-06-03 02:06:20 +09:00
  d2452ca25f
• Bring back missing logic to avoid stutters when scrolling

  Again, I don't know why the new implementation didn't just draw from the
  old which was known to work. This mostly matches what was there in v1.

  Dean Herbert · 2025-06-03 01:22:02 +09:00
  fa4c72887f
• Fix unstable x positions when scrolling carousel
  Dean Herbert · 2025-06-03 01:15:49 +09:00
  13cf927922
• Fix unstable y positions when panels are displayed on scroll
  Dean Herbert · 2025-06-03 01:15:48 +09:00
  e2bbe49ca0
• Add basic delay before beginning background load to avoid load on large scroll
  Dean Herbert · 2025-06-03 00:46:34 +09:00
  920eec2c58
• SongSelectV2: Fix backgrounds taking too long to load due to model backed drawable
  Dean Herbert · 2025-06-02 23:19:22 +09:00
  7ffead6878
• Store input padding adjustments in CarouselItem to allow more reliable inflation
  Dean Herbert · 2025-06-02 19:11:47 +09:00
  90b9fb0809
• Merge pull request #33354 from peppy/song-select-v2-fix-random-difficulty-filtered

  Fix random selection potentially selecting a filtered-away beatmap

  Bartłomiej Dach · 2025-06-02 11:59:59 +02:00
  9554732958
• Fix multiple incorrect behaviours due to reliance on dictionary init state
  Dean Herbert · 2025-06-02 18:10:59 +09:00
  ea2eded6e1
• Merge pull request #33353 from peppy/song-select-v2-polish-3

  SongSelectV2: Various polish, pass 3

  Bartłomiej Dach · 2025-06-02 10:56:25 +02:00
  f9aeef0e21
• Merge branch 'master' into fix-dir-breadcrumbs-buttons-double-click-sound
  Bartłomiej Dach · 2025-06-02 10:09:14 +02:00
  cb6334008d
• Merge branch 'master' into song-select-v2-polish-3
  Bartłomiej Dach · 2025-06-02 10:00:06 +02:00
  42ab6fbcb3
• Merge branch 'master' into song-select-v2-fix-random-difficulty-filtered
  Bartłomiej Dach · 2025-06-02 09:57:05 +02:00
  d819dfc180
• Merge pull request #33328 from frenzibyte/ssv2-placeholder-atmosphere

  Duck music and dim background when "no results" placeholder is visible

  Dean Herbert · 2025-06-02 16:56:03 +09:00
  bd4e95eb64
• Fix directory breadcrumb buttons playing clicking sounds twice
  Joseph Madamba · 2025-06-02 00:27:39 -07:00
  b7eba1bdc8
• Don't touch beatmap background
  Dean Herbert · 2025-06-02 16:02:32 +09:00
  b56fd5b4b4
• Fix accent colour not always propagating to statistics display
  Dean Herbert · 2025-06-01 15:12:05 +09:00
  e1ebb7ccca
• Fix random selection potentially selecting a filtered-away beatmap
  Dean Herbert · 2025-06-01 00:58:56 +09:00
  4d33602ccd
• Fix clicking song select search links not working
  Dean Herbert · 2025-05-31 14:06:56 +09:00
  b650309706
• Fix footer buttons handling input in non-sheared space
  Dean Herbert · 2025-05-31 14:04:35 +09:00
  914abd1c25
• Merge pull request #33348 from bdach/song-select-v2-gap-between-beatmap-panel-and-set-panel

  SongSelectV2: Fix input gap between last beatmap panel in set and next set panel

  Dean Herbert · 2025-05-31 12:07:58 +09:00
  ccb47baa8c
• Merge pull request #33345 from bdach/song-select-v2-human-fuzzers

  SongSelectV2: Fix more crashes resulting from users deliberately trying to break things

  Dean Herbert · 2025-05-31 11:46:07 +09:00
  b569de3343
• Duck music and dim background when "no results" placeholder is visible
  Salman Alshamrani · 2025-05-31 03:23:02 +03:00
  59045c8bca
• SongSelectV2: Fix more crashes resulting from users deliberately trying to break things

  See https://github.com/ppy/osu/issues/33336#issuecomment-2922443444.
  
  Can't wait for even more human fuzzing to come later.

  Bartłomiej Dach · 2025-05-30 19:54:49 +02:00
  d2abfe4370
• Merge pull request #33321 from peppy/song-select-v2-scroll-to-selected

  SongSelectV2: Fix scroll to selected not always scrolling

  Dean Herbert · 2025-05-31 02:46:39 +09:00
  28342c51b1
• SongSelectV2: Fix input gap between last beatmap panel in set and next set panel
  Bartłomiej Dach · 2025-05-30 19:13:42 +02:00
  f462c683ee
• Merge pull request #33333 from nekodex/rank-display-sfx

  Adds SFX for rank changes to the in-game rank display

  Dean Herbert · 2025-05-31 01:21:00 +09:00
  d18efc9ab4
• Fix abhorrently incorrect bindable usage
  Dean Herbert · 2025-05-31 00:41:28 +09:00
  43b7171f5c
• Update resources
  Dean Herbert · 2025-05-30 23:12:53 +09:00
  1b9d6dab2e
• Merge pull request #33338 from nekodex/songselect-v2-sfx-fixes

  SongSelectV2: Fix some missing/incorrect SFX

  Dean Herbert · 2025-05-30 22:14:26 +09:00
  b597f3eb17
• Replace assertion with hard guard

  Closes https://github.com/ppy/osu/issues/33336.
  
  I was worried that doing that was going to cause terminal breakage but
  in testing it does not appear to so I'm just going to do this and call
  it a day.

  Bartłomiej Dach · 2025-05-30 15:05:14 +02:00
  ba1148c59e
• Delay scroll to after children update

  Without it the layout height set does not take effect for the scroll to
  correctly execute.

  Bartłomiej Dach · 2025-05-30 14:49:03 +02:00
  b6fa9c9dca
• Fix selection's carousel Y position being read too early

  `updateItemYPosition()` mutates `item.CarouselYPosition`, so storing
  that to the selections before it's updated is storing stale values.

  Bartłomiej Dach · 2025-05-30 14:49:03 +02:00
  a3db764008