1273 Commits

• Merge pull request #27180 from bdach/better-submission-failure-messaging

  Add better submission failure messaging

  Dean Herbert · 2024-02-19 21:38:23 +08:00
  c87bc8b597
• Add failing tests for beatmap inconsistencies
  Dean Herbert · 2024-02-18 19:32:21 +08:00
  415a65bf59
• Show selected submission failure messages even in solo

  Previously, if a `SubmittingPlayer` instance deemed it okay to proceed
  with gameplay despite submission failure, it would silently log all
  errors and proceed, but the score would still not be submitted. This
  feels a bit anti-user in the cases wherein something is genuinely wrong
  with either the client or web, so things like token verification
  failures or API failures are now shown as notifications to give the user
  an indication that something went wrong at all.
  
  Selected cases (non-user-playable mod, logged out, beatmap is not
  online) are still logged silently because those are either known and
  expected, or someone is messing with things.

  Bartłomiej Dach · 2024-02-15 10:55:08 +01:00
  898d5ce88b
• Fix multiplayer tests
  Dan Balasescu · 2024-02-02 22:34:48 +09:00
  50f9c61029
• Revert unnecessary changes
  Dan Balasescu · 2024-02-02 21:05:50 +09:00
  20ae88b0a0
• Update R# + fix inspections
  Dan Balasescu · 2024-02-02 21:00:28 +09:00
  b44f77cee1
• Merge branch 'master' into 2fa
  Dean Herbert · 2024-01-29 16:57:29 +09:00
  4a2602a775
• Rename PollingChatClientConnector to better describe usage
  Dean Herbert · 2024-01-29 16:56:28 +09:00
  ef94eff574
• Merge branch 'decouple-notification-websocket-from-chat' into 2fa
  Bartłomiej Dach · 2024-01-26 11:21:33 +01:00
  b39b112548
• Make sure the polling connector actually auto-starts itself
  Bartłomiej Dach · 2024-01-26 11:21:23 +01:00
  243c2bc9b4
• Merge branch 'decouple-notification-websocket-from-chat' into 2fa
  Bartłomiej Dach · 2024-01-25 14:51:42 +01:00
  3d3506b906
• xmldoc everything
  Bartłomiej Dach · 2024-01-25 14:47:29 +01:00
  c463aa5ba1
• Decouple notifications websocket handling from chat operations

  This is a prerequisite for https://github.com/ppy/osu/pull/25480.
  
  The `WebSocketNotificationsClient` was tightly coupled to chat specifics
  making it difficult to use in the second factor verification flow.
  This commit's goal is to separate the websocket connection and message
  handling concerns from specific chat logic concerns.

  Bartłomiej Dach · 2024-01-25 14:47:29 +01:00
  de52f0a80c
• Fix OsuGameTestScene not clearing second auth factor
  Bartłomiej Dach · 2024-01-23 17:00:16 +01:00
  5d26afc531
• Update IPC usages

  Of note, I've disabled IPC on visual test runners as we generally don't
  use IPC in these cases. Having it set means that the game will not open
  while visual tests are open, which has been a complaint from devs in the
  past.

  Dean Herbert · 2024-01-18 19:45:36 +09:00
  82e7643df5
• Reduce code duplication in test
  Bartłomiej Dach · 2024-01-08 12:52:14 +01:00
  50eba9ebdb
• ...in a safer way
  Dean Herbert · 2024-01-04 17:13:21 +09:00
  f0aeeeea96
• Fix another realm null inspection
  Dean Herbert · 2024-01-04 17:11:40 +09:00
  df99a37254
• Add mania/osu sudden death mod tests
  Dan Balasescu · 2023-12-22 16:43:09 +09:00
  88a5ba8167
• Add failing tests
  Dan Balasescu · 2023-12-22 13:58:12 +09:00
  9c35e25036
• Update currently online display tests
  Bartłomiej Dach · 2023-12-06 19:37:35 +01:00
  86e003aec1
• Add test
  Dan Balasescu · 2023-12-01 21:34:20 +09:00
  f3530a79b1
• Rename LoadAborted -> GameplayAborted, AbortGameplayReal -> AbortMatch
  Dan Balasescu · 2023-12-01 18:26:59 +09:00
  a94180c8c6
• Add initial support for aborting multiplayer games
  Dan Balasescu · 2023-12-01 15:31:06 +09:00
  894c31753b
• Merge pull request #25522 from bdach/no-concurrent-connections

  Implement flow allowing disconnection from online services when another client instance for same user is detected

  Dean Herbert · 2023-11-28 19:09:38 +09:00
  537c9e031d
• Merge branch 'master' into scoring-test-mods
  Dean Herbert · 2023-11-28 18:38:50 +09:00
  efb6c30252
• Centralise and improve messaging around online state

  When the server requests a disconnect due to a user connecting
  via a second device, the client will now log the user out on the first
  device and show a notification informing them of the cause of
  disconnection.

  Bartłomiej Dach · 2023-11-21 15:15:46 +09:00
  42fada578e
• Implement client-side disconnection flow
  Bartłomiej Dach · 2023-11-21 15:15:45 +09:00
  1c612e2e0c
• Change ResourceStore provided to Skin to be a fallback, not replacement
  Dean Herbert · 2023-11-16 20:19:01 +09:00
  b88e3cd26f
• Merge pull request #25157 from peppy/spinner-anti-cheese-final

  Fix spinner cheese by accounting for spin directionality

  Bartłomiej Dach · 2023-10-24 08:13:32 +02:00
  0e5a521695
• Fix test clock no longer accounting for rate changes
  Dean Herbert · 2023-10-23 22:28:40 +09:00
  baf4130f3a
• Set ManualClock rate to 0 to avoid interpolation causing test errors
  Dean Herbert · 2023-10-23 20:29:36 +09:00
  15c1fcbf96
• Bypass Parent nullability checks for now
  Dean Herbert · 2023-10-17 17:48:45 +09:00
  5341a335a6
• Merge branch 'master' into multiplayer-invites
  Dean Herbert · 2023-10-12 18:17:15 +09:00
  56e27f1c27
• Remove test scene background stack and use new ChangeBackgroundColour method
  Dean Herbert · 2023-10-12 14:08:31 +09:00
  194ad9650d
• Apply mod multipliers to local score V1/V2 reimplementations
  Bartłomiej Dach · 2023-10-09 13:04:12 +02:00
  d7e891140d
• Apply mods to processor-based score algorithms
  Bartłomiej Dach · 2023-10-09 12:59:02 +02:00
  419cc8784a
• Add mod controls to scoring test scene
  Bartłomiej Dach · 2023-10-09 12:59:02 +02:00
  55064c387d
• Add Invited task to multiplayer client
  Marvin Schürz · 2023-10-02 22:53:28 +02:00
  574dc67a9e
• Merge branch 'master' into mania-edit-disable-sv
  Dean Herbert · 2023-09-20 14:23:07 +09:00
  c5397bdbb3
• Merge pull request #24450 from cdwcgt/missing-beatmap

  Fetch missing beatmap when importing replay

  Dean Herbert · 2023-09-19 18:40:02 +09:00
  067c487b21
• Merge pull request #24831 from peppy/update-deps

  Update all dependencies (except for Moq)

  Bartłomiej Dach · 2023-09-19 07:50:27 +02:00
  0ffb906741
• Merge pull request #24823 from bdach/scoring-test-scene-catch

  Add scoring test scene for catch

  Dean Herbert · 2023-09-19 13:59:11 +09:00
  aba98f2985
• Fix crash when loading player instance without exiting previous instance
  Salman Ahmed · 2023-09-19 05:09:01 +03:00
  8e992de763
• Fix OsuTestScene.CreateAPIBeatmapSet() not backlinking set beatmaps to the set
  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  47764b3012
• Update all dependencies (except for Moq)
  Dean Herbert · 2023-09-16 15:37:31 +09:00
  56b5f52e83
• Add example scenarios and configurable score multiplier
  Bartłomiej Dach · 2023-09-15 12:58:29 +02:00
  ebdc501e5b
• Turn off non-perfect judgements for catch scoring test scene
  Bartłomiej Dach · 2023-09-15 12:58:29 +02:00
  5eccc771c2
• Refactor further to allow extensibility to other rulesets
  Bartłomiej Dach · 2023-09-15 12:58:29 +02:00
  0c22ff2a80
• Minimum viable changes for ruleset-specific scoring test scenes
  Bartłomiej Dach · 2023-09-15 12:58:29 +02:00
  45751dd1f2