Joseph Madamba
4a3b8c405e
Fix login error text adding unnecessary spacing
2023-06-25 11:57:17 -07:00
Joseph Madamba
442fda3598
Remove using aliases
2023-06-25 11:39:33 -07:00
Joseph Madamba
1058f434d7
Update login overlay background to conform to other overlays
2023-06-25 11:39:32 -07:00
Joseph Madamba
25c9bf4061
Improve and refactor LoginPanel test scene to use LoginOverlay
2023-06-25 11:39:32 -07:00
Joseph Madamba
f87ac3f405
Merge remote-tracking branch 'upstream/master' into pr/23331
2023-06-25 10:01:32 -07:00
Bartłomiej Dach
66f1ed052b
Merge pull request #24033 from cdwcgt/chatdisplay-fix
...
Fix tournament chat potentially crashing due to null current match
2023-06-25 18:12:15 +02:00
cdwcgt
1b671b8c6e
Use GetResultSafely()
2023-06-26 00:45:59 +09:00
Bartłomiej Dach
88fbc3094a
Merge branch 'master' into chatdisplay-fix
2023-06-25 17:39:45 +02:00
Bartłomiej Dach
44a3f40188
Rename test step
2023-06-25 17:39:36 +02:00
Bartłomiej Dach
7d9d7066cd
Remove no-longer-needed BDL permitNulls spec
2023-06-25 17:39:15 +02:00
Bartłomiej Dach
9862992af0
Use alternative guard
...
Early-returning from ctors feels pretty bad. Also saves on some
nested accesses.
2023-06-25 17:37:05 +02:00
cdwcgt
14e26d2a85
use BeatmapCache for populate beatmap information
2023-06-25 22:57:39 +09:00
cdwcgt
e02a06e3e5
Revert "remove #nullable disable in LadderInfo"
...
This reverts commit 0dced46100
2023-06-25 22:47:36 +09:00
tsrk
350d722c8d
Merge branch 'master' into hud/kc-skinnable
2023-06-25 15:42:08 +02:00
tsrk
a7088ffe22
revert: bring back old attachment flow
...
As discussed, this would bring more problems that anything.
Refs: 4c39708f83a4f4
2023-06-25 15:21:55 +02:00
Bartłomiej Dach
35d2c0f4cf
Merge pull request #23987 from peppy/no-confirmation-on-update-restart
...
Only require exit confirmation when there are background operations
2023-06-25 15:12:03 +02:00
Bartłomiej Dach
4215ca313f
Add missing using
2023-06-25 14:36:21 +02:00
Dean Herbert
cf43cd2bdc
Rename test scene to match updated class name
2023-06-25 21:26:10 +09:00
Dean Herbert
3d1a8aeb54
Use more understandable cancel button text
2023-06-25 21:25:16 +09:00
Dean Herbert
95e8dd2e8e
Don't attempt to access notifications before loaded
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-06-25 21:25:07 +09:00
cdwcgt
a3cd0d14a3
null guard for Current Match in MatchMessage
2023-06-25 20:46:58 +09:00
cdwcgt
0dced46100
remove #nullable disable in LadderInfo
2023-06-25 20:46:55 +09:00
Bartłomiej Dach
a7202721ff
Merge branch 'master' into no-confirmation-on-update-restart
2023-06-25 13:35:21 +02:00
Bartłomiej Dach
25842105ce
Merge pull request #23976 from peppy/gameplay-sample-trigger-source-correctness
...
Adjust `GameplaySampleTriggerSource` to only switch samples when close enough to the next hit object
2023-06-25 08:23:55 +02:00
Dean Herbert
922fe927ac
Update resources
2023-06-25 15:18:56 +09:00
Bartłomiej Dach
d43131ac88
Merge pull request #24019 from peppy/framework-update
...
Apply required nullability changes in line with framework update
2023-06-25 06:43:21 +02:00
Dean Herbert
5806153cfd
Update framework
2023-06-25 12:00:14 +09:00
Bartłomiej Dach
f8d2f2f7e1
Fix more issues discovered by CI that can be fixed game-side
2023-06-24 19:04:05 +02:00
Bartłomiej Dach
d7ae430ec2
Merge branch 'master' into framework-update
2023-06-24 18:47:52 +02:00
Bartłomiej Dach
511451770c
Merge pull request #24021 from peppy/mass-nrt
...
Apply NRT to all files where it can be easily applied
2023-06-24 18:31:32 +02:00
Dean Herbert
ca402c4d2f
Update framework
2023-06-25 00:38:19 +09:00
Salman Ahmed
9a5f033a0f
Change OpenUserProfile argument type to always use IUser
2023-06-24 18:12:35 +03:00
Bartłomiej Dach
e273c223a8
Fix some more missed CI inspections
2023-06-24 17:11:38 +02:00
Bartłomiej Dach
df2dcf85b4
Fix wrong disable
2023-06-24 17:07:42 +02:00
Bartłomiej Dach
34e2540331
Fix nullability-related warnings in Android project
2023-06-24 17:05:52 +02:00
Bartłomiej Dach
e3a89a6273
Fix remaining obvious CI inspections
2023-06-24 16:07:01 +02:00
Bartłomiej Dach
caf5673b68
Revert nullability enables in tournament client
...
Not trivial to fix right now and I'm not fixing in a 1k-line changeset.
2023-06-24 16:05:19 +02:00
Bartłomiej Dach
2c1a44da89
Revert nullability enable in BeatmapBackground
...
Due to varying expectations in handling of `Beatmap`. Some places allow
or expect null and some don't. Needs to be looked at closer separately.
2023-06-24 15:40:06 +02:00
Bartłomiej Dach
66ef199fa4
Revert nullability enable in Score (and related changes)
...
Causes several knock-on inspections in `OsuGame` et al. Probably best
addressed in a separate pass, because treatment is mixed at best (some
places nullcheck, some expect non-null).
2023-06-24 15:35:07 +02:00
Bartłomiej Dach
8fdd599b39
Match field NRT annotation in ctor argument
2023-06-24 15:17:14 +02:00
Bartłomiej Dach
1f2f522a1e
Mark override as null-accepting
...
`ModelBackedDrawable<T>.CreateDrawable()` is R#-annotated to accept
a potentially null model. Apply nullability there too for better reading
experience.
2023-06-24 15:07:04 +02:00
Bartłomiej Dach
354e85a2e1
Trim redundant BDL nullability spec
2023-06-24 14:35:23 +02:00
Dean Herbert
2bda63c2c8
Merge branch 'master' into mass-nrt
2023-06-24 09:59:15 +09:00
Dean Herbert
58e6b3782b
Fix a couple of remaining issues
2023-06-24 09:58:36 +09:00
Dean Herbert
3585c3f1d5
Apply required nullability changes
2023-06-24 09:58:36 +09:00
Bartłomiej Dach
23aa1752c3
Merge pull request #24009 from peppy/fix-touch-input-controls-floating-fruits
...
Change "floating fruits" mod to only apply adjustments to the playfield
2023-06-23 23:26:20 +02:00
Salman Ahmed
318260bbfd
Merge pull request #23890 from cdwcgt/tournament-chatcolor
...
Tint username of team members in tournament chat according to the team colour
2023-06-23 23:22:40 +03:00
Salman Ahmed
ff17685bc3
Fix OpenUserProfile links having multiple argument types
2023-06-23 22:38:16 +03:00
Salman Ahmed
c5771912db
Merge branch 'master' into tournament-chatcolor
2023-06-23 22:23:33 +03:00
Salman Ahmed
7a771609f9
Reword and fix typo
2023-06-23 22:20:25 +03:00
