Dean Herbert
c935d3bf6c
Reduce font size in channel listing too
2024-05-03 14:00:28 +08:00
Joseph Madamba
c21b7c7df9
Use IsLoaded instead of Schedule
2024-05-02 22:46:42 -07:00
Dean Herbert
058bd5ced6
Stop using visually noisy bg4 for default backgrounds
...
This has always really annoyed me.
2024-05-03 13:38:27 +08:00
Dean Herbert
3249ecee27
Fix chat overlay being far too large
2024-05-03 12:31:19 +08:00
Dean Herbert
aa4d16bdb8
Fix beatmap listing cards being far too large
2024-05-03 12:13:52 +08:00
Joseph Madamba
c15a685071
Remove unused usings
2024-05-02 17:07:49 -07:00
Joseph Madamba
381ddb0676
Fix weird formatting
2024-05-02 17:06:11 -07:00
Joseph Madamba
269077f854
Only support centre anchors
2024-05-02 17:06:11 -07:00
Joseph Madamba
2f075e3247
Apply half margin of tolerance on both sides before text scrolls
2024-05-02 17:06:11 -07:00
Bartłomiej Dach
f78abf801c
Autosave edited skin on change
2024-04-29 14:38:53 +02:00
Joseph Madamba
d4951a093f
Scroll now playing overlay text when overflowing
2024-04-27 20:18:49 -07:00
Joseph Madamba
48c608e016
Make player width a const
2024-04-27 20:06:09 -07:00
Taevas
694e3900db
Add missing space in setup wizard
2024-04-27 23:43:27 +02:00
Dan Balasescu
52addc775e
Merge pull request #27965 from bdach/generic-math
...
Apply generic math-related changes
2024-04-26 01:33:54 +09:00
Dean Herbert
999c8fdc38
Merge pull request #27969 from bdach/enter-to-confirm-keybinding-conflict
...
Allow confirming keybinding overwrite on conflict via "select" binding
2024-04-23 23:38:50 +08:00
Dean Herbert
221af74f95
Merge branch 'master' into generic-math
2024-04-23 22:21:31 +08:00
Bartłomiej Dach
f7626aba18
Fix mod select overlay columns not displaying properly sometimes
...
Closes https://github.com/ppy/osu/issues/26504 .
As far as I can tell the issue is basically another manifestation of
https://github.com/ppy/osu-framework/issues/5129 , i.e. presence
overrides causing dropped invalidations and thus completely bogus
hierarchy state. The fix is to raise the appropriate invalidation
manually.
2024-04-23 13:36:12 +02:00
Bartłomiej Dach
1e0db1ab9f
Allow confirming keybinding overwrite on conflict via "select" binding
2024-04-23 12:44:16 +02:00
Bartłomiej Dach
09b0f3005e
Apply generic math-related changes
2024-04-22 10:15:56 +02:00
Bartłomiej Dach
1344ca4e19
Merge pull request #27780 from mafarrica/27105-fix-mod-search-box-focus-changes
...
Fix mod search box not tracking external changes to focus state
2024-04-19 17:00:06 +02:00
Bartłomiej Dach
509862490e
Revert unnecessary changes
2024-04-19 11:11:18 +02:00
Bartłomiej Dach
2dcbb823ef
Use textbox focus state directly rather than trying to track it independently
2024-04-19 11:08:34 +02:00
Salman Ahmed
a7e043bdbe
Fix beatmap rulest selector playing sound for initial ruleset selection
2024-04-17 11:20:17 +03:00
Salman Ahmed
24e8b88320
Add inline comment to the custom implementation of multiple-selection tab items
2024-04-17 11:20:17 +03:00
Salman Ahmed
42892acc1a
Fix multiple selection filter tab items no longer playing sounds
...
These tab items are not managed by a `TabControl`, activation events are manually served by the class itself toggling `Active` when clicked.
2024-04-17 11:20:17 +03:00
Salman Ahmed
50a21fb727
Change ToolbarRulesetSelector to use SelectItem to trigger new sound feedback path
2024-04-17 11:20:17 +03:00
Salman Ahmed
2a3ae6bce1
Update all TabItem implementations to play select sample on OnActivatedByUser
2024-04-17 11:20:17 +03:00
Bartłomiej Dach
6c943681b0
Fix preview tracks playing after their owning overlay has hidden
...
RFC. Closes https://github.com/ppy/osu/issues/27883 .
The idea here is that `PopOut()` is called _when the hide is requested_,
so once an overlay trigger would hide, the overlay would
`StopAnyPlaying()`, but because of async load things, the actual track
would start playing after that but before the overlay has fully hidden.
(That last part is significant because after the overlay has fully
hidden, schedules save the day.)
Due to the loose coupling between `PreviewTrackManager` and
`IPreviewTrackOwner` there's really no easy way to handle this locally
to the usages of the preview tracks. Heck, `PreviewTrackManager` doesn't
really know which preview track owner is to be considered _present_ at
any time, it just kinda works on vibes based on DI until the owner tells
all of its preview tracks to stop.
This solution causes the preview tracks to stop a little bit later but
maybe that's fine? Just trying to not overthink the issue is all.
No tests because this is going to suck to test automatically while it is
pretty easy to test manually (got it in a few tries on master).
The issue also mentions that the track can sometimes resume playing
after the overlay is pulled up again, but I don't see that as a problem
necessarily, and even if it was, it's not going to be that easy to
address due to the aforementioned loose coupling - to fix that, play
buttons would have to know who is the current preview track owner and
cancel schedules upon determining that their preview track owner has
gone away.
2024-04-16 16:19:26 +02:00
Ondřej Vajďák
ed6680a61d
Fixed type inconsistency and rounding
2024-04-14 15:10:05 +02:00
Ondřej Vajďák
9833dd955f
Fix toolbar volume bar masking
2024-04-14 01:30:59 +02:00
Dean Herbert
c0dce94f15
Fix newly placed items in skin editor not getting correct anchor placement
2024-04-12 17:08:49 +08:00
Mafalda Fernandes
16276dfcd6
Fix #27105 : Mod search box doesnt track external focus changes
...
In the Mod selection area, the search bar's focus could be changed by pressing TAB.
However, when clicking outside of the search bar, the focus would be killed but two TABs were required to get the focus back on the search bar.
This happened because the action of clicking in an empty area would trigger the search bar to change its appearence, but not its internal state.
In my solution, I made the OnClick function aware of the search bar's state, so it would not only change its appearance, but also its state.
Now, after clicking in an empty area, there is only needed one TAB to select the search box again, as expected.
2024-04-03 14:06:11 +01:00
Bartłomiej Dach
05fe8968d8
Only interact with clipboard via bound copy
2024-04-03 11:39:12 +02:00
Dan Balasescu
ce68f6adb7
Fix SkinEditor binding event to external bindable
2024-04-03 17:46:26 +09:00
Dean Herbert
94cbe1838f
Replace usages of is null with == null
2024-04-03 01:50:39 +08:00
Nguyên Minh Hồ
113dbcd10f
Merge branch 'master' into fix-rotate-editor-button-disabled
2024-03-30 13:56:31 +07:00
Dean Herbert
d9cf5b5440
Fix bindable not being correctly re-bound across local user changes
2024-03-29 15:50:10 +08:00
Dean Herbert
fef8afb833
Fix double binding causing game crash after API enters failing state
...
See https://sentry.ppy.sh/organizations/ppy/issues/33406/?alert_rule_id=4&alert_timestamp=1711655107332&alert_type=email&environment=production&project=2&referrer=alert_email
2024-03-29 12:19:14 +08:00
Bartłomiej Dach
d32f19b546
Fix first word bold not applying correctly after first language change
...
Closes https://github.com/ppy/osu/issues/27549 .
I'm not entirely sure why the old solution failed exactly, but also
think it's unimportant because I think past me was an idiot and was
playing stupid games with the juggling of indices between two callbacks
with no ordering guarantees and expecting not to win stupid prizes.
I'm not sure this requires any follow-up reconsiderations of that entire
text flow API, but if opinions differ, I'll re-examine.
2024-03-13 15:18:20 +01:00
Joseph Madamba
e2e99fc5cc
Rearrange rankings overlay tabs to match web
2024-03-12 21:15:59 -07:00
Bartłomiej Dach
09179f99c0
Merge branch 'master' into wrap-beatmap-listing-filters
2024-03-11 14:59:48 +01:00
Bartłomiej Dach
e5e7c8f268
Wrap beatmap listing filter names too
...
While we're here fixing...
Addresses
https://github.com/ppy/osu/discussions/15452#discussioncomment-2734237 .
2024-03-11 14:58:28 +01:00
Andrei Zavatski
26c97ef733
Fix WikiPanelContainer causing poor performance
2024-03-09 00:51:33 +03:00
Joseph Madamba
db1c59475b
Wrap beatmap listing filters and match web spacing
2024-03-08 12:13:54 -08:00
Dean Herbert
c9b4c684e5
Merge pull request #27403 from Gabixel/increase-modselect-initial-scroll
...
Change initial scroll effect to mod columns
2024-03-08 14:00:40 +08:00
Dean Herbert
5e7d9ea04a
Adjust scroll speed back to original
2024-03-08 13:59:04 +08:00
Bartłomiej Dach
644553d5b4
Merge branch 'master' into freemod_mapinfo_fix
2024-03-07 09:24:44 +01:00
Bartłomiej Dach
53fffc6a75
Remove unused using directives
2024-03-06 07:57:59 +01:00
Dean Herbert
06c7483347
Merge branch 'master' into update-framework
2024-03-06 12:36:05 +08:00
Dean Herbert
85364d25dc
Merge pull request #27276 from bdach/medals
...
Add flow for displaying achieved medals
2024-03-06 12:31:55 +08:00
Dean Herbert
b53b752e54
Update usage of MathUtils
2024-03-06 12:13:12 +08:00
Dean Herbert
6455c0583b
Update usage of CircularProgress.Current
2024-03-06 12:13:10 +08:00
Bartłomiej Dach
09c6c5d79b
Merge pull request #27497 from frenzibyte/mod-select-overlay-fix-ux
...
Fix mod select overlay settings order not always matching mod panels
2024-03-05 19:40:13 +01:00
Bartłomiej Dach
429fa8dfae
Merge pull request #27242 from Susko3/log-global-statistics
...
Log `GlobalStatistics` when exporting logs from settings
2024-03-05 19:32:54 +01:00
Salman Ahmed
9543908c7a
Fix mod select overlay settings order not always matching panels order
2024-03-04 23:36:45 +03:00
Dean Herbert
f44aadaaa8
Merge pull request #27331 from bdach/statistics-updates-in-multi
...
Show user statistics updates on multiplayer and playlists results screens
2024-02-29 12:26:48 +08:00
Salman Ahmed
8f97f0503f
Move away from Solo namespace
2024-02-29 01:21:17 +03:00
Salman Ahmed
de48c51715
Apply renaming in remaining usages
2024-02-29 01:11:08 +03:00
Salman Ahmed
4a4ef91bc9
Simplify active mods computation
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-02-29 00:42:52 +03:00
Bartłomiej Dach
a5948d38ac
Merge pull request #27380 from frenzibyte/fix-advanced-stats-display
...
Fix advanced stats in beatmap info overlay showing "key count" on non-mania beatmaps
2024-02-28 18:02:48 +01:00
Bartłomiej Dach
9902dad4c6
Merge branch 'master' into log-global-statistics
2024-02-28 15:09:24 +01:00
Dean Herbert
31f667224f
Merge branch 'master' into medals
2024-02-28 13:48:57 +08:00
Gabriel Del Nero
09dee50372
Change initial scroll animation to mod columns
...
Starting from the end (which should be fine with the current number of columns, even on different/wider screen resolutions), and with a custom decay value when it reaches zero offset.
2024-02-27 15:35:51 +01:00
Dean Herbert
7f0a552b86
Merge pull request #27366 from EVAST9919/mod-overlay-performnce
...
Reduce allocations when `ModSelectOverlay` is visible
2024-02-27 08:54:18 +08:00
Salman Ahmed
3f9fbb9318
Introduce the concept of ActiveMods in mod select overlay and rewrite once more
2024-02-26 22:25:06 +03:00
Salman Ahmed
2b73d816a7
Bring back mod setting tracker in BeatmapAttributesDisplay
2024-02-26 22:24:45 +03:00
Dean Herbert
fe59a3b9be
Merge branch 'master' into medals
2024-02-26 22:49:55 +08:00
Dean Herbert
c686dfd361
Apply safeties for AudioFilter usage around drawables which go non-present
2024-02-26 21:22:25 +08:00
Salman Ahmed
5c049feca1
Fix advanced stats in beatmap info overlay showing "key count" on non-mania beatmaps
2024-02-25 21:18:15 +03:00
Andrei Zavatski
081aa84718
Simplify last footer button selection
2024-02-25 10:36:15 +03:00
Andrei Zavatski
6d2187e079
Reduce allocations in ModSelectOverlay
2024-02-24 22:58:23 +03:00
Andrei Zavatski
3b53ed3c3a
Reduce allocations in ModColumn
2024-02-24 22:44:58 +03:00
Salman Ahmed
d4bc3090e7
Fix incorrect conflict resolution
2024-02-23 18:42:07 +03:00
Salman Ahmed
618819ba9f
Merge branch 'master' into freemod_mapinfo_fix
2024-02-23 18:34:41 +03:00
Salman Ahmed
c1db9d7819
Add test coverage
2024-02-23 18:16:44 +03:00
Salman Ahmed
fdc0636554
General code cleanup
2024-02-23 17:31:54 +03:00
Salman Ahmed
9ce07a96b2
Rewrite mods flow and remove RoomBeatmapAttributesDisplay
2024-02-23 17:30:13 +03:00
Salman Ahmed
323d7f8e2d
Change BeatmapAttributesDisplay retrieval to proper method
2024-02-23 16:59:43 +03:00
Salman Ahmed
ae9c58be30
Remove "multiplayer" references from subclass and move to appropriate place
2024-02-23 16:50:33 +03:00
Brandon
6c8204f9a3
Update delete collections message when none
2024-02-22 19:40:02 -08:00
Brandon
d6beae2ce1
Update delete/restore mod presets message when none
2024-02-22 19:10:15 -08:00
Bartłomiej Dach
eac4c5f69d
Rename {Solo -> User}StatisticsWatcher et al.
...
The "solo" prefix is a bit unbecoming now. The updates are not only
for solo.
2024-02-22 20:36:24 +01:00
Bartłomiej Dach
f9e92c69a8
Merge branch 'master' into fix-skin-editor-init-fail
2024-02-22 14:08:38 +01:00
Bartłomiej Dach
49b7f0e3a7
Merge pull request #26531 from smallketchup82/multiplayer-difficulty-tooltip
...
Implement difficulty tooltips for multiplayer lobbies
2024-02-22 12:57:35 +01:00
Bartłomiej Dach
46c8560ca5
Merge branch 'master' into multiplayer-difficulty-tooltip
2024-02-22 12:08:29 +01:00
Bartłomiej Dach
d06c67ad8f
Substitute two jank interdependent bool flags for single tri-state enums
2024-02-22 12:05:50 +01:00
Bartłomiej Dach
6770b73e4e
Merge pull request #27192 from smoogipoo/mod-search-ignore-whitespace
...
Adjust search terms for mods
2024-02-22 11:41:31 +01:00
Bartłomiej Dach
84fdcd24ef
Remove description from mod search terms
...
Closes https://github.com/ppy/osu/issues/27111 .
2024-02-22 11:02:08 +01:00
Bartłomiej Dach
1a831145ce
Merge branch 'master' into fix-bpm-differences
2024-02-22 10:41:22 +01:00
Bartłomiej Dach
81a9908c60
Extract common helper for BPM rounding
2024-02-22 10:27:37 +01:00
Bartłomiej Dach
57bb0b85a1
Merge pull request #27107 from Joehuu/rank-highest-tooltip
...
Add highest rank tooltip to global rank display
2024-02-22 09:08:22 +01:00
Dean Herbert
9d732bd9b1
Merge branch 'remove-legacy-gl' into update-framework
2024-02-21 21:44:19 +08:00
Andrei Zavatski
2543a48ac8
Apply padding to GridContainers directly
2024-02-20 23:18:37 +03:00
Bartłomiej Dach
33a0dcaf20
NRT-annotate MedalAnimation and fix possible nullref
2024-02-20 17:59:21 +01:00
Bartłomiej Dach
9b938f333d
Fix test failures
2024-02-20 17:25:11 +01:00
Bartłomiej Dach
611e3fe76b
Delay medal display when wanting to show results animation
2024-02-20 16:31:31 +01:00
Bartłomiej Dach
96825915f7
Fix threading failure
...
Implicitly showing the medal overlay fires off some transforms, and the
websocket listener runs on a TPL thread. That's a recipe for disaster,
so schedule the show call.
2024-02-20 16:31:31 +01:00
Bartłomiej Dach
b334b78b63
Make medal overlay respect overlay disable via activation mode
2024-02-20 16:31:31 +01:00
Bartłomiej Dach
e4971ae121
Add display queueing when multiple medals are granted in quick succession
2024-02-20 16:31:31 +01:00
Bartłomiej Dach
2e5b61302a
Implement basic medal display flow
2024-02-20 16:31:31 +01:00
