1803 Commits

Author	SHA1	Message	Date
smoogipoo	dd702ccfd2	Make mania FI/HD incompatible with each other	2021-02-24 14:34:37 +09:00
Samuel Cattini-Schultz	66643a97b0	Add a list of mods to Skill class ... Although this isn't necessary for existing official rulesets and calculators, custom calculators can have use cases for accessing mods in difficulty calculation. For example, accounting for the effects of visual mods.	2021-02-20 20:37:44 +11:00
Samuel Cattini-Schultz	442347df8e	Fix clockrate adjusted difficulty calculations bug in strain decay ... When starting a new section, the starting strain value was calculated using the unadjusted timing value, meaning decay curves were essentially being stretched or squashed according to the clockrate. This caused incorrect strain peaks for any section where the peak occurs at the start of the section (none of the objects in the section added enough strain after decay to exceed the starting strain). This bug caused star ratings with clockrates above 1 to be lower than they should and below 1 to be higher than they should.	2021-02-20 20:23:49 +11:00
Dean Herbert	00574a5288	Use ISample everywhere in Skin GetSample lookup path	2021-02-18 18:32:28 +09:00
smoogipoo	d3f0c0730d	Merge branch 'master' into non-concurrent-sample-playback	2021-02-12 17:22:15 +09:00
Bartłomiej Dach	68c20a2a37	Allow autoplay score generation to access mod list	2021-02-07 18:35:34 +01:00
Dean Herbert	f86f323625	Add a basic guard against setting ScrollMethod too late in initialisation	2021-02-04 22:28:17 +09:00
smoogipoo	8295fb9081	Implement mania constant speed mod	2021-02-03 16:28:22 +09:00
smoogipoo	de9d075f94	Initial sample + samplechannel rework	2021-01-19 17:11:40 +09:00
smoogipoo	1b166d809e	Adjust package titles	2021-01-18 11:08:03 +09:00
smoogipoo	ec00aaef90	Add nuget deploys for all rulesets	2021-01-18 10:53:31 +09:00
Dean Herbert	bf39aa5980	Fix incorrectly converted rotation values	2020-12-22 12:18:42 +09:00
Dean Herbert	e1b2de27a6	Update osu!mania legacy skin's judgement animation to match stable	2020-12-21 17:23:23 +09:00
Dean Herbert	1793385e96	Pass a score to the replay recorder to allow reading more general scoring data	2020-12-14 16:52:14 +09:00
smoogipoo	a835ca9612	Fix anchors/origins for legacy pieces	2020-12-14 14:20:43 +09:00
smoogipoo	1794bfeddb	Move offset into legacy mania judgement	2020-12-14 13:07:55 +09:00
smoogipoo	ca11eeefdf	Merge branch 'master' into mania-legacyskin-scoreposition	2020-12-14 11:25:34 +09:00
Firmatorenio	cf7303e072	dotnet format	2020-12-13 22:54:01 +06:00
Firmatorenio	3741c2339a	simplify implementation and adjust the default values	2020-12-13 22:43:36 +06:00
Firmatorenio	2108844319	apply ScorePosition to the judgement container	2020-12-13 22:01:08 +06:00
Firmatorenio	f14e49c72e	fetch ScorePosition from the skin	2020-12-13 21:59:04 +06:00
Firmatorenio	60379b09db	added a container for the judgements to move up or down	2020-12-13 18:14:41 +06:00
ekrctb	e3c035fe9c	Adjust namespace	2020-12-07 12:32:52 +09:00
ekrctb	40da799103	Move piece files of Mania ruleset	2020-12-07 12:31:56 +09:00
Bartłomiej Dach	5fbe1823a0	Merge branch 'master' into editor-beat-snap-always	2020-11-30 18:39:22 +01:00
Dean Herbert	7f34e11467	Merge pull request #10962 from smoogipoo/improve-dho-time-offsets ... Fix judgement offsets in non-framestable contexts	2020-11-30 19:13:25 +09:00
Dean Herbert	c17d67bc7d	Merge branch 'master' into editor-beat-snap-always	2020-11-30 18:34:38 +09:00
Dean Herbert	9811c46e35	Rename application method to better describe what it actually does	2020-11-26 19:16:18 +09:00
ekrctb	f3f5ec7665	Fix Column not calling base.Add	2020-11-26 18:08:40 +09:00
smoogipoo	0414e5c550	Add MaximumJudgementOffset to DrawableHitObject, use in more places	2020-11-26 01:12:42 +09:00
Bartłomiej Dach	827a089810	Merge branch 'master' into change-taiko-ez	2020-11-22 13:29:02 +01:00
Bartłomiej Dach	24d7fa03d8	Merge branch 'master' into legacy-jugement-match-stable-transforms	2020-11-18 20:33:58 +01:00
Bartłomiej Dach	5156de3a10	Merge branch 'master' into fix-judgement-transform-logic	2020-11-18 19:20:11 +01:00
Dean Herbert	20bb64c627	Fix mania misses not correctly animating (temporary solution)	2020-11-18 19:34:00 +09:00
Dean Herbert	94886a09b2	Remove fades from DrawableJudgement itself	2020-11-18 19:03:34 +09:00
Dean Herbert	49b8331ccd	Merge pull request #10877 from smoogipoo/fix-mania-judgement-displays ... Fix hold note judgements displaying incorrectly	2020-11-18 19:00:14 +09:00
Dean Herbert	8247e6ce91	Move result type to ctor	2020-11-17 15:43:54 +09:00
Dean Herbert	f465dd5a5e	Move all extended animation logic out of DrawableJudgement	2020-11-17 14:59:34 +09:00
Dan Balasescu	cb3280af7c	Merge branch 'master' into hold-note-fade	2020-11-17 13:49:28 +09:00
smoogipoo	77942af3a6	Fix hold note judgements displaying incorrectly	2020-11-17 13:37:58 +09:00
Bartłomiej Dach	21f29e28e2	Add clarification comment	2020-11-16 20:36:56 +01:00
Bartłomiej Dach	e88920442c	Use HitStateUpdateTime instead	2020-11-16 20:01:10 +01:00
Bartłomiej Dach	8da40ce2dc	Reduce duplication by extracting ModEasyWithExtraLives	2020-11-16 19:54:00 +01:00
Bartłomiej Dach	128adce017	Merge branch 'master' into change-taiko-ez	2020-11-16 19:37:47 +01:00
PercyDan54	99ee5e3ad7	Correct inheritance	2020-11-16 18:28:50 +08:00
PercyDan54	d7acfd5413	Remove retires from ModEasy	2020-11-16 18:15:15 +08:00
Dean Herbert	a4c17906b4	Make comment a bit more explicit	2020-11-16 14:52:18 +09:00
Bartłomiej Dach	e5d9cca9de	Fix mania-specific missing cases	2020-11-15 15:38:12 +01:00
Bartłomiej Dach	ba30800bf4	Extract constant	2020-11-13 22:21:22 +01:00
Bartłomiej Dach	a199a957cc	Use stored hold note break time to fade upon it	2020-11-13 22:16:38 +01:00
Bartłomiej Dach	b62bf5798d	Store time of hold note break	2020-11-13 21:14:34 +01:00
Bartłomiej Dach	4777b1be81	Fix fade not applying to tails sometimes	2020-11-13 20:52:15 +01:00
Bartłomiej Dach	55a91dbbe0	Add fading on hit state change	2020-11-13 20:52:15 +01:00
Bartłomiej Dach	7a89e58483	Disable pressed/released action logic when rewinding	2020-11-13 20:49:06 +01:00
smoogipoo	4ef2e9548c	Pass HitObjectComposer to BlueprintContainer via ctor	2020-11-13 16:59:37 +09:00
smoogipoo	60f95e897d	Revert unnecessary change	2020-11-12 18:29:22 +09:00
smoogipoo	ad38867b1d	Completely remove check as it can occur for hits too	2020-11-12 18:29:22 +09:00
smoogipoo	44aed19e4e	Fix mania notelock crashing with overlapping hitwindows	2020-11-12 18:29:22 +09:00
Dean Herbert	a3dc1d5730	Update existing implementations	2020-11-04 17:14:23 +09:00
Dean Herbert	fed4accfea	Update tests to refect new mappings	2020-10-30 12:12:30 +09:00
Dean Herbert	ef2e2894a2	Merge branch 'master' into fix-mania-diffcalc	2020-10-14 23:49:14 +09:00
smoogipoo	26dffbfd3b	Replicate hit window calculation	2020-10-14 20:40:39 +09:00
smoogipoo	1a2dc83740	Make field readonly	2020-10-14 20:40:17 +09:00
smoogipoo	da8565c0fa	Add 10K mod to incompatibility list	2020-10-14 18:28:19 +09:00
smoogipoo	3e6ed6c9ff	Add support for dual stages (keycoop) and score multiplier	2020-10-14 17:53:28 +09:00
Dan Balasescu	4eccb03d71	Add copyright notice ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2020-10-14 17:08:14 +09:00
Dean Herbert	207c409792	Merge branch 'master' into fix-mania-diffcalc	2020-10-14 15:26:32 +09:00
Dean Herbert	010f86ff34	Merge pull request #10452 from smoogipoo/fix-mania-conversion ... Make mania beatmap conversions match stable	2020-10-13 01:17:42 +09:00
smoogipoo	ac4290dfb6	Add comment about stable calculation	2020-10-12 15:27:33 +09:00
Bartłomiej Dach	146b15371d	Merge branch 'master' into fix-slider-sample-parsing	2020-10-10 14:02:33 +02:00
smoogipoo	65d8530a11	Fix tests	2020-10-09 22:47:32 +09:00
smoogipoo	306d876d22	Replicate stable's unstable sort	2020-10-09 21:50:20 +09:00
smoogipoo	5017c92fe8	Combine mania skills	2020-10-09 21:47:34 +09:00
smoogipoo	08f3481b59	Use integer calculations to replicate stable's slider conversion	2020-10-09 21:22:20 +09:00
smoogipoo	5f19081db6	Fix incorrect probability calculation for hitobject conversion	2020-10-09 21:20:00 +09:00
smoogipoo	9d09503ace	Fix spinner conversion not considering stacking + forced initial column	2020-10-09 21:13:04 +09:00
smoogipoo	4d0e4f4ade	Fix incorrect initial density	2020-10-09 21:11:18 +09:00
Dean Herbert	681e88af40	Merge branch 'master' into editor-fix-button-states-after-paste	2020-10-09 20:51:09 +09:00
Dean Herbert	3838f405dd	Fix missed usages	2020-10-09 18:50:05 +09:00
Dean Herbert	07558b5bc0	Merge branch 'master' into ruleset-result-types	2020-10-09 13:17:05 +09:00
Dean Herbert	f1a3b6d0ba	Merge branch 'master' into perf-calculator-remove-working-beatmap	2020-10-07 17:43:17 +09:00
Dean Herbert	6020ec9ca3	Add valid result types for all rulesets	2020-10-07 15:43:52 +09:00
Dean Herbert	9d7880afda	Make SettingsItem conform to IHasCurrentValue	2020-10-06 17:18:54 +09:00
Dean Herbert	5dea37792c	Merge branch 'master' into health-adjustments	2020-10-04 21:38:40 +09:00
Lucas A	d7747ebb2d	Remove unused WorkingBeatmap argument.	2020-10-03 16:51:22 +02:00
Bartłomiej Dach	309714081f	Make new health increase values mania-specific	2020-10-03 12:16:22 +02:00
Bartłomiej Dach	1f0620ffd4	Replace assignment references to HitResult.Miss with Judgement.MinResult	2020-10-02 23:31:24 +02:00
Bartłomiej Dach	2b1ef16f89	Replace comparison references to HitResult.Miss with IsHit	2020-10-02 23:31:24 +02:00
Lucas A	abd395a030	Remove unecessary using references.	2020-10-02 19:41:24 +02:00
Lucas A	0163688a17	Remove IBeatmap from PerformanceCalculator.	2020-10-02 19:24:30 +02:00
smoogipoo	e789e06c86	Don't display hold note tick judgements	2020-09-29 16:33:38 +09:00
smoogipoo	bad48d6d44	Merge branch 'master' into scoring-standardisation	2020-09-29 16:33:38 +09:00
smoogipoo	31fae045fa	Update judgement processors with new hit results	2020-09-29 16:33:38 +09:00
smoogipoo	b1877b649b	Use new hit results in mania	2020-09-29 16:33:38 +09:00
Dean Herbert	6095446f10	Fix autoplay generators failing on empty hitobjects lists	2020-09-28 15:38:54 +09:00
smoogipoo	c7d24203ce	Make beatmap conversion support cancellation tokens	2020-09-17 17:40:05 +09:00
Morilli	9c041dbac2	Fix mania scrollspeed slider precision	2020-09-15 08:24:01 +02:00
Dean Herbert	ef44c7d063	Merge branch 'master' into score-recalc	2020-09-10 18:30:41 +09:00
Dean Herbert	a65f564e45	Add icons for other ruleset editors	2020-09-09 18:40:01 +09:00
smoogipoo	117c7ec6b2	Merge branch 'master' into score-recalc	2020-09-09 14:38:36 +09:00
Dean Herbert	4680728b9c	Merge branch 'master' into update-dcc-exclusions	2020-09-07 18:01:44 +09:00
smoogipoo	c72a8d4755	Add zero-length slider test	2020-09-07 17:18:40 +09:00
smoogipoo	ecc9c2957f	Avoid float precision error in mania conversion	2020-09-07 16:30:05 +09:00
smoogipoo	1143d5d992	Update class exclusion for dynamic compilation	2020-09-04 20:41:08 +09:00
Dean Herbert	25e142965d	Strongly type and expose default beatmap information icon implementations for other rulesets	2020-09-04 15:01:32 +09:00
Dean Herbert	72cb65c22f	Update and add missing beatmap statistic icons to info wedge	2020-09-03 17:52:22 +09:00
Bartłomiej Dach	d419fe4dbf	Remove note shaking mention that doesn't apply in mania	2020-08-31 12:03:05 +02:00
smoogipoo	acbeb5406f	Add/improve xmldoc	2020-08-31 13:33:41 +09:00
smoogipoo	aa151e4cd7	Merge branch 'master' into mania-notelock	2020-08-31 13:31:41 +09:00
Dan Balasescu	bd2f863b56	Merge branch 'master' into legacy-mirror-mod-replays	2020-08-31 12:41:17 +09:00
Dean Herbert	cd0a73883d	Merge pull request #9945 from smoogipoo/skin-colour-fix-2 ... Exactly reproduce osu!stable skin colour alphas	2020-08-29 20:06:26 +09:00
Bartłomiej Dach	da82556f6b	Add two-way legacy conversions for mirror mod	2020-08-29 11:49:17 +02:00
smoogipoo	85bda29b71	Add mania max combo attribute	2020-08-28 19:16:24 +09:00
Dean Herbert	da34544fdc	Merge branch 'master' into hold-note-lighting	2020-08-28 18:27:29 +09:00
Bartłomiej Dach	43d6d2b2e8	Add back unstable rate display	2020-08-27 20:46:49 +02:00
Bartłomiej Dach	f152e1b924	Revert IStatisticRow changes	2020-08-27 20:13:44 +02:00
Bartłomiej Dach	1a04ec5375	Merge branch 'master' into unstable-rate	2020-08-27 19:56:08 +02:00
smoogipoo	7002193165	Mark nullable members	2020-08-27 23:16:59 +09:00
smoogipoo	29b29cde8e	Flip condition to reduce nesting	2020-08-27 23:09:54 +09:00
smoogipoo	7a5292936e	Add some xmldocs	2020-08-27 21:15:05 +09:00
Bartłomiej Dach	a1f731d455	Merge branch 'master' into mania-keys-under-notes	2020-08-27 14:06:43 +02:00
smoogipoo	6f93df0b9d	Fix ticks causing hold note misses	2020-08-27 21:05:12 +09:00
smoogipoo	deb172bb6c	Implement basic mania hit order policy	2020-08-27 20:24:21 +09:00
Bartłomiej Dach	05e725d59f	Add unstable rate statistic to rulesets in which it makes sense	2020-08-26 22:06:29 +02:00
Bartłomiej Dach	bbb3d7522e	Scope up return type to IStatisticRow	2020-08-26 19:24:12 +02:00
smoogipoo	157e1d8965	Add fades	2020-08-26 20:46:12 +09:00
smoogipoo	6fe1279e9d	Re-use existing inset container	2020-08-26 20:23:01 +09:00
smoogipoo	1db836e9e0	Merge branch 'master' into hold-note-lighting	2020-08-26 20:22:07 +09:00
smoogipoo	9372c6eef6	Implement hold note lighting	2020-08-26 20:21:56 +09:00
smoogipoo	d057f5f4bc	Implement mania "KeysUnderNotes" skin config	2020-08-26 15:37:16 +09:00
smoogipoo	0800e43796	Remove padding from columns	2020-08-25 19:57:49 +09:00
smoogipoo	c09cef4fca	Apply post-merge fixes to LegacyStageBackground	2020-08-25 19:40:17 +09:00
smoogipoo	8dde512657	Merge branch 'master' into skin-colour-fix-2	2020-08-25 19:39:01 +09:00
smoogipoo	ff72ccabd8	Rename method	2020-08-25 18:44:32 +09:00
Dean Herbert	940b4acf0d	Merge branch 'master' into fix-hittarget-layering	2020-08-25 15:44:38 +09:00
smoogipoo	ab8d9be095	Move out into a separate method	2020-08-25 15:16:41 +09:00
smoogipoo	723e5cafb6	Fix column potentially added at wrong indices	2020-08-25 14:49:04 +09:00
smoogipoo	018523a43a	Rework to remove cross-class pollutions	2020-08-25 01:21:27 +09:00
smoogipoo	77bf646ea0	Move column lines to background layer	2020-08-24 23:01:06 +09:00
smoogipoo	500cb0ccf5	Fix legacy hit target being layered incorrectly	2020-08-24 22:36:37 +09:00
Dean Herbert	1f717c4b00	Merge branch 'master' into hold-note-freeze	2020-08-23 22:38:48 +09:00
Bartłomiej Dach	891f5cb130	Add padding to mania column borders to match stable	2020-08-21 20:00:20 +02:00
smoogipoo	08078b9513	Rename method to remove "InitialColour" namings	2020-08-22 00:56:29 +09:00
smoogipoo	454564b189	Update mania with legacy colour setters	2020-08-22 00:19:15 +09:00
smoogipoo	b3338347b7	Remove fade on successful hits	2020-08-21 23:56:27 +09:00
smoogipoo	8632c3adf0	Fix hold notes bouncing with SV changes	2020-08-21 23:11:15 +09:00
Dan Balasescu	42ee9b75df	Apply suggestions from code review ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-08-21 19:38:59 +09:00
smoogipoo	aead13628b	Rework freezing to use masking	2020-08-21 17:52:42 +09:00
smoogipoo	37cf7999b1	Merge branch 'master' into hold-note-freeze	2020-08-21 14:39:25 +09:00
smoogipoo	54a2322090	Use Array.Empty<>	2020-08-20 22:51:52 +09:00