Dean Herbert
635e225d19
Add correct lookup for WidthForNoteHeightScale
2023-02-10 19:18:41 +09:00
Dean Herbert
5c795f492f
Reorder game key bindings to allow skip overlay to have precedence over replay controls
2023-02-10 18:57:21 +09:00
Dean Herbert
96fbd04698
Add failing test coverage of skip no longer working in replay playback
2023-02-10 18:57:04 +09:00
Dean Herbert
4f7d26b776
Actually apply new parameter
2023-02-10 18:29:39 +09:00
Dean Herbert
6d876fdb9a
Automatically select the closest timing point on entering the timing screen
2023-02-10 17:48:56 +09:00
Dean Herbert
03e623d1d2
Move ControlPointList
to own file
2023-02-10 17:37:31 +09:00
Dean Herbert
ad8b01b478
Merge pull request #22589 from sw1tchbl4d3r/file_hitsample_additions
...
Always add to additions soundbank in `convertSoundType`
2023-02-10 17:14:29 +09:00
Dean Herbert
eccde923e5
Merge pull request #22554 from Walavouchey/ranking-accuracycircle-readability
...
Improve readability of `AccuracyCircle`
2023-02-10 17:03:46 +09:00
Dean Herbert
1df6fc6311
Use if
statements rather than conditional case
2023-02-10 17:03:27 +09:00
Dean Herbert
199fb0fd85
Apply NRT to ClickableAvatar
and UpdateableAvatar
2023-02-10 16:32:58 +09:00
Dean Herbert
5866b67a5b
Simplify tooltip implementation
2023-02-10 16:24:44 +09:00
Dean Herbert
68c37585e5
Use string.Empty
instead of default
2023-02-10 16:22:06 +09:00
Joseph Madamba
a86f06df96
Add back Enabled
checks to TooltipText
and OnClick
to fix guest case
2023-02-09 17:00:32 -08:00
Bartłomiej Dach
96c1832af4
Fix grammar in xmldoc
...
Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>
2023-02-10 00:07:24 +01:00
sw1tchbl4d3
f0d11f44fc
Always add to additions soundbank in convertSoundType
2023-02-09 22:27:52 +01:00
Joseph Madamba
0b41dbf579
Remove code bloat from ClickableAvatar
2023-02-09 12:59:26 -08:00
Ruki
2c1154afc6
refactor: improve wording
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2023-02-09 17:15:30 +00:00
Dean Herbert
ab81397119
Merge pull request #22553 from OpenSauce04/taiko-stable-snapping
...
Snap Taiko hit objects to match Stable
2023-02-09 23:28:21 +09:00
Dean Herbert
34d1890f1c
Change snapping to only apply to classic mod
2023-02-09 18:22:14 +09:00
Dean Herbert
28897b6e18
Merge pull request #22566 from Joehuu/profile-tournament-banner
...
Display tournament banner on user profile
2023-02-09 16:06:36 +09:00
Dean Herbert
cf009432cc
Centralise accuracy cutoff constants and add lookup helper methods
2023-02-09 15:41:58 +09:00
Joseph Madamba
f1decb667e
Address todos relating to init-only usages
2023-02-08 17:51:28 -08:00
Walavouchey
57312279f0
adjust RankNotch
gap size to match original value
2023-02-09 02:20:05 +01:00
Joseph Madamba
3b5d573db1
Display tournament banner on user profile
2023-02-08 17:16:09 -08:00
Walavouchey
fd93bd3f50
move rank accuracy requirements to class-local constants
2023-02-09 00:46:24 +01:00
Walavouchey
ee40444fd3
use Precision.AlmostEquals
for bounds check
2023-02-08 23:59:19 +01:00
Bartłomiej Dach
0a5c4e04bf
Merge branch 'master' into skin-editor-undo-support
2023-02-08 18:43:59 +01:00
Walavouchey
0531c010eb
display RankBadge
s on on their sector centres
...
the D `RankBadge` does this anyway. the A and S badges are slightly off
centre to prevent overlap with the SS badge
2023-02-08 14:01:40 +01:00
Walavouchey
6ace6bfee1
ensure AccuracyCircle
doesn't land in gaps created by RankNotch
es
2023-02-08 13:20:53 +01:00
Joseph Madamba
0156ff732f
Fix beatmap cards not showing context menu on user profile
2023-02-07 22:56:09 -08:00
Dean Herbert
17ca26ebee
Remove unnecessary null check on targetScreen
2023-02-08 15:44:24 +09:00
Dean Herbert
3a3c2e78a1
Merge branch 'master' into skin-editor-undo-support
2023-02-08 15:41:58 +09:00
Dean Herbert
78eae171ed
Merge pull request #22507 from Joehuu/fix-comment-padding
...
Fix comments having too much padding at the bottom
2023-02-08 15:01:05 +09:00
Dean Herbert
b6809e156b
Merge pull request #22432 from mk56-spn/sheared_slider_implementation_clean_ii
...
Implement a sheared slider for the updated design
2023-02-08 15:01:00 +09:00
Dean Herbert
5cd111e6f1
Fix ordering of methods in OsuSliderBar
2023-02-08 14:01:50 +09:00
Dean Herbert
cec1f77e6c
Fix glow flash occurring after releasing mouse and adjust transition slightly
2023-02-08 13:59:09 +09:00
Dean Herbert
ee65c65893
Attempt to fix channel join / leave loop
...
I don't have a solid way to repro the issue, but this should hopefully
help in resolving it. Either way, I think this change brings more
correct behaviour (if a websocket message comes through that we have
left the channel, I don't believe we should be sending a request to
leave that channel again).
2023-02-08 11:31:30 +09:00
Joseph Madamba
277f71d36a
Expire reply editor instead of clearing container
2023-02-07 15:15:51 -08:00
Dean Herbert
0320ba770f
Handle component changes via ISkinnableTarget.Components
rather than inside SkinEditor
directly
...
Seems saner? Maybe?
2023-02-07 16:23:25 +09:00
Dean Herbert
e162fd56da
Change the way initial state saving works in EditorChangeHandler
to be closer to first change
2023-02-07 16:22:51 +09:00
Dean Herbert
dad348111d
Fix holding a selection while changing screens causing a crash
2023-02-07 16:07:33 +09:00
Dean Herbert
71eef238c4
Make OnStateChange
non-implemented rather than wrong
2023-02-07 16:04:31 +09:00
tsrk
da10166628
quality: convert getter property to method so that sensible information can be hidden via an argument
2023-02-06 21:30:55 +00:00
tsrk
1baaae35a9
quality: Simplify string
2023-02-06 20:07:16 +00:00
Bartłomiej Dach
12f6d461b9
Merge pull request #22532 from peppy/fix-long-storyboard-outro
...
Fix storyboard outro time potentially running too long
2023-02-06 20:30:36 +01:00
Bartłomiej Dach
179db09075
Merge pull request #22531 from peppy/apply-future-rider-inspection
...
Apply single inspection from newer inspectcode versions
2023-02-06 20:05:49 +01:00
tsrk
bc89f8dc5b
feat: add name and rulset verb display support
2023-02-06 12:44:00 +00:00
Dean Herbert
aaf3ad805c
Fix potential nullref in tests
2023-02-06 19:31:45 +09:00
Dean Herbert
b83c8443ea
Ensure pause sample loop is stopped on exiting player
2023-02-06 18:24:31 +09:00
Dean Herbert
c691a0d3af
Merge branch 'master' into sheared_slider_implementation_clean_ii
2023-02-06 17:49:33 +09:00
Dean Herbert
c078d3a344
Merge pull request #22357 from EXtremeExploit/groups-probationary-badges
...
Make probationary groups a bit transparent
2023-02-06 17:43:57 +09:00
Dean Herbert
ddcc02fdfe
Merge pull request #22505 from Joehuu/fix-hover-click-sounds
...
Fix some clickable elements having no hover and click sounds
2023-02-06 16:52:19 +09:00
Dean Herbert
eabd1a0cc1
Remove unused Duration
property to avoid any misunderstandings
2023-02-06 16:42:39 +09:00
Dean Herbert
679ec986d5
Fix storyboard outro time potentially running too long
2023-02-06 16:39:44 +09:00
Dean Herbert
4c868372a2
Correctly handle anchor/origin changes as undo states
2023-02-06 15:05:05 +09:00
Dean Herbert
778b8a9bf7
Fix default settings not being serialised / state tracked correctly
2023-02-06 15:00:42 +09:00
Dean Herbert
7445814fc6
Handle changes to SettingSource
skin element settings
2023-02-06 14:42:59 +09:00
Dean Herbert
e5f62b0d2e
Remove public
access modifier from interface methods
2023-02-06 14:19:25 +09:00
Dean Herbert
e4b17588f5
Add missing xmldoc to new methods in EditorChangeHandler
2023-02-06 14:11:40 +09:00
Dean Herbert
701d21c26f
Apply single inspection from newer inspectcode verisons
...
As found in rider EAPs. Appears as a warning and is annoying me
occasionally.
2023-02-06 13:52:27 +09:00
Dean Herbert
10ab4d572a
Merge branch 'master' into skin-editor-undo-support
2023-02-06 13:46:50 +09:00
tsrk
b3f38b0f4c
quality: remove redundant Status
override
2023-02-06 00:56:11 +00:00
tsrk
bf273597ea
feat: actually support status also for Replays
2023-02-06 00:41:10 +00:00
tsrk
d5b2d9ce97
feat: add support for spectating status
2023-02-05 23:58:08 +00:00
Joseph Madamba
cb8458cceb
Use linq and alpha instead
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-02-04 20:11:29 -08:00
Joseph Madamba
191259c050
Use equals instead and update other usage
2023-02-04 19:58:48 -08:00
Bartłomiej Dach
ef900bccdf
Merge branch 'master' into BPM_counter_fix
2023-02-04 23:44:58 +01:00
Bartłomiej Dach
cb7540564a
Merge pull request #22504 from peppy/fix-editor-positional-nudge-undo
...
Fix beatmap editor positional nudging not being undoable
2023-02-04 15:52:34 +01:00
Joseph Madamba
4192388b20
Fix expanded beatmap cards getting cut off at the end of profile sections
2023-02-03 21:29:01 -08:00
mk56-spn
88872cf1cf
Use ``GetTrueGameplayRate()
`` to remove need for jank
2023-02-04 00:53:54 +01:00
mk56-spn
d9bee958dd
Stop ``BPMCounter.cs
``'s value from going to 0 after failing.
2023-02-03 23:56:34 +01:00
Bartłomiej Dach
97afb83394
Merge branch 'master' into carousel
2023-02-03 22:15:44 +01:00
Bartłomiej Dach
63f7d326c2
Merge branch 'master' into fix-editor-positional-nudge-undo
2023-02-03 21:31:05 +01:00
Bartłomiej Dach
4bd43171e8
Merge branch 'master' into fix-skin-editor-padding-weirdness
2023-02-03 20:28:47 +01:00
Bartłomiej Dach
b2a5cf9f2d
Merge branch 'master' into triangles-old-texel
2023-02-03 19:43:34 +01:00
Bartłomiej Dach
59656a7286
Merge branch 'master' into skin-editor-dont-show-save-on-no-change
2023-02-03 19:08:33 +01:00
EXtremeExploit
f9809c9481
the comment
2023-02-03 11:48:11 -03:00
mk56-spn
e1af5e110a
Remove ``RoundedNub.cs
` and make
`Nub.cs
`` non abstract again
2023-02-03 12:19:09 +01:00
mk56-spn
8c11e8e6f4
Extract ShearedNub.cs implementation into its own entirely independent implementation
2023-02-03 11:58:10 +01:00
Joseph Madamba
461b5c5375
Fix comment cancel button not behaving the same as reply text toggle
...
- Removed the fading animation as it is awkward right now (needs resizing)
2023-02-03 02:04:19 -08:00
Dean Herbert
2cda277c09
Add a basic change handler to the skin editor
2023-02-03 18:57:50 +09:00
Dean Herbert
2f30306ea2
Expose a method to reload a SkinnableTargetContainer
from provided info
2023-02-03 18:53:09 +09:00
Dean Herbert
3345e34544
Move beatmap specific logic out of EditorChangeHandler
2023-02-03 17:53:54 +09:00
Joseph Madamba
94d2799b90
Fix comments having too much padding at the bottom
2023-02-03 00:47:10 -08:00
Joseph Madamba
5a76c1ab9c
Refactor HoverSampleDebounceComponent
to inherit Component
2023-02-03 00:29:25 -08:00
Dean Herbert
b437501b0f
Fix beatmap editor positional nudging not being undoable
2023-02-03 17:28:58 +09:00
Dean Herbert
554f14151c
Apply NRT to EditorChangeHandler
2023-02-03 17:13:24 +09:00
Dean Herbert
b19047b90b
Fix skin editor component list having uneven padding
2023-02-03 16:55:51 +09:00
Joseph Madamba
f27bf3ca20
Fix click sounds potentially not working
2023-02-02 23:54:57 -08:00
Joseph Madamba
77569058cb
Alternatively fix hover sounds playing out of clicking bounds
2023-02-02 23:45:54 -08:00
Dean Herbert
60ccf35125
Update resources
2023-02-03 16:44:53 +09:00
Joseph Madamba
6135db6bd7
Revert moving hover sounds to content container
2023-02-02 23:43:08 -08:00
Dean Herbert
7b9239088b
Comment space addition
2023-02-03 16:40:16 +09:00
Andrei Zavatski
14524237ac
Add comment explaining texelSize value
2023-02-03 10:32:41 +03:00
Dean Herbert
4ec46c7476
Merge branch 'master' into footer_V2_implementation
2023-02-03 16:30:16 +09:00
Dean Herbert
48f7e0163c
Adjust comments and formatting of comments
2023-02-03 16:27:20 +09:00
Dean Herbert
4248453616
Use FinishTransforms
rather than manual duplication of background colour logic
2023-02-03 16:27:20 +09:00
Dean Herbert
a1200b8fe8
Adjust footer button colour handling to read better and take into account mouse down
2023-02-03 16:27:20 +09:00
Dean Herbert
92306b9123
Combine localisations for abstract skinnable components into a single file
...
Generally we don't want localisation files with only one to two
translations. It makes it harder for translators to handle in crowdin (a
lot of file changes for small results).
So for cases like this I believe we should be grouping translations
where it makes sense.
I've left individual components in their own files as I can see
potential for more settings to be added in the future. Plus it gives a
bit of extra context.
2023-02-03 16:02:18 +09:00
Dean Herbert
cf8cfe0d2c
Move skin component localisations to namespaces
2023-02-03 15:34:57 +09:00