Dean Herbert
ecf144f4a5
Add failing test of importing failed replay in OsuGame flow
...
We had a test covering this but it wasn't within `OsuGame` so didn't
have full import blocking coverage (see
cbbe2f9dc0/osu.Game.Tests/Visual/Gameplay/TestScenePlayerLocalScoreImport.cs (L89-L88)
2024-10-03 17:11:25 +09:00
Dean Herbert
8773c34fdd
Rename enum to non-plural now that it won't conflict
2024-10-01 19:55:46 +09:00
Dean Herbert
54e68005ef
Merge pull request #29691 from bdach/hotkeys-in-context-menus
...
Add hotkey hints to editor menus
2024-10-01 19:29:05 +09:00
Dean Herbert
598bc74614
Merge pull request #30058 from bdach/disabled-beatmap-comment-box
...
Properly disable comment box on things that cannot be commented on
2024-10-01 18:52:40 +09:00
OliBomby
3769b0da5d
Fix TestHotkeysUnifySliderSamplesAndNodeSamples
2024-10-01 11:02:46 +02:00
Dean Herbert
ad3007eaad
Adjust ILocalUserPlayInfo to expose whether gameplay is in a paused/break state
2024-10-01 17:53:46 +09:00
Bartłomiej Dach
8eb5e6b1d5
Merge branch 'master' into shuffle
2024-10-01 10:07:54 +02:00
Bartłomiej Dach
a9818854f4
Merge pull request #30024 from peppy/edit-url-decode
...
Fix editor timestamp URLs not working when they contain a space
2024-10-01 09:44:18 +02:00
Dean Herbert
1b4215576d
Merge branch 'master' into additions
2024-10-01 16:38:56 +09:00
Dean Herbert
87ab953935
Merge pull request #30062 from bdach/distance-snap-weirdness
...
Fix various distance snap grid weirdness around unsnapped objects
2024-10-01 16:16:22 +09:00
Dean Herbert
590f27e0a0
Merge branch 'master' into hotkeys-in-context-menus
2024-10-01 15:50:19 +09:00
Bartłomiej Dach
155d6e57be
Isolate tests properly
2024-09-30 14:05:20 +02:00
Bartłomiej Dach
75fc57c34b
Fix distance spacing grid displaying incorrectly for unsnapped objects with duration
2024-09-30 13:36:16 +02:00
Bartłomiej Dach
e91c8fb4bd
Properly disable comment box on beatmaps that cannot be commented on
...
Closes https://github.com/ppy/osu/issues/30052 .
Compare:
- 83816dbe24/resources/js/components/comment-editor.tsx (L54-L60)83816dbe24/resources/js/components/comment-editor.tsx (L47-L52)
2024-09-30 11:02:00 +02:00
Bartłomiej Dach
23b8354af4
Add more test steps demonstrating another failure case
2024-09-30 08:46:45 +02:00
Bartłomiej Dach
3fac9baa9f
Add test steps demonstrating failure case
2024-09-30 08:46:33 +02:00
Dean Herbert
a258059d43
Merge pull request #29918 from bdach/control-drag
...
Add to existing selection when dragging with control pressed
2024-09-30 14:00:36 +09:00
Dean Herbert
c46d787f1e
Merge pull request #29949 from minetoblend/feature/scale-around-center
...
Support scaling around center when scaling with select box
2024-09-28 21:37:39 +09:00
Dean Herbert
f6c5f975ee
Add failing test showing url decoding is not being performed
2024-09-27 20:08:26 +09:00
Bartłomiej Dach
eb725ec1fb
Nudge test coverage to also cover discovered fail case
2024-09-27 12:13:11 +02:00
Bartłomiej Dach
b45fedc356
Merge branch 'master' into control-drag
2024-09-27 11:39:50 +02:00
Bartłomiej Dach
a00ed8dd77
Merge pull request #29914 from peppy/fix-judgement-counter-sync
...
Fix judgement counter not showing correct counts when spectating user mid-play
2024-09-27 10:57:26 +02:00
Bartłomiej Dach
fa90b43233
Merge branch 'master' into selection-center
2024-09-27 09:30:36 +02:00
Dean Herbert
5efdc6cdd7
Merge pull request #29936 from u4vh3/skinning-colour-customisation
...
Add colour customisation to layout editor
2024-09-27 14:20:58 +09:00
Bartłomiej Dach
f4a4807449
Implement "form" file picker
2024-09-26 14:36:24 +02:00
Bartłomiej Dach
f16f419928
Merge pull request #29983 from bdach/directory-selector-redesign
...
Redesign directory & file selector
2024-09-26 14:14:22 +02:00
Bartłomiej Dach
555d4ffe89
Add failing test case
2024-09-24 17:51:54 +02:00
Bartłomiej Dach
7f8b64bb6d
Redesign directory & file selector (and update usages accordingly)
2024-09-24 14:54:48 +02:00
Marvin Schürz
15c4b1dc8f
Move mouse horizontally in test to make sure it doesn't accidentally maintain aspect ratio
2024-09-24 13:45:03 +02:00
Marvin Schürz
3ad7342964
Add tests for shift and alt modifiers in select box
2024-09-24 13:35:56 +02:00
Bartłomiej Dach
4f57a67ea4
Merge branch 'master' into skinning-colour-customisation
2024-09-24 13:02:22 +02:00
Bartłomiej Dach
d6c17f6ac0
Implement "form" dropdown control
2024-09-23 14:41:39 +02:00
OliBomby
a9ebfbe431
Assert default origin not null in rotation handle
2024-09-23 11:37:42 +02:00
Daniel Cios
59df9cbf0f
Remove nullable disable
2024-09-20 18:07:26 +02:00
Daniel Cios
1a48b46536
Fix test failures
2024-09-19 21:50:59 +02:00
Daniel Cios
b86f246095
Fix code inspection failure
2024-09-19 19:24:05 +02:00
Daniel Cios
c77afe2a13
Add tests
2024-09-19 17:27:26 +02:00
Dean Herbert
bd8addfb5f
Merge pull request #29897 from bdach/editor/setup-screen-slider
...
Implement "form" slider bar control
2024-09-19 19:07:14 +09:00
Dean Herbert
188a430418
Merge branch 'master' into grids-3
2024-09-19 18:21:05 +09:00
Bartłomiej Dach
2d3b027f85
Add test case covering desired behaviour
2024-09-18 15:18:13 +02:00
Bartłomiej Dach
12bd516a57
Shuffle playback order in global playlist by default
...
RFC. Closes https://github.com/ppy/osu/issues/18169 .
Implements the given proposal of keeping the current stable order but
adding a shuffle facility to the now playing overlay, and enabling it by
default.
There are more changes I want to make here but I'd like this to get
discussion first, because I am likely to continue putting this sort of
selection logic into `MusicController` and I just want to confirm nobody
is going to have a problem with that.
In particular this is not sharing the randomisation implementation with
beatmap carousel because it doesn't generalise nicely (song select cares
about the particular *beatmap difficulties* selected to rewind properly,
while the music controller only cares about picking a *beatmap set*).
2024-09-18 14:19:55 +02:00
Bartłomiej Dach
d506d8a150
Implement TabbableContentContainer for slider control
2024-09-18 11:32:55 +02:00
Bartłomiej Dach
95e26e6fd8
Make slider bar instantaneous by default (and fix broken implementation)
2024-09-18 11:23:00 +02:00
Dean Herbert
743d509241
Also ensure filter is applied when returning to song select
2024-09-18 17:22:08 +09:00
Dean Herbert
aae98e6906
Add failing test showing crash at song select on selection edge case
2024-09-18 16:12:34 +09:00
Dean Herbert
2d993645af
Add test coverage of judgements not being synced when resuming a replay
2024-09-18 15:28:10 +09:00
Bartłomiej Dach
1b17231da4
Implement "form" slider bar control
2024-09-17 11:40:57 +02:00
Dean Herbert
5ea7061d5a
Merge pull request #29712 from bdach/editor/setup-screen-checkbox
...
Implement "form" check box control
2024-09-14 02:26:59 +09:00
Bartłomiej Dach
f71ce8869e
Limit width of test scene controls
...
To better reflect what the widths should be in actual usage.
2024-09-13 14:54:10 +02:00
Bartłomiej Dach
2ccb4a48eb
Add test coverage for seeking between objects in editor
2024-09-13 11:40:01 +02:00
Bartłomiej Dach
1292a34b9d
Add failing test coverage for object nudging
2024-09-13 11:39:56 +02:00
Bartłomiej Dach
652a590611
Attempt to address design concerns
2024-09-13 09:59:20 +02:00
Bartłomiej Dach
0e663d1801
Revert default combo counter code to pre-abstractification (and nuke eldritch abstract entity)
2024-09-11 11:44:59 +02:00
Bartłomiej Dach
134bcc85b7
Add failing test case
2024-09-08 16:06:35 +02:00
Dean Herbert
4a6266efcf
Merge pull request #29714 from Crystallized21/total-participation-tooltip
...
Add Total Participation stat to users profile Daily Challenge Tooltip
2024-09-08 22:42:02 +09:00
Bartłomiej Dach
7f814d3106
Fix incorrect tiers being used for tooltip total participation display
...
Compare: 95e4561a54
2024-09-08 14:26:50 +02:00
Dean Herbert
3e3ee3757c
Add failing test case for difficulty splitting
2024-09-07 22:14:02 +09:00
Bartłomiej Dach
7e53df5226
Add failing test coverage
2024-09-06 13:15:21 +02:00
Bartłomiej Dach
2c19b7994c
Implement "form" check box control
2024-09-06 11:45:13 +02:00
Bartłomiej Dach
925710d9b3
Merge pull request #29702 from peppy/fix-offset-control-wrong-order
...
Fix beatmap offset control not working correctly when calibrating from quitting gameplay
2024-09-06 09:39:14 +02:00
Dean Herbert
791ce218fc
Add test coverage of beatmap offset edge case failure
2024-09-05 19:04:52 +09:00
Bartłomiej Dach
49b14ad579
Merge branch 'master' into editor/setup-screen-textbox
2024-09-05 11:22:10 +02:00
Bartłomiej Dach
b7a56c8a45
Implement "form" text box control
2024-09-04 14:09:50 +02:00
Dean Herbert
ca09028b06
Merge pull request #29616 from peppy/break-overlay-animation
...
Add beat-synced animation to break overlay
2024-09-04 19:39:35 +09:00
Bartłomiej Dach
0c4f5bcdaa
Decouple editor main menu items from DrawableOsuMenuItem
...
It didn't ever really make sense for it to be sharing the implementation
details of that (e.g. colouring of primary/dangerous actions), and with
the hotkey display things got outright hacky, so I'm decoupling it
entirely.
2024-09-04 12:16:52 +02:00
Bartłomiej Dach
3c6c49187a
Implement component for displaying hotkeys
2024-09-04 11:57:09 +02:00
Bartłomiej Dach
16c2c14037
Adjust tests further to match new UX
2024-09-02 14:46:40 +02:00
Bartłomiej Dach
d99b2312cd
Merge branch 'master' into Fabep/master
2024-09-02 14:35:44 +02:00
Bartłomiej Dach
10901075be
Modify existing test coverage to demonstrate failure with touch
2024-09-02 11:33:37 +02:00
Dean Herbert
e79604cc13
Merge pull request #29542 from frenzibyte/show-daily-challenge-intro-once-per-session
...
Show daily challenge intro screen once per session
2024-09-01 21:27:16 +09:00
Dean Herbert
a09c6e2a25
Merge pull request #29656 from peppy/provide-api-earlier
...
Provide API context earlier to api requests in order to fix missing schedules
2024-08-30 23:15:28 +09:00
Bartłomiej Dach
4811481483
Merge pull request #29639 from peppy/detached-beatmap-cache
...
Improve song select load and reload with large beatmap databases
2024-08-30 15:00:20 +02:00
Bartłomiej Dach
8b04455c29
Fix chat overlay tests
...
Not entirely sure why they were failing previously, but the most likely
explanation is that by freak accident some mock requests would
previously execute immediately rather than be scheduled on the API
thread, which would change execution ordering and ensure that
`ChannelManager.CurrentChannel` would become the joined channel, rather
than remaining at the channel listing.
2024-08-30 14:57:15 +02:00
Fabian Bech Persson
363fc0d5da
Merge branch 'master' into master
2024-08-30 11:06:54 +02:00
Dean Herbert
a71bc3a24a
Merge pull request #28737 from OliBomby/doubleclick
...
Add more ways to seek to sample points
2024-08-30 16:22:50 +09:00
Dean Herbert
60c1e0fa72
Merge pull request #29440 from OliBomby/spacebar-resume
...
Allow play/pause with spacebar while placing hitobjects
2024-08-30 12:58:41 +09:00
OliBomby
3a1afda2b3
fix test
2024-08-29 22:22:15 +02:00
OliBomby
ba0c4df2a9
Merge remote-tracking branch 'upstream/master' into doubleclick
2024-08-29 19:34:18 +02:00
Dean Herbert
c013974790
Merge branch 'master' into detached-beatmap-cache
2024-08-29 22:49:11 +09:00
Dan Balasescu
fec8fa46fa
Merge pull request #29533 from bdach/fix-sample-bank-stuff-again
...
Fix incorrect bank set / sample addition logic
2024-08-29 21:36:26 +09:00
Dean Herbert
def1abaeca
Fix some tests not always waiting long enough for beatmap loading
...
These used to work because there was a huge blocking load operation,
which is now more asynchronous.
Note that the change made in `SongSelect` is not required, but defensive
(feels it should have been doing this the whole time).
2024-08-29 18:42:43 +09:00
Joseph Madamba
f0b2176c30
Add failing pinned comment replies state test
2024-08-28 22:58:57 -07:00
Dean Herbert
e04b5bb3f2
Tidy up test beatmap loading
2024-08-28 23:28:44 +09:00
Dean Herbert
853023dfba
Reduce test filter count expectation by one due to initial filter being implicit
2024-08-28 23:28:44 +09:00
Dean Herbert
9123d2cb7f
Fix multiple test failures
2024-08-28 23:28:43 +09:00
Dean Herbert
dd4a1104e4
Always debounce external Filter requests (except for tests)
...
The only exception to the rule here was "when screen isn't active apply
without debounce" but I'm not sure we want this. It would cause a
stutter on returning to song select and I'm not even sure this is a
common scenario.
I'd rather remove it and see if someone finds an actual case where this
is an issue.
2024-08-28 19:13:50 +09:00
Dean Herbert
336abadbd1
Allow running initial filter criteria asynchronously
...
This reverts a portion of https://github.com/ppy/osu/pull/9539 .
The rearrangement in `SongSelect` is required to get the initial filter
into `BeatmapCarousel` (and avoid the `FilterChanged` event firing,
causing a delayed/scheduled filter application).
2024-08-28 19:13:50 +09:00
Fabep
6adaf6a41f
Changed ModCustomisationPanelState names
2024-08-28 10:09:47 +02:00
Bartłomiej Dach
a3b0ff4808
Merge branch 'master' into break-overlay-animation
2024-08-27 11:17:56 +02:00
Bartłomiej Dach
321e509f11
Merge pull request #29615 from peppy/break-overlay-improvements
...
Add shadow around break overlay middle content to make sure it remains visible
2024-08-27 11:16:08 +02:00
Bartłomiej Dach
7c0550d251
Merge pull request #29500 from frenzibyte/fix-pausing-for-the-millionth-time
...
Fix oversight in osu! pause input handling
2024-08-27 10:04:47 +02:00
Bartłomiej Dach
e59689f31a
Fix test and NRT failure
2024-08-27 09:49:49 +02:00
Dean Herbert
6f1664f0a6
Add beat-synced animation to break overlay
...
I've been meaning to make the progress bar synchronise with the beat
rather than a continuous countdown, just to give the overlay a bit more
of a rhythmic feel.
Not completely happy with how this feels but I think it's a start?
I had to refactor how the break overlay works in the process. It no
longer creates transforms for all breaks ahead-of-time, which could be
argued as a better way of doing things. It's more dynamically able to
handle breaks now (maybe useful for the future, who knows).
2024-08-27 16:34:37 +09:00
Dean Herbert
c2c83fe73d
Fix TestSceneBreakTracker not removing old drawables
...
Also adds a bright background for testing overlay display.
2024-08-27 14:33:36 +09:00
Salman Ahmed
b54487031a
Add DailyChallengeButton for intro played flag reset logic
2024-08-24 22:19:17 +09:00
Jonas Brandstötter
89a4025c01
Fix Daily Challenge play count using a different colour than osu-web
2024-08-24 11:21:28 +02:00
Salman Ahmed
f5e195a7ee
Remove existing test asserts
2024-08-24 06:40:30 +09:00
Dean Herbert
60271fb0f7
Merge pull request #29564 from peppy/skinnable-components-what-2
...
Remove requirement of `base` calls to ensure user skin container layouts are retrieved
2024-08-23 17:52:46 +09:00
Dean Herbert
48cfd77ee8
Component -> Lookup
2024-08-23 14:48:50 +09:00
Bartłomiej Dach
a32a817305
Merge pull request #29512 from peppy/toolbar-pp-change-weird
...
Fix toolbar PP change showing `+0` instead of `0`
2024-08-22 12:08:12 +02:00
Dean Herbert
b57b8168a6
Rename Target lookup to Component
2024-08-22 19:00:28 +09:00
Dean Herbert
9a21174582
Move GlobalSkinnableContainers to global scope
2024-08-22 18:46:07 +09:00
Dean Herbert
f37cab0c6e
Rename SkinComponentsContainerLookup to GlobalSkinnableContainerLookup
2024-08-22 18:39:36 +09:00
Dean Herbert
41756520b1
Rename SkinComponentsContainer to SkinnableContainer
2024-08-22 17:42:50 +09:00
Dean Herbert
67f0ea5d7d
Fix flooring causing delta to not work as expected
2024-08-22 16:22:00 +09:00
Dean Herbert
7e483bbee3
Merge pull request #29541 from frenzibyte/fix-mod-customisation-dragging-outside
...
Keep mod customisation panel open when dragging outside
2024-08-22 15:28:32 +09:00
Bartłomiej Dach
d33f4837fa
Merge pull request #29532 from bdach/redesign-timing-table-tracking
...
Redesign timing table tracking
2024-08-22 08:21:39 +02:00
Dean Herbert
9b9986b6f2
Add isolated test for daily challenge intro flag
2024-08-22 15:14:52 +09:00
Dean Herbert
236a273e09
Simplify DailyChallengeIntro test scene
...
Seems like some bad copy-paste in the past. Most of this is already
being done in `TestSceneDailyChallenge`.
2024-08-22 15:14:42 +09:00
Dean Herbert
dfb4a76e29
Fix test being repeat step
2024-08-22 14:45:40 +09:00
Dean Herbert
54e5f1c9f0
Merge pull request #29556 from frenzibyte/kiai-star-bursts
...
Add star fountains/bursts when entering kiai mode in gameplay
2024-08-22 14:14:25 +09:00
Salman Ahmed
a669c53df7
Add failing test cases
2024-08-22 06:00:07 +09:00
Dean Herbert
2876cb73bd
Merge pull request #28991 from Layendan/master
...
Add collection and favourite buttons to results screen
2024-08-21 23:59:26 +09:00
Salman Ahmed
c92af71029
Add in-gameplay version of kiai star fountains/burst
2024-08-21 17:34:38 +09:00
OliBomby
ae6d855f8d
Merge remote-tracking branch 'upstream/master' into doubleclick
2024-08-20 23:19:27 +02:00
Salman Ahmed
ae4fefeba1
Add failing test case
2024-08-21 03:22:03 +09:00
Dan Balasescu
2011d5525f
Add flaky test attribute to some tests
...
See occurences like https://github.com/ppy/osu/actions/runs/10471058714 .
2024-08-20 22:21:10 +09:00
Dan Balasescu
44213a34ae
Merge pull request #29508 from peppy/hold-for-menu-sometimes
...
Change "hold for menu" button to only show for touch by default
2024-08-20 21:45:50 +09:00
Bartłomiej Dach
3202c77279
Add failing test
2024-08-20 12:36:05 +02:00
Dean Herbert
a633fcdb49
Merge branch 'master' into redesign-timing-table-tracking
2024-08-20 19:16:03 +09:00
Bartłomiej Dach
333e5b8cac
Remove outdated tests
2024-08-20 11:23:39 +02:00
Dean Herbert
73f2f5cb12
Fix more tests
2024-08-20 17:59:55 +09:00
Dean Herbert
c85b04bca5
Add more test coverage to better show overlapping break / kiai sections
2024-08-20 17:45:44 +09:00
Salman Ahmed
2ecf5ec939
Add further test coverage
2024-08-20 16:47:20 +09:00
Dean Herbert
5ba1b4fe3d
Update test coverage
2024-08-20 01:13:00 +09:00
Bartłomiej Dach
7693d4c039
Merge branch 'master' into master
2024-08-19 14:30:20 +02:00
Dean Herbert
610ebc5481
Fix toolbar PP change showing +0 instead of 0
2024-08-19 20:50:11 +09:00
Bartłomiej Dach
42675be6cf
Merge branch 'master' into additions
2024-08-19 11:13:43 +02:00
Salman Ahmed
9e962ce314
Add failing test case
2024-08-19 14:14:12 +09:00
OliBomby
3d4bc8a2cc
fix tests
2024-08-16 15:04:38 +02:00
Dean Herbert
68bad9a277
Attempt file operations more than once in another test instance
...
See
https://github.com/ppy/osu/pull/29433/checks?check_run_id=28833985792 .
2024-08-16 17:39:45 +09:00
Dean Herbert
5710f0f302
Merge pull request #26254 from frenzibyte/mania-combo-counter
...
Add argon/classic osu!mania combo counter
2024-08-15 17:56:28 +09:00
Dean Herbert
e603888130
Update remaining tests to use new base class (and tidy up V2 suffixes)
2024-08-14 21:09:28 +09:00
Dean Herbert
1665d9a93e
Fix failing test setup
2024-08-14 21:01:35 +09:00
Joseph Madamba
6f2bc7e6f1
Use Content override instead
2024-08-14 00:44:03 -07:00
Dean Herbert
2174510544
Move other V2 tests to new test namespace
2024-08-14 15:51:07 +09:00
Joseph Madamba
c24f1444f9
Directly resolve IBindable<WorkingBeatmap> by making a local variant of DifficultyNameContent
2024-08-13 23:26:18 -07:00
Joseph Madamba
f8796e3192
Move resizing width and background logic to SongSelectComponentsTestScene
2024-08-13 23:26:17 -07:00
Joseph Madamba
2b41f71fd0
Workaround single-frame layout issues with {Link|Text|Fill}FlowContainers
2024-08-13 23:26:17 -07:00
Joseph Madamba
625c6fc7eb
Implement song select v2 difficulty name content component
2024-08-13 23:26:17 -07:00
Joseph Madamba
46d41cb590
Add base song select components test scene
2024-08-13 23:26:17 -07:00
Dean Herbert
e465049050
Merge branch 'master' into mania-combo-counter
2024-08-14 15:12:00 +09:00
Dean Herbert
dd9705b660
Fix file access test failure by forcing retries
...
See https://github.com/ppy/osu/actions/runs/10369630825/job/28708248682 .
2024-08-14 12:26:21 +09:00
Salman Ahmed
7acc1772cb
Add test coverage
2024-08-13 13:07:21 +03:00
Dean Herbert
14a00621f8
Fix occasional test failures in TestSceneBetmapRecommendations
...
The game was being constructed befor the API was setup, which could mean
depending on test execution ordering and speed, the recommendations
array would not be filled.
Easy to reproduce by `[Solo]`ing `TestCorrectStarRatingIsUsed`.
See https://github.com/ppy/osu/runs/28689915929#r0s0 .
2024-08-13 17:28:16 +09:00
Dan Balasescu
4b4f0ecf7d
Merge pull request #29342 from cl8n/remove-mania-action-special
...
Remove "Special" `ManiaAction`s for center columns
2024-08-13 15:36:36 +09:00
Bartłomiej Dach
06c2952fe8
Merge branch 'master' into grids-3
2024-08-12 13:55:35 +02:00
Bartłomiej Dach
92bd123ebc
Merge pull request #29363 from peppy/fix-daily-challenge-notification-spam
...
Fix daily challenge notification spam
2024-08-12 12:18:38 +02:00
Bartłomiej Dach
041c70e4eb
Fix tests
2024-08-12 11:19:02 +02:00
Dean Herbert
c8a7727199
Make ID retrieval global to all tests and fix multiple other usages
2024-08-09 17:46:51 +09:00
