Dan Balasescu
748c2eb390
Refactor RoomSubScreen update
2025-02-11 12:43:54 +09:00
Dan Balasescu
78e5e0eddd
Refactor with a bit more null safety
...
In particular I don't like the non-null assert around
`GetCurrentItem()`, because there's no reason why it _couldn't_ be
`null`.
Consider, for example, if these panels are used in matchmaking where
there are no items initially present in the playlist.
The ruleset nullability part is debatable, but I've chosen to restore
the original code here.
2025-02-11 12:20:09 +09:00
Dean Herbert
8dc616738c
Merge pull request #31844 from bdach/fix-mp-players-appearing-as-spectators
...
Fix spectator list showing other users in multiplayer room even if they're not spectating
2025-02-10 21:49:06 +09:00
Dean Herbert
310700b4e7
Space out comment
2025-02-10 21:48:27 +09:00
Bartłomiej Dach
38e2f793ca
Add menu items to open beatmap info & discussion pages in browser from editor
2025-02-10 12:47:38 +01:00
Bartłomiej Dach
288851c606
Fix score position not being displayed in solo results screen
...
Closes https://github.com/ppy/osu/issues/31842 .
To be honest, I recall this working too, but I don't recall when it
might have broken, nor do I want to go look for the point of breakage
because it might be borderline impossible to find it now. So I'm just
fixing as if it was just a straight omission.
Opting for a client-side fix because server-side inclusion of the score
position for an entire leaderboard has been previously rejected as too
expensive:
https://github.com/ppy/osu-web/pull/11354#discussion_r1689217450
2025-02-10 12:17:52 +01:00
Bartłomiej Dach
ad642b8425
Fix spectator list showing other users in multiplayer room even if they're not spectating
2025-02-10 11:17:17 +01:00
Bartłomiej Dach
3ba56e009e
Privatise a few members
2025-02-10 10:41:10 +01:00
Dean Herbert
b8e33a28d2
Minor code refactors
2025-02-10 17:41:38 +09:00
Bartłomiej Dach
45259b374a
Remove unused using
2025-02-10 09:09:43 +01:00
Bartłomiej Dach
895493877c
Allow performing beatmap reload after submission from song select
2025-02-10 09:03:40 +01:00
Layendan
5e9f195117
Fix tests failing if playlist was empty
2025-02-09 23:27:28 -07:00
Dean Herbert
eae1ea7e32
Adjust animations and induce some short delays to make things more graceful
2025-02-10 15:23:25 +09:00
Dean Herbert
930aaecd7f
Fix back button displaying before it should
2025-02-10 15:22:31 +09:00
Dean Herbert
7853456c06
Add delay before browser displays beatmap
2025-02-10 15:12:59 +09:00
Dean Herbert
274b422139
Add percent progress display to editor footer
2025-02-10 14:51:48 +09:00
Layendan
f9bda0524a
Update button text to include downloaded beatmaps and collection status
2025-02-09 18:45:13 -07:00
Bartłomiej Dach
64f0d234d8
Fix exiting being eternally blocked after successful beatmap submission
2025-02-07 15:37:27 +01:00
Bartłomiej Dach
1afd1f5000
Merge branch 'master' into bss/the-actual-submission
2025-02-07 15:30:37 +01:00
Layendan
d4c69f0c90
Assume room is setup correctly and remove duplicate maps before querying realm
2025-02-07 04:04:29 -07:00
Dean Herbert
d8f3dbf988
Merge branch 'master' into carousel-v2-implement-designs
2025-02-07 19:37:06 +09:00
Layendan
aad12024b0
remove using cache, improve tests, and revert loading
2025-02-07 03:13:51 -07:00
Bartłomiej Dach
a068d88b84
Merge pull request #31823 from peppy/carousel-v2-optimisation-pass
...
Refactor grouping to be much more efficient
2025-02-07 10:44:53 +01:00
Dean Herbert
753eae426d
Update strings
2025-02-07 18:42:41 +09:00
Dean Herbert
783ef00785
Change BeatmapSubmissionScreen to use global back button instead of custom implementation
2025-02-07 18:34:48 +09:00
Dean Herbert
95967a2fde
Adjust beatmap stream creation to make a bit more sense
2025-02-07 18:17:49 +09:00
Bartłomiej Dach
ae179c8feb
Merge pull request #31824 from peppy/carousel-v2-group-click-transfer-keyboard
...
Always transfer keyboard selection on activation
2025-02-07 10:12:10 +01:00
Dean Herbert
12881f3f36
Don't show informational screens for subsequent submissions
...
These are historically only presented to the user when uploading a new
beatmap for the first time.
2025-02-07 18:06:31 +09:00
Dean Herbert
46290ae76b
Disallow changing beatmap / ruleset while submitting beatmap
2025-02-07 18:05:47 +09:00
Dean Herbert
6335228fb0
Merge branch 'master' into bss/the-actual-submission
2025-02-07 17:44:48 +09:00
Dean Herbert
cf4b501214
Merge pull request #31804 from bdach/bss/api-setup
...
Add API request & response structures for beatmap submission
2025-02-07 17:43:38 +09:00
Bartłomiej Dach
9af5ebbca9
Merge pull request #31822 from peppy/dont-submit-zero-scores
...
Don't attempt to submit zero scores
2025-02-07 09:42:38 +01:00
Dean Herbert
177ca4fb7c
Merge pull request #31799 from frenzibyte/carousel-v2-spacing
...
Support variable spacing between beatmap carousel panels
2025-02-07 17:41:28 +09:00
Dean Herbert
29b0b62ffa
Rename variables to something more sane
2025-02-07 17:39:38 +09:00
Dean Herbert
3da615481e
Change switch to simple conditional for now
2025-02-07 17:38:24 +09:00
Dean Herbert
41c8f64806
Simplify naming of endpoints
2025-02-07 17:33:32 +09:00
Dean Herbert
c935c3154b
Always transfer keyboard selection on activation
2025-02-07 17:02:53 +09:00
Dean Herbert
9d979dc3f4
Refactor grouping to be much more efficient
2025-02-07 16:35:20 +09:00
Dean Herbert
50d880e2ae
Fix unnecessary BeatmapSet.Metadata lookups
2025-02-07 16:09:36 +09:00
Dean Herbert
0235928fda
Merge pull request #31815 from smoogipoo/score-panel-ruleset
...
Add ruleset icon to expanded score panel
2025-02-07 16:04:24 +09:00
Dean Herbert
4d1167fdcc
Don't attempt to submit zero scores
2025-02-07 15:36:59 +09:00
Dean Herbert
d73f275143
Don't inflate set / group panels for simplicity
2025-02-07 15:15:59 +09:00
Dean Herbert
1cf375e329
Merge branch 'master' into carousel-v2-spacing
2025-02-07 14:34:59 +09:00
Dean Herbert
975c35f5ac
Also add difficulty icon to contracted panel
2025-02-07 14:27:37 +09:00
Dean Herbert
25846b2327
Adjust results screen designs and tests slightly
2025-02-07 14:21:43 +09:00
Layendan
2aa930a36c
Corrected notification strings
2025-02-06 17:46:49 -07:00
Layendan
6769a74c92
Add loading in case cache lookup takes longer than expected
2025-02-06 17:23:06 -07:00
Layendan
b7483b9442
Add playlist collection button w/ tests
2025-02-06 07:25:45 -07:00
Bartłomiej Dach
91bc23e39e
Merge pull request #31801 from peppy/carousel-v2-artist-grouping
...
Add support for grouping by artist to beatmap carousel v2
2025-02-06 13:13:35 +01:00
Dean Herbert
cb42ef95c5
Add invalidation on draw size change in beatmap carousel v2
...
Matching old implementation.
2025-02-06 17:48:42 +09:00
