1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-18 07:22:57 +08:00
Commit Graph

37996 Commits

Author SHA1 Message Date
Dean Herbert
4269cb7124 Extract majority of token retrieval code out of LoadComponentAsync for legibility 2021-03-25 13:48:41 +09:00
Dean Herbert
ff139c2056 Merge branch 'master' into solo-score-submission 2021-03-25 13:46:29 +09:00
Dean Herbert
4f8edcd336 Don't strip comments from metadata during parsin 2021-03-25 13:35:54 +09:00
Dean Herbert
e22650293d Remove unnecessary second call to StripComments in skin parsing logic 2021-03-25 13:35:42 +09:00
Dan Balasescu
6e103fca99
Merge pull request #12176 from peppy/issue-template-improvements
Include blurb in issue template to hopefully help people find existing reports
2021-03-25 13:05:15 +09:00
Dean Herbert
f8f461a7a4 Include blurb in issue template to hopefully help people find existing reports 2021-03-25 12:33:07 +09:00
Dean Herbert
8753d45b71 Remove duplicate crash report issue template 2021-03-25 12:32:51 +09:00
Salman Ahmed
35810bb2fb Add test coverage 2021-03-24 22:55:15 +03:00
Salman Ahmed
fc5719e445 Fix SkinManager not handling extensions casing comparsion properly 2021-03-24 21:31:53 +03:00
Naxess
9df059b01d Add bounding box limit 2021-03-24 17:25:28 +01:00
Naxess
0f4314c1d8 Add complete arc test
Ensures we can still make smaller circles properly.
2021-03-24 17:24:33 +01:00
Naxess
b4dc35f66b Update large arc tests
Should now be more robust and readable.
2021-03-24 17:24:05 +01:00
Leon Gebler
e67ab3cca7 Change single slider scaling to a method that works 2021-03-24 12:24:11 +01:00
Leon Gebler
3d471d239f Clamp multi-object scale instead of cancelling it 2021-03-24 12:24:11 +01:00
Leon Gebler
def0e5c42e Fix off-by-one error in isQuadInBounds 2021-03-24 12:24:11 +01:00
Dean Herbert
6a37fb41cc
Merge pull request #12161 from MiraiSubject/tournament-disable-rawinput 2021-03-24 14:54:43 +09:00
Dean Herbert
93921af82d
Merge pull request #12163 from owen-young/default-fullscreen 2021-03-24 14:54:03 +09:00
Dean Herbert
5ad8dc316f Add inline comment and improve linq robustness 2021-03-24 14:09:15 +09:00
Naxess
415797aadd Fix broken control point drag test
Broken for 2 reasons:
- Assert checks the wrong control point.
- The exterior arc is now too big.

This fixes both.
2021-03-24 06:01:12 +01:00
Naxess
e0240ab9d9 Increase exterior threshold 2021-03-24 05:55:34 +01:00
Naxess
f80b3ada25 Add circular arc size tests 2021-03-24 05:54:48 +01:00
Dean Herbert
f95175983a Make code more concise and move method to a more appropriate place 2021-03-24 13:37:37 +09:00
Dean Herbert
d55324585d Change RoomSubmittingPlayer's request implementation to return null on RoomID missing, rather than silently succeeding 2021-03-24 13:23:23 +09:00
Dean Herbert
84b2f9a848 Make token private 2021-03-24 13:20:44 +09:00
Dean Herbert
a0c6c4da35 Rename and refactor token request process to be easier to understand 2021-03-24 13:17:29 +09:00
Naxess
7b395ed783 Add exterior arc test 2021-03-24 05:15:50 +01:00
Naxess
23a4d1c135 Shorten recovery test name 2021-03-24 05:15:28 +01:00
Naxess
6fbe530016 Fix coordinates 2021-03-24 05:14:35 +01:00
Naxess
847d44c7d9 Remove unnecessary length asserts
We don't actually care about the length (as this isn't what we're testing), just the type of the slider.
2021-03-24 05:13:37 +01:00
Dean Herbert
e372e355ef Reorder overrides in SoloPlayer to better follow chronological request order 2021-03-24 13:12:51 +09:00
Naxess
7bae4ff43d Add control point dragging tests 2021-03-24 05:06:04 +01:00
Dean Herbert
8bed7748d6 Rename token request method to avoid double Request terminology 2021-03-24 13:02:37 +09:00
Dean Herbert
a1c35677ef Add more xmldoc 2021-03-24 13:02:17 +09:00
Naxess
4ae3eaaac6 Move path type correction
This is better because `PathControlPointVisualizer` is local to the editor, meaning there is no chance that this could affect gameplay.
2021-03-24 03:02:19 +01:00
Naxess
0bcd38e661 Simplify path type maintenance when dragging 2021-03-24 02:57:47 +01:00
Naxess
5ee280f941 Update PointsInSegment when adding/removing points
There was a bug where if you created a slider, moved the last point, and then added a point such that it became a PerfectCurve, it would fail to recover after becoming a Bezier.

This fixes that.
2021-03-24 02:56:32 +01:00
Owen Young
c8542d2434
Merge branch 'master' into default-fullscreen 2021-03-23 19:44:22 -05:00
Owen Young
437dadc85f Changed comment on GetFrameworkConfigDefaults() to be more accurate 2021-03-23 19:37:55 -05:00
Owen Young
67a03ebc23 Fixed formatting issues to be in line with osu coding standards 2021-03-23 19:31:16 -05:00
Owen Young
fbb992fc7e Added a comment to new method 2021-03-23 19:18:32 -05:00
Shivam
d17c431faf Disable relative mode for TournamentGame 2021-03-23 23:22:17 +01:00
Dean Herbert
217f6083ca
Merge branch 'master' into solo-score-submission 2021-03-23 21:12:52 +09:00
Dan Balasescu
bb6e50eb27
Merge pull request #12151 from peppy/fail-dummy-api-requests
Fail all API requests sent to DummyAPIAccess
2021-03-23 20:54:04 +09:00
Dan Balasescu
578128f803
Merge branch 'master' into fail-dummy-api-requests 2021-03-23 20:14:56 +09:00
Dan Balasescu
ade542191a
Merge pull request #12154 from peppy/fix-hitcircle-glow-fade-out
Fix default skin's glow resetting fade on miss
2021-03-23 20:14:51 +09:00
Dan Balasescu
5f956971cc
Merge pull request #12153 from peppy/fix-appproach-circle-fade-out
Always fade out approach circles at a HitObject's start time to better match stable
2021-03-23 20:04:38 +09:00
Dean Herbert
d10ff615fe Fix default skin's glow resetting fade on miss 2021-03-23 19:28:08 +09:00
Dean Herbert
64e85ba995 Always fade out approach circles at a HitObject's start time to better match stable 2021-03-23 19:19:07 +09:00
Dean Herbert
e649a330a4 Implement SoloPlayer's request construction 2021-03-23 18:23:25 +09:00
Dean Herbert
242b847516 Add flow for allowing gameplay to continue even when an error occurs with token retrieval 2021-03-23 18:23:25 +09:00