40782 Commits

Author	SHA1	Message	Date
Dean Herbert	a4be28a2ae	Don't show buttons on fail overlay when player interaction is disabled	2023-11-27 12:25:24 +09:00
Bartłomiej Dach	98ab9853ce	Merge branch 'master' into show-spectator-fail-2	2023-11-27 12:24:59 +09:00
Bartłomiej Dach	e8730fae84	Merge branch 'master' into skin-editor-load-gameplay	2023-11-27 12:14:25 +09:00
Bartłomiej Dach	7e3bb5f8db	Make skin editor overlay dependency nullable to fix tests	2023-11-27 12:09:13 +09:00
Bartłomiej Dach	3f48f4acdf	Remove blank line	2023-11-27 12:06:08 +09:00
Bartłomiej Dach	19639de299	Merge branch 'master' into fix-spectator-quit-2	2023-11-27 11:36:10 +09:00
Bartłomiej Dach	7f788058cd	Revert incorrect xmldoc change	2023-11-27 11:35:10 +09:00
Bartłomiej Dach	1388e492b1	Merge branch 'master' into chat-drag-improvements	2023-11-27 10:46:55 +09:00
Bartłomiej Dach	6f66819e51	Privatise setter	2023-11-27 10:44:50 +09:00
Zyf	71e5654b64	Account for legacyAccScore in score conversion	2023-11-24 23:07:27 +01:00
Zyf	27f9dfccc4	Fix scoring-conversion when miss-count is 0	2023-11-24 22:05:24 +01:00
Dean Herbert	a6cf1e5d2e	Make osu! logo do something when in edit submenu	2023-11-25 00:53:25 +09:00
Dean Herbert	a44edfdedd	Fix incorrect sample for top level edit button	2023-11-24 19:37:57 +09:00
Dan Balasescu	8314f656a3	Encapsulate common HP logic from osu and catch HP calculations	2023-11-24 18:32:06 +09:00
Dean Herbert	3015135178	Merge branch 'master' into chat-drag-improvements	2023-11-24 18:13:18 +09:00
Dean Herbert	7153c823e8	Choose a better beatmap if the intro is still playing ... Also skip intro time.	2023-11-24 17:47:20 +09:00
Dean Herbert	95229cb336	Show gameplay when loading the skin editor from the main menu	2023-11-24 17:47:20 +09:00
Dean Herbert	290c3d6349	Clean up left-overs	2023-11-24 17:46:23 +09:00
Dean Herbert	3b41480bef	Always show drag bar on mobile	2023-11-24 17:46:02 +09:00
Dean Herbert	de1d921383	Merge branch 'master' into menu-skin-editor-button	2023-11-24 17:39:54 +09:00
Dean Herbert	55df8e81b9	Merge pull request #25560 from peppy/hexacons-sprite-icon ... Replace all hexacon lookups with strongly typed properties	2023-11-24 17:38:58 +09:00
Dean Herbert	59800821da	Update framework	2023-11-24 16:44:18 +09:00
Dean Herbert	7600595e5d	Add drag bar on chat overlay to better signal resizability	2023-11-24 16:39:54 +09:00
Dean Herbert	36b45d34f7	Check drag location on mouse down instead of drag start to avoid lenience issues	2023-11-24 16:39:29 +09:00
Dean Herbert	e3217bc82e	Merge branch 'master' into hp-drain-fix-breaks	2023-11-24 15:15:48 +09:00
Dan Balasescu	289cda71b2	Fix inspections	2023-11-24 15:06:51 +09:00
Dean Herbert	7ceb49fbc0	Add extra test coverage and handle case where still at loading screen	2023-11-24 15:05:39 +09:00
Dean Herbert	d3a55d83c0	Schedule FailScore inside onFail instead of onFailComplete	2023-11-24 14:44:57 +09:00
Dean Herbert	ef5dd24589	Update failing test coverage and fix onFail being called too often	2023-11-24 14:44:57 +09:00
Dean Herbert	4ad3cb3b49	Submit and send failed spectator state more aggressively	2023-11-24 14:44:57 +09:00
Dean Herbert	8375dd72d6	Add xmldoc to new AllowFail method	2023-11-24 14:44:57 +09:00
Dean Herbert	ca93fdc94b	Add visualisation of when a spectated player fails ... Create a new stack each time for isolation and safety	2023-11-24 14:44:57 +09:00
Dean Herbert	b024065857	Remove implicit schedule of abstract methods in SpectatorScreen ... This allows each implementation to have control over scheduling. Without this, the solo implementation would not be able to handle quit events while watching a player, as it would push a child (gameplay) screen to the stack where the `SpectatorScreen` would usually be.	2023-11-24 14:26:09 +09:00
Dean Herbert	ed5375536f	Reduce access to various fields and events in SpectatorClient ... Restore some `virtual` specs to appease Moq	2023-11-24 14:26:09 +09:00
Dean Herbert	335e8efff7	Apply NRT to SoloSpecatorScreen	2023-11-24 14:26:09 +09:00
Dean Herbert	dabbdf674b	Rename SoloSpectator to SoloSpectatorScreen	2023-11-24 14:26:08 +09:00
Dean Herbert	4c7d2bb0fb	Apply NRT to SpectatorScreen	2023-11-24 14:26:08 +09:00
Dean Herbert	b8179aa875	Use better(?) icons and full strings	2023-11-24 13:23:47 +09:00
Dean Herbert	a069a673fa	Allow buttons to be displayed on more than one state (and share the back button)	2023-11-24 13:18:17 +09:00
Dean Herbert	1d1b3ca982	Apply NRT to MainMenuButton	2023-11-24 13:18:17 +09:00
Dean Herbert	8ad414488a	Play out previous transforms immediately to avoid flow issues with multiple sub menus	2023-11-24 13:18:17 +09:00
Dean Herbert	7e59a1d0be	Apply NRT to ButtonSystem	2023-11-24 13:18:17 +09:00
Dean Herbert	5905ca6492	Add second level menu for skin editors	2023-11-24 13:18:17 +09:00
Dean Herbert	340227a06d	Replace all hexacon lookups with strongly typed properties	2023-11-24 13:17:39 +09:00
Dean Herbert	95c00f9666	Add HexaconIcons lookup to allow usage with SpriteIcon	2023-11-24 13:17:39 +09:00
Dean Herbert	537b0ae870	Add silly annotation for now (more new r# rules)	2023-11-24 12:47:42 +09:00
Bartłomiej Dach	9541d3d452	Merge pull request #25553 from peppy/skin-player-elements ... Allow use of skin username/flag/avatar components outside of gameplay	2023-11-24 11:28:01 +09:00
Bartłomiej Dach	02c794cc1f	Merge pull request #25552 from peppy/fix-r#-inpsections ... Fix a couple of new r# inspections	2023-11-24 11:04:08 +09:00
Bartłomiej Dach	ca37e1afc2	Merge branch 'master' into scorev3	2023-11-24 10:37:10 +09:00
Bartłomiej Dach	7590bae445	Rename and comment everything in score migration code ... Hopefully, _hopefully_, makes all this a little bit less inscrutable.	2023-11-24 10:34:13 +09:00
Dean Herbert	686afa9697	Merge branch 'master' into fix-combo-handling	2023-11-24 10:30:52 +09:00
Dan Balasescu	10e16e4b04	Fix handling of combo offset without new combo, and incorrect lazer tests	2023-11-24 09:46:06 +09:00
Dean Herbert	268b965ee8	Enable NRT on Beatmap	2023-11-23 17:28:16 +09:00
Dean Herbert	5239fee947	Allow use of skin username/flag/avatar components outside of gameplay	2023-11-23 17:15:03 +09:00
Dean Herbert	a80a5be4ec	Fix a couple of new r# inspections	2023-11-23 17:11:40 +09:00
Dean Herbert	9a6857bfad	Merge pull request #25530 from yesseruser/FlagHUD ... Fix skin element "PlayerFlag" responding to clicks/hovers	2023-11-23 16:51:09 +09:00
Dean Herbert	191e8c5487	Add note about skin editor reload jank	2023-11-23 16:39:05 +09:00
Dan Balasescu	7bc2d6e6cd	Merge branch 'master' into fix-combo-handling	2023-11-23 16:22:01 +09:00
Dean Herbert	5d367c247c	Merge pull request #25547 from bdach/skin-editor-paste-catching-fire ... Fix skin editor crashing when pasting with nothing in clipboard	2023-11-23 16:15:11 +09:00
Dan Balasescu	7998204cfe	Fix combo/combo colouring issues around spinners	2023-11-23 13:54:05 +09:00
Bartłomiej Dach	d4519f74ab	Merge branch 'master' into hp-drain-fix-breaks	2023-11-23 10:31:42 +09:00
Bartłomiej Dach	abbcdaa7f7	Fix skin editor crashing when pasting with nothing in clipboard	2023-11-23 09:55:27 +09:00
Dan Balasescu	30309cdf11	Merge pull request #25415 from Poyo-SSB-forks/unify-ur ... Change unstable rate calculation to account for rate-change mods	2023-11-23 09:53:28 +09:00
Dan Balasescu	5b0f8ee9c2	Merge pull request #25546 from bdach/classic-score-overflow ... Fix classic scoring overflowing in osu! ruleset due to integer multiplication overflow	2023-11-23 09:03:43 +09:00
Bartłomiej Dach	e28e0ef1cc	Fix classic scoring overflowing in osu! ruleset due to integer multiplication overflow ... Closes https://github.com/ppy/osu/issues/25545.	2023-11-23 08:16:25 +09:00
Dean Herbert	52dc02fd32	Merge pull request #25418 from smoogipoo/hp-drain-v1-2 ... Add `OsuHealthProcessor` that uses the legacy drain rate algorithm	2023-11-23 00:08:20 +09:00
yesseruser	82fec4194d	Disabled RecievePositionalInputAtSubTree in PlayerFlag.	2023-11-22 15:45:32 +01:00
yesseruser	08e0279d72	Revert "Renamed UpdateableFlag to ClickableUpdateableFlag." ... This reverts commit 671177e871.	2023-11-22 15:25:43 +01:00
yesseruser	be8b59e59d	Revert "Created and implemened a BaseUpdateableFlag." ... This reverts commit cd7e0bf620.	2023-11-22 15:25:35 +01:00
yesseruser	7bc304f20e	Revert "Added a BaseDrawableFlag without a tooltip, and used it." ... This reverts commit b2f74325ef.	2023-11-22 15:25:17 +01:00
yesseruser	33de27499a	Merge branch 'master' into FlagHUD	2023-11-22 14:36:20 +01:00
Dan Balasescu	cb4568c4a1	Fix first object after break not starting a new combo	2023-11-22 17:22:48 +09:00
Bartłomiej Dach	f1f820bec3	Merge pull request #25523 from peppy/save-skin-on-screen-change ... Save any unsaved changes in the skin editor when game changes screens	2023-11-22 14:19:57 +09:00
Dean Herbert	b30a4ab3a9	Merge pull request #25536 from peppy/combo-commenting ... Improve commenting around `IHasCombo` interfaces	2023-11-22 13:28:03 +09:00
Dean Herbert	d86e743745	Merge branch 'master' into login-state-changes-user-profile-overlay	2023-11-22 12:13:49 +09:00
Dean Herbert	ad6af1d9b7	Ensure only run once	2023-11-22 12:03:42 +09:00
Dean Herbert	fe15b26bd2	Refactor to use API state instead of logged in user state	2023-11-22 12:02:37 +09:00
Dean Herbert	04640b6fb0	Improve commenting around IHasCombo interfaces ... Following discusion with smoogi IRL.	2023-11-22 10:44:29 +09:00
Poyo	3a0586a8f5	Rewrite backwards assertion	2023-11-21 15:19:04 -08:00
Poyo	0cf925dadf	Use better fallback ... Seems better to use the rate from a non-gameplay clock than to arbitrarily apply 1.	2023-11-21 15:18:04 -08:00
Bartłomiej Dach	c98be5823d	Update framework	2023-11-22 07:52:28 +09:00
yesseruser	b2f74325ef	Added a BaseDrawableFlag without a tooltip, and used it. ... The BaseDrawableFlag is used in a BaseUpdateableFlag so the tooltip is not shown, the ClickableUpdateableFlag still shows the tooltip.	2023-11-21 19:51:35 +01:00
yesseruser	cd7e0bf620	Created and implemened a BaseUpdateableFlag. ... The tooltip still shows.	2023-11-21 19:27:33 +01:00
yesseruser	671177e871	Renamed UpdateableFlag to ClickableUpdateableFlag.	2023-11-21 19:02:23 +01:00
Clément Burgelin (Zyfarok)	901e45b6a4	Scoring conversion: remove mention of v3 + improve comments	2023-11-21 14:26:07 +01:00
Clément Burgelin (Zyf)	16acec335f	Fix: update score migration of special case to match the new score ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-11-21 11:27:03 +01:00
Dan Balasescu	8302ebcf1a	Remove default DrainRate value	2023-11-21 19:18:02 +09:00
Dean Herbert	aa749aeb73	Save any unsaved changes in the skin editor when game changes screens ... Closes https://github.com/ppy/osu/issues/25494.	2023-11-21 17:49:57 +09:00
Bartłomiej Dach	85bddab52b	Refactor OnlineStatusNotifier to be more local	2023-11-21 17:36:29 +09:00
Dean Herbert	21bf288277	Merge pull request #25520 from peppy/context-menu-spacers ... Allow context menus to have visible spacers	2023-11-21 16:56:36 +09:00
Bartłomiej Dach	bf972a04ee	Merge pull request #25409 from Tom94/bspline-sliders ... Add free-hand drawing of sliders to the editor	2023-11-21 16:28:14 +09:00
Bartłomiej Dach	d83b2e24e7	Merge pull request #25371 from RatinFX/open-editor-timestamp ... Implement opening editor timestamp links	2023-11-21 15:48:36 +09:00
Dean Herbert	4b2d8aa6a6	Add ToString on PathType for better test output	2023-11-21 15:38:12 +09:00
Dean Herbert	ba6fbbe43c	Update framework	2023-11-21 15:38:12 +09:00
Dean Herbert	3d094f84ad	Fix incorrect parsing of BSpline curve types	2023-11-21 15:38:12 +09:00
Bartłomiej Dach	aa3ff151c0	Fix RoomManager attempting to part room when not online	2023-11-21 15:15:46 +09:00
Bartłomiej Dach	42fada578e	Centralise and improve messaging around online state ... When the server requests a disconnect due to a user connecting via a second device, the client will now log the user out on the first device and show a notification informing them of the cause of disconnection.	2023-11-21 15:15:46 +09:00
Bartłomiej Dach	2391035e49	Remove redundant api field from HubClientConnector	2023-11-21 15:15:46 +09:00
Bartłomiej Dach	1c612e2e0c	Implement client-side disconnection flow	2023-11-21 15:15:45 +09:00
Dean Herbert	7c5345bf7e	Use SimpleErrorNotification for error display	2023-11-21 15:10:41 +09:00
Dean Herbert	917a68eac3	Adjust localisablel strings and keys	2023-11-21 15:08:15 +09:00
Dean Herbert	405ab499e9	Allow context menus to have visible spacers	2023-11-21 14:24:10 +09:00
Stedoss	ec7b82f5e8	Change early return to check for online State instead of IsLoggedIn	2023-11-21 01:55:08 +00:00
Stedoss	5514a53df1	Pass ruleset to callback to prevent ruleset desync	2023-11-21 01:04:46 +00:00
Bartłomiej Dach	b6215b2809	Rename and document SelectFromTimestamp	2023-11-20 21:57:14 +09:00
Bartłomiej Dach	234ef6f923	Rectify selection keep-alive logic	2023-11-20 21:57:14 +09:00
Bartłomiej Dach	246aacb216	Remove unnecessary guard ... Setting a bindable's value to something if that value is already there is a no-op (doesn't trigger bindings / callbacks).	2023-11-20 21:57:14 +09:00
Bartłomiej Dach	0e0ab66148	Simplify parsing code ... Less methods, less smeared around logic, saner data types.	2023-11-20 21:57:12 +09:00
Bartłomiej Dach	c9e8d66e19	Improve xmldoc	2023-11-20 21:02:12 +09:00
Dean Herbert	ded9981d07	Update framework	2023-11-20 17:55:01 +09:00
Bartłomiej Dach	8e39dbbff1	Adjust casing of curve type menu items ... The "Perfect curve" one in particular... fixes test failures, as some tests were relying on this particular casing. But the new version feels more correct anyway, so it's whatever.	2023-11-20 15:42:55 +09:00
Bartłomiej Dach	6d7d826b8b	Fix incorrect legacy conversion when B-splines are used	2023-11-20 15:08:58 +09:00
Bartłomiej Dach	80a3225bb2	Use static BEZIER instead of allocating new every time	2023-11-20 13:35:07 +09:00
Bartłomiej Dach	487326a4c7	Remove pattern matching syntax usage in switch ... Also throw on unknown types.	2023-11-20 13:34:01 +09:00
Bartłomiej Dach	5d1bac6d7a	Remove IToolboxAttachment for now ... The interface doesn't really do anything useful right now because it enforces a common contract, but all usages of the contract go through the concrete implementation, and it inflates the already-huge diff.	2023-11-20 13:17:43 +09:00
Bartłomiej Dach	7820c8ce4d	Decrease redundancy of equality implementations	2023-11-20 12:28:20 +09:00
Bartłomiej Dach	25c1a90047	Change switchexpr to standard switch statement	2023-11-20 12:26:45 +09:00
Bartłomiej Dach	577cb9994c	Move static instances / construction methods closer together	2023-11-20 12:26:43 +09:00
Bartłomiej Dach	33b592f1c7	Update framework (again)	2023-11-20 12:04:30 +09:00
Bartłomiej Dach	b6e3e42445	Merge branch 'master' into bspline-sliders	2023-11-20 12:03:29 +09:00
Clément Burgelin (Zyfarok)	1f88658bad	Fix syntax	2023-11-20 03:05:46 +01:00
Stedoss	bfcca38200	Handle login API state changes in UserProfileOverlay	2023-11-20 02:00:57 +00:00
Zyf	432b88674b	Scoring : change formula parameters to match survey results	2023-11-20 00:02:58 +01:00
Zyf	cadd9b4ace	Merge remote-tracking branch 'upstream/master' into scorev3	2023-11-19 23:53:05 +01:00
Poyo	d9cd546377	Use rate fallback in DrawableHitObject	2023-11-18 12:09:37 -08:00
Dean Herbert	6fa7b4f552	Merge branch 'master' into hp-drain-v1-2	2023-11-17 18:33:03 +09:00
Dean Herbert	bd932a5417	Update localisation analyser ... Pulls in https://github.com/ppy/osu-localisation-analyser/pull/60.	2023-11-17 17:07:21 +09:00
Dean Herbert	b88e3cd26f	Change ResourceStore provided to Skin to be a fallback, not replacement	2023-11-16 20:19:01 +09:00
Dean Herbert	87a76b9ee8	Merge pull request #25478 from Joehuu/fix-comment-markdown ... Fix `CommentMarkdownTextFlowContainer` not inheriting osu! class	2023-11-16 17:39:35 +09:00
Dean Herbert	0a8ede6274	Merge pull request #25469 from Joehuu/argon-hide-counter-labels ... Add ability to toggle labels on argon counter components	2023-11-16 17:01:03 +09:00
Bartłomiej Dach	1e2f1b3ef2	Merge branch 'master' into unload-main-menu-storyboard	2023-11-16 15:46:44 +09:00
Bartłomiej Dach	dbd4f26436	Use alternative method of scheduling storyboard unload	2023-11-16 15:37:53 +09:00
Dean Herbert	b45872d2e0	Merge branch 'master' into argon-hide-counter-labels	2023-11-16 14:20:13 +09:00
Dean Herbert	73eda6c09c	Move non-matching default value to argon skin default speficiation instead	2023-11-16 14:18:49 +09:00
Dean Herbert	39a3313929	Update tooltip description slightly	2023-11-16 14:11:01 +09:00
Joseph Madamba	dc2d574965	Fix comment markdown image not showing tooltips	2023-11-15 19:50:32 -08:00
Joseph Madamba	2b19cf6ce4	Fix comment markdown style regression	2023-11-15 19:50:32 -08:00
Poyo	a73c870712	Allow GameplayRate to be nullable and assert before use	2023-11-15 17:00:35 -08:00
Dean Herbert	7f90db7603	Merge pull request #25472 from bdach/argon-health-folding-in-on-self ... Fix argon health bar folding in on itself when too narrow	2023-11-15 19:02:30 +09:00
Dean Herbert	2987c0e802	Add note about enfocing size methodology	2023-11-15 19:01:52 +09:00
Dean Herbert	189fca2eb6	Merge pull request #25339 from joshika39/change-clickable-avatars-tooltip-for-usergrid ... Add `UserGridPanel` as the `ClickableAvatar` tooltip	2023-11-15 18:01:24 +09:00
Joseph Madamba	7b987266d5	Change behavior of some clickable avatars in line with web	2023-11-15 17:22:36 +09:00
Joshua Hegedus	deef8998f7	reverted the change	2023-11-15 17:22:36 +09:00
Joshua Hegedus	aa9deecafe	added missing comment, fixed incorrect visibility	2023-11-15 17:22:36 +09:00
cs	520642975b	Fix control point hover text and context menu	2023-11-15 07:45:09 +01:00
Bartłomiej Dach	8cd1f08a92	Fix argon health bar folding in on itself	2023-11-15 15:42:45 +09:00
Joseph Madamba	62352ce5f3	Add ability to toggle labels on argon counter components	2023-11-14 20:46:42 -08:00
Joseph Madamba	87ace7565d	Use existing localisation for argon counter component labels	2023-11-14 20:44:33 -08:00
Bartłomiej Dach	159cf41f82	Fix default argon health bar width being zero ... Closes #25460.	2023-11-15 12:53:09 +09:00
Dean Herbert	2264e1e249	Change default value and range of BoxElement's corner radius to match other usages	2023-11-15 10:45:01 +09:00