Dan Balasescu
a0ee86ddd2
Fix improperly considering rate adjustment mods
2022-02-16 19:51:42 +09:00
Dan Balasescu
1f9892802c
Merge pull request #16886 from peppy/clarify-parenthesis
...
Clarify ambiguous conditionals in `LegacyStageBackground`
2022-02-16 19:15:21 +09:00
Dean Herbert
252b945d3b
Merge pull request #16889 from smoogipoo/remove-mod-multiplier
...
Remove mod multipliers from applying to scores
2022-02-16 17:59:26 +09:00
Dean Herbert
28fcad9281
Update failing test to not account for no-longer-existing multiplier
2022-02-16 17:33:55 +09:00
Dean Herbert
23933fc881
Update xmldoc to mention that multipliers are not applied anywhere
2022-02-16 17:32:22 +09:00
Dan Balasescu
4c1413e0c7
No longer require Mod implementation
2022-02-16 16:36:02 +09:00
Dan Balasescu
5dd9771c5f
Remove mod multipliers from being applied to scores
2022-02-16 16:27:27 +09:00
Dan Balasescu
d4bf335fcc
Use score multiplier attribute in ManiaPerformanceCalculator
2022-02-16 16:24:40 +09:00
Dan Balasescu
55d9f0b44b
Store beatmap to a field instead
2022-02-16 16:03:08 +09:00
Dan Balasescu
edd31bf3aa
Revert styling change
2022-02-16 15:51:18 +09:00
Dean Herbert
f703828e1b
Clarify ambiguous conditionals in LegacyStageBackground
2022-02-16 15:27:49 +09:00
Dean Herbert
a1b39a96cf
Merge pull request #16884 from smoogipoo/difficulty-attribute-xmldocs
...
Add XMLDocs to difficulty attribute properties
2022-02-16 14:37:59 +09:00
Dean Herbert
7e24b36f26
Merge branch 'master' into remove-playlistitem-beatmap
2022-02-16 14:24:57 +09:00
Dan Balasescu
84e82ef5e4
Add XMLDocs to difficulty attribute properties
2022-02-16 14:09:19 +09:00
Dean Herbert
74a0e002dc
Merge pull request #16879 from smoogipoo/fix-multi-cache-dependencies
...
Fix incorrectly cached lookup components in tests
2022-02-16 11:51:39 +09:00
Dan Balasescu
5db63a8751
Expose read-only list from request
2022-02-16 11:30:03 +09:00
Dean Herbert
6a08fd57ef
Rename "client" fields in tests to specify whether spectator or multiplayer
2022-02-16 09:52:18 +09:00
Dean Herbert
187870b794
Merge branch 'master' into fix-multi-cache-dependencies
2022-02-16 09:44:37 +09:00
Dean Herbert
081353890c
Merge pull request #16861 from bdach/copy-existing-difficulty
...
Add option to create copy of existing difficulty
2022-02-16 09:23:37 +09:00
Dean Herbert
954ae60b81
Merge branch 'master' into copy-existing-difficulty
2022-02-16 08:55:12 +09:00
Dan Balasescu
3cb123619d
Merge pull request #16843 from peppy/net6
...
Update desktop projects to target .NET 6
2022-02-16 01:05:38 +09:00
Dan Balasescu
ea5bb46fb8
Merge branch 'master' into net6
2022-02-16 00:40:04 +09:00
Dan Balasescu
6e99fe04c3
Revert more NUnit test adapter bumps
2022-02-16 00:39:43 +09:00
Dan Balasescu
f5b34e0313
Fix some test failures due to now-async lookups
2022-02-16 00:01:22 +09:00
Dan Balasescu
b1dbd4abfe
Fix incorrect playlist item <-> availability tracker logic
...
Results in revert to some prior logic for the tracker implementation.
2022-02-15 23:50:12 +09:00
Dan Balasescu
48573d2401
Move test request handling earlier in setup
2022-02-15 23:50:10 +09:00
Dan Balasescu
bdc3b76df0
Remove beatmap bindable from PlaylistItem
2022-02-15 23:50:08 +09:00
Dan Balasescu
94a974e1c9
Make OnlinePlayBeatmapAvailabilityTracker look up the online beatmap
2022-02-15 23:41:50 +09:00
Dan Balasescu
afcb7a4630
Make DrawableRoomPlaylistItem look up the online beatmap
2022-02-15 23:41:50 +09:00
Dan Balasescu
73ce1b324e
Make DrawableRoom look up the online beatmap
2022-02-15 23:41:50 +09:00
Dan Balasescu
ccd265ebe7
Handle beatmap lookup requests in TestRoomRequestsHandler
2022-02-15 23:41:50 +09:00
Dan Balasescu
a5183cec77
Add helper to construct APIBeatmap
2022-02-15 23:41:08 +09:00
Dan Balasescu
539cbe62c6
Fix incorrect usages of user lookup cache in tests
2022-02-15 21:23:24 +09:00
Dan Balasescu
2675bb87ff
Add BeatmapLookupCache as another dependency
2022-02-15 21:05:25 +09:00
Dan Balasescu
c48a0dc993
Move UserLookupCache to online play test dependencies
2022-02-15 20:56:46 +09:00
Dan Balasescu
b2276baf71
Seal OnlinePlayTestScene.CreateChildDependencies()
2022-02-15 20:55:57 +09:00
Dean Herbert
9b7cc632c0
Merge pull request #16876 from smoogipoo/remove-playlistitem-ruleset-mods
...
Remove ruleset and mod bindables from PlaylistItem
2022-02-15 18:05:53 +09:00
Dean Herbert
a8f09a8676
Merge branch 'master' into remove-playlistitem-ruleset-mods
2022-02-15 17:40:39 +09:00
Dan Balasescu
64c14c8fc8
Merge pull request #16877 from peppy/ef-realm-migration-test
...
Add test coverage of EF to Realm migration process
2022-02-15 17:39:53 +09:00
Dan Balasescu
03106e846c
Fix test failures due to async mod icon loads
2022-02-15 17:15:00 +09:00
Dean Herbert
d79845fb1d
Revert NUnit3TestAdaptor
(again)
...
Console output is still broken. See
https://github.com/ppy/osu/runs/5196023462?check_suite_focus=true .
2022-02-15 17:06:34 +09:00
Dean Herbert
b1cf014dc2
Add test coverage of EF to Realm migration process
2022-02-15 17:00:17 +09:00
Dean Herbert
f03de16ee5
Add a test EF database
...
Created on d8a23aad4
(just before skins were migrated to realm).
This contains:
- 2 beatmap sets (intro and disco prince)
- 1 score (set on disco prince using autopilot/DT)
- 1 skin (haxwell)
- 322 named files (from skin)
- 5 named files (from beatmaps)
- 270 total file infos
2022-02-15 16:56:00 +09:00
Dan Balasescu
5b765581d8
Fix free mod selection not showing allowed mods
2022-02-15 16:28:15 +09:00
Dan Balasescu
efeba30b9f
Remove ruleset and mod bindables from PlaylistItem
2022-02-15 16:28:15 +09:00
Dean Herbert
2c3e50a450
Update package references in xamarin props
files
2022-02-15 15:46:25 +09:00
Dean Herbert
334fe1f120
Add AsSplitQuery
specification to avoid optimisation recommendation log messages
2022-02-15 15:23:17 +09:00
Dean Herbert
8ec28dc8bc
Update OsuDbContext
in line with EF changes
2022-02-15 15:19:50 +09:00
Dean Herbert
28b45fa899
Add assertions against null reference for connection usages
2022-02-15 15:19:50 +09:00
Dean Herbert
60153bb69d
Update nuget packages to highest usable versions
...
EF packages are intentionally pinned to 5.0.14 as higher versions no
longer support `netstandard2.1`, which we require for xamarin projects.
2022-02-15 15:19:23 +09:00