810 Commits

Author	SHA1	Message	Date
Salman Ahmed	2734a28115	Merge branch 'master' into tourney-save-changes-button-ux	2022-07-14 04:37:03 +03:00
Salman Ahmed	24df8f6a0d	Enable NRT on save changes button	2022-07-14 04:33:07 +03:00
Salman Ahmed	776d9551e2	Disable "save changes" button by default	2022-07-14 04:16:25 +03:00
Dan Balasescu	b6528b9ff7	Merge pull request #19102 from peppy/fix-ladder-editor-commit-on-selection-change ... Ensure any changes are committed before changing `LadderEditorSettings`'s target match	2022-07-13 22:06:10 +09:00
Dean Herbert	467f83b603	Add non-null assertion missing in BeatmapScoreRow	2022-07-13 18:48:12 +09:00
Dean Herbert	214351a87e	Ensure any changes are committed before changing LadderEditorSettings's target match	2022-07-13 18:32:47 +09:00
Dean Herbert	5c6fa2341f	Fix TeamScoreDisplay not tracking team changes properly	2022-07-13 18:15:59 +09:00
Dean Herbert	1516756d8b	Fix team name not updating on TeamDisplay immediately	2022-07-13 18:10:27 +09:00
Dean Herbert	4dff999ce6	Fix potential null referenced in SeedingScreen ... Also ensure that any update operations only occur when the seeding screen is displayed. They were running in the background until now.	2022-07-13 18:09:55 +09:00
Dean Herbert	b9ad90ce54	Switch TeamWinScreen scheduling to AddOnce	2022-07-13 17:57:45 +09:00
Dean Herbert	11c8a2c16e	Disable tournament client "save changes" button when there's no changes to save	2022-07-13 17:46:09 +09:00
Dean Herbert	bae314a254	Add background on SetupScreen to hide video	2022-07-12 13:03:43 +09:00
Dean Herbert	76be9a829c	Fix mutation after disposal in TeamEditorScreen	2022-07-12 12:59:55 +09:00
Dean Herbert	73e924479f	Find video by recursive check rather than marker interface ... Seems a lot more reliable, and allows falling back to the "main" video in cases which didn't support this previously. A next step may be to allow every screen to support a video based on its screen name, rather than specifying the local `TourneyVideo` every time.	2022-07-11 20:42:05 +09:00
Dean Herbert	00c7101f54	Remove DrawingsScreen world map completely	2022-07-11 20:36:05 +09:00
Dean Herbert	22a51fdc50	Add support for a drawings screen video background	2022-07-11 15:35:00 +09:00
Bartłomiej Dach	a83c45b50e	Fix compile failures from framework breaking change	2022-06-24 16:07:14 +02:00
Dean Herbert	31a447fda0	Update parameter discards	2022-06-24 21:26:19 +09:00
Bartłomiej Dach	26c5b59f6d	Replace usages of string.To{Lower,Upper}()	2022-06-24 11:57:45 +02:00
Dean Herbert	50e40756c4	Rename GracefullyExit to AttemptExit	2022-06-19 12:34:44 +09:00
Dean Herbert	f3c9f9a216	Merge pull request #18751 from frenzibyte/tournament-beatmap ... Improve tournament beatmap JSON storage using lightweight model	2022-06-18 11:00:26 +09:00
Salman Ahmed	4c47996130	TournamentPlayer -> TournamentUser	2022-06-18 02:33:26 +03:00
Salman Ahmed	60903be566	Standardise naming for online ID ... Rather than continuing with `ID` or `Id`, this should follow the new standards and use `OnlineID` instead. Only updating this since it's a newly introduced class.	2022-06-18 01:48:16 +03:00
Salman Ahmed	9f97d1a7db	Replace tournament beatmap storage type with lightweight model	2022-06-18 01:34:09 +03:00
Salman Ahmed	200b23c689	Add lightweight TournamentBeatmap model	2022-06-18 01:30:56 +03:00
Salman Ahmed	b977ce7995	Replace tournament player storage type with lightweight model	2022-06-17 21:35:04 +03:00
Salman Ahmed	f3793c8809	Add lightweight TournamentPlayer model	2022-06-17 21:35:04 +03:00
Dan Balasescu	f8830c6850	Automated #nullable processing	2022-06-17 16:37:17 +09:00
Bartłomiej Dach	f88c568c8d	Update flag sizes after switch to twemoji assets ... The old flags used a size of 150x100, while the new assets based on twemoji use a size of 150x108. Update existing usages to match this new aspect ratio better.	2022-06-15 21:45:47 +02:00
Dean Herbert	c661f2b059	Ensure ChannelManager has access to API from point of construction ... Closes https://github.com/ppy/osu/issues/18451.	2022-06-08 19:15:23 +09:00
Dean Herbert	afbb1fa750	Fix tournament user stat population potentially using wrong ruleset ... `OsuGameBase.Ruleset` is bound [late](7d0470794b/osu.Game.Tournament/TournamentGameBase.cs (L169)) so we must use the ladder one during user retrieval. Closes https://github.com/ppy/osu/issues/18363.	2022-05-23 14:07:11 +09:00
Dean Herbert	218642c300	Update unsafe file write usages	2022-05-16 18:05:27 +09:00
Dan Balasescu	494955aff1	Resolve inspection issues	2022-04-14 13:11:11 +09:00
Dean Herbert	ea672745b0	Add ability to switch between most common tournament scenes using key bindings	2022-04-01 12:44:49 +09:00
Dean Herbert	a06b0a4966	Fix tournament bracket parsing's ruleset refetch logic not working correctly ... Due to equality being based on `ShortName`, it was feasible that the re-fetch exited early (in bindable shortcutting logic) causing the ruleset's `OnlineID` to remain `-1` or something equally wrong. Resolves issue pointed out at https://github.com/ppy/osu/discussions/17538#discussioncomment-2471746.	2022-03-31 18:41:00 +09:00
Dean Herbert	a7a7584d3e	Add test coverage ensuring ruleset ID is correct after bracket read ... Historically, tournament client may have written incorrect `OnlineID` values. We wanted to use `ShortName` to re-fetch the ruleset. This test ensures this flow is working correctly.	2022-03-31 18:39:58 +09:00
Dean Herbert	2938f44e6c	Update PresentExternally usages in line with framework changes	2022-03-24 23:41:07 +09:00
Dean Herbert	df4170b939	Display star ratings in tournament mode using two decimal places	2022-02-27 23:17:04 +09:00
Dean Herbert	297e5ec62e	Remove unused constants	2022-02-27 23:16:04 +09:00
Shivam	4c56458173	Change button location to the right side of dropdown	2022-02-25 15:15:40 +01:00
Shivam	333c0cd4f9	Add open folder button to open currently selected tournament	2022-02-25 14:31:46 +01:00
Dean Herbert	44f2d8a448	Allow game folder migration to fail gracefully when cleanup cannot completely succeed	2022-02-10 19:30:26 +09:00
Bartłomiej Dach	9deeaee404	Fix tournament client not loading ... Caused by a `LoadComponentsAsync()` call being fired from a worker thread, which will throw exceptions since the recent addition of safety checks around that method.	2022-01-27 17:31:12 +01:00
Dean Herbert	5288eedd31	Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID	2022-01-27 15:38:03 +09:00
Salman Ahmed	b2d1bd029d	Turn on high poll rate when tournament chat is expanded	2022-01-22 16:34:57 +03:00
Bartłomiej Dach	03e4ec4214	Merge branch 'master' into realm-integration/score-and-beatmaps	2022-01-15 14:45:42 +01:00
Susko3	19467e58c1	Remove unused params from BDL methods	2022-01-15 01:06:39 +01:00
Dean Herbert	b5f670cc5b	Add far too many fixes for ruleset non-nullable requirements	2022-01-12 23:24:11 +09:00
Dean Herbert	51251e3204	Fix CI reported warnings	2022-01-12 22:39:00 +09:00
Joseph Madamba	5082b0e63f	Fix some identifiers using shortened naming	2021-12-27 20:26:28 -08:00
Joseph Madamba	7de43e3aba	Fix most open compound words in identifiers being closed	2021-12-27 20:26:28 -08:00
Bartłomiej Dach	38702beabf	Merge branch 'master' into i-ruleset-store	2021-12-04 15:05:39 +01:00
Dean Herbert	1eed2436e6	Clean up unused resolved properties	2021-12-03 18:49:49 +09:00
Dean Herbert	e75e209053	Cache and consume IRulesetStore where feasible	2021-12-03 18:16:01 +09:00
Dean Herbert	5158736839	Avoid saving bracket if parsing failed, at all costs	2021-12-03 16:06:38 +09:00
Dean Herbert	ba05a0a383	Centralise specification of bracket.json filename	2021-12-03 16:04:11 +09:00
Bartłomiej Dach	87d6a743dd	Migrate custom tournament client assets to uppercased directories ... It has transpired that on filename-case-sensitive filesystems, the tournament client does not consistently handle custom asset paths. Videos and mods could only be looked up from `videos` and `mods` directories (lowercase), while flags could only be looked up from the `Flags` directory (uppercase). A complicating circumstance is that default country flags, coming from osu-resources, also depend on the flag lookup being uppercased. To attempt to clean up the handling as much as it appears to be possible, automatically move user-supplied lowercase directories to uppercase.	2021-11-28 16:36:19 +01:00
Dean Herbert	bbd3ea5b77	Update all actual usages of RulesetInfo.ID to use OnlineID instead	2021-11-24 15:50:26 +09:00
Dean Herbert	86540d1fb6	Update existing usages of Author as string to access Username directly	2021-11-04 18:57:54 +09:00
Dean Herbert	b9983add15	Rename User to APIUser and move to correct namespace	2021-11-04 18:21:31 +09:00
Dean Herbert	10a9266956	Fix beatmap creator showing twice in tournament map pool panels	2021-11-01 14:33:24 +09:00
Dean Herbert	6f5040722a	Merge branch 'master' into beatmap-refactor/uncontested	2021-10-28 16:37:26 +09:00
Dan Balasescu	f9ca7f5df1	Merge pull request #15319 from peppy/beatmap-refactor/tournament ... Remove all usage of `BeatmapInfo` / `BeatmapSetInfo` from tournament mode	2021-10-28 16:26:06 +09:00
smoogipoo	313f78cbfb	Fix non-null inspection	2021-10-28 15:24:44 +09:00
Dean Herbert	a6669a3892	Add mention of why the serialisation happens outside stream usage	2021-10-28 15:04:09 +09:00
Dean Herbert	ef26b0ba8a	Fix serlialisation failure during ladder saving causing all existing file content to be deleted	2021-10-28 15:00:30 +09:00
Dean Herbert	f3d208fecf	Remove TODO (tested to work correctly)	2021-10-28 14:48:36 +09:00
Dean Herbert	7245baba69	Remove IBeatmapSetOnlineInfo implementation from BeatmapSetInfo to avoid null cases	2021-10-28 00:50:45 +09:00
Dean Herbert	f1499641f3	Rename all usages of APIBeatmap to beatmap in tournament namespace	2021-10-27 18:42:48 +09:00
Dean Herbert	5448b94039	Change repopulation rules to cover the fact that the serisalisation model has changed ... This also adds a progress display to show how repopulation is going. It can take a while on a large bracket.	2021-10-27 18:42:48 +09:00
Dean Herbert	35168948fe	Fix PopulateUser not populating immediately when immediate is specified (due to scheduling)	2021-10-27 18:26:44 +09:00
Dean Herbert	3130616300	Update tournament components to use APIBeatmap directly	2021-10-27 18:26:44 +09:00
Dean Herbert	6944151486	Apply batch fixing of built-in types using var	2021-10-27 13:04:41 +09:00
Dean Herbert	7111f58bfe	Fix tournament client silently failing on error during parsing	2021-10-25 16:49:33 +09:00
Dean Herbert	7c99193ada	Add tournament LadderInfo serialisation tests	2021-10-25 16:49:33 +09:00
Dean Herbert	32d01f022f	Rename usages which rely on online backing	2021-10-21 16:58:42 +09:00
Dean Herbert	0706ad70fb	Move BeatmapSetOnlineInfo to an interface type	2021-10-21 16:58:42 +09:00
Dean Herbert	794b4c46cf	Split score counter class into two distinct classes to simplify usages	2021-10-10 17:56:32 +09:00
Dean Herbert	446f091d32	Use comma separator for tournament score displays	2021-10-10 16:06:12 +09:00
Dean Herbert	672664dce7	Fix all remaining cases of incorrect Bindable<string> defaults	2021-10-08 13:55:22 +09:00
Dean Herbert	42d3fe8f02	Merge branch 'master' into fix-SettingsTextBox-using-null-as-default	2021-10-08 13:37:28 +09:00
Dan Balasescu	4bbff2ebf7	Merge branch 'master' into new-interfaces	2021-10-06 11:38:17 +09:00
Dean Herbert	b41fa41c85	Rename APIRequest.Result to Response	2021-10-05 14:28:56 +09:00
Dean Herbert	1d99bc280f	Merge branch 'master' into new-interfaces	2021-10-04 20:42:40 +09:00
Dean Herbert	ec61c3c5ee	Rename all remaining cases	2021-10-03 00:55:29 +09:00
Dean Herbert	973c31132b	Rename BeatmapInfo variables which were named beatmap for clarity	2021-10-02 12:45:34 +09:00
Susko3	6d6fda8337	Fix some usages of SettingsTextBox using a bindable with null as default	2021-10-01 19:55:22 +02:00
Dean Herbert	05996cc2e9	Add changes that got forgotted in branch surgery	2021-10-01 17:04:53 +09:00
Dean Herbert	cf633973a9	Refactor exposed mod retrieval methods for better safety	2021-09-10 11:09:13 +09:00
Dean Herbert	2edb851008	Add ability to lookup mod from a type specification	2021-09-09 16:50:59 +09:00
Dean Herbert	4d0530ca9d	Add new methods to ruleset for quicker mod lookups	2021-09-09 16:46:14 +09:00
Bartłomiej Dach	acf38c723a	Move labelled dropdown from tournament to main game	2021-08-30 21:37:08 +02:00
Dean Herbert	6ef096001e	Fix several cases of incorrect handling of CurrentMatch nullability	2021-08-28 16:24:36 +09:00
Dean Herbert	e9b97f7937	Fix tournament crashing when osu!(stable) is at ranking screen at startup	2021-08-28 14:28:33 +09:00
Dean Herbert	aa4c6b9341	Bring across tournament score display for game usage	2021-08-09 16:30:37 +09:00
Dean Herbert	e08b1223ab	Move team colours to OsuColour	2021-08-09 16:30:37 +09:00
Dean Herbert	081dafc4e4	Update existing inline usages to use new extension method	2021-07-31 16:46:02 +09:00
Dean Herbert	6249ce0ea3	Add a warning and link for more information on drawings.txt population	2021-07-30 13:21:50 +09:00
Dean Herbert	fc66476107	Merge branch 'master' into dont-throw-on-missing-drawings	2021-07-30 13:10:03 +09:00
Dean Herbert	77b354bfba	Resolve ruleset from store after loading tournament ladder	2021-07-30 02:12:03 +09:00