3091 Commits

• Merge branch 'master' into verify-tab
  Dean Herbert · 2021-04-13 23:05:48 +09:00
  1ff4e2076f
• Add missing period
  Naxess · 2021-04-13 13:57:56 +02:00
  69da804f81
• Fix typo in xmldoc
  Dean Herbert · 2021-04-13 20:18:18 +09:00
  0d6890243f
• Split out general checks into its own verifier class (and remove static usage)
  Dean Herbert · 2021-04-13 19:50:22 +09:00
  03ba04e8ce
• Rename BeatmapVerifier -> IBeatmapVerifier
  Naxess · 2021-04-13 11:02:01 +02:00
  aa5fe2e9fc
• Make BeatmapVerifier an interface
  Naxess · 2021-04-13 10:40:56 +02:00
  60c2494b31
• Use is class instead of Equals with template index

  Ensures ordering of `PossibleTemplates` does not affect tests.

  Naxess · 2021-04-13 02:29:25 +02:00
  6d3f9fa9ce
• Add Equals method to IssueTemplate

  This will be useful in tests.

  Naxess · 2021-04-13 01:21:34 +02:00
  d8088777ea
• Merge branch 'master' into mod-using-reference-equality
  Salman Ahmed · 2021-04-12 20:56:24 +03:00
  9679bdfed2
• Take current mod settings value into account on equality comparsion
  Salman Ahmed · 2021-04-12 20:51:13 +03:00
  92fab653e1
• Rename checkOrigin -> check

  More consistent with `Issue.ctor`'s "template".

  Naxess · 2021-04-12 17:28:12 +02:00
  19a154ddf1
• Remove check ctors and locals
  Naxess · 2021-04-12 17:12:37 +02:00
  bb720c23a0
• Remove redundant parameter naming
  Dean Herbert · 2021-04-12 23:37:47 +09:00
  62c1812282
• Move nested classes to bottom of file
  Dean Herbert · 2021-04-12 23:36:10 +09:00
  36bd235021
• Make IssueTemplate.Check readonly
  Naxess · 2021-04-12 16:23:05 +02:00
  6d50d01186
• Rename Check -> ICheck
  Naxess · 2021-04-12 16:20:53 +02:00
  caaaba5950
• Reverse IssueType ordering

  Reversed both in the enum and where it's displayed, so ends up the same in the end.

  Naxess · 2021-04-12 15:49:13 +02:00
  008dbc7dd6
• Rework template usage

  Includes moving the origin check back to templates, constructing nested template classes in each check, and making parameterized template usage.

  Naxess · 2021-04-12 15:47:26 +02:00
  7c4f6d2b62
• Remove empty <returns> xmldoc
  Dean Herbert · 2021-04-12 17:46:14 +09:00
  b5954a55ad
• Rename CreateChecker -> CreateBeatmapVerifier
  Naxess · 2021-04-12 10:08:30 +02:00
  a2fc9c398f
• Move check origin from IssueTemplate to Issue

  As a result we can also make check an interface, and need to provide the check itself when constructing an issue.

  Naxess · 2021-04-12 10:08:08 +02:00
  65ebdd8f7a
• Change Metadata into a get property
  Dean Herbert · 2021-04-12 15:52:29 +09:00
  8bf85d737c
• Tidy some remaining code
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  78bbc8f5c8
• Change some methods to get properties
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  8c31e96cdf
• Move enums out of nesting
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  f78239c7f2
• Fix formatting of colour getter
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  3551322f1d
• Colour constants to private
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  257acf9cd8
• Wrap xmldoc less and make a few fixes
  Dean Herbert · 2021-04-12 15:52:18 +09:00
  136627b9ac
• Checker -> BeatmapVerifier
  Dean Herbert · 2021-04-12 15:29:05 +09:00
  1c553b5d48
• Merge branch 'master' into verify-tab
  Dean Herbert · 2021-04-12 15:14:37 +09:00
  14bd5bdc77
• Merge branch 'master' into mod-using-reference-equality
  Salman Ahmed · 2021-04-11 19:48:55 +03:00
  18fb9f5ac9
• Merge Check and BeatmapCheck

  We're probably not going to need GeneralChecks or BeatmapsetChecks.
  
  The verify tab is only available to a single difficulty at a time, and we already have access to the rest of the set through `IBeatmap`.

  Naxess · 2021-04-10 14:56:30 +02:00
  3289bb0379
• Replace checks with realistic ones
  Naxess · 2021-04-10 13:03:16 +02:00
  bc4f3351f3
• Fix comment; mode -> ruleset
  Naxess · 2021-04-10 13:02:36 +02:00
  b30e41b805
• Move components to more appropriate spot
  Naxess · 2021-04-10 13:02:22 +02:00
  d1007ff26a
• Merge pull request #11688 from Syriiin/diffcalc/dynamic-history

  Implement dynamic previous hitobject retention for Skill class

  Dan Balasescu · 2021-04-10 01:25:07 +09:00
  9aa30fb323
• Implement custom enumerator for ReverseQueue to avoid allocations
  Samuel Cattini-Schultz · 2021-04-10 01:16:54 +10:00
  bfd3d0cce9
• Remove unused using
  smoogipoo · 2021-04-09 13:58:24 +09:00
  76981f2547
• Remove obsolete code
  smoogipoo · 2021-04-09 13:56:58 +09:00
  8293b06c0a
• Merge branch 'master' into circular-arc-freeze
  Dean Herbert · 2021-04-08 14:33:03 +09:00
  a8839792fd
• Add ruleset-specific checker
  Naxess · 2021-04-07 14:36:43 +02:00
  0343ef7f14
• Add check/issue classes
  Naxess · 2021-04-07 14:35:33 +02:00
  b24ce66a0d
• Refactor to keep a consistent API
  smoogipoo · 2021-04-06 16:39:02 +09:00
  37e30b00bf
• Merge pull request #12303 from smoogipoo/fix-last-control-point-segmenting

  Make last control point not able to make an implicit segment

  Dean Herbert · 2021-04-06 13:35:55 +09:00
  784552022f
• Set default history retention to 0 for Skill and override in StrainSkill

  Some skills might not even require history retention, so why waste the allocations?

  Samuel Cattini-Schultz · 2021-04-06 11:53:31 +10:00
  5cd43b3a7f
• Merge branch 'master' into diffcalc/dynamic-history
  Samuel Cattini-Schultz · 2021-04-06 11:34:33 +10:00
  4f614a703e
• Add more descriptive xmldoc for ReverseQueue
  Samuel Cattini-Schultz · 2021-04-06 11:30:58 +10:00
  65f93d6f9d
• Update xmldocs

  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

  Samuel Cattini-Schultz · 2021-04-06 11:06:10 +10:00
  ffe7edc16a
• Merge branch 'master' into diffcalc/refactor-strain-skill
  Dan Balasescu · 2021-04-06 08:21:38 +09:00
  9d8a26f373
• Refactor Skill.Process() to not require calling base.Process()
  Samuel Cattini-Schultz · 2021-04-05 22:14:59 +10:00
  5bdd15f746