9126 Commits

• Manual fixes to reduce warnings to zero
  Dean Herbert · 2023-06-24 01:52:53 +09:00
  df5b389629
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Merge branch 'master' into no-confirmation-on-update-restart
  Dean Herbert · 2023-06-23 15:33:01 +09:00
  1dc7c05c12
• Expose all notifications from INotificationOverlay

  Also fixes `HasOngoingOperations` not actually working.

  Dean Herbert · 2023-06-23 15:19:21 +09:00
  7fa07805b0
• Move confirmation bypass implementation to MainMenu to allow for more correct logic
  Dean Herbert · 2023-06-23 14:42:56 +09:00
  11a97e1bb8
• Add Schedule to ensure correct thread for UI code
  Dean Herbert · 2023-06-23 14:07:33 +09:00
  343271751a
• Bind to API.State instead of API.User
  Dean Herbert · 2023-06-23 14:05:02 +09:00
  ce1579f2fe
• Merge branch 'master' into comment-logged-out
  Bartłomiej Dach · 2023-06-22 23:19:00 +02:00
  c06b825d9b
• Rename and xmldoc members
  Bartłomiej Dach · 2023-06-22 23:00:52 +02:00
  786deec296
• Merge pull request #23888 from peppy/fix-intro-playing-twice

  Fix music sometimes restarting twice if exiting song select with no beatmap selected

  Bartłomiej Dach · 2023-06-22 22:49:15 +02:00
  0ce4d17e30
• Merge branch 'master' into skin-editor-beatmap-skin-disable
  Bartłomiej Dach · 2023-06-22 20:30:51 +02:00
  a11b3a67fb
• Remove unused using directive
  Bartłomiej Dach · 2023-06-22 20:24:44 +02:00
  aea5eb37dc
• Don't require exit confirmation when there are no ongoing operations that could be interrupted
  Dean Herbert · 2023-06-21 19:06:28 +09:00
  59b1f08d53
• Add method to queue a restart after app is exited (when supported)
  Dean Herbert · 2023-06-21 19:06:28 +09:00
  c3f772f0da
• Change skin editor flow to always save on toggle

  This also moves the beatmap skin disable toggle to on toggle, in line
  with review feedback.
  
  I've decided to always apply the disable, not just on the `Player`
  screen. It should be assumed that if a user is in the skin editor they
  are never going to need access to this anyway.

  Dean Herbert · 2023-06-21 16:14:47 +09:00
  cb0f642ad7
• Use bindable lease instead of reimplementing the same thing locally
  Dean Herbert · 2023-06-21 16:09:54 +09:00
  366dd96875
• use two separate buttons for posting / login
  Liam DeVoe · 2023-06-21 00:58:43 -04:00
  cc764afe3e
• move commitButton.Text update to appropriate method
  Liam DeVoe · 2023-06-21 00:37:54 -04:00
  8460873e61
• Disable beatmap skinning when entering the skin editor
  Dean Herbert · 2023-06-20 19:18:17 +09:00
  d7b486e2ac
• Apply more correct fix for double-playing menu track
  Dean Herbert · 2023-06-20 18:35:51 +09:00
  2e02b4a85b
• Allow notifications while the game is paused (or in break time)

  RFC. This is to allow notifications to show at the pause screen
  (specifically for #23967, where exports are now happening).
  
  Not sure about the break time part of this, but might be fine? The
  toasts are immediately flushed before break time ends.

  Dean Herbert · 2023-06-20 16:57:35 +09:00
  7b69b92eab
• rename GetTextBoxPlaceholder to GetPlaceholderText
  Liam DeVoe · 2023-06-19 22:05:18 -04:00
  60eedbafd1
• use runOnceImmediately instead of duplicating logic
  Liam DeVoe · 2023-06-19 18:20:16 -04:00
  f7dde53f9b
• extract button text properties to methods, show login overlay on click
  Liam DeVoe · 2023-06-19 18:10:37 -04:00
  591277e0f9
• resolve protected API in comments superclass
  Liam DeVoe · 2023-06-19 17:36:40 -04:00
  d5d494f07b
• disable posting comments when logged out
  Liam DeVoe · 2023-06-19 17:08:04 -04:00
  4a9543092a
• Fix beatmap info not showing individual difficulty bpm
  Joseph Madamba · 2023-06-19 11:05:29 -07:00
  362fe62b4b
• Document DrawableChatUsername members
  Bartłomiej Dach · 2023-06-18 18:46:49 +02:00
  ee08ed414c
• Rename constant
  Bartłomiej Dach · 2023-06-18 18:46:49 +02:00
  a2a9823d84
• Improve UsernameColour documentation
  Bartłomiej Dach · 2023-06-18 18:46:49 +02:00
  dad32817ee
• Revert to non-bindable AccentColour

  Not necessary for now, so let's not incur unnecessary overheads.

  Bartłomiej Dach · 2023-06-18 18:46:49 +02:00
  bd174b5193
• Avoid resolving realm Live more than once
  Dean Herbert · 2023-06-19 01:06:45 +09:00
  db445660e7
• Fix some code layout and NRT some classes
  Dean Herbert · 2023-06-19 01:03:43 +09:00
  425d3c23f5
• Add TODO for future support of typical search shortcuts
  Bartłomiej Dach · 2023-06-18 15:58:50 +02:00
  b4c1266fc5
• Dynamically change placeholder to convey how to activate search
  Bartłomiej Dach · 2023-06-18 15:58:50 +02:00
  b87acfa66f
• Switch search box to initially unfocused

  Done primarily to keep mod hotkeys working without any behavioural
  changes when mod select is opened.

  Bartłomiej Dach · 2023-06-18 15:58:50 +02:00
  75300ca229
• Merge branch 'master' into add-mod-search-option
  Bartłomiej Dach · 2023-06-18 15:06:21 +02:00
  9ba4bf5fb7
• Fix bugged initial state of matching filter flag

  Was preventing mod preset panels from refiltering correctly on ruleset
  change due to the `matchingFilter == value` guard.

  Bartłomiej Dach · 2023-06-18 14:51:52 +02:00
  d4c9eb013e
• Reword comments in ModSelectOverlay
  Bartłomiej Dach · 2023-06-18 14:34:33 +02:00
  a49af06e88
• Remove yet another redundant guard
  Bartłomiej Dach · 2023-06-18 14:28:26 +02:00
  28f929dc4d
• Remove obvious comment
  Bartłomiej Dach · 2023-06-18 14:04:00 +02:00
  4c78144d10
• Fix duplicate linq and reword comment
  Bartłomiej Dach · 2023-06-18 14:03:26 +02:00
  64e96c6d82
• Remove duplicated xmldoc and move into relevant region
  Bartłomiej Dach · 2023-06-18 13:59:36 +02:00
  a1015b4145
• Remove redundant guard

  `Bindable` has one of those already.

  Bartłomiej Dach · 2023-06-18 13:58:25 +02:00
  1b4d7db1e6
• Remove unused property
  Bartłomiej Dach · 2023-06-18 13:58:25 +02:00
  c7e8990576
• Rename ModState members to better convey what's what
  Bartłomiej Dach · 2023-06-18 13:58:25 +02:00
  62f01e4f40
• Apply osu! side changes in line with FocusedOverlayContainer.PopIn abstract change

  See https://github.com/ppy/osu-framework/pull/5834

  Dean Herbert · 2023-06-18 20:57:32 +09:00
  eb31fdecee
• Fix beatmap info length tooltip not showing actual drain length
  Joseph Madamba · 2023-06-17 15:00:32 -07:00
  9ae864c219
• Move OrderByTotalScore() to an extension method
  Dean Herbert · 2023-06-16 15:24:30 +09:00
  ce41ef6e5d
• Remove unused load dependency
  Joseph Madamba · 2023-06-14 08:09:03 -07:00
  45e67fbe78