87 Commits

• Remove unused using directive
  Bartłomiej Dach · 2023-06-22 20:24:44 +02:00
  aea5eb37dc
• Change skin editor flow to always save on toggle

  This also moves the beatmap skin disable toggle to on toggle, in line
  with review feedback.
  
  I've decided to always apply the disable, not just on the `Player`
  screen. It should be assumed that if a user is in the skin editor they
  are never going to need access to this anyway.

  Dean Herbert · 2023-06-21 16:14:47 +09:00
  cb0f642ad7
• Use bindable lease instead of reimplementing the same thing locally
  Dean Herbert · 2023-06-21 16:09:54 +09:00
  366dd96875
• Disable beatmap skinning when entering the skin editor
  Dean Herbert · 2023-06-20 19:18:17 +09:00
  d7b486e2ac
• Fix weird state when attempting to enter gameplay skin editor scene from multiplayer

  Closes https://github.com/ppy/osu/issues/23626.

  Dean Herbert · 2023-05-23 17:58:44 +09:00
  adf9a596b5
• Trim comments

  Leaving only the ones that add anything useful and do not restate the
  code verbatim.

  Bartłomiej Dach · 2023-05-03 19:22:52 +02:00
  1d4d31e35c
• Rename variables for legibility

  Having `typedComponents` and `typeComponents` next to each other is
  asking for trouble.

  Bartłomiej Dach · 2023-05-03 19:21:16 +02:00
  27fabd99fb
• Revert SaveState() calling on initialization
  Terochi · 2023-05-01 12:53:58 +02:00
  4d52ce769b
• Use Queue instead of Stack
  Terochi · 2023-04-30 16:36:01 +02:00
  fb4b681cc5
• Addressed changes
  Terochi · 2023-04-30 16:11:52 +02:00
  8f02bd80f9
• Improved logic
  Terochi · 2023-04-30 12:05:55 +02:00
  949dc1c0f9
• Fixed ApplyStateChange to happen in correct order
  Terochi · 2023-04-30 02:01:18 +02:00
  8ec2154965
• Save first state when editing
  Terochi · 2023-04-29 20:54:19 +02:00
  17e4b75dfd
• Improved logic for ApplyStateChange for skin editor
  Terochi · 2023-04-29 19:52:22 +02:00
  3b0ba4b38b
• Merge branch 'master' into skin-editor-cyclic-selection
  Dean Herbert · 2023-03-14 20:43:56 +09:00
  6546f5968a
• Merge branch 'master' into make_skin_reset_dangerous
  Bartłomiej Dach · 2023-03-07 21:06:44 +01:00
  5213bfa5c9
• Fix localisations
  Dean Herbert · 2023-03-07 18:07:53 +09:00
  97bee4db89
• Rename confirmation dialog class to mention revert not reset
  Dean Herbert · 2023-03-07 18:07:46 +09:00
  26ef7c2637
• Add optional support for cyclic selection to BlueprintContainer
  Dean Herbert · 2023-03-07 14:22:12 +09:00
  21bdbb20e6
• make ResetConfirmDialog properly utilise its parent's logic

  Adjust name of `DeleteAction` to `DangerousAction`

  mk56-spn · 2023-03-05 20:57:26 +01:00
  908651cc11
• Clear components sidebar unconditionally on every target change

  Fixes the working layer dropdown lingering after exiting from a
  skinnable screen to a non-skinnable one.

  Bartłomiej Dach · 2023-03-04 14:10:05 +01:00
  60cdd3c070
• Show non-skinnable screen placeholder at higher level
  Bartłomiej Dach · 2023-03-04 13:49:10 +01:00
  d233f3a3ab
• Accept ISerialisableDrawableContainer directly in SkinBlueprintContainer

  An end result of #22674 is that `SkinBlueprintContainer`s are only ever
  created by supplying a `SkinComponentsContainer` to them. However,
  `SkinBlueprintContainer` still contained remnants of code that suggested
  it was designed to handle cases where more than the drawable supplied to
  it contained more than one `ISerialisableDrawableContainer`, or even
  zero.
  
  The zero path is totally dead right now (because every
  `SkinComponentsContainer` is *by necessity* an
  `ISerialisableDrawableContainer`), and the more-than-one path is dead
  *for now* (and potentially forever?). Therefore, just hard-couple
  `SkinBlueprintContainer` to receive a single target container.

  Bartłomiej Dach · 2023-03-04 13:33:21 +01:00
  49e298e304
• Move NonSkinnableScreenPlaceholder to outer scope
  Bartłomiej Dach · 2023-03-04 13:22:43 +01:00
  2f25fb4083
• Fix skin selection not clearing on exit to non-skinnable screen
  Bartłomiej Dach · 2023-03-04 13:18:34 +01:00
  15409b9c15
• Adjust reversion header text naming.
  mk56-spn · 2023-03-03 15:12:20 +01:00
  2b7111867c
• Rename DeleteConfirmationDialog.cs into DangerousActionDialog.cs
  mk56-spn · 2023-02-27 21:57:59 +01:00
  90227a6496
• Make ResetConfirmDialog inherit from DeleteConfirmationDialog
  mk56-spn · 2023-02-27 21:50:27 +01:00
  00a00ead22
• Upper case web using alias
  mk56-spn · 2023-02-27 21:34:07 +01:00
  1239de6f41
• Adjust warning text slightly.
  mk56-spn · 2023-02-27 16:08:14 +01:00
  bf1897a98f
• Make reverting changes to a given skin into a "dangerous action"
  mk56-spn · 2023-02-26 20:38:50 +01:00
  ff0d1aa9f7
• Set better defaults for SkinBlueprint transforms
  Dean Herbert · 2023-02-23 21:10:15 +09:00
  dc3c1150b8
• Fix undo history not being batched correctly for depth change operations
  Dean Herbert · 2023-02-23 20:03:36 +09:00
  c48aceb055
• Add ability to send selected skin components to front or back
  Dean Herbert · 2023-02-22 18:17:20 +09:00
  16c8a392a1
• Merge branch 'master' into skin-editor-layer-select
  Bartłomiej Dach · 2023-02-21 21:38:51 +01:00
  051eb18b33
• Merge branch 'master' into skin-editor-clipboard
  Bartłomiej Dach · 2023-02-21 19:35:58 +01:00
  ec1bf7b0b2
• Change placeComponent to only add to selection, not clear an existing selection
  Dean Herbert · 2023-02-21 14:11:18 +09:00
  af062e7a68
• Remove unnecessary TriggerChange call
  Dean Herbert · 2023-02-21 13:50:19 +09:00
  0d229d959b
• Merge branch 'master' into skin-editor-layer-select
  Bartłomiej Dach · 2023-02-20 21:33:48 +01:00
  6799492596
• Only add valid placed components to selected collection on paste
  Dean Herbert · 2023-02-20 20:02:43 +09:00
  43d33d45ca
• Make placeComponent resilient to missing dependencies
  Dean Herbert · 2023-02-20 20:00:12 +09:00
  b68562b033
• Remove copy pasted comment
  Dean Herbert · 2023-02-20 19:57:16 +09:00
  a9c7edd087
• Merge branch 'master' into blueprint-improve-visuals
  Bartłomiej Dach · 2023-02-19 15:55:30 +01:00
  1ba1298850
• Also tween origin position
  Dean Herbert · 2023-02-19 23:52:21 +09:00
  d7381b762c
• Merge branch 'master' into blueprint-labels-while-hovering
  Bartłomiej Dach · 2023-02-18 15:57:30 +01:00
  ea04c487f2
• Merge branch 'master' into skin-editor-improve-toolbox-hover
  Bartłomiej Dach · 2023-02-18 10:02:02 +01:00
  fbea3e312f
• Fix toolbox items spontaneously contracting after briefly losing hover

  Reproduction scenario:
  
  1. Hover a toolbox item
  2. Unhover the item, but do not hover any other item (can be done by
     exiting the toolbox completely to the right)
  3. Come back to the item hovered in step (1)
  4. The item would spontaneously contract after a second

  Bartłomiej Dach · 2023-02-17 22:54:11 +01:00
  2aa4481f68
• Remove unused field
  Bartłomiej Dach · 2023-02-17 21:51:19 +01:00
  b390fdb8cc
• Make skin editor focus only one layer at a time
  Dean Herbert · 2023-02-17 19:27:16 +09:00
  0a018514e1
• Add per-ruleset component toolbox and placement support
  Dean Herbert · 2023-02-17 19:27:16 +09:00
  00fcee0c5a