1435 Commits

• Give last bundled replay frame the frame header
  Dan Balasescu · 2022-01-31 18:53:47 +09:00
  4727aeda01
• Rename dictionary and make private for added safety
  Dean Herbert · 2022-01-31 15:12:08 +09:00
  57f793aff0
• Replace LINQ Count() invocation with count property access
  Bartłomiej Dach · 2022-01-28 20:25:12 +01:00
  1253e1ecc1
• Purge final spectator frames before ending play
  Dan Balasescu · 2022-01-28 22:26:05 +09:00
  3037a3a769
• Remove unused using
  Dan Balasescu · 2022-01-28 15:26:29 +09:00
  32f9299fe0
• Ensure hold for menu button fades out if the cursor is never moved

  Closes https://github.com/ppy/osu/discussions/16669.

  Dean Herbert · 2022-01-28 14:48:35 +09:00
  28c8e07e3f
• Bring HoldForMenuButton tests up-to-date in code quality
  Dean Herbert · 2022-01-28 14:48:17 +09:00
  f32d56e213
• Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID
  Dean Herbert · 2022-01-27 15:38:03 +09:00
  5288eedd31
• Remove ILive<> interface (and use abstract Live<> instead)
  Dean Herbert · 2022-01-26 13:38:56 +09:00
  cd71ec0edd
• Remove Task from the inner-most Import method in RealmArchiveModelImporter

  One of my pending work items for post-realm merge.
  
  The lowest-level import task is no longer asynchronous, as we don't want
  it to span multiple threads to allow easier interaction with realm.
  Removing the `Task` spec simplifies a heap of usages.
  
  Individual usages should decide whether they want to run the import
  asynchronously, by either using an alternative override or spooling up a
  thread themselves.

  Dean Herbert · 2022-01-25 15:30:29 +09:00
  778d2a71b4
• Replace TimeSignatures enum with struct for storage of arbitrary meter
  Bartłomiej Dach · 2022-01-22 20:50:31 +01:00
  735414bc49
• Remove all usage of BaseDifficulty (and access Difficulty instead)
  Dean Herbert · 2022-01-18 22:57:39 +09:00
  7f65f3a47f
• Update tests which were importing scores without a valid beatmap
  Dean Herbert · 2022-01-17 14:47:19 +09:00
  90166829c3
• Merge branch 'master' into realm-integration/score-and-beatmaps
  Bartłomiej Dach · 2022-01-15 14:45:42 +01:00
  03e4ec4214
• Remove unused params from BDL methods
  Susko3 · 2022-01-15 01:06:39 +01:00
  19467e58c1
• Remove pointless Metadata set
  Dean Herbert · 2022-01-14 23:27:33 +09:00
  8d4a3cc569
• Add RulesetInfo hashcode implementation and tidy up equality
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  5cbd731864
• Add missing "non-null" elements missing from some tests
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  605898ec53
• Add missing Ruleset in ReplayRecorder tests
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  6251713796
• Make tests compile again
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  31a3161189
• Update null fallback cases involving OnlineID
  Dean Herbert · 2022-01-12 16:39:36 +09:00
  213d89b479
• Merge branch 'master' into async-deadlock-safety
  Dan Balasescu · 2022-01-10 16:11:09 +09:00
  af9fad00c3
• Merge branch 'master' into async-deadlock-safety
  Dean Herbert · 2022-01-07 17:28:59 +09:00
  3cd996eb4a
• Update usages to new naming
  Dean Herbert · 2022-01-06 22:54:43 +09:00
  00177a3ae1
• Wait for async continuation in score submission test

  The previous assert step was optimistically assuming that the async
  continuation that writes the value of
  `FakeImportingPlayer.ImportedScore` always completes before it, but
  that's not necessarily true even if the continuation is instant (it is
  still subject to things like task scheduling and TPL thread pool
  limits).
  
  To ensure no spurious failures, swap out the assert step for an until
  step instead.

  Bartłomiej Dach · 2022-01-06 13:09:25 +01:00
  66613cbaa4
• Handle score submission request in submission test scene

  Was previously not handled at all, therefore displaying request failures
  in the test log output. While that was mostly a red herring and
  shouldn't have caused any actual *test* failures, it is still better to
  handle this explicitly in a realistic manner.

  Bartłomiej Dach · 2022-01-06 12:57:26 +01:00
  84765b99b3
• Replace usage of .Result with .WaitSafelyForResult
  Dean Herbert · 2022-01-04 11:51:41 +09:00
  73b40e6833
• Add test coverage of score submission if player is exited during import
  Bartłomiej Dach · 2022-01-03 22:00:47 +01:00
  7cdba2f7c3
• Improve reliability of TestStoryboardSkipOutro

  Aims to resolve failures as seen at
  https://github.com/peppy/osu/runs/4677353822?check_suite_focus=true.
  
  Have run quite a lot locally with no failures (while removing the skip step 100% fails).

  Dean Herbert · 2022-01-01 15:32:39 +09:00
  04d8fd3a58
• Add visual test coverage of "hidden by ruleset" combo option
  Bartłomiej Dach · 2021-12-26 16:49:18 +01:00
  34b0101ff4
• Remove unused load checks
  Dean Herbert · 2021-12-22 18:17:00 +09:00
  f3f491374b
• Merge branch 'master' into fix-realm-post-storage-migration-failure
  Bartłomiej Dach · 2021-12-17 00:19:46 +01:00
  54790bb758
• Fix incorrect test
  Dan Balasescu · 2021-12-14 15:08:00 +09:00
  eb3050b2ac
• Provide a realm factory to usages of ToLive/RealmLive
  Dean Herbert · 2021-12-14 14:26:34 +09:00
  441b7baa93
• Use new method in more places that can benefit from it
  Dean Herbert · 2021-12-13 16:56:43 +09:00
  309290a3c9
• Rename APIScoreInfo to APIScore
  Dean Herbert · 2021-12-10 16:11:49 +09:00
  bff02bedbf
• Add test coverage showing intended UX of user's volume levels being retained when unmuting
  Dean Herbert · 2021-12-08 13:37:47 +09:00
  a969fe3ef8
• Merge pull request #15951 from peppy/fix-failing-recorder-tests-w

  Fix intermittent test failures in scenes using `SpectatorClient`

  Dean Herbert · 2021-12-06 18:40:27 +09:00
  9033169177
• Fix indentation
  Dan Balasescu · 2021-12-06 17:38:57 +09:00
  568364b604
• Update TestSceneReplayReocorder to be safer about disposal
  Dean Herbert · 2021-12-06 17:09:12 +09:00
  0d3d22d3e1
• Remove duplicated test scene (see TestSceeneReplayRecorder)
  Dean Herbert · 2021-12-06 17:09:11 +09:00
  50a5f52f92
• Refactor TestScenSpectatorPlayback to properly clean up without async disposal
  Dean Herbert · 2021-12-06 17:09:11 +09:00
  d58b85b381
• Merge branch 'master' into realm-integration/skins-rebase
  Dean Herbert · 2021-12-06 15:21:02 +09:00
  452fa93444
• Clean up unused resolved properties
  Dean Herbert · 2021-12-03 18:49:49 +09:00
  1eed2436e6
• Store default skins to database
  Dean Herbert · 2021-11-29 18:28:25 +09:00
  f6a3709060
• Use ILive for current skin
  Dean Herbert · 2021-11-29 18:28:25 +09:00
  23146d59d1
• Update mock RulesetInfo usage to set OnlineID instead of ID
  Dean Herbert · 2021-11-24 15:50:26 +09:00
  f283770f34
• Remove subclassing of RulesetInfo
  Dean Herbert · 2021-11-22 16:39:17 +09:00
  b9923e5396
• Update test scenes which should not handle key repeat
  Dean Herbert · 2021-11-18 13:13:36 +09:00
  d7b178ea37
• Update all simple cases of switching to IWorkingBeatmap
  Dean Herbert · 2021-11-17 20:56:57 +09:00
  7c2e79f911