51150 Commits

This Branch

This Branch

All Branches

• Fix loading player via skin editor still allowing changing current audio track

  `PlayerLoader` is required in the sequence to get the game into the
  correct state for gameplay right now. Applying ths simplest fix here.
  
  Closes https://github.com/ppy/osu/issues/17351.

  Dean Herbert · 2022-03-21 13:49:56 +09:00
  355b0fa314
• Merge pull request #17315 from hwabis/queue-list-counter
  Salman Ahmed · 2022-03-21 05:28:33 +03:00
  6fbeea78dd
• Merge branch 'master' into queue-list-counter
  Salman Ahmed · 2022-03-21 05:01:09 +03:00
  5c1e11c153
• Revert OsuTabItem Text to protected, update tab count test
  hwabis · 2022-03-20 21:37:02 -04:00
  06136b2247
• make test name clearer
  hwabis · 2022-03-20 16:28:05 -04:00
  63b6686384
• add queue tab count test
  hwabis · 2022-03-20 16:24:41 -04:00
  8fbdd06895
• Nest specific object classes within the mod
  apollo-dw · 2022-03-20 15:56:41 +00:00
  d3742a91a8
• Remove slider tick judgement flag
  apollo-dw · 2022-03-20 15:41:46 +00:00
  35e2e6a4e7
• Obsolete BeatmapInfo.MaxCombo and suppress in usages
  Salman Ahmed · 2022-03-20 16:30:29 +03:00
  b9859f9f21
• Remove no longer necessary MaxCombo assignment in tests
  Salman Ahmed · 2022-03-20 16:29:56 +03:00
  6f47f7ffc8
• Remove unnecessary MaxCombo migration between unmapped database fields
  Salman Ahmed · 2022-03-20 16:27:54 +03:00
  c2063f415d
• Add note about null return value
  Salman Ahmed · 2022-03-20 16:24:30 +03:00
  aef40da8d4
• GetBeatmapMaximumComboAsync -> GetMaximumAchievableComboAsync
  Salman Ahmed · 2022-03-20 16:18:53 +03:00
  2a78042038
• Simplify queue count text logic
  Salman Ahmed · 2022-03-20 06:25:14 +03:00
  e1d22e58bf
• Bind queue items during playlist initialization

  Along with where the other bindables are bound together (only bind, not
  listening).

  Salman Ahmed · 2022-03-20 06:23:44 +03:00
  7529d6fc00
• Compute the beatmap maximum achievable combo instead of Beatmap.MaxCombo
  Salman Ahmed · 2022-03-20 05:38:14 +03:00
  eca7975864
• Introduce method for computing maximum achievable combo properly
  Salman Ahmed · 2022-03-20 05:38:14 +03:00
  d36f32a9c9
• Add explicit todo about removing BeatmapInfo.MaxCombo

  Using that property is a trap basically.

  Salman Ahmed · 2022-03-20 05:38:14 +03:00
  c5cc7eec79
• Only miss slider tail on untrack
  apollo-dw · 2022-03-19 23:42:12 +00:00
  52d6f083dc
• Pass correct params to UpdateableAvatar ctor in ChannelListItem
  Jai Sharma · 2022-03-19 22:20:17 +00:00
  f3702fbefb
• Rename ControlItem -> ChannelListItem and associated classes
  Jai Sharma · 2022-03-19 21:49:14 +00:00
  ba5a43b526
• Use UpdateableAvatar and remove redundant ControlItemAvatar class
  Jai Sharma · 2022-03-19 21:36:11 +00:00
  653bb47dd5
• Use OsuAnimatedButton as base for ControlItemClose
  Jai Sharma · 2022-03-19 21:23:32 +00:00
  5373c3066f
• Use new mod-related object types for Strict Tracking
  apollo-dw · 2022-03-19 18:29:44 +00:00
  149cfd338d
• address frenzibyte review (refactor bindable flow, clean up CI stuff)
  hwabis · 2022-03-19 13:05:35 -04:00
  ef823d58a7
• Remove redundant ControlItemText class
  Jai Sharma · 2022-03-19 16:44:58 +00:00
  a293e0c766
• Fix potentially null drawable call to SetLayoutPosition
  Salman Ahmed · 2022-03-19 14:54:58 +03:00
  9afe82a0d5
• Merge pull request #17299 from nekodex/arm64

  Update download links for macOS builds (to add Apple Silicon)

  Dean Herbert · 2022-03-19 20:45:51 +09:00
  2022.319.0 d681643c38
• Merge pull request #17327 from frenzibyte/simplify-extension-methods

  Simplify `IncreasesCombo`/`BreaksCombo` helper method implementation

  Dean Herbert · 2022-03-19 20:23:09 +09:00
  9aa902785c
• Merge pull request #17331 from Sublimelime/make-relax-aimassist-incomp

  Make Relax and Aim assist mods incompatible

  Dean Herbert · 2022-03-19 20:22:06 +09:00
  acaa3ff21b
• Merge pull request #17341 from peppy/fix-spectator-seeks-hot

  Fix spectator not starting from current player position (hotfix version)

  Dean Herbert · 2022-03-19 20:21:41 +09:00
  2c5af6265e
• Merge branch 'master' into fix-spectator-seeks-hot
  Bartłomiej Dach · 2022-03-19 11:39:01 +01:00
  b7d5a628bc
• Merge pull request #17337 from frenzibyte/improve-exit-button-placement

  Improve visual behaviour of "hold for menu" to not distract players

  Dean Herbert · 2022-03-19 18:18:54 +09:00
  89c43d0e07
• Use schedule to workaround seek issue instead
  Dean Herbert · 2022-03-19 18:00:14 +09:00
  a903aee17e
• Revert "Fix spectator not starting from correct seek point (hotfix)"

  This reverts commit 2b59eff465.

  Dean Herbert · 2022-03-19 17:20:54 +09:00
  cf2212e794
• Fix spectator not starting from correct seek point (hotfix)
  Dean Herbert · 2022-03-19 15:14:25 +09:00
  2b59eff465
• Add test coverage of SpectatorPlayer failing to seek on inopportune frame arrival time
  Dean Herbert · 2022-03-19 15:06:22 +09:00
  63998ad9f1
• Use nullable in PlayerLoader
  Dean Herbert · 2022-03-19 15:06:22 +09:00
  dae5569e36
• Expose the loading player in PlayerLoader
  Dean Herbert · 2022-03-19 15:06:22 +09:00
  da76358ee0
• Revert "Swap placements of "hold for menu" and key counter"

  This reverts commit 5bcb7c167c.

  Salman Ahmed · 2022-03-19 08:08:07 +03:00
  b99541fb5e
• Merge pull request #17322 from frenzibyte/form-bug-report

  Add "bug report" GitHub issue form template

  Dean Herbert · 2022-03-19 13:54:25 +09:00
  e2c0e3bafd
• Simplify screenshot/video attach text

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2022-03-19 12:43:48 +09:00
  41ab798bbe
• Simplify log drag-drop message

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2022-03-19 12:43:08 +09:00
  762385d336
• Simplify wording of description hint

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2022-03-19 12:42:25 +09:00
  79f6e7cc1c
• make code prettier
  hwabis · 2022-03-18 23:41:55 -04:00
  5d16519a82
• Reduce "hold for menu" radius of visibility
  Salman Ahmed · 2022-03-19 05:04:54 +03:00
  ad9b119e3d
• Calculate position adjustment distance in local parent space
  Salman Ahmed · 2022-03-19 05:04:13 +03:00
  486be83177
• Swap placements of "hold for menu" and key counter
  Salman Ahmed · 2022-03-19 05:02:22 +03:00
  5bcb7c167c
• Handle potential null room hosts
  Salman Ahmed · 2022-03-19 04:01:35 +03:00
  0adad3a599
• (works now) use BindValueChanged to set the Queue text
  hwabis · 2022-03-18 20:47:45 -04:00
  5a5629eb5a