51150 Commits

This Branch

This Branch

All Branches

• Fix visual test crashes due to local realm not having update thread
  Dean Herbert · 2022-03-25 16:35:32 +09:00
  5fcd3b07f1
• Update multiplayer countdown button text more often

  At once a second, it regularly skips whole seconds (because scheduler
  isn't guaranteed to run exactly as often as specified). 10 updates a
  second seems amicable and less noticeable to my eye.

  Dean Herbert · 2022-03-25 16:25:20 +09:00
  4a30b6ef56
• Revert unintentional behavior change of random mod

  Actually, using OsuPlayfield.BASE_SIZE.Y makes a touch more sense since it is the short side of the playfield, but I guess it is better to preserve replays than to introduce pointless breaking changes.

  Henry Lin · 2022-03-25 15:13:25 +08:00
  e44db4e726
• Merge pull request #17443 from peppy/fix-unexpected-immediate-exit

  Fix game unexpectedly exiting without outro sequence occasionally on macOS

  Dan Balasescu · 2022-03-25 15:57:57 +09:00
  8553adc401
• Apply notnull constraint
  Dan Balasescu · 2022-03-25 15:54:01 +09:00
  23c4f9910e
• Add ignore rule for new helper property
  Dean Herbert · 2022-03-25 15:46:27 +09:00
  792e79265b
• Simplify AutoStart and Host checks
  Dean Herbert · 2022-03-25 15:41:01 +09:00
  b1f0f89fdd
• Merge branch 'master' into skin-nullable
  Dan Balasescu · 2022-03-25 15:36:21 +09:00
  2d8d177807
• Merge pull request #17416 from peppy/skin-fuck

  Refactor skin construction

  Dan Balasescu · 2022-03-25 15:36:06 +09:00
  478174dd58
• Fix non-matching json propert for AutoStartDuration
  Dean Herbert · 2022-03-25 15:34:33 +09:00
  de4c04ef80
• Fix main menu buttons handling keys when super (cmd) is held
  Dean Herbert · 2022-03-25 15:13:22 +09:00
  416b57ea69
• Rename Button to MainMenuButton to differentiate better
  Dean Herbert · 2022-03-25 15:12:39 +09:00
  816fcae3a1
• Merge branch 'master' into extract-random-mod-logic-2
  Dan Balasescu · 2022-03-25 14:25:43 +09:00
  cd5907f8da
• Merge pull request #17432 from peppy/realm-subscription-any-thread

  Allow realm subscriptions to be initiated from any thread

  Dan Balasescu · 2022-03-25 14:05:03 +09:00
  c6182c2b09
• Update resources
  Dean Herbert · 2022-03-25 13:18:49 +09:00
  09c5325b08
• Update framework
  Dean Herbert · 2022-03-25 13:07:21 +09:00
  b4c0155b3d
• Merge pull request #17431 from peppy/fix-participants-panel-null-ref

  Guard against potential null `CurrentItem` in `ParticipantPanel`

  Dan Balasescu · 2022-03-25 11:47:43 +09:00
  def2ce243f
• Merge pull request #17429 from peppy/fix-old-legacy-replays

  Fix replays set on old beatmaps having incorrect timing

  Bartłomiej Dach · 2022-03-24 23:45:42 +01:00
  e58b742728
• Merge branch 'master' into fix-old-legacy-replays
  Bartłomiej Dach · 2022-03-24 23:21:50 +01:00
  5f730c0cd4
• Merge pull request #17425 from peppy/fix-realm-import-test-assert-failure

  Fix realm potentially not being refreshed in time for test asserts in `BeatmapImporterTests`

  Bartłomiej Dach · 2022-03-24 22:16:25 +01:00
  959f200638
• Remove assertion to fix "expression always true" inspection
  Bartłomiej Dach · 2022-03-24 21:51:10 +01:00
  878e8d21a3
• Merge branch 'master' into fix-realm-import-test-assert-failure
  Bartłomiej Dach · 2022-03-24 21:48:10 +01:00
  b76cd2beae
• Allow realm subscriptions to be initiated from a non-update thread
  Dean Herbert · 2022-03-24 23:41:07 +09:00
  b04ca111c6
• Update PresentExternally usages in line with framework changes
  Dean Herbert · 2022-03-24 23:41:07 +09:00
  2938f44e6c
• Fix cancel tooltip showing for autostart countdowns
  Dan Balasescu · 2022-03-24 20:25:17 +09:00
  1abf3f7bf4
• Fix test client not receiving initial value
  Dan Balasescu · 2022-03-24 20:24:09 +09:00
  d3a957d64e
• Fix local setting not being updated
  Dan Balasescu · 2022-03-24 20:23:58 +09:00
  0d88af19ae
• Add missing TestMultiplayerClient coverage
  Dan Balasescu · 2022-03-24 20:19:05 +09:00
  f80692f342
• Update room state in more situations
  Dan Balasescu · 2022-03-24 20:17:16 +09:00
  5fe46a73cb
• Add method to stop countdown
  Dan Balasescu · 2022-03-24 20:17:16 +09:00
  209de886ce
• Split countdown start into separate method
  Dan Balasescu · 2022-03-24 20:09:32 +09:00
  ea9de0199d
• Merge branch 'master' into multiplayer-auto-countdown
  Dan Balasescu · 2022-03-24 18:11:51 +09:00
  40eca0fbe2
• Guard against potential null CurrentItem in ParticipantPanel
  Dean Herbert · 2022-03-24 17:54:21 +09:00
  2d58feebb1
• Add asserts of playlist being non-empty after client operations
  Dean Herbert · 2022-03-24 17:52:20 +09:00
  e889d93441
• Merge pull request #17326 from smoogipoo/multiplayer-countdown-timers-2

  Implement multiplayer countdown timers

  Dean Herbert · 2022-03-24 17:50:53 +09:00
  d7faff15c0
• Merge branch 'master' into multiplayer-countdown-timers-2
  Dean Herbert · 2022-03-24 17:24:00 +09:00
  0275e974e5
• Revert Availability to private
  Dean Herbert · 2022-03-24 17:15:17 +09:00
  e3f8bc0588
• Fix incorrect event binding
  Dan Balasescu · 2022-03-24 17:11:08 +09:00
  528ffea38d
• Split out shared code for encode-decode cycle (and remove unrelated culture set)
  Dean Herbert · 2022-03-24 17:00:49 +09:00
  d6fc53579e
• Use a constant for the early version timing offset
  Dean Herbert · 2022-03-24 16:43:41 +09:00
  a7554dcdf7
• Add test coverage of decode specifically
  Dean Herbert · 2022-03-24 16:39:56 +09:00
  2efae031c9
• Add test coverage ensuring offsets are correct before and after legacy replay encode
  Dean Herbert · 2022-03-24 16:34:21 +09:00
  59a7eb5322
• Refactor cancellation logic
  Dan Balasescu · 2022-03-24 16:29:59 +09:00
  dfa076c169
• Apply beatmap offsets to legacy replay frame handling
  Dean Herbert · 2022-03-24 16:16:40 +09:00
  a7d5f2281c
• Asserate code is running on update thread
  Dan Balasescu · 2022-03-24 15:51:30 +09:00
  4c0d76573c
• Rename FinishCountdown() -> SkipToEndOfCountdown()
  Dan Balasescu · 2022-03-24 15:21:46 +09:00
  f0d132b16e
• Revert unnecessary async change
  Dan Balasescu · 2022-03-24 15:07:24 +09:00
  d2ecc100e5
• Add explanation for try-catch
  Dan Balasescu · 2022-03-24 15:07:24 +09:00
  8f3a4df70a
• Dispose token manually

  Cover more branches with cancellation source disposal

  Dan Balasescu · 2022-03-24 15:07:24 +09:00
  d36944ac95
• Add test coverage of user offset being set before construction of MasterGameplayClockContainer
  Dean Herbert · 2022-03-24 14:55:01 +09:00
  1049e349e3