51150 Commits

This Branch

This Branch

All Branches

• Merge pull request #17550 from smoogipoo/fix-score-display-race

  Fix scores sometimes shown with incorrect scoring mode

  Dean Herbert · 2022-03-30 16:05:28 +09:00
  bd3c401363
• Merge pull request #17551 from peppy/realm-database-filename-const

  Move all usages of `client.realm` filename to a single `const`

  Dan Balasescu · 2022-03-30 14:09:08 +09:00
  7d338fb4be
• Move all usages of client.realm filename to a single const
  Dean Herbert · 2022-03-30 13:34:48 +09:00
  975883da5c
• Merge pull request #17527 from peppy/switch-osu-folder

  Add ability to "migrate" data to another folder which has an existing install

  Dan Balasescu · 2022-03-30 13:20:49 +09:00
  c311e11496
• Prevent scores being calculated twice
  Dan Balasescu · 2022-03-30 13:15:41 +09:00
  4df63a4900
• Fix scores sometimes shown with incorrect scoring mode
  Dan Balasescu · 2022-03-30 13:03:12 +09:00
  bd9c0076df
• Merge pull request #17547 from frenzibyte/m1-ignore-realm-migration

  Ignore EF-to-realm migration tests on M1 ARM architectures

  Dan Balasescu · 2022-03-30 11:47:29 +09:00
  e869b7286a
• Merge pull request #17510 from Wieku/combo-counter

  Adjust legacy combo counter appearance to closer match stable

  Dean Herbert · 2022-03-30 11:17:30 +09:00
  555e127bc2
• Fix code quality issues in ChatTextBar
  Jai Sharma · 2022-03-30 02:16:50 +01:00
  e7d2d94eee
• Remove skin dependency as component is reinitialized on skin change
  Sebastian Krajewski · 2022-03-30 01:09:05 +02:00
  cb62d3d4b9
• Use In/Out instead of {In/Out}Quad
  Sebastian Krajewski · 2022-03-30 00:48:59 +02:00
  7582c943a4
• Ignore EF-to-realm migration tests on ARM architectures
  Salman Ahmed · 2022-03-30 01:24:37 +03:00
  7495a04990
• Fix potential nullref on OsuGameTestScene.TearDownSteps
  Salman Ahmed · 2022-03-30 01:15:24 +03:00
  986aad4bd5
• Add test coverage
  Salman Ahmed · 2022-03-30 01:08:22 +03:00
  b7ae431252
• Improve behaviour of "Autoplay" shortcut during gameplay start

  This also opens up the way to adding shortcut for "Cinema" mod
  (Ctrl+Shift+Enter), but will leave adding that until there's a demand
  for it.

  Salman Ahmed · 2022-03-30 01:07:48 +03:00
  cef1b93471
• Remove changes to InspectCode.sh
  Jai Sharma · 2022-03-29 22:50:24 +01:00
  06c32aa136
• Implement ChatTextBox for new chat design

  Reference design: https://www.figma.com/file/f8b2dHp9LJCMOqYP4mdrPZ/Client%2FChat?node-id=1%3A297
  
  Adds new component `ChatTextBox`.
  Exposes `BindableBool` `ShowSearch` to change text input behaviour
  between normal and search behaviour.
  
  Adds new component `ChatTextBar`.
  Exposes `BindableBool` `ShowSearch` which toggles between showing current
  chat channel or search icon.
  Additionally binds to child `ChatTextBox` components.
  Requires a cached `Bindable<Channel>` instance to be managed by a parent
  component.

  Jai Sharma · 2022-03-29 22:33:38 +01:00
  f049d7cb67
• Add test coverage of migrating to folder with existing data
  Dean Herbert · 2022-03-29 23:28:07 +09:00
  f762af1344
• Mark "autoplay" and "cinema" mods as mutually exclusive
  Salman Ahmed · 2022-03-29 17:26:02 +03:00
  8d4356f23b
• Merge pull request #17530 from frenzibyte/spin-speed-display-value

  Fix "Barrel Roll" tooltip not limiting decimal places for spin speed

  Dean Herbert · 2022-03-29 22:47:40 +09:00
  30fae452a4
• Merge branch 'master' into fix-countdown-refresh
  Salman Ahmed · 2022-03-29 16:16:36 +03:00
  26b72fc449
• Fix "Barrel Roll" tooltip not limiting decimal places for spin speed
  Salman Ahmed · 2022-03-29 16:11:44 +03:00
  9a09c97457
• Merge pull request #17502 from peppy/m1-migration-information
  Salman Ahmed · 2022-03-29 13:40:46 +03:00
  fefff59b9a
• Change confirmation message to be more clear about intentions

  Co-authored-by: Henry Lin <henry.ys.lin@gmail.com>

  Dean Herbert · 2022-03-29 19:03:50 +09:00
  4741679a94
• Merge branch 'master' into m1-migration-information
  Salman Ahmed · 2022-03-29 13:03:36 +03:00
  cdc2ae7991
• Add ability to "migrate" data to another folder which has an existing install

  Until now, migrating would always attempt to move files.
  
  There's a chance that a user is reinstalling osu! but has their data at
  a custom location. We want to allow the chance for them to continue
  using the external data. This seems like the easiest way to make it
  work.
  
  Would be nice if we had a `Game.Restart()` method, but maybe this is
  enough for now?
  
  Note that further down the road we will probably prompt the user to
  potentially select a custom install path (including one with existing
  data) before osu! gets to writing anything.

  Dean Herbert · 2022-03-29 18:04:31 +09:00
  1fb3d11591
• Merge pull request #17525 from peppy/remove-set-replay-mod-cinema

  Remove unnecessary `SetReplayScore` call in `ModCinema`

  Dan Balasescu · 2022-03-29 17:21:56 +09:00
  10c23e3506
• Bring all mod implementations up-to-date
  Dean Herbert · 2022-03-29 16:59:03 +09:00
  4b2c01a8c1
• Update all existing calls to extension method with correct fallback handling
  Dean Herbert · 2022-03-29 16:51:30 +09:00
  ea9495eb74
• Create new ICreateReplayData interface and obsolete ICreateReplay
  Dean Herbert · 2022-03-29 16:51:30 +09:00
  7d716adf39
• Remove unnecessary SetReplayScore call in ModCinema
  Dean Herbert · 2022-03-29 16:51:30 +09:00
  3fc8c23fe4
• Remove unnecessary SetReplayScore call in ModCinema
  Dean Herbert · 2022-03-29 16:50:05 +09:00
  327477d050
• Restructure transforms slightly
  Dean Herbert · 2022-03-29 13:18:31 +09:00
  8948bcce19
• Add safety to realm instance retrieval in RealmAccess
  Dean Herbert · 2022-03-29 11:40:58 +09:00
  0433d2fe6a
• Fix countdown timer not refreshing on new countdown
  Dan Balasescu · 2022-03-29 11:27:26 +09:00
  375a752e24
• Remove redundant ClearTransforms
  Sebastian Krajewski · 2022-03-28 23:50:35 +02:00
  caf641e1ab
• Always start small pop out from its initial size
  Sebastian Krajewski · 2022-03-28 19:57:59 +02:00
  981ef735cf
• Don't scale big pop out as much
  Sebastian Krajewski · 2022-03-28 19:33:00 +02:00
  e3289bb080
• Remove comment
  Sebastian Krajewski · 2022-03-28 18:08:51 +02:00
  265b2111ef
• Fix LegacyComboCounter not unsubscribing from skin
  Sebastian Krajewski · 2022-03-28 18:08:35 +02:00
  001a98e069
• Avoid deadlock during migration failed exit process
  Dean Herbert · 2022-03-29 00:04:13 +09:00
  ea46e024c1
• Limit macOS specific log output to macOS platforms specifically
  Dean Herbert · 2022-03-28 23:46:07 +09:00
  b6ae0ebb6f
• Add test coverage for autoplay avatar not being clickable
  Dean Herbert · 2022-03-28 23:37:39 +09:00
  7059e4bf94
• Merge pull request #17506 from peppy/fix-skin-editor-exit

  Fix skin editor not exiting correctly when using the menu

  Bartłomiej Dach · 2022-03-28 16:36:47 +02:00
  9ceceeca3d
• Update LegacyComboCounter layout and scaling
  Sebastian Krajewski · 2022-03-28 16:36:37 +02:00
  05a978ce8c
• Update UserProfileOverlay and ClickableAvatar to treat system users more correctly
  Dean Herbert · 2022-03-28 22:57:16 +09:00
  dc7dc7f65a
• Update all cinema/autoplay mods to specify the system user ID
  Dean Herbert · 2022-03-28 22:22:56 +09:00
  d2d88015e3
• Add a const for system users which should never display a profile
  Dean Herbert · 2022-03-28 22:22:56 +09:00
  a0692ce477
• Fix skin editor not exiting correctly when using the menu

  Closes https://github.com/ppy/osu/issues/17489.

  Dean Herbert · 2022-03-28 20:43:26 +09:00
  b5834dabdb
• Better inform users of migration failure reason when running Apply Silicon build

  As mentioned in https://github.com/ppy/osu/discussions/17409#discussioncomment-2445464?

  Dean Herbert · 2022-03-28 17:34:36 +09:00
  a98aac3bf2