51150 Commits

This Branch

This Branch

All Branches

• Merge branch 'master' into runtime-clock-weight
  Bartłomiej Dach · 2022-03-31 21:24:45 +02:00
  48df34d0a8
• Remove unused using directives
  Bartłomiej Dach · 2022-03-31 21:20:30 +02:00
  e14d5b8adb
• Rebind SaveState() to bpmTextEntry
  CenTdemeern1 · 2022-03-31 21:06:05 +02:00
  a6875383fc
• Fix my code according to the changes @bdach requested
  CenTdemeern1 · 2022-03-31 20:39:26 +02:00
  bdb21b17f7
• Remove BPM slider
  CenTdemeern1 · 2022-03-31 20:11:07 +02:00
  52d723aaa6
• Remove a newline to comply with codefactor
  CenTdemeern1 · 2022-03-31 17:21:50 +02:00
  c64a90b39e
• Make the clock feel more like a button
  CenTdemeern1 · 2022-03-31 16:26:53 +02:00
  f1aa60c0f1
• Guard other multiplayer client calls with exception handling
  Dean Herbert · 2022-03-31 19:45:38 +09:00
  0b6db31511
• Replace existing usage with helper method
  Dean Herbert · 2022-03-31 19:27:45 +09:00
  e0c125a628
• Add helper class to handle firing async multiplayer methods
  Dean Herbert · 2022-03-31 19:27:45 +09:00
  5b3eb2d6f4
• Merge pull request #17574 from peppy/fix-tournament-bracket-invalid-ruleset-id

  Fix tournament bracket parsing's ruleset refetch logic not working correctly

  Dan Balasescu · 2022-03-31 19:18:18 +09:00
  46be6bcadc
• Increase font weight for runtime clock

  Fonts this small are required to be `SemiBold` by design guidelines.
  Somehow missed this.

  Dean Herbert · 2022-03-31 19:07:30 +09:00
  0a34ce2509
• Fix tournament bracket parsing's ruleset refetch logic not working correctly

  Due to equality being based on `ShortName`, it was feasible that the
  re-fetch exited early (in bindable shortcutting logic) causing the
  ruleset's `OnlineID` to remain `-1` or something equally wrong.
  
  Resolves issue pointed out at
  https://github.com/ppy/osu/discussions/17538#discussioncomment-2471746.

  Dean Herbert · 2022-03-31 18:41:00 +09:00
  a06b0a4966
• Add test coverage ensuring ruleset ID is correct after bracket read

  Historically, tournament client may have written incorrect `OnlineID`
  values. We wanted to use `ShortName` to re-fetch the ruleset. This test
  ensures this flow is working correctly.

  Dean Herbert · 2022-03-31 18:39:58 +09:00
  a7a7584d3e
• Merge pull request #17570 from peppy/fix-settings-textbox-focus

  Focus focus not being transferred correctly to parent settings panel on exiting nested panel

  Dan Balasescu · 2022-03-31 18:07:51 +09:00
  bc4d6a3ace
• Merge pull request #17572 from peppy/fix-multi-sounds-explosion

  Fix multiplayer sounds playing too much after gameplay

  Dean Herbert · 2022-03-31 16:52:24 +09:00
  140eaa6039
• Fix multiplayer sounds playing too much after gameplay

  Regressed in https://github.com/ppy/osu/pull/15936.
  
  Closes #17295.

  Dean Herbert · 2022-03-31 16:18:28 +09:00
  ef5e37c47a
• Merge pull request #17565 from smoogipoo/fix-gameplay-leaderboard-allocations

  Remove ScoreInfo allocations in multiplayer leaderboard

  Dean Herbert · 2022-03-31 15:48:14 +09:00
  ad14b7cac5
• Merge pull request #17569 from Joehuu/ignore-line-ending-rev

  Ignore line ending normalisation commit from blame

  Dean Herbert · 2022-03-31 15:31:53 +09:00
  496e025fae
• Focus focus not being transferred correctly to parent settings panel on exiting nested panel

  Seemingly harmless schedule delay ommission meant that the textbox may
  not be in a state it can handle the incoming focus event. Regressed in
  https://github.com/ppy/osu/pull/14345#discussion_r690697501.

  Dean Herbert · 2022-03-31 15:24:21 +09:00
  726b49fdf3
• Add test coverage of textbox focus in settings panels when switching between nested panels
  Dean Herbert · 2022-03-31 15:24:21 +09:00
  e8a295a61b
• Rename method to CalculateAllLegacyCombinations()
  Dan Balasescu · 2022-03-31 15:09:06 +09:00
  40b6f3ff0a
• Merge branch 'master' into osu-diff-calc-max-combo
  Dan Balasescu · 2022-03-31 15:08:08 +09:00
  32e55e7d78
• Merge pull request #17568 from Joehuu/fix-logo-clicking-when-exiting

  Fix osu! logo being clicked when exiting via cmd-q on initial state

  Dean Herbert · 2022-03-31 14:12:15 +09:00
  538e553455
• Ignore line ending normalisation commit from blame
  Joseph Madamba · 2022-03-30 21:58:39 -07:00
  615e4f0f3b
• Merge branch 'master' into extract-random-mod-logic-2
  Dan Balasescu · 2022-03-31 13:42:47 +09:00
  ff4745be59
• Fix osu! logo being clicked when exiting via cmd-q on initial state
  Joseph Madamba · 2022-03-30 21:26:30 -07:00
  36c02573a8
• Merge pull request #17509 from peppy/fix-autoplay-mod-user-id

  Fix autoplay avatar being clickable on results screen

  Dan Balasescu · 2022-03-31 12:56:42 +09:00
  d17cf0631f
• Remove no longer necessary ruleset field
  Salman Ahmed · 2022-03-31 06:40:38 +03:00
  9c19ae1df8
• Remove ScoreInfo allocations in multi leaderboard
  Dan Balasescu · 2022-03-31 12:23:00 +09:00
  6e94a9780b
• Remove unused using statement
  Dean Herbert · 2022-03-31 11:34:32 +09:00
  e0d434b89f
• Shorten class name of ModCreatedReplayUser
  Dean Herbert · 2022-03-31 11:34:23 +09:00
  0cac935939
• Update obsolete message to match targeted developers' use case

  Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>

  Dean Herbert · 2022-03-31 11:33:26 +09:00
  2c1ccc7d36
• Remove unnecessary logging
  Dean Herbert · 2022-03-31 11:32:00 +09:00
  234bec45cc
• Remove unnecessary public prefix in interface method
  Salman Ahmed · 2022-03-31 01:50:46 +03:00
  6874cdf0c8
• Implement sheared toggle button
  Bartłomiej Dach · 2022-03-30 22:50:21 +02:00
  3ac0da2da3
• Fix typo in step name
  Bartłomiej Dach · 2022-03-30 22:04:55 +02:00
  f4184cb6fe
• Use provided extension method instead of reimplementing locally
  Bartłomiej Dach · 2022-03-30 22:04:54 +02:00
  436dec68c9
• Fill out ICreateReplayData xmldocs
  Bartłomiej Dach · 2022-03-30 22:04:54 +02:00
  83bae81095
• Simplify show/hide of text and search in ChatTextBar
  Jai Sharma · 2022-03-30 21:02:12 +01:00
  fff30e8a6e
• Merge branch 'master' into fix-autoplay-mod-user-id
  Bartłomiej Dach · 2022-03-30 21:41:45 +02:00
  9621a7f9cb
• Remove the enter box in ChatTextBar
  Jai Sharma · 2022-03-30 20:25:23 +01:00
  eec3fef7a6
• Merge pull request #17520 from smoogipoo/fix-countdown-refresh

  Fix countdown timer not refreshing on new countdown

  Dean Herbert · 2022-03-30 22:58:26 +09:00
  0020102810
• Merge branch 'master' into fix-countdown-refresh
  Salman Ahmed · 2022-03-30 16:26:12 +03:00
  0f144f6801
• Merge pull request #17556 from peppy/fix-multiplayer-unobserved

  Fix `MultiplayerMatchSongSelect` potentially attempting to exit when not the current screen

  Dan Balasescu · 2022-03-30 21:10:11 +09:00
  b60c253831
• Fix MultiplayerMatchSongSelect potentially attempting to exit when not the current screen
  Dean Herbert · 2022-03-30 20:36:12 +09:00
  671386ba6c
• Merge pull request #17555 from peppy/remove-source-from-wedge

  Remove song source from main wedge display

  Dan Balasescu · 2022-03-30 18:57:25 +09:00
  cb1ee05539
• Simplify string bindings
  Dean Herbert · 2022-03-30 17:59:45 +09:00
  f9f6248101
• Remove song source from main wedge display

  This was definitely added at someone's request, since I wouldn't have
  put it here. But it's displayed below in the details section already and
  also not displayed in the updated "wedge" in the new design.
  
  See https://github.com/ppy/osu/discussions/17537 for discussion.

  Dean Herbert · 2022-03-30 17:59:40 +09:00
  bc0b982102
• Merge pull request #17546 from frenzibyte/autoplay-cinema-incompatibility

  Mark both "Autoplay" and "Cinema" mods as mutually exclusive

  Dean Herbert · 2022-03-30 16:41:07 +09:00
  99f141d396