16 Commits

• Tooling updates (#37031)

  Most of this is as everywhere else, but there's also interesting code
  inspection fixes from the InspectCode bump, so I'll talk about that a
  little.
  
  ## [Fix suspicious equality in
  `Hotkey`](https://github.com/ppy/osu/commit/948136e49e88a721827d54e51c5759fe9aca811d)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/TypeWithSuspiciousEqualityIsUsedInRecord.Global.html
  
  Pretty annoying to fix, nullable array types are a pain. Does look legit
  though.
  
  ## [Fix `StarDifficulty` using inefficient struct
  equality](https://github.com/ppy/osu/commit/2db775ebb0bb9f18de67677ef84b993465d26545)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/DefaultStructEqualityIsUsed.Global.html
  
  This is a dodgy one because there's no real sane way to define equality
  on `StarDifficulty` now that it has difficulty and performance
  attributes jammed into it. So I just basically shut the inspection up
  with a `record` modifier and move on.
  
  Unclear where the equality is used precisely. It's from a global
  inspection. F12 is very unhelpful when trying to track down usages of
  `Equals()`. We definitely have `Bindable<StarDifficulty>` instances and
  those do use equality. Maybe more than that.
  
  ## [Use `nameof` expressions to reference enum member
  names](https://github.com/ppy/osu/commit/aa08175c803bc725f3b15a92174dfe6d1b812d91)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html
  
  Pretty quaint.
  
  ## [Prefer using concrete values over `default` or
  `new()`](https://github.com/ppy/osu/commit/b21ee08d7748be10d42268d5c2eb77369026545d)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/PreferConcreteValueOverDefault.html
  
  I could see this one going both ways, but I'm kinda sold on this
  inspection. Explicit is always better. Saves some allocations in the
  `CancellationToken` cases as well.
  
  ## [Explicitly call `.AsEnumerable()` in some realm
  usages](https://github.com/ppy/osu/commit/c8ce1ecd42b9d8abb8b9e2ab93d471f463e80401)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/PossibleUnintendedQueryableAsEnumerable.html
  
  Not fully sold on this one but it's quick and simple so might as well.
  
  ## [Simplify dictionary removal with single `.Remove()`
  call](https://github.com/ppy/osu/commit/5964ceccea900302df726b7a8ecbf6b74eb2e427)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html
  
  Not much to say.

  Bartłomiej Dach · 2026-03-19 00:05:52 +09:00
  18d4ba5874
• Update editor hitsound icons with new designs from Adarin (#36940)

  | Before | After |
  | :---: | :---: |
  | <img width="584" height="672" alt="2026-03-12 00 56 58@2x"
  src="https://github.com/user-attachments/assets/f1714f4d-ba78-4e41-a8f8-1a22dac01d9f"
  /> | <img width="584" height="672" alt="2026-03-12 01 06 04@2x"
  src="https://github.com/user-attachments/assets/4fc2d7ed-c9e0-45c7-8ff7-394d7ee2eff8"
  /> |

  Dean Herbert · 2026-03-12 08:03:01 +01:00
  94c9f16b27
• Add osu!-style undo icon
  Salman Alshamrani · 2025-12-18 04:08:16 -05:00
  8da1fde981
• Refactor spritesheet-based icons to be single-file based (#34976)

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Jinkku · 2025-10-01 13:30:06 +02:00
  b7d36cffd4
• Add and use new mod icon assets
  Bartłomiej Dach · 2025-08-21 09:00:44 +02:00
  92016a7d9b
• Add specifications for new song select icons
  Salman Alshamrani · 2025-04-11 02:33:57 +09:00
  36a11d4bf7
• Add button to access daily challenge playlist from main menu
  Bartłomiej Dach · 2024-05-17 11:15:52 +02:00
  a4f8ed2a0e
• Update hit error metre to use new icons

  - [ ] Depends on https://github.com/ppy/osu-resources/pull/317.

  Dean Herbert · 2024-04-04 14:31:40 +08:00
  9521c1e3e4
• Implement new icon store
  Bartłomiej Dach · 2023-12-27 17:42:17 +01:00
  45143a6c17
• Make room for OsuIcon to accept new icons
  Bartłomiej Dach · 2023-12-27 15:04:28 +01:00
  13333f7575
• Update other usages of OsuIcon.ModBg and remove
  Dean Herbert · 2023-09-28 19:03:34 +09:00
  d4cf6e100f
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix most open compound words in identifiers being closed
  Joseph Madamba · 2021-12-27 20:26:28 -08:00
  7de43e3aba
• Fix osu! icon font name mismatch
  Dean Herbert · 2019-04-02 19:55:46 +09:00
  bcd51afea1
• Update icon usage to match framework changes
  Dean Herbert · 2019-03-27 19:29:27 +09:00
  de80fc0eac