75266 Commits

This Branch

This Branch

All Branches

• Merge pull request #30848 from Joehuu/dicord-fix-beatmap-button-visibility

  Fix discord "view beatmap" button being shown when editing and hide identifiable information is set

  Dean Herbert · 2024-11-28 13:29:09 +09:00
  e0fdcaf523
• Move beatmap ID lookup to UesrActivity
  Salman Alshamrani · 2024-11-27 16:54:51 -05:00
  24c0799680
• Fix tests reliability and improve code

  Shaved off lots of copypasta so the test actually shows what it's testing.

  Salman Alshamrani · 2024-11-27 15:27:21 -05:00
  238a1ce284
• Fix comment
  Salman Alshamrani · 2024-11-27 06:07:10 -05:00
  f792b6de00
• Make BackButtonVisibility in game class private
  Salman Alshamrani · 2024-11-27 06:05:02 -05:00
  4ae3ccfe48
• Update test coverage
  Salman Alshamrani · 2024-11-27 05:58:06 -05:00
  4b8094d0db
• Refactor ResourcesSection to support new form of selection
  Salman Alshamrani · 2024-11-27 05:53:22 -05:00
  efb68e4232
• Add FormBeatmapFileSelector for intermediate user-choice step
  Salman Alshamrani · 2024-11-27 05:52:43 -05:00
  b70fb4b0fe
• Combine new implementation back into the old one and use everywhere
  Dean Herbert · 2024-11-27 17:47:42 +09:00
  0f73941808
• Adjust the colour of non-pinned settings groups' headers to be more legible
  Dean Herbert · 2024-11-27 17:47:27 +09:00
  7fdf13911b
• Move player settings out of right flow
  Dean Herbert · 2024-11-27 17:09:15 +09:00
  782ce24ca6
• Rename class and fix padding considerations
  Dean Herbert · 2024-11-27 16:47:54 +09:00
  9c707ed341
• Merge branch 'master' into multi-spectator-settings-sidebar
  Dean Herbert · 2024-11-27 16:35:05 +09:00
  5ce55e9cb4
• Delete changes.patch

  oops

  HenintsoaSky · 2024-11-27 10:22:30 +03:00
  c3ac6d7fe5
• Ensure events are unbound on disposal as a safety
  Dean Herbert · 2024-11-27 15:46:55 +09:00
  4fcc76270a
• Use RealmLive in SaveFailedScoreButton

  This also optimises the manager classes to better support `Live` usage
  where the managed object is already in a good state (ie. doesn't require
  re-fetching).

  Dean Herbert · 2024-11-27 15:25:42 +09:00
  5260a401d4
• Knock some sense into the playlists results screen implementation

  As we're moving towards using the `/playlist/<id>/scores/<id>` endpoint,
  the existing playlists results screen classes needed some restructuring.

  Salman Alshamrani · 2024-11-27 01:20:43 -05:00
  dfbccc2144
• Remove unnecessary local subscription in BeatmapCarousel

  Not sure why I left this around during the refactor. This is 100%
  handled by the `DetachedBeatmapStore`.
  
  Removing this subscription reduces overheads by a huge amount for users
  with large beatmap databases. My hypothesis is that subscriptions are
  more expensive based on **the number of results matching**. This one
  matches almost every beatmap so removing it is a large win.

  Dean Herbert · 2024-11-27 14:24:57 +09:00
  aa3d3a6344
• Renaming of 'StarFountainEnabled'
  HenintsoaSky · 2024-11-27 07:38:33 +03:00
  a477bb7bfe
• Merge pull request #27128 from frenzibyte/user-statistics-provider

  Introduce `UserStatisticsProvider` component and add support for respecting selected ruleset

  Dean Herbert · 2024-11-27 13:13:47 +09:00
  573aaf6637
• Fix epic code failure

  I wasn't feeling well last night.

  Salman Alshamrani · 2024-11-26 20:04:36 -05:00
  9083daf363
• A toggle for star fountains
  HenintsoaSky · 2024-11-27 00:53:22 +03:00
  16d8b11385
• Rename AllowBackButton to AllowUserExit and rewrite visibility flow structure

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Salman Alshamrani · 2024-11-26 16:52:39 -05:00
  3e1b4f4ac5
• rename and remove again
  HenintsoaSky · 2024-11-27 00:41:02 +03:00
  80a66085a9
• Rename of the setting
  HenintsoaSky · 2024-11-27 00:27:22 +03:00
  460471e73f
• Add option to disable star fountain in gameplay
  HenintsoaSky · 2024-11-27 00:13:32 +03:00
  df74a177ae
• Merge pull request #30865 from ItsShamed/xxx-add-localisation-support-for-menu-tip

  Add localisation support for menu tip

  Joseph Madamba · 2024-11-26 12:54:17 -08:00
  a1a63608dd
• Merge branch 'master' into xxx-add-localisation-support-for-menu-tip
  Joseph Madamba · 2024-11-26 12:13:08 -08:00
  9173a74552
• Edit one more word not using british english
  Joseph Madamba · 2024-11-26 12:11:29 -08:00
  f04862ea74
• Merge pull request #30884 from peppy/fix-spinner-legacy-new-order-

  Fix classic skin spinner's middle pieces displaying in the wrong order

  Bartłomiej Dach · 2024-11-26 14:57:42 +01:00
  359cb71dd9
• Merge pull request #30881 from peppy/fix-editor-state-leaking

  Fix hitobjects' samples getting in bad state when changing selection between objects

  Bartłomiej Dach · 2024-11-26 13:54:50 +01:00
  33c2eb1af7
• Merge pull request #30868 from peppy/ur-perf-fix

  Improve performance of UR calculations

  Bartłomiej Dach · 2024-11-26 13:54:17 +01:00
  3e373ae85e
• Empty commit to fix CI
  Dan Balasescu · 2024-11-26 21:35:24 +09:00
  bd1f978138
• Remove unused using
  Dan Balasescu · 2024-11-26 21:11:48 +09:00
  4c7976bb93
• Add Room.HasEnded helper method
  Dan Balasescu · 2024-11-26 21:09:28 +09:00
  af0c6fc51b
• Remove leftover [Solo] attribute
  Bartłomiej Dach · 2024-11-26 12:40:49 +01:00
  c69d36dc96
• Fix Beatmap.Countdown not being copied on conversion
  Bartłomiej Dach · 2024-11-26 11:39:03 +01:00
  46d1f00590
• Merge branch 'master' into beatmap-info-purge
  Bartłomiej Dach · 2024-11-26 10:21:16 +01:00
  cf905d0f5c
• Fix classic skin spinner's middle pieces displaying in the wrong order

  Closes https://github.com/ppy/osu/issues/30873.
  See [stable
  reference](https://github.com/peppy/osu-stable-reference/blob/3ea48705eb67172c430371dcfc8a16a002ed0d3d/osu!/GameplayElements/HitObjects/Osu/SpinnerOsu.cs#L148-L158).

  Dean Herbert · 2024-11-26 18:12:28 +09:00
  312336de24
• Simplify hide code by moving to common method
  Dean Herbert · 2024-11-26 18:00:32 +09:00
  bf29e3ae71
• Change point of queueing to avoid loading-from-in-queue
  Dean Herbert · 2024-11-26 17:58:50 +09:00
  71294c312b
• Revert "Ensure DrawableMedal loading doesn't ever block on online resources"

  This reverts commit 8585327858.

  Dean Herbert · 2024-11-26 17:41:12 +09:00
  98044c108e
• chore(MenuTip): update text according to recent changes

  Signed-off-by: tsrk. <tsrk@tsrk.me>

  tsrk. · 2024-11-26 09:35:18 +01:00
  41c309fb72
• Don't reset state when changing from one selection to another in the editor

  This was causing state pollution in the new selection. I can't see why
  this needs to happen when a selection changes to another.
  
  This fixes https://github.com/ppy/osu/issues/30839 and also the same
  issue happening for the new combo toggle.
  
  Tests all seem to pass, and I can't immediately find anything broken,
  but YMMV.

  Dean Herbert · 2024-11-26 17:33:41 +09:00
  3ecb3b674d
• Add failing test case showing changing selection in editor affects samples
  Dean Herbert · 2024-11-26 17:33:41 +09:00
  e0199386a3
• Merge pull request #30832 from peppy/mania-precise-scroll-speed

  Allow setting osu!mania scroll speed to single decimal precision

  Dan Balasescu · 2024-11-26 17:30:56 +09:00
  d3d111de7d
• Merge pull request #30878 from peppy/config-pause-hold-thing-of-course

  Add setting to allow hold-for-pause to still exist

  Dan Balasescu · 2024-11-26 16:35:35 +09:00
  943837e3b5
• Remove debug logging
  Dean Herbert · 2024-11-26 16:11:06 +09:00
  1e6c04e98b
• Add inline comment
  Salman Alshamrani · 2024-11-26 01:28:58 -05:00
  42c68ba43e
• Schedule the thing

  Queuing up requests on change to `api.LocalUser` is bad because the API
  state is updated after `LocalUser` is updated, therefore we have to
  schhhhhedullllllllleeeeeeeeeeeeeeee.

  Salman Alshamrani · 2024-11-26 01:26:44 -05:00
  b76460f100