75266 Commits

This Branch

This Branch

All Branches

• Avoid beatmap lookup per bar in logo visualisation

  Just noticed in passing.

  Dean Herbert · 2024-12-10 14:45:36 +09:00
  d69f5fd4cf
• Adjust bad grammar
  Dean Herbert · 2024-12-10 14:35:09 +09:00
  92dfcae6eb
• Merge branch 'master' into editor-multiple-background-audio-files
  Dean Herbert · 2024-12-10 14:19:55 +09:00
  7ec2d91e14
• Merge pull request #31041 from bdach/wtf-wtf-wtf-wtf-wtf-wtf

  Fix top score statistics section total score display being terminally broken

  Dean Herbert · 2024-12-09 19:57:00 -08:00
  197d553238
• Fix top score statistics section total score display being terminally broken

  Closes https://github.com/ppy/osu/issues/31038.
  
  If you don't realise why this does anything, realise this: the drawable
  creation callback runs for every created sprite text in the text flow.
  ANd the created sprite texts are split by whitespace. And Russian /
  Ukrainian / Polish etc. use spaces as thousands separators.
  So on those languages the first encountered part of the score would
  duplicate itself to the remaining parts.
  
  I'm actively convinced it was _more difficult_ to produce what was in
  place in `master` than to do it properly. Why did `TextColumn` even have
  `LocalisableString Text` and `Bindable<string> Current` next to each
  other?????

  Bartłomiej Dach · 2024-12-09 23:51:57 +09:00
  1febed66cf
• Update exporter test to use OsuStorage
  Salman Alshamrani · 2024-12-09 08:26:18 -05:00
  f0f3c53571
• Merge pull request #31035 from frenzibyte/ios-uttype-description

  Add description to osu! file associations in iOS

  Dan Balasescu · 2024-12-09 22:16:42 +09:00
  216e0c768b
• Use temporary storage for exported files on iOS
  Salman Alshamrani · 2024-12-09 08:16:37 -05:00
  0c0dcb1e15
• Enable exporting beatmaps in iOS
  Salman Alshamrani · 2024-12-09 07:47:28 -05:00
  e9868c6318
• Add description to osu! file associations in iOS
  Salman Alshamrani · 2024-12-09 07:02:53 -05:00
  a46070be30
• Merge pull request #30973 from frenzibyte/copy-effect-points

  Preserve effect point specifications when creating blank difficulties

  Dan Balasescu · 2024-12-09 16:13:52 +09:00
  1b8d9370aa
• Add special handling for file import button on iOS
  Salman Alshamrani · 2024-12-09 01:59:18 -05:00
  2bae93d7ad
• Adjust test to load song select during setup
  Dan Balasescu · 2024-12-09 13:48:05 +09:00
  a99a992ceb
• Merge branch 'master' into bookmarks
  Bartłomiej Dach · 2024-12-07 22:22:04 +09:00
  459533aba6
• Merge pull request #31000 from LittleEndu/release-ipc-name

  Fix IPC not working in release

  Dean Herbert · 2024-12-07 04:37:13 -08:00
  2024.1208.0 eeac8f530f
• Fix IPC not working in release
  Endrik Tombak · 2024-12-07 14:13:14 +02:00
  b04f5ab6e4
• Remove unused using
  Dean Herbert · 2024-12-07 14:41:30 +09:00
  2713ae601a
• Back out test change

  It was mostly a demonstrative thing to use in the heat in the moment for
  the skinnable mod display and it breaks all other tests. So let's just
  not.

  Bartłomiej Dach · 2024-12-07 13:47:09 +09:00
  13759f5aa0
• Update default osk for skinnable mod display
  Thomas Müller · 2024-12-07 13:12:09 +09:00
  db18492fbc
• Implement skinnable mod display

  Also makes the mod display initialization sequence (start expanded, then
  unexpand) controlled by HUDOverlay rather than mod display itself. This
  enabled different treatment depending on whether the mod display is
  viewed in the skin editor or in the player.
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Thomas Müller · 2024-12-07 12:06:33 +09:00
  0a00f7a7c2
• Merge pull request #30956 from peppy/named-pipe

  Fix osu! sometimes not starting when WSL is running in the background

  Dean Herbert · 2024-12-06 18:49:52 -08:00
  3e7005d50f
• Update framework
  Dean Herbert · 2024-12-07 10:46:03 +09:00
  b9f1fef250
• Merge branch 'master' into named-pipe
  Dean Herbert · 2024-12-07 10:42:55 +09:00
  e22f3b7d05
• Merge pull request #30921 from huoyaoyuan/netcore-analyzer

  Set up-to-date .NET code quality analyzers

  Dean Herbert · 2024-12-06 17:29:09 -08:00
  5849a69a86
• Fix reference effect point getting mutated
  Salman Alshamrani · 2024-12-06 05:47:41 -05:00
  5cb6b86b1c
• Handle non-legacy types

  Also used in some tests (e.g. beatmaps containing `HitCircle`s).

  Dan Balasescu · 2024-12-06 17:47:49 +09:00
  ec8b320e21
• Populate default LegacyType value on convert hitobjects

  Normally not an issue, but some tests create their own hitobjects
  deriving from `ConvertHitObject`.

  Dan Balasescu · 2024-12-06 17:47:14 +09:00
  8dda5aada8
• NRT refactorings + rename generators to match usage

  In particular, "EndTimeObject" is no longer correct - it's strictly used
  for spinners and not holds.

  Dan Balasescu · 2024-12-06 17:16:04 +09:00
  e703d9e814
• Add some explanatory comments

  In particular, the spinner one is the most relevant to this batch of
  changes.

  Dan Balasescu · 2024-12-06 16:40:29 +09:00
  1bbf32d567
• Rename LegacyPatternGenerator to stop naming conflicts
  Dan Balasescu · 2024-12-06 16:40:29 +09:00
  e8728abc00
• Simplify implementation
  Dan Balasescu · 2024-12-06 16:40:29 +09:00
  e65f8ba7a0
• Split out + rename PassThroughPatternGenerator

  Better symbolises the intent of this generator which is to convert
  hitobjects in their most simple forms - anything with an end time
  converts to a hold or otherwise converts to a normal note.

  Dan Balasescu · 2024-12-06 16:40:29 +09:00
  8e1bd98386
• Always convert mania spinners

  A big part of these changes is refactoring, which is somewhat necessary
  because it was previously implemented as two separate pathways which
  in-fact need to be joined at the hip when handling spinners.
  
  I've chosen to use `IHasLegacyHitObjectType` here because there's no
  other flag that allows us to tell `ConvertHold` apart from
  `ConvertSpinner`.

  Dan Balasescu · 2024-12-06 16:40:28 +09:00
  8b456e1379
• Add failing test
  Dan Balasescu · 2024-12-06 16:40:25 +09:00
  62ea4e0970
• Merge pull request #30910 from nekodex/improve-menu-sample-playback

  Improve menu/context-menu sample playback

  Dean Herbert · 2024-12-05 20:50:14 -08:00
  7592813e56
• Remove unnecessary null checks
  Dean Herbert · 2024-12-06 12:48:06 +09:00
  69014550b5
• Update resources
  Dean Herbert · 2024-12-05 21:07:13 +09:00
  49f4b0e6ef
• Update framework
  Dean Herbert · 2024-12-05 21:07:08 +09:00
  84a85000af
• Merge branch 'master' into improve-menu-sample-playback
  Dean Herbert · 2024-12-05 21:07:03 +09:00
  8d0e1f9d18
• Put globalconfig into seperated folder and reference explicitly
  Huo Yaoyuan · 2024-12-05 18:00:42 +08:00
  68e400dd0c
• Merge branch 'master' into netcore-analyzer
  Huo Yaoyuan · 2024-12-05 17:18:56 +08:00
  d92ea910cf
• Merge pull request #30976 from frenzibyte/hide-some-settings

  Hide debug settings in release builds

  Dean Herbert · 2024-12-05 00:24:26 -08:00
  2024.1205.0 3d6e766b32
• Clean up code slightly
  Salman Alshamrani · 2024-12-05 02:48:51 -05:00
  1b1e7b63e9
• Merge pull request #30937 from frenzibyte/fix-quick-restart-not-saving-score

  Fix score no longer being saved when quick-restarting after pass

  Dean Herbert · 2024-12-04 23:48:18 -08:00
  791416c8f1
• Remove unnecessary localisations
  Salman Alshamrani · 2024-12-05 02:45:43 -05:00
  7c1be5eca2
• Make debug section only visible on debug builds
  Salman Alshamrani · 2024-12-05 02:42:08 -05:00
  7ab16a55e5
• Move latency certifier and import files button outside debug section
  Salman Alshamrani · 2024-12-05 02:42:08 -05:00
  f83ec721fb
• Merge pull request #30965 from Susko3/use-GetLocalisedString

  Use `LocalisationManager.GetLocalisedString()` instead of bindable hack

  Dean Herbert · 2024-12-04 23:34:32 -08:00
  72aa65206d
• make tests pass condition more rigid
  Hiviexd · 2024-12-04 21:15:22 +01:00
  f3eb21cfec
• minor cleanup
  Hiviexd · 2024-12-04 21:14:51 +01:00
  4918b61412